From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by sourceware.org (Postfix) with ESMTPS id 1BDBD3858C53 for ; Thu, 19 Jan 2023 09:59:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1BDBD3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674122388; x=1705658388; h=from:to:subject:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding; bh=GbarJmyvBcjl4KZ/BpIfZK/GYabmOhr+C0hAYCnqPAg=; b=jEyxcrFg8oFvRlE3uXXxFcAVePX0yLTlsZPRBM1MkdxQDgMbMTKl9OPK f726lkQbIkmnYCa/BPryhVWdncuMHx5BF8CoCNA/3iqWqExm4n02Oa7Iy O5Vclx+Bz9BptCfr5wWIPcC3kF1fisIaEr+9O3ixWCIVBLmvdYAelvymh sH7Ni/XrpIsGQVQR+tTVPmB2NSEI8WX8tAbvi5cgdKd7CsbqDmnlsw3Jz A7P8zQK3OLWJMi39jlak1jfVCZAy5WR6Y+5C5MsIA0JjwIkHuc+1/e01p Dvd1vCjvN366BI6/LGL9s+7E0cWq7JDAUTJN/OUfEcdYwyLX2/04+XDvM Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="326506313" X-IronPort-AV: E=Sophos;i="5.97,228,1669104000"; d="scan'208";a="326506313" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2023 01:59:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="905459700" X-IronPort-AV: E=Sophos;i="5.97,228,1669104000"; d="scan'208";a="905459700" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 19 Jan 2023 01:59:46 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 19 Jan 2023 01:59:45 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 19 Jan 2023 01:59:45 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 19 Jan 2023 01:59:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ABKiVGK66fruVJmwnjBcMPiHsRywjgxPacvdPAzREW1pCSz25W86Oyhr2ZQtvb/ZRgPY+WMZOoba1oriVrIfxsryKIRhMAHGKdWzKyKyVISwrNfciZVRnfNTmhbyQUdb2zgYIQSn2ESqBj4es6Nn2cNNSNi0PhbByCESq+AmgPfy1Vb1WxB0ABAh7tEZ++dGUteC8ago8Ba9HEHKd0nX7xE38JijkEJVaYhS9etBEMK18As/cBjIAK3d9PdkAfsweYo3GNGyik9Z8qV7T4WQ/gX4gnn2XrLP5ixznJ0cgxpzClY09r0amN/NC/Zr+X99TY8EpU6NtPVrvjvdz2dIvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cKRO6GGGHiWCQ15hKdqw6G4iOrbgVLlv2oQ2HeZxZzk=; b=GNCIhE9lxKEcXzAbHurGxQ6QT8B0kDooJX8De3zjztgvKWBZ34GCLv73YjEpOibEykIbSr6GWEFnD6RyEnYvitU0iyADeZfUiqke5mImsHJc/npax8HKgIjhqmeNKrR0SVecN8GvhXAPeFijrtFaRCnPzk1ED9jNWJQXB+PX2PVSGXtWEdHsb13X6heE0yYtoLEPoP+/m19MC2qECCmX1r8xZfeUY2vImcMzghJVo7OOvj+Pc35DK8ebOfVRdL3LiL/n1wS+S5Wt/l5JxrxO3kXj+DZvi360T2YvpeHf8uOf53fzcJ94dp0Dvegp4wA8QqGeoeFivZP6fuYnovVtzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by MN6PR11MB8169.namprd11.prod.outlook.com (2603:10b6:208:47d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.24; Thu, 19 Jan 2023 09:59:38 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::d2a1:8dd2:854f:d5df]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::d2a1:8dd2:854f:d5df%8]) with mapi id 15.20.5986.023; Thu, 19 Jan 2023 09:59:38 +0000 From: "Aktemur, Tankut Baris" To: Andrew Burgess , "gdb-patches@sourceware.org" Subject: RE: [PATCHv2 04/13] gdbserver: allows agent_mem_read to return an error code Thread-Topic: [PATCHv2 04/13] gdbserver: allows agent_mem_read to return an error code Thread-Index: AQHZK1iWEPtCjNti7EyAks9EVp5q+66lgb+Q Date: Thu, 19 Jan 2023 09:59:38 +0000 Message-ID: References: <38df45adb7bfb18c47724d63f67bd35b5cd0923c.1674058360.git.aburgess@redhat.com> In-Reply-To: <38df45adb7bfb18c47724d63f67bd35b5cd0923c.1674058360.git.aburgess@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|MN6PR11MB8169:EE_ x-ms-office365-filtering-correlation-id: 40153ba8-72b0-49db-620b-08dafa03e056 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eMXddSQkaoVWRVI+DCCOplh90ndo0NLWpR17xPv5BtbdSQ4rqYbA5wziRjAGQZNtHWIPbuAS9F6W+ic+3Fenv0I0tVXHSY1uECt4H2zzEs0KZpwh3Y7iHCo9wfWJxwLTN6OiA8Y1tVCPORI7jle+jKiqqGK8id6wnbtDfQcIYt7pE/DPI6t4u09aAmy6d4LTUcvO4Iu/cgde3IzxdTio+BxxS8xfhuXtmRqe795jdnTP/l2CM4RaqmGQpMe9tcjlymn3ZQO2Mi41lXcG9mK/Yqk2jDB1TiZ18g6gXotTBeyLo/D66P07zvvh9e+uMAlSFj0yNUwXtRzEe5rB/zsEqgEc2St+/aAxkuYMCyfHiAoVe4tjKaohFyUfplb9aI/DipY/8T0GSHA81NNka1/JJiDlrZPF3k65VAH8Qw50j8jNapjsCy7qcWtqQplMz+rbUuJwGkMGnRzyiGE5KU2vIyKA34xfIXcAxmo/CGBaddzR6/ZAuwFfKVrCtxpmInnHi0ra9pcfCCGGx7zHazMd2zm91byME564cI/PfrXhkc2j66jrkHXDPIyVl4iIUzFYzD96jM6oL6YfCBtDGFBOF6UkyL//4/ngvAuQYRSdrlwVNevM+PteGgXUlqOVvBPewTIe8/cRfieEdMDyhttcLSkSkQIxsitvlrbZrt98Y2OInfob/UeYtRf0JPm6ey+B x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(136003)(346002)(39860400002)(366004)(451199015)(38100700002)(7696005)(38070700005)(122000001)(33656002)(55016003)(86362001)(82960400001)(71200400001)(478600001)(6506007)(53546011)(9686003)(186003)(26005)(4744005)(8936002)(2906002)(5660300002)(52536014)(8676002)(64756008)(66556008)(76116006)(66946007)(110136005)(66446008)(66476007)(316002)(41300700001)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?m7Iw3x+IhQxwZCCpKWC/jZbyhKMTFeVZk0JzYk9nPhsaFHZgbnQsYuGEdG8s?= =?us-ascii?Q?z1Si33K2H2eGGN7a3uyZqBR44yFfwTLYJymzZhSNmh6f5xuDEPyFXhYEZzxk?= =?us-ascii?Q?Zl8kATlem5zsWan24jEKXmL69RScJ/Tic1/vFpGNhZkJdO4OV7SnRNNlR5CV?= =?us-ascii?Q?zJL+qOlKwhRm74iOB1dVNwxEPeFFSMxxWYh4w+Jf1ufTeq4ZGvJqEHJo38aX?= =?us-ascii?Q?cdzCw6aKzNHcOUzT/YyblFg76NH6CU5gXMgq2Pi/dxv0F8hxZzm9GQzf8mNw?= =?us-ascii?Q?XpM5qvUqz2uPqaX+BGn4iMpvuUvw9XNbpn2B+FslFaiTHM5K9xR+XulS6c98?= =?us-ascii?Q?8fhBKkiIFdG8GZMAPWNa9TthPiq9Fue0RSYkXuKnJQ6fQxokLa+/HShzS81w?= =?us-ascii?Q?1F8whnLrrlyp7djFm+i4v0vE+EaYBMkqAU9Z+wgsfFIZf7sCprSER6lcxb41?= =?us-ascii?Q?I3LlMpE+FR9yFGWuzgevnwkmcHt9Afskfvf/2tWEl6+IyCD5EWQ0NvAtNKOz?= =?us-ascii?Q?3Z8fkwNwL504bEFwgGm6NO/1rddD60gHE/dgLq4Vpozc8htoDOfrAwFI6fIR?= =?us-ascii?Q?NjD9OJ4NlqsCNNTAlUUjR1pyMAAyeLP2af+qu6D7skfdLJeQZnkenLDJ3j3y?= =?us-ascii?Q?HhKl8/Oqm4VfXUKtyrX5qbNJVVqYTutOWXXJUnBkE7SyVqEwfY/2ctwRWYgX?= =?us-ascii?Q?zIZ3DgcAQIZfiYI5U7FLCsf/88qHbxBiYoXrI9Ogrn9LnbVVgVV6Alkfrw/X?= =?us-ascii?Q?XzQHOiCp7lqF26iZC5wOhyQzNp9jED7E9pk1rkvoFI8XJA/uDMO7CcKffYYX?= =?us-ascii?Q?pjlvxZW242MV3D60ImPuYqn4aQE24jem+GJNT03qn+K61oLazZ411WRafOFL?= =?us-ascii?Q?g5NY27vrJa5SPCotG9FJIAudM5uhKCbUDh1XooY3DMOO01jV01GzBxasEEsN?= =?us-ascii?Q?U6fZ3grin3OLaCzfqdkvJ4sk8GsL1jKZmB0qg6lkXOyp140AYpqMZ89Z6xHY?= =?us-ascii?Q?9/jzimUO4CJRDCiVhxi8o5zaAcIjBlgNN59l9rfvo5KRHdenpmKqf8U94Cj2?= =?us-ascii?Q?ZR88VvSuhzivUXx8WtCO/UxjkTUxsJ3CAr4H2fI0+KctzuMkOGeAUYHfWRw1?= =?us-ascii?Q?tP9WZpFNtjyr/LeHHN/BmHfC6CSqoWUCLufs/M2poP5J816cbuc8Kd8hvbK2?= =?us-ascii?Q?BOIK88p3h2OP0om04gCAhY2BMYLMVspI6uoq3tEVJuYfhNds47ashU8JW5tw?= =?us-ascii?Q?3BXqEa1Ma4wFtrmONLgLib0tKfQtRWUw72mGsekPMGr9FtS6ySWXu+xDY8np?= =?us-ascii?Q?1bRKn63ZSJFxIYMt4EhYIqjCy2jhCwGSp8oiupVpYKZLfolTI1RJVv85mOD2?= =?us-ascii?Q?uPnwX/cooSVJiMKYsb24TYexru2izxPEye0p2rACTz8sCafNoGYhdHNjvNE9?= =?us-ascii?Q?TkvITyEmyyXLa2NRsO7YKPnu1CHTtz4vBbfjNj9v+IyaSDt61n0ndlhAlxyv?= =?us-ascii?Q?zI2/pKKMtYBnqJ6L43aajxh8x+m7TdLepkQ1vvIaJFeWNfUuWdT342XH9l/c?= =?us-ascii?Q?d4ohxhMewy/wq//u/JktXgB9U+C+/VFExrcSJ3frl3HQ+hYNrOgmNCRztYh6?= =?us-ascii?Q?nQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40153ba8-72b0-49db-620b-08dafa03e056 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2023 09:59:38.1793 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kV1e+B/TZz17GyaomhATcVqpho1OYoYcW/nQ4cbFdTsS+BvFonrJ1ikCkA2BxMKeh/dXGWoo/8+9XowT/yUkAOFzSFKjM2HP51XSRIfpTBs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8169 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wednesday, January 18, 2023 5:18 PM, Andrew Burgess wrote: > Currently the gdbserver function agent_mem_read ignores any errors > from calling read_inferior_memory. This means that if there is an > attempt to access invalid memory then this will appear to succeed. > = > In this I update agent_mem_read so that if read_inferior_memory fails, Did you mean "In this *patch* I update"? > agent_mem_read will return an error code. > = > However, non of the callers of agent_mem_read actually check the non -> none Regards -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928