From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by sourceware.org (Postfix) with ESMTPS id 4F9223857B87 for ; Thu, 14 Mar 2024 10:36:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4F9223857B87 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4F9223857B87 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=198.175.65.19 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710412605; cv=fail; b=w3EYeekLzeBReTZp3b7VKslWU2KRagZdabdaKJD5n5zhHr7rA7eTF1QCXDjOGrxqp/Rc3XFAHMsjAZ5pWzUJ3StvqwSJprRqi9yYYzuEdJvJo3uAxkQSCNF9ZXONRAI2XDp5U/gEEbQHPelOdUdxZ2gZqgj/EXLFn15gbJvWjfA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710412605; c=relaxed/simple; bh=MtbS9X26OOXgWioaesmQ12Xx+uFE2FS6tomQf8JL844=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=SHMjUU6zPIEITX5Uu+03qHdRJt8RHPqXU++OE4bWmibxUUTot93xSAWv2WcCExOnbbpieWxKSvuOohBe2TgN6hYcWJh1HIjgiiPzu38wVfLSc18pSBVaXVdjPxYe2Vr+aQYNO1dTLRAQBbfGxABt6fYaBrP+6A/tNOt2ubTtSm4= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710412604; x=1741948604; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=MtbS9X26OOXgWioaesmQ12Xx+uFE2FS6tomQf8JL844=; b=RQu2whKQ/VGFZDXWzyPdw3oWtRarp8mO2HWvwk7TQO07Dl/XJHEOrz4I K5IjyXEBpo0cskpfZL263RfWeqJx0NbYleZEHqTBYyFf4z94jt1hri977 us0JbsuEEhJc/w2BwcNCXNhX+WFiKE9LsIjSW941d0fStufHphJ26m+kT terJH9sPXEAW9xesrisz3MJPR2yRRvgHXdKU4RnCJ4BezONvFpfiIt0Yf 116eLgKKAw8+Ww/1j31QAvtuw9xfCLwpVnGOTFLXgF+ALk617cZOnROmi 7hTLyWfAHaPtxLKo4VmggfyaBvvdNgNFYIBdN3Pn6g0wnDbpLVFggDkex Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11012"; a="5086372" X-IronPort-AV: E=Sophos;i="6.07,125,1708416000"; d="scan'208";a="5086372" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2024 03:36:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,125,1708416000"; d="scan'208";a="35379142" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Mar 2024 03:36:42 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 14 Mar 2024 03:36:41 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 14 Mar 2024 03:36:41 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 14 Mar 2024 03:36:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jHFnMH9a7YcPoPNWwYBLv+gzDl4DPVGIK1C5p/8ci4xIRFxdtVmwXSU6zRYlUzlmRTZZGe11Q7KGpCw/3g/FRFvHLWmjheW1hG37q+rhurNYrjCLnrlad3KUSxaJ2fhiWA8muZFAwa7Mw/7zjnESoHodu/AGZaiMKuuzCAO7B9yYyLbtNACJSQ4eZlwBX3ot7OOgJ8tLHqAVEXDWQW9po7IVILtbhC9wPp4TgCqunjdrGHj1WOSlFeGQDq3tFO5JOfRV5VWSSiq5Sq0F47UGWgR/yD+WxNncB8OZDt+vjiTpN5YhuJJRpjaQ5tSKPEmDxsmAdzjlKFhBXTHxyhCUNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x4fMU0ntFDSassgapQtpyOAe/uoWn02/DE1dWJ9/X9M=; b=NiqzDUObe8ungiuIOQaXCS3HjlQS8VDh4XRQT5S7ShLviHeKzFZerzbB+DzmwScnQMEe9rT6od54ekP/mLIkqjy/imeSBP1Tm+VWOGHs2Hy1pq2FVn4+X69L1yItqZSWYJ+AfL/1Qfla9PYb834uJKMZkxW71rso2Bo6vCDxPx6zKFBmOhXknrm41eLIpwY2PAon9ZBkVdeYcdKxbauxPsJX4ICo0kCnmeZ7cpISRPhzA274tEhBcC2Lie/sB3+iWrmpUj39AG2uNcyyIanr/FJK+n3c/zFPfuOvagPn6DmxEeupX0PNP38P7feCUSOQbojNj0Y8opSvbCQVuymviQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by CH3PR11MB8591.namprd11.prod.outlook.com (2603:10b6:610:1af::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.16; Thu, 14 Mar 2024 10:36:34 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::d151:d3b0:297c:ec32]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::d151:d3b0:297c:ec32%7]) with mapi id 15.20.7386.017; Thu, 14 Mar 2024 10:36:34 +0000 From: "Aktemur, Tankut Baris" To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 1/3] gdbserver: allow suppressing the next putpkt remote-debug log Thread-Topic: [PATCH 1/3] gdbserver: allow suppressing the next putpkt remote-debug log Thread-Index: AQHadVxcPIblIM8yxEKza+RXAjyZD7E2CXHngADjuOA= Date: Thu, 14 Mar 2024 10:36:34 +0000 Message-ID: References: <44e58e5113d85284e5cd5bc33badd3ac55390dc2.1710343840.git.tankut.baris.aktemur@intel.com> <87sf0ulzhz.fsf@tromey.com> In-Reply-To: <87sf0ulzhz.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|CH3PR11MB8591:EE_ x-ms-office365-filtering-correlation-id: 4aea1dae-e9b5-4ad4-9e51-08dc44129f04 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: m2zgbydAsnp1zqGI4ii12mG2SELdWmFJAnv+iMH7q3MX3wzMO2ijck7nf0Mi6oYLwIdZAbIwjtcuf3ZozTpc2WD8Mupqdk/G6+IG0WIWdDToHsdY5GH/0vI9phvXwFgmDrZSKTsTxtS/HTwl1TNd7EtJXBlnxqmSE8Oz+9RPQju+0WAO1UAJQ3Y7a2y7QTtnLpsAPMdpLaK/y1tyGWuybGAvI/57BdRUWgh98ZPHI/Ae/Qzm22WL021EcHsT6ASpRkmwvXvKjmRPDm+3/DV4DqhFHmrT8qCKCwHfLq89u8tdS8zJOdi9lOJEP3KHKkDcjP5NtwLKgMlX+mZRuITEjOAM57dnN9A5wlwI1ypExOKKTfBkyhMUNIjFma24WdMhHPDXs0TB6ShEKY80gUkYA4P4OoVuDv8QyNZ/ZIgQ9UV1FAGT9genm+rtF6D+1H0GBj0xf18H+cwEbIbPMZqEkWWM6km9B5J1Bc8inF+JIFtbffg1otB/U++RmpySj/ez/MWq80KFpsYk0Z/ULLMapUOP9kHNHTHafORfakHuKFrMgi8UjWGh/jppWtthrzZtGQkMVuH+Yvnwqss0L4mgVc29bbfeXVYRUiP8CNcqIJaHCtrWQtKnaBSV9R3emH5cFYMLhTeEo5KGN+qJ31eCZSiI65hKaIiLVnOpC7aGVR0TY+JMoq0YvOJqr+WRsC5gRrdlVWZjllxZTOJ0XY/xWfjOkCs8B14vujNS1WDP36Y= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZOrX4D9OQAcr4etBGczRAq2U1wrdqGUUIjtZOmUZlE/mtlBEl0ytYMtj9b8f?= =?us-ascii?Q?huyxmMg1WWiqSeuJgh5z5N6Jcog8fd1aRrqm9cFXrx4RGSRA0BAul4gejVae?= =?us-ascii?Q?m9QEWsveH6Pi/nYLieqe/1eLeTHJeqtfe7leWRzEmsAOg/g2sY5iHPZH2NOl?= =?us-ascii?Q?NA3/qilwSYLQvnJSDgmusRjOM9msmwxJGNd79+dYT3vN+yEWvkqXnnoBbttM?= =?us-ascii?Q?RIkDrK9WdH5sJKfxuYJTxESHlc8tSjg04LB9ywvYxrg3yhWyLJ7LBfqiq4Kg?= =?us-ascii?Q?13lMzA6jDbxbeTpBbWYAKl8VQfixfa2dhI1JvGoWTotyHqSuHGe4g4jig3xd?= =?us-ascii?Q?0aX1s5+Nqxu6+VCKqENBmytTqmECffCwJczj7SQda8HGk6Ma3pk90E2bdULW?= =?us-ascii?Q?eFnK+B1WvZiUwvuC1/qMsXdD5lbAW0CFkTjsQBbnL5vJgMNKK+2MGcAC1r2x?= =?us-ascii?Q?NHQnXPSych34e824TWELC6ztGXH9eU1rWa/c/Rz9jUUa3hg0OYoXIqVUonKI?= =?us-ascii?Q?7Vg05dqexVF05+Scl+4WRi3FY2Zlhf56q92zMNuqDaiUe6h1de6+IrejqL/v?= =?us-ascii?Q?E1+SDNK5bfXZoHVyGMIR+SWrNw5Lb7J4FpwgLSsRZNWFtbZlZHcmGAAhAyrY?= =?us-ascii?Q?DzWuM24JudvcaviD5d5p1xh+jHRbqRMqyGRcEe5AunZjOa8S+djU/Xeh2uTP?= =?us-ascii?Q?oxHsP+rHmQEMCGk7sZqQcrk4AYaUJscipYPaMMOe4CFqU/QIhA64S40XmQNW?= =?us-ascii?Q?jN5TxXgfrXXbODk2nDZLaVVzyBEM4Vti3L7SBvC6XKoO3iCTy7RN/WXCeyvq?= =?us-ascii?Q?4mAz8YuLV1CAx/oMWn0yae8bwtNYTLQ0xVdzEYFWJUu85QE61e+WkzDtKxfH?= =?us-ascii?Q?UViGnllBwhSNWy9uvNPQPinYee1/vk7UOJWc/VQRM8nE+tocWIHeoKmKSehf?= =?us-ascii?Q?KHJMhom9+/J6z/bxfP9Ahgvo0CA11rWk1a+41gf1BJL56f4BeyL7QOCiO5DK?= =?us-ascii?Q?WgLGbSZcoMAVtdW0LM2SGxuLxhsTn/wZEaiPEXQT9f5b8YhIX0+lJzG54owU?= =?us-ascii?Q?vvIkWBr7z9oCRlZe6b+MKml6CxFERSWO9lbQ+S2gUZSWs6kMQhl0ymkgGzUK?= =?us-ascii?Q?ExIkhkf+6cvNrpebQNJGeFSnlhZ6QsgWv1OZWhnMyvIttLzFOaKrsCTLD86+?= =?us-ascii?Q?7zIfxq4yvOkI/svlwQSy5F/fK8PA2L82tREiiwsgCq0cTxyRFNb88JQDr+r0?= =?us-ascii?Q?imv34pPZUlcClG+/op5DqP87fFZfSFpsxZByutVaJZM/Ya1i9XAZ0yJo1OWs?= =?us-ascii?Q?851xhG4ZRPYAneLQ3zxwvMVfz/x5w9fW55SCNaNXYKoWGEFFUjhnxQWCbH+x?= =?us-ascii?Q?xXTB3Wi6ZdGlnkp1RbAKR3eIZkD6ZsTLqS+lwfXCY3kv2c3h345q1dYRzXC7?= =?us-ascii?Q?UpfKRKOpdXOJJMCwBcdl6QqKfnZTCYXN5+vM4JRrpC8xC1+ZQxH/z+5aaMAA?= =?us-ascii?Q?2f+OyZFVlMqyuGdSGQ6YWhWe7++lc0OllcpVstXtoIBUQIfFqCd2R7uG1d/q?= =?us-ascii?Q?YsJZ/JVvlsu5Ek+/56qT3s6wJe3PlIlsZBV84mQ0pDpf3q6Hm93if1EyEAKO?= =?us-ascii?Q?bg=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4aea1dae-e9b5-4ad4-9e51-08dc44129f04 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2024 10:36:34.7461 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UZMz2ZA2IUouVigojaIJIEfOm1502Rm+hS731dSEAhl8IL+J+Pxv9AcUzdl+GKA0nba6Zt3dzomkt/23+VJsrccMG3RZnAiXCYfgvR/M4TI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8591 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wednesday, March 13, 2024 8:10 PM, Tom Tromey wrote: > >>>>> Tankut Baris Aktemur writes: > = > > When started with the --remote-debug flag, gdbserver enables the debug > > logs for the received and sent remote packets. If the packet contents > > are too long or contain verbatim binary data, printing the contents > > may create noise in the logs or even distortion in the terminal output. > = > I'm sort of meh about this patch. However, there are already other ways > to get more complete logs (my fave is "set remotelogfile", since that > can be replayed), so I guess the concept is alright. I'm also not so happy about this patch, but because of how the logging is d= one in the lower-level RSP utility functions, this was the solution I had to co= me up with. > > +void > > +suppress_next_putpkt_log () > > +{ > > + suppressed_remote_debug =3D true; > > +} > = > I think returning a scoped_restore here would be better. > Or just letting clients do this directly. > = > > + SCOPE_EXIT { suppressed_remote_debug =3D false; }; > = > Then you wouldn't need a SCOPE_EXIT here. > = > Tom Based on your comment later in the last patch, I concur that there isn't a = change request for this patch and I'll keep it the same in the next revision. Ple= ase let me know if I misunderstood. -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928