From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by sourceware.org (Postfix) with ESMTPS id 9FD1F3858D20 for ; Wed, 5 Apr 2023 10:19:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FD1F3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680689975; x=1712225975; h=from:to:subject:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding; bh=Giex2R2lbySZQftOIPuICNNI8fukE/nGB8I5cqXtljM=; b=hu/sUuR3q2f9C3UGpkKPKjUAB/iN4htxdrCNG7Dj8+jZN9JXsqQKXdjx a9lPHLg0gO6i/p9eznReI5d5CJCLRKzuVuEAiMTQQYOW5fNgFTI7QrrqR YTflvs0HfNPU+ziRbkTvwYfbkY4JqQmT8wLCotQwoVNrPcNDtUyifTulG V3lcT+WcdFKHiTSfiSLPM8FxcNweEO5LBYXR9WWSH5Tg3cH4MwF8B1qzM pdtERn9bjr/F3na1q01Qg15Df7TqbZmF6JC/DCtLWVcs5x/Z8mySLmdrt T/QMn9K3NDqPEJywgki49A+4fZDVsQqAFrPPl07eXOxMWzHCy45sF0bhJ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="331016490" X-IronPort-AV: E=Sophos;i="5.98,319,1673942400"; d="scan'208";a="331016490" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 03:19:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="830315805" X-IronPort-AV: E=Sophos;i="5.98,319,1673942400"; d="scan'208";a="830315805" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 05 Apr 2023 03:19:34 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 5 Apr 2023 03:19:34 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 5 Apr 2023 03:19:33 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 5 Apr 2023 03:19:33 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.42) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Wed, 5 Apr 2023 03:19:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JnfWNVk3KO5yzZh7kDhRpG1CNZaywUjZd5+bRqFSFrLPpXDAWPIrPbr76MxDG/R/F1+lS6I3LvEIja3ki0IGKuUD1TYwfmBYyfS+OGQNLktAHo8KNK0B6Jj/1wVkGtx1Roj3U8rOmyFF0pWQCltf+D5SbJqlwc8bC8D/DzbyqiyHX0ncYNfMDjd4hcq6Jmh5VzP+Q4vp90HS9ubI+od3UR2EtQfh4la/mqVulE+TYTYCVSaQissMTykTWZF42qb6JmCztpa02ZSVIccSFEH9oYKzPJ4hOhlwc3PiqETSO7cfjoe0LNe5LrZqjxrKnXTEN4Xqols/vB7FfDzTFGu4KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mFHGezNclF339I8h37+6IBQOyTW1jOrVhoYRGcGcAGY=; b=aXPJuP5R74PdFUb4PfLwRrLLp31fvmJv4z01tDexx32eOPMpHROsGTxBhJMry8IPDYd/EMY2RDGQwULk8R0u1LhwLWOeLtz0NxUf0KiY6gW9Q9kGqsJoKfoM01gihzzZ3zEKmTPoBQTw9xJQSCdDHYX0+kvCkzQpoUXXebDF/TDnJfk37rn1VQo/+jNloFeK38JjCDKpHUdt5tm8wo877m/BCQb7gqB/tkPIVFUS/liMZRvhJv3F9BmOxslp+4/PilbZi2iKrfNS3AmmOCDYxPGUK0m9ieDUdOGHwrn5L2OnZ49XYv5DhF7PXF4hhL2qZtHDad/EkVtNh2IDWqkmlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by IA0PR11MB7839.namprd11.prod.outlook.com (2603:10b6:208:408::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Wed, 5 Apr 2023 10:19:26 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::cc2a:b1a3:91ad:780d]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::cc2a:b1a3:91ad:780d%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 10:19:26 +0000 From: "Aktemur, Tankut Baris" To: Eli Zaretskii , "gdb-patches@sourceware.org" Subject: RE: [PATCH 3/3] gdb: add a '-stopped' option to "info threads" Thread-Topic: [PATCH 3/3] gdb: add a '-stopped' option to "info threads" Thread-Index: AQHZZ5/n5Bpr23fnrEuCgUohHAN2TK8ce8AUgAADPtA= Date: Wed, 5 Apr 2023 10:19:26 +0000 Message-ID: References: <83ileasl6h.fsf@gnu.org> In-Reply-To: <83ileasl6h.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|IA0PR11MB7839:EE_ x-ms-office365-filtering-correlation-id: 398c27bf-f003-4369-dbc1-08db35bf3bc4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Zqz7ZsSqjQlrMUbQ36mby4mpmtORiCNapN67aoYijc3lJP/G8DckYzqkNMK9Yi84M5VprcFwt+a4Gr+BcNleXE8Qh0Dgki+PRJnZjk1AoVIWMx35KOYr4qjL0w83TTeu8FGZugCDsDROYGYrU5eKJKKwwxsgffw7RB33Ndjle2MIra+hOnF6rX96OgaPTKXoBjguCC6qo8EOiTSLRrPZjY1Euxeg9h5zK2STpQRB3N0wnDsVMFNZwXOiTut39AifyDORMm/M2XXGGzz8BChyTYwrTccYHUt4GTaLQI7coK2ZiHx7tD2WwfuTfE4FtT8qm2HAxNUIIayErnYsCtGA7PQ0S69DrSG4lpwRXW6iZFD5XGA7sRcdWiIsgWj0kolR8ZjuT9ffs6F3WSLxfqRQifM8OqjkUvFU8AV1+sdM9/SMFjC3p0VKpf1WEZCy23QjGIP8xQd/vHS5iwoCmN22sqGq/Hp1vY1/dc39xcQa7Fb2E7oiLO2vZ+THfLNYYIFNQItA0CTRClYfbORoQs5yszEFGP0Z8hW/o7VG/zkKIaF5bfa3etKzbJjEYl1ZscjKfHItSdXTfT/L39wmu8qcu32lar+lau2uHMMrj9xRDOCxvBALZ3xzpWoh5Yp10R7F x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(396003)(39860400002)(346002)(136003)(451199021)(38100700002)(55016003)(122000001)(76116006)(66946007)(38070700005)(33656002)(66476007)(66556008)(82960400001)(52536014)(8936002)(5660300002)(86362001)(66446008)(8676002)(41300700001)(110136005)(83380400001)(64756008)(6506007)(9686003)(53546011)(2906002)(26005)(71200400001)(186003)(478600001)(316002)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bka9kvfzsTO2vi459jx8Wez97eAreO/pvcc5rA/6q5ENRUZxHj2aTy7YG/yY?= =?us-ascii?Q?f17unrXIlrbg2dEJA9lf/WFX18c3tgpwrgvKYn24VofkKyfB2pH6/LOs3Rfp?= =?us-ascii?Q?HH3FC+Oo7UTpnGCZ7YmwBwoNWNzq7FLvk9WVL3nfarlAIcJlsv9kQDHVcag2?= =?us-ascii?Q?MrD6kkAbtDO5zG3oJJ9Ju7hDdcmhwxgdI8nTu2lSKHgfrCpxWlCv0uJ4K2nC?= =?us-ascii?Q?W1QaJvYz4AvOgUcfiQNYi8AYFGv9zK/sce4n9RgKf/8Rvj5DBLdeHIGbmnYz?= =?us-ascii?Q?gyom4IA4tO0kSuK5eR7DoziHRDdF62mtQCVty5EV09Xunk2/r6ib3hH8BnQV?= =?us-ascii?Q?lnUPuK9UtDjwllf0xxiqjTRsm3ka8yEpWR3tAZjE2JhzKqHkKuztIPX63ueE?= =?us-ascii?Q?B+qF+drNaY3aFy/lngqvYdH5i+1sOj0C1heU15wU+h8BiJqzUAX5lc2yfUns?= =?us-ascii?Q?Y2fkqxc8o7LJUHibPnJ3J5C30kZhMapyZAuQ+7uSeyNCL4tUWpe+X1M9zZOM?= =?us-ascii?Q?zmHbHu3HsmnR2jTfv4Z3viNugoKcfGRp5G5nZ4XmxYLKBq44rwNCBv9Bt5Pz?= =?us-ascii?Q?28YN6VBUXG8A112j0FTz9VzUTexwIhjNq4mMtnCa9OvcneEOTfT/48mzO994?= =?us-ascii?Q?WM+HvEGl1bVqomn9yDzGdM3D9n1xWxcohMYwWUtl0vCSOmBjIObUFc1PyggC?= =?us-ascii?Q?GQ/SYU31v5rhfAYEf/iTs49Th7nxzJI/OT51xANvp2LPf46+Ih8MnmUMrqXt?= =?us-ascii?Q?rFxVp0T95/yiuAOnelbAL9lRaAgZNwKTH0T5B30OWN1YlsHweNGVQygdO/ZU?= =?us-ascii?Q?McJQIAZSBxw2dL6OzF3v4dZuYh96SWtIK/t/0tmZj3uqbblSTpk0lJdpiLlH?= =?us-ascii?Q?YOPo/lQv97INq0VHxXfLeRk4ilwG/RdCqj4PZXejxktbvuKJd3Mmm6m8aCdr?= =?us-ascii?Q?7psFD4VLqeBbCEhJnG5rQSu72wM5bZoLkvHwwDLGhdBpTALO6Cp+rbTP8PQ/?= =?us-ascii?Q?bDCwhXl52xBxbLeWrLkPXU3o7MujrfYeCF1oUoA+mT5QeTA76cSIzcYduTfr?= =?us-ascii?Q?8Mg/NLpjvUbxe5+3bAppqBcb6Txx30z5UIxVC7RqtSByaIgWCHH+FdCvVIkH?= =?us-ascii?Q?m2m0bdLTxEsdTQSCVdZE+9Vm1VU8WbKPYBVHt35ni/DiHvMRU0d5ob+l47FH?= =?us-ascii?Q?8XKqP9xvTZqVKiNXlrdQo80de6lYuDBLBVmjb/m3RhtxsfXEuk8LffLiX4ZN?= =?us-ascii?Q?/eDPDaXfo/5kcS0ELXd0poA32ZpztrVSncrTNnYyAqsv26dkrDG/mLM5NKuU?= =?us-ascii?Q?v2cTBrw+5YjT/3ePc54Pm/Tjrf4TqZDjvXgwiLX/cy+WpXRllwSERSWiqgao?= =?us-ascii?Q?3+tRhB6ek5JowH2hSguiEpdzQov67+1WZBB+UcteBbj0guPoo1AB21EOtII0?= =?us-ascii?Q?3QYnnkVAB1/apgDwxa+gTb5kszWxwI/UVIGH+f5w7B0Lv1dpqGbR5R4sjg9i?= =?us-ascii?Q?MdlpBG4M2vGgeoDIEUEzHJjmkRMoCXtcQj0sx4ApxarZVlNh99nF3pjF5/5j?= =?us-ascii?Q?JLz7+AUOQ2av37d2K4J66qFtqX5GD0osZM8gKl34NK7x3ESwBIGOfLvd9/K/?= =?us-ascii?Q?UQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 398c27bf-f003-4369-dbc1-08db35bf3bc4 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2023 10:19:26.0615 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Qs1AT3qmxO2S03UGTmqUs+2EPT4qm31/LRDdN1ZnBSmrm05C0Fw2AtC7ZTKZS4/gGnpVjgl3dYaJEw2rc1BGTu9o6JAjRI4pe7cp+lg96PI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7839 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wednesday, April 5, 2023 12:01 PM, Eli Zaretskii wrote: > > Date: Wed, 5 Apr 2023 11:20:02 +0200 > > From: Tankut Baris Aktemur via Gdb-patches > > > > gdb/NEWS | 7 ++ > > gdb/doc/gdb.texinfo | 6 +- > > gdb/testsuite/gdb.base/options.exp | 11 ++- > > .../gdb.threads/info-threads-stopped.c | 78 +++++++++++++++++++ > > .../gdb.threads/info-threads-stopped.exp | 75 ++++++++++++++++++ > > gdb/thread.c | 17 +++- > > 6 files changed, 190 insertions(+), 4 deletions(-) > > create mode 100644 gdb/testsuite/gdb.threads/info-threads-stopped.c > > create mode 100644 gdb/testsuite/gdb.threads/info-threads-stopped.exp > = > Thanks, the documentation parts are OK. > = > But I have a question about the new behavior: > = > > (gdb) info threads -stopped 3 > > No stopped threads match '3'. > = > Is it really useful to show nothing and emit an error message if > explicit thread IDs were specified by the user? Wouldn't it be better > to ignore the -stopped switch in that case? > = > Reviewed-By: Eli Zaretskii The user may have given a thread id range or a wildcard, like "info threads -stopped 1-999" or "info threads -stopped 2.*". Ignoring the flag for these cases can output a very long list. I'm fine if we make the single thread id a special case. But then the question is, where do we draw the line? If the user gave just a few thread ids, do we still ignore the flag? What is the limit to the acceptable list length? Because of these questions, consistently applying the flag made more sense to me. Regards -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928