From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by sourceware.org (Postfix) with ESMTPS id A81073857C69 for ; Thu, 30 Nov 2023 16:11:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A81073857C69 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A81073857C69 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=198.175.65.12 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701360716; cv=fail; b=bAEJrszv1deoWIydMapWOobl59dLAOHl3q6PQbaXtmspwXJYp+/NWQ+3RlzEibbdZ7sMdZCYEemsUNhHwQeP10J+VJOXl/lBKNh0rFPz4FlDQFf1JmdcOBPt6H7RJ0Zoinp6147I1gdLRbj3Vja2+A4yREiW+dnMdutiYlKYuac= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701360716; c=relaxed/simple; bh=Hhj5P+dUAiiJ3VAoUSGMiKnsnlO1kROTaINBL92KcPI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=AIqukEj+zgOHJilH3Y6rBoQ36YnWqFfqpK4AS7boZdvWFjK98f0egvFkbdchTueNyKWGZMbOIRlygAYPFPf1+9QJs5QzVeQ3W6pAFjn9wY/3hrL8Q3BEMhvhHd1eWkSQNTD9x8hkBSQzJ806S//AgWiXCBEwAXV+E+aNc4TXe60= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701360715; x=1732896715; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=Hhj5P+dUAiiJ3VAoUSGMiKnsnlO1kROTaINBL92KcPI=; b=U3ZdjjkVwZZdLeiW2TPdOii/ulSMo8JnIuU90hy69mRLoTES65fyBMTV d+t8QXY3sYJqyLQhks/w2FtAX3PytrTielzdtk9P5GD582uzY3oCXfkyt aAPqfYEsmJcKRTbep3veBgIw8U4c0tjJVFsIXXAe5WtJS7zqVPsbgfLT8 tIb0nalgTbSK3plU8Hp1R5X7SYP1lBmQP6LchsHVkSCixZrIm6JGDjMGk SCtkdlCDnxH+7BV8zH2vI3Rh2S/LjVzGSnjFoBi3f9DUoMkdegRhK8Ck9 7txmYlAyCK9/+z6alvqNeEH4+OEdGW54wxrDla4wBp8D5e8xEIplFwXL0 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="336165" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="336165" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 08:11:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="719173356" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="719173356" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Nov 2023 08:11:53 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 30 Nov 2023 08:11:52 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 30 Nov 2023 08:11:52 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 30 Nov 2023 08:11:52 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 30 Nov 2023 08:11:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VSZ5n09rN5y8zKgXXn75/INzJgrBwsaaUeXvvWB0Bg7n8BrZFqJ2ysz9DTFym5m5U5ZG20BFbamN/WaFd6tKcGGmiw+evs0Ts1PlF0ei/JF2Il5zFkwc14y60rN2gDcTMCS/arwbHCF4Vg7xixuVmluVVMWeT4+yG0Zxsfwfn7DMropfdcOYivvmmwiA79W7ml2Pitq5XXlk4IchTHatJoVtSKvin/PlK+B31xjMz4/uvaxXQiCSm3UF6C7KRNubmPr39tsSEeB+r8hUcJXTJPoVn+I5EFje1ILKkR84x6oPfP56aSjHMu7Z9OEyDTquD//ZO5TkSxOHHeCyEzY+FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=swGM6djkgRt9xbvFPAb3wE8U3kpydK+ZhR7CAL6SFpE=; b=TXx7FvPfRYackxAVudSKPDzuPr7O8tW+XZrSuQ1weqf+Q0ZlDW/6BdB8xPqlhK3i0WDJcMrwYRsBrfudEHL/2RK8WDFvmA5jZYvqSgsovPLojC2bzcRyZhTB+UhwIluzynTHSna7X+JWVkya8dwMjJ14LT80mu+Xj83hbobAr14vlNTEoKnl4e+qMW/Uk0sS4ugTCGwkZXv7/vkkjzoY0erw0c1EhnlzppLTpStwwRIWX6Ttd9eQXeoVCwGw2lSlpXNnR5qUkMZRNKH8+NMeyRH6p2liidnmr3dkc4GaEKPkkZ1R3z75EU8DkBWXwvksa4YUOefvrOwZYoJSjRlj8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by PH7PR11MB8525.namprd11.prod.outlook.com (2603:10b6:510:304::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.23; Thu, 30 Nov 2023 16:11:50 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::b960:9754:455d:b195]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::b960:9754:455d:b195%7]) with mapi id 15.20.7046.024; Thu, 30 Nov 2023 16:11:50 +0000 From: "Aktemur, Tankut Baris" To: Simon Marchi , "gdb-patches@sourceware.org" CC: Luis Machado , John Baldwin , Andrew Burgess , John Baldwin Subject: RE: [PATCH v2 02/24] gdb: use reg_buffer_common throughout gdbsupport/common-regcache.h Thread-Topic: [PATCH v2 02/24] gdb: use reg_buffer_common throughout gdbsupport/common-regcache.h Thread-Index: AQHaHx0Tk8QjW624gUih/hTB3RGa+7CTERYQ Date: Thu, 30 Nov 2023 16:11:50 +0000 Message-ID: References: <20231124212656.96801-1-simon.marchi@efficios.com> <20231124212656.96801-3-simon.marchi@efficios.com> In-Reply-To: <20231124212656.96801-3-simon.marchi@efficios.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|PH7PR11MB8525:EE_ x-ms-office365-filtering-correlation-id: 5a2717af-a39f-43c2-cb78-08dbf1bf0f73 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: acrR9tenKlVmqZFT61rF3nI3B+X1GnmqZ+0gEMz6/4JyWBBUkLVXBi5TX64+EZNsmb3ItwAdab1rx39EoNPCSpd7PG9lvzjSB+cSecbOHfCWwySKg1nq/kvlJM/0rlHkJx9ETeB1udMxigm3LNTX+kU+2FIlva+tR9yX572gETLT1021n0TG1AdSsKxJ5C13xx5NDbL20nIYLaf2Na5rViLu61JmpxVZCtDYo2qc1mAdyHTSZtyxGs+oMz0rRDm8ERUTAWou9fKkRv5gLXi52XnSvlrXb/xo25Gk9GBSJ5vkzIwAtnsZCWOBJ6Ode0l5OWUO7WqwPw8VRmYeFYxVmjcPWEZx9OKztgDBCu/Kkmm1Xes4kJmULtrFVINh9eqU/mQisPd5HbpSOzcNmuRF7keVtZ6ASfl6ng08Kw2saZuOIXk5aee9VEmCztl0xFnSWZfoyVC3GVJUQwRc70VbyOoIItGp7+Bq/XZS7XwLC1q9TiGeBQ/eibABrg0kwwjHUlx3BeYoSez2kux+1Zg3ObkDOM5BDl0XiAQt+eKoaBhLzf59uCir9EeCsNiWRiHe0EBrpVsIELmfYdtkddDra5Gabsp84mpB9N0bJswHzlc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(346002)(136003)(396003)(39860400002)(376002)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(41300700001)(38070700009)(71200400001)(52536014)(4326008)(38100700002)(86362001)(8936002)(8676002)(5660300002)(55016003)(122000001)(2906002)(26005)(110136005)(7696005)(6506007)(478600001)(316002)(66556008)(76116006)(66946007)(53546011)(66446008)(66476007)(54906003)(64756008)(82960400001)(9686003)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TuHl9QhRWTbonukmvzJkin4NPHbrE45ocABXWzi9g5O7vX8B8jLPknNHIj7A?= =?us-ascii?Q?up6vXk+NmyPPhUtclWRdIfhvtegpfHRmg/tQBKnM8MPikq5MGVkuS9oqgWMi?= =?us-ascii?Q?fR3bIsaEBBHBopynWzUkqyRUe3xo4ijYabDPP8l5nQNaMb3E+kIddLQCSgD0?= =?us-ascii?Q?YdOnxyVDBdL0uizt0NhA2yiMdd85hHexYtm9ZYwEqahTeOlmDo3GXnLy7vrj?= =?us-ascii?Q?eqW8iLqNEqIDmPk/4vzQsSvV+E9Tu1RP/sfc0+GdI2/19XLT87+eyjE+dmaW?= =?us-ascii?Q?JvcPJBixJ9BYNp42lFYmd9JcIfm7y5Izl7jX1vLOe3ghqscVBI52B+/iLM2q?= =?us-ascii?Q?yTKnnnckpQ+0j6BTQzaVO/tuR6r+I+u1ii9OxC3lhSkZQg+/3DjHnVYIbZeq?= =?us-ascii?Q?FyT7w3U4pU+delMDl7+iq3Pdy2DdAdfjMjI9NcxBb10Pw/nVi28pHzYpZEWy?= =?us-ascii?Q?XGV5qaEKm3avc/EtBIjWejqwVEerkT1j0on5SYsa/Hs/2M3QizvSPteTd9gX?= =?us-ascii?Q?vdtkeTbUaIPFgw5g8W2LYcKo6E4i25ctOwSuMPHYkBMnMJeSYSnxo7vVtxjA?= =?us-ascii?Q?R7dKQtz30Mznu3ZUN48pjBlaxqR7nabS8Bd4cChsixuVS4HzW9BgxGnvh7u/?= =?us-ascii?Q?6rTChwDHxXeXdsOIbmN3YakJ+0N1kUQmfrK+ohyyhOFIq41cULC/vlknvWDL?= =?us-ascii?Q?fd9uJyvyEu5Cri/5diWdYKyRJ/Xe9JlIrrxT2FQPupFDvPm01FpBWvhjvntR?= =?us-ascii?Q?rzT0Wvuow2syJPLoa0DJsnn4lLQU7mIWUWA3wCX2DvlQLv01stj+QMkuO7G5?= =?us-ascii?Q?3GbxWIB7/jZo6l0PxG6vW9n4PVEO31L2gjLm0O5o00ly8piITRGwCBWHiHic?= =?us-ascii?Q?FoUvaY/OukVGIa04zZPM2+6d5gFyDQ3hfyNuAFF8GV5PjE18WnC8hivc6Gd1?= =?us-ascii?Q?5t07i0PBbTeQnmUaVYNoiDbXslZn7IAfgxzzZGszOqLljpk7jit+6ZgSb/71?= =?us-ascii?Q?CIBEirrEEX1UnonUaHTLb1aIra0Gr5IRA46kzbvB7uIeI4CpS21207/l/W/A?= =?us-ascii?Q?V3p/zmnQwwKp+lIBkw9kY7AHuMsGmRI1kkAy1cs546fceQ+N0dR4lH1H7/nY?= =?us-ascii?Q?+5GZM+qjM02jU0+GO7mfd3cVpV6aDtAm69Tno4Q3l4by+xZRqhAQ9VCgpDsZ?= =?us-ascii?Q?1do9TrnMIJQQKxJOVoTn3TTWSiB+toFr+IPcI41CKtnQxtYmrRMA8cXEB95X?= =?us-ascii?Q?37FVcLzuY8k2tm9obP1t4pQdVEr3E7Rphgjh3kezB6Bma9ECHxwUVMJtCQoE?= =?us-ascii?Q?poRs/VeROv8nY00ExXes9ICiIDC5QxMW/1Y+48Ty5uWGGqGy//P88L04i+2m?= =?us-ascii?Q?jIfTt4kWt6eGXJGQz8ZDtcKc7EvYnafrOSpUjFrP1jQxcADx28WR+DIA0e6A?= =?us-ascii?Q?4C+pAM/qlf2A3n7XQ3EtXZP4ogoJhn4KoN1g32CkdcmH47SIuBcUCV4h4Pau?= =?us-ascii?Q?Uj1Ep2Hh0eZhSKT1EynpfZXZ2iFVPF2Or0J78SzaSe3BU38YII+wUQj4+z2n?= =?us-ascii?Q?bNPGo26DvUrQje+Ygigdsb9oyIzVZcVZYX1raSTGSoZ/g+TZdIuSdNKFzdEX?= =?us-ascii?Q?rA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a2717af-a39f-43c2-cb78-08dbf1bf0f73 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2023 16:11:50.3092 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D9IOhVW43yuq+Bq05Qm7zPRWh7wueBxn+t1kdFkzCFLTjYuteIwolpefVhiih+lvtHeAG2yj+Oizgz14WtI3eRaBx1ujuck22aAV0eSjZ+0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8525 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Friday, November 24, 2023 10:26 PM, Simon Marchi wrote: > diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc > index 2e75a948a198..336b00008be5 100644 > --- a/gdbserver/regcache.cc > +++ b/gdbserver/regcache.cc > @@ -21,6 +21,8 @@ > #include "gdbthread.h" > #include "tdesc.h" > #include "gdbsupport/rsp-low.h" > +#include "gdbsupport/gdb-checked-static-cast.h" > + > #ifndef IN_PROCESS_AGENT > = > struct regcache * > @@ -64,7 +66,7 @@ get_thread_regcache (struct thread_info *thread, int fe= tch) > = > /* See gdbsupport/common-regcache.h. */ > = > -struct regcache * > +reg_buffer_common * > get_thread_regcache_for_ptid (ptid_t ptid) > { > return get_thread_regcache (find_thread_ptid (ptid), 1); > @@ -307,9 +309,10 @@ register_size (const struct target_desc *tdesc, int = n) > /* See gdbsupport/common-regcache.h. */ > = > int > -regcache_register_size (const struct regcache *regcache, int n) > +regcache_register_size (const reg_buffer_common *regcache, int n) > { > - return register_size (regcache->tdesc, n); > + return register_size > + (gdb::checked_static_cast (regcache)->tdesc= , n); > } > = > static unsigned char * > @@ -437,13 +440,14 @@ regcache::raw_collect (int n, void *buf) const > } > = > enum register_status > -regcache_raw_read_unsigned (struct regcache *regcache, int regnum, > +regcache_raw_read_unsigned (reg_buffer_common *reg_buf, int regnum, > ULONGEST *val) > { > int size; > + regcache *regcache =3D gdb::checked_static_cast (re= g_buf); > = > gdb_assert (regcache !=3D NULL); > - > + Trailing space seems to have been inserted here. -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928