From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by sourceware.org (Postfix) with ESMTPS id B3F813857C42 for ; Tue, 5 Dec 2023 15:09:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B3F813857C42 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B3F813857C42 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=134.134.136.20 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701789009; cv=fail; b=ZlDH04z4EC3X0r3yrqBEWQl4EoQjF/bWJNcLGQPjgB1C0f8miipAPfkNjGqGMCxaIdb+K7svw5JT19XKT2VClEgkvHlQMmvmhsoGnE8tFCKz9RW+oFm2yTP85rui7O9G4ZPtUcgGasb0I3TH4mIHs6wOFTU3t6RVYBwQcu49dfk= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701789009; c=relaxed/simple; bh=VQr4FgCrFeI8wNnUs+klhP3g9FF2EtiNRph14wwDZpQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=R5uguvlwtXIJ/a4yzIQR1SaqEW96XNQVkl85/L6QQqd25D0mlpaUvChaITz+q8mf1U5b+gEqHieDT3KJXY+C8I2m7qYUNk5htyViw3vf/lI48zh4aGWIc0AHN/CC38Dr63hbE/bT19afmawFoVkQfXLULXtGPNydGnmj44WOJXY= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701788998; x=1733324998; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=VQr4FgCrFeI8wNnUs+klhP3g9FF2EtiNRph14wwDZpQ=; b=lZ6RtikRaFNOGlPY2eo615pvCvpSAelFUfbLiRraQt0mlVG6erxeV2px YCPYwQpENjs+mm3tSaGHzHFEWZZH9L3hPm8ww1FQ63vXU03Se5ODy1ZIC wdTmalhZHXPvOZ+PitEZwZ2yDZT4cI0KLLO3EotGojNKfArSiv32UW0Kp bStDKLJarTs6j+UXGrpEgjT3KGjMYHqeC2GN2cIizbFeVtGMSSCPIe9DM f7pHrh6BKuRlBKKT1Rk00zAB+QNOL4k591md8lSfJNFcQR5v10u3sT5CX wc8IUR06HQ894wn8rIRJeUHtR5YCruFK7vBU+avxhvAtEgYp6q3sC5axz A==; X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="384309398" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="384309398" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 07:09:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="944289187" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="944289187" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Dec 2023 07:09:55 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 5 Dec 2023 07:09:55 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 5 Dec 2023 07:09:55 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 5 Dec 2023 07:09:55 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Tue, 5 Dec 2023 07:09:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oTgjrym+gO4qk8VCfbPQqBTrLG7GHtT3hZa3tchT+lm7icwr116Uoy7jUcy6r4repRCUGCEhKrcXGOn/+7viGhwqMNbspHi8iKQqyKxg9GPZ1ETpvgJ/n3iusHAkjosIHOz9qxyXzBLo8FbDCS3EXAjGG/yq1k979+cAEpyYRWBitSZKaUa9/iKj2AlgC37IabzH4ld3q4PPlR2Vs92r/hjXZe2owWKx9ZzgpGdeyai2JIygXVtGWOMDHT6ZS5gAX8z6qcOfyf5OOUWTU+3702fyZIrxyga/BUF1mB3RgIoBpYqsLH80HVUIwbGptY3huuWTo4EcoKqBvOI5ay6WbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lSoav1Gnuo915LHwGOtCO8LEhJcij4CLI09aDrugOHE=; b=DMpLpH42mr8qdsCzOB1ynPfYOv5Nj9IT+FYmg8zorDjQgzgafmb9ZZaJRArB8ePYXVjKHC8iIYjeTPWF/+y5/EuNb6JLT1lSEq4Sw7IUgTr8mPY7aunGfTKMXMYcBPPxqYkJdPApVJ/Aa5g3yK5CtJT/15ASvAXnW267tcOUjvdBUIQThM4vspReQEmAns5IIl5bwTdeZIN+cJ71IO/+2roQWmJVk1M0+EKskwwKLYqBBE7U7jLEFyFiKLTFqfeOPZpWLyu1eJyZulxIaDPHGAdgB3EhUtEIy6j590uDWENHNNsyvZm+xxBhuX4I+UfVdpg6s3anU18p2u5Ty0JFxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by PH7PR11MB6032.namprd11.prod.outlook.com (2603:10b6:510:1d3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Tue, 5 Dec 2023 15:09:52 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::b960:9754:455d:b195]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::b960:9754:455d:b195%7]) with mapi id 15.20.7046.034; Tue, 5 Dec 2023 15:09:51 +0000 From: "Aktemur, Tankut Baris" To: Andrew Burgess , "gdb-patches@sourceware.org" CC: Eli Zaretskii Subject: RE: [PATCHv6 06/10] gdb: parse pending breakpoint thread/task immediately Thread-Topic: [PATCHv6 06/10] gdb: parse pending breakpoint thread/task immediately Thread-Index: AQHaJQyAxkSyt0Io6kG7ShR5XLkm27Cad3Nw Date: Tue, 5 Dec 2023 15:09:51 +0000 Message-ID: References: <2b291071a7869e0ca69aa89d3f197c68512439c1.1701513409.git.aburgess@redhat.com> In-Reply-To: <2b291071a7869e0ca69aa89d3f197c68512439c1.1701513409.git.aburgess@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|PH7PR11MB6032:EE_ x-ms-office365-filtering-correlation-id: bde3d82c-2f17-421e-6745-08dbf5a43ad6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: t+WUY91n4c1V30NTn5UA55SPG80wqYPD5nzCPwVkz6OTB6C6FW74n+ZrO3OHVOVluMLlRT9BEkO5EMMbtxiwM0x2rnR6tYyPF33Jb8K+HDEibYO5DiOW9jTeCOQFOy7gzivlEkUyoglUomI34FU/j388Rnfen2tJ+EILYTM4AWPaJ6Nq3wQ2wvQ1msHvOw59zWVJ7oV6YVqiQzN9b0IAfoDR1pd5xJ6FQlz5QN0LoB1cuAdcw/4pXclNIsD2Z+6Iyyhko4H6HHahbQddN/RXRHPQalslRx0xoeeYRLGrg+tgZormoCRSePOP55h5M+YSfhHhHvePpFTGw1TAcuzr5AJT6v7kl2dE0f4QBRFiVCKRH/adLe0QZzRs4Jf+K02L2D0T3CeJI/ko1dlNXroQjDFpRNMOyqe+uN5DSQUchp90su8G4VC4VZOUDCF2MwyWeILPckYuI2IirmfoGnB9zq2GHZ8RJSUtQv8pShT1NXXKADgA6vDXUVFnbV9fjJ/Q+N4/inytNGEo8vBi6fmvCYuX/H96q/tG4ATbneh57w7U2DR+ztcX93AUXDVXK5yVgGdVzW+KCz4ZnSlX4fmg45vjzEK71hrISS1I9NxzakTuTv+sULixW7fnMpSZvTdGQgqaHQ5Ed62/Z24+YhlCtBreTzUa4hCtF/bvaGa3LsNgTA0RLBSsG/M8BEEKi2Sa x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(366004)(136003)(39860400002)(346002)(396003)(230922051799003)(1800799012)(451199024)(186009)(64100799003)(8936002)(8676002)(52536014)(4326008)(7696005)(6506007)(966005)(71200400001)(53546011)(26005)(9686003)(110136005)(316002)(66946007)(76116006)(66476007)(66446008)(64756008)(66556008)(478600001)(14773004)(41300700001)(38070700009)(5660300002)(2906002)(55016003)(38100700002)(122000001)(33656002)(82960400001)(83380400001)(86362001)(2004002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xWGKHJD2xMtBNlvP7OKyccnO708gfPPZ/I4ZEnoN5onl4Ww0DxEPVSPx6Szz?= =?us-ascii?Q?zPIkXcV4Wh5hwbkclqXr2vPLu22de33A3Td+wxVYwqbId1hh9AaXA5wpgQMI?= =?us-ascii?Q?NE6BZO1WE/WagwlQQCpUQbTe7si6pKVngefqKMTXaddLJymH//M+3iWrEN3q?= =?us-ascii?Q?ey6bBENspQ5PTbJB1uGINq/xq6X8OIwLkj3YtZp+jpVU3XEMGYkANl74kZtX?= =?us-ascii?Q?0I0dNAInVAAqxBDyMJTPkaJmpVv5E9mO0YmJ71YE2Bgq1WxfYcnH7RBdTg0i?= =?us-ascii?Q?eJ/JFdb02tDbaEZODAb3kEDdh6vOJEHO0AbNoQHTii7wyYxpkUSwCJEU1swz?= =?us-ascii?Q?rHpR3rseM7gx6MXQQ+ue/RMH4RmJXbJWm6y7gZE/yGrNPrcaWLOxp/Up2/oi?= =?us-ascii?Q?6RbzZTx5by/4w2c08RLcbhbG1DCoVGIgUl1tdsvta7OTtPRdPrZEA0srpMgG?= =?us-ascii?Q?zFADdAxnKivCVBE3sKHUmCO0dvOQgkqCxqlonAUp066WySwECaKhMSw0wm1l?= =?us-ascii?Q?tYik6CEce3N1WKU03u2z4f4mx2XN4WyTVviWvO2UIRKMvinNqVZMsYvl4ca/?= =?us-ascii?Q?K3wCf0oF8gGROw054fCEJMJowTN9dGD7XkUAZO7B72xqi4XMk/0jUaHWiGKW?= =?us-ascii?Q?JoSZ2vOeREzUNOvmj4SQQMfwrGyMLaJcrH7M9HTWqsDvxOhpKjWAfO9uoPs6?= =?us-ascii?Q?51zbxSylgnTgEcJNy4bUO4ZtkewhyioKQmmZAljiuk8CBR1r0dwYIW5wjN4o?= =?us-ascii?Q?6cS3L0Ky+HmH/0dd/Dui2sQJtcGNPD41Gg8c7RPOF8OPVQg6gjLfAodGBtX1?= =?us-ascii?Q?GTsNs28uvWC9yD5Xkft55C1ZVWRFBbBhx/lWPeoMASKoPoCIej0hAL4msECg?= =?us-ascii?Q?9bVuTjLcZa7ci/iGz8KqW1se36t5WKd9gRtmLMLej96TT5eFYasAu1mRwf3Y?= =?us-ascii?Q?vh4xcSgmLmZPE4mev59fuX4eTr9p0z9eBpgI31PfHvf7+40T6IDnHattlAlI?= =?us-ascii?Q?dbZCuaov7/COLTuFS/4vUGpEU7jrk4Hvi+bJJ4rlPjUWYNSQUF2M0DbNFbb/?= =?us-ascii?Q?ke3VjsBI5Jn9IjLD6BKu6Thn4kt1fJyZjrr44/B95V7t/cXgxOwoRFZg9CH6?= =?us-ascii?Q?CUpMLpjvfg053/RFGNUSBcqnJVXRoOlt3OR4Cn+85cgkCcg9Y1z/NcHEisA3?= =?us-ascii?Q?402sIvz2PiM6QoxCPFMPTd9DyTbB1+EvNckwQjMBHwnYIa/FoJQG2EUe3zEy?= =?us-ascii?Q?tY6+UrFW+eA7llBvCbIrp3h0urGw/yv5yT87rbBR6p9KE1e65LuiPz4c8pok?= =?us-ascii?Q?0bH/l8YC57fPGIdix99o9xQZGsCHTeArLdNT2zf5Tj8slvpFg9fea4QaJofd?= =?us-ascii?Q?DWaONzpF7Wk164EwrWhcMmk7B9dxbzovaNDmuTxo1djqHl07Kp8aUClE+N0v?= =?us-ascii?Q?rKvS80/I/2Mqfz1jn371BcR+SuwEq+4vkFOlUA5HAB3J/WSYZcnAp7+yHEHX?= =?us-ascii?Q?4D9aogXZVu+iIH30PnkHS44+zQyssQ7NZmYb7A0AZ8awW6k0LjjoPW8nLg8D?= =?us-ascii?Q?xUeTS2qoJsDyTQSnKWdVwuI/+LYHSMqc/P4qUXAzjZd7B+A+/s0ApKnYquAB?= =?us-ascii?Q?kg=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bde3d82c-2f17-421e-6745-08dbf5a43ad6 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2023 15:09:51.3286 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IbqQEc0yTl1JgHXuMIq22x185L077OCDPZUXu8neEfM+d2JKsqi/OYsf3bDWqa0EgNWWClMX4VWM+VRkVo8NMTpvGcp/tLkJxdLkZeoDXdA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6032 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Saturday, December 2, 2023 11:42 AM, Andrew Burgess wrote: > diff --git a/gdb/break-cond-parse.c b/gdb/break-cond-parse.c > new file mode 100644 > index 00000000000..b59bd7aeeec > --- /dev/null > +++ b/gdb/break-cond-parse.c > @@ -0,0 +1,463 @@ > +/* Copyright (C) 2023 Free Software Foundation, Inc. > + > + This file is part of GDB. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see .= */ > + > +#include "defs.h" > +#include "gdbsupport/gdb_assert.h" > +#include "gdbsupport/selftest.h" > +#include "test-target.h" > +#include "scoped-mock-context.h" > +#include "break-cond-parse.h" > +#include "tid-parse.h" > +#include "ada-lang.h" > + > +/* When parsing tokens from a string, which direction are we parsing? > + > + Given the following string and pointer 'ptr': > + > + ABC DEF GHI JKL > + ^ > + ptr > + > + Parsing 'forward' will return the token 'GHI' and update 'ptr' to poi= nt > + between GHI and JKL. Parsing 'backward' will return the token 'DEF' = and > + update 'ptr' to point between ABC and DEF. > +*/ > + > +enum class parse_direction > +{ > + /* Parse the next token forwards. */ > + forward, > + > + /* Parse the previous token backwards. */ > + backward > +}; > + > +struct token > +{ > + /* Create a new token. START points to the first character of the new > + token, while END points at the last character of the new token. > + > + Neither START or END can be nullptr, and both START and END must po= int > + into the same C style string (i.e. there should be no null character > + between START and END). END must be equal to, or greater than STAR= T, > + that is, it is not possible to create a zero length token. */ > + > + token (const char *start, const char *end) Have you considered using std::string_view? > + : m_start (start), > + m_end (end) > + { > + gdb_assert (m_end >=3D m_start); > + gdb_assert (m_start + strlen (m_start) > m_end); > + } > + > + /* Return a pointer to the first character of this token. */ > + const char *start () const > + { > + return m_start; > + } > + > + /* Return a pointer to the last character of this token. */ > + const char *end () const > + { > + return m_end; > + } > + > + /* Return the length of the token. */ > + size_t length () const > + { > + /* The + 1 is because the character at m_end is part of the token. = */ > + return m_end - m_start + 1; > + } > + > + /* Return true if this token matches STR. */ > + bool matches (const char *str) const > + { > + return strncmp (m_start, str, length ()) =3D=3D 0; > + } > + > +private: > + /* The first character of this token. */ > + const char *m_start; > + > + /* The last character of this token. */ > + const char *m_end; > +}; > + > +/* Find the next token in DIRECTION from *CURR. */ > + > +static token > +find_next_token (const char **curr, parse_direction direction) > +{ > + const char *tok_start, *tok_end; > + > + gdb_assert (**curr !=3D '\0'); > + > + if (direction =3D=3D parse_direction::forward) > + { > + *curr =3D skip_spaces (*curr); > + tok_start =3D *curr; > + *curr =3D skip_to_space (*curr); > + tok_end =3D *curr - 1; > + } > + else > + { > + gdb_assert (direction =3D=3D parse_direction::backward); > + > + while (isspace (**curr)) > + --(*curr); > + > + tok_end =3D *curr; > + > + while (!isspace (**curr)) > + --(*curr); > + > + tok_start =3D (*curr) + 1; > + } > + > + return token (tok_start, tok_end); > +} > + > +/* See break-cond-parse.h. */ > + > +void > +create_breakpoint_parse_arg_string > + (const char *tok, gdb::unique_xmalloc_ptr *cond_string, > + int *thread, int *inferior, int *task, > + gdb::unique_xmalloc_ptr *rest, bool *force) > +{ > + /* Set up the defaults. */ > + cond_string->reset (); > + rest->reset (); > + *thread =3D -1; > + *inferior =3D -1; > + *task =3D -1; > + *force =3D false; > + > + if (tok =3D=3D nullptr) > + return; > + > + /* The "-force-condition" flag gets some special treatment. If this > + token is immediately after the condition string then we treat this = as > + part of the condition string rather than a separate token. This is > + just a quirk of how this token used to be parsed, and has been > + retained for backwards compatibility. Maybe this should be updated > + in the future. */ (I was the author of the -force-condition patch.) The quirks about the -force-condition flag were not a deliberate feature. For whatever it's worth, I think it's OK to de-prioritize backwards compatibility for this flag. I doubt that it would impact many users. In fact, in a post-merge comment, Pedro and Tom had suggested converting the flag to an option rather than a keyword: https://sourceware.org/pipermail/gdb-patches/2020-October/172952.html https://sourceware.org/pipermail/gdb-patches/2020-December/173802.html https://sourceware.org/pipermail/gdb-patches/2020-December/173999.html I (embarrassingly) did not have the opportunity to get back to it. Maybe it's now the correct time to address the concerns? I can gladly help. What do you think? ... > try > { > ops->create_sals_from_location_spec (locspec, &canonical); > @@ -9285,6 +9122,13 @@ create_breakpoint (struct gdbarch *gdbarch, > throw; > } > = > + /* The only bp_dprintf should have anything in EXTRA_STRING_COPY by th= is This sentence sounds odd. Did you mean "Only the bp_dprintf type should ha= ve..."? > + point. For all other breakpoints this indicates an error. We could > + place this check earlier in the function, but we prefer to see erro= rs > + from the location spec parser before we see this error message. */ > + if (type_wanted !=3D bp_dprintf && extra_string_copy.get () !=3D nullp= tr) > + error (_("Garbage '%s' at end of command"), extra_string_copy.get ()= ); > + > if (!pending && canonical.lsals.empty ()) > return 0; > = Regards -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928