From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by sourceware.org (Postfix) with ESMTPS id 9FEF5385840C for ; Mon, 27 Feb 2023 09:53:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FEF5385840C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677491602; x=1709027602; h=from:to:subject:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding; bh=/gKXimyzeg5XxqEbJdQBLUTrkw93+CI57wYSGGzo7vk=; b=FkWJCwRv522Dztrh3fzQh+TQ4O8LJ+qRKzP76e4pkmzNBNfI3pgVYQyT 25WXtBg0AvcBnjSIq4QDKpjwD0klKjKnRD8I9K1SFG0oeTd9sUlsHscsG RKTU3WP8yGAs9uykYxQ+52+YIRoJUyV/NGp2DuqPeoj0iRxyeGOqlX8yP nz+NDfJHI7HsRvpvr+/x5BpwL7Mb9e2F3gNMgHR4r5oCGLWoWyneYipdf +oUGoP/PE6eRTkEtETPeooxWI4h3t2Maw2aZirAPC3BZB8bZ4kMsQx2dj ej5ueHvd5MEpUMV+qz86uRE+BjO2cdESLfC5HjHmi1CTpzgr3irkIh7hn A==; X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="336101833" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="336101833" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 01:53:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="847756388" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="847756388" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 27 Feb 2023 01:53:21 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 27 Feb 2023 01:53:21 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 27 Feb 2023 01:53:20 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 27 Feb 2023 01:53:20 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 27 Feb 2023 01:53:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JV2d0jpOcek0Wljujdy4Zg8/pFyAtA4zvza1Mik8n98v2s5sa26w23d95UJ75qm0Kiq4rm+2gSKM+EV0MTsNPLX7viFMuNDxs37oqS6JJWf9hYIEFEa6Ri5Y7E37fd6BPVUUxONGV6JZLoxeGoopxwDxjckz/DLFZ+mXiXuqB5i897d43sJkNaVKNkmAdcGGubsdo7Fn3jM0oTWcoa/UPlc3Nc2ZT941/xcYADs6Y85e8vESUqWzzMzs90xO5Ro9mTiVMDSRHk4O0sHzfO6RC41Z/WnFCdtVIC/M/bieDOCXKGfU6kSH7skQbuFzsdmbpNgWcWP4UHgYGNUG10NVBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pUZqsUY3v3kKGa8MnMtH+Ekyt7FwaHNX25PSXr7S8Iw=; b=hJ2rcE9dtEwMLI3cH6PuQLmoW+qnT1e6e7mrHEKRktBGuYTCfqtN5voIQAE8KdQabW5oIDTIlbGBo3ffvFAZqIWRGAK1JteHL/Nx8FG9Q9v2LUvsoVeldenIX5DGzQc9O9oKIA4WD8ybBW7AGaMj0/J8miqf9I6tGrgPwktRM9/61OvqtncNgmnVFlqWRZU0Ny2ynjOATCNCPRbWhSx60uOEryU81QFxnsQOeXhVEV1QcaZ26u/snXWH/ZYFYkB4pYd8CX7ZPUzd52DsfsmUWtaDQIXOjnzZ03i/uZTRQudvyNI3CfxCJLzYtqr4JVXGQgIJDIwGPK8Yj11WrPPtBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by DS7PR11MB6101.namprd11.prod.outlook.com (2603:10b6:8:86::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Mon, 27 Feb 2023 09:53:18 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::dec6:d57d:f767:c5f2]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::dec6:d57d:f767:c5f2%6]) with mapi id 15.20.6134.029; Mon, 27 Feb 2023 09:53:18 +0000 From: "Aktemur, Tankut Baris" To: Tom Tromey , "gdb-patches@sourceware.org" Subject: RE: [PATCH 2/2] gdb, python: selectively omit enabling stdin in gdb.execute exception Thread-Topic: [PATCH 2/2] gdb, python: selectively omit enabling stdin in gdb.execute exception Thread-Index: AQHZSFj9VU/SoSBLCEyly4D49TyT/K7ef9j0gAQQkgA= Date: Mon, 27 Feb 2023 09:53:17 +0000 Message-ID: References: <20230224140410.2647437-1-tankut.baris.aktemur@intel.com> <20230224140410.2647437-2-tankut.baris.aktemur@intel.com> <87ilfqhmsx.fsf@tromey.com> In-Reply-To: <87ilfqhmsx.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|DS7PR11MB6101:EE_ x-ms-office365-filtering-correlation-id: d250c0b6-899d-4c7e-226f-08db18a87394 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +UtJV7kRHcC3gvYdv+lRa63fEEnqG2A3myrZ52sSmdFoeTMiDU0+897y+VsSwc3V9wOWUPyavZLJ0izz5yzv4dOzLLPrPVWzSt5KzVU5IqOROwXF/gAaPhZgbXp4uFYw+PhsWhAIgYXHKX4K7EzXQHl1ZMjgQTsnO7wHaZfqEUPIKd/gIjs6w9DSzp48DG0bpQpB8s1zn7ur8OBrMCcSZOcVOeHHNNueOnhnyeHz1sUXwf5EjtxV5Aria/XmUArF8ViIkVKyd6uoKh6w7DCRhkLYMya1grv2fWmPtwaZBH6epzX+eS5lxd7GUhsCSd/TrEDDcmBN4kZwKb6ZU+UDmkoiXjkUDBDTH1IjLzqxfVdCbAmRBKUqrflojffNYLwBWiqMFmyoVglcJs2Q36AOWtkGu5jDckPLl/hGm8FrfPBScMDopOrQJW7tVP52TKpBRr0crhhDTpq+tU0xIZbkHBbgTSkloh5NAO1iaBcONM14Epo9bGr316cb/5FV3jSO7IN3H4MnxR8NohhtYctPT9au8ZavFmImXQmMqwC6kE1TIzjFUF0TJg4kNjVgrh5abQ5lbKRxOXM+l85Kl2mgWiKQvdREmPoO4VYZJTBmIk0yLtfCqQfULTxx8Q+cihKAE5T1wglB4bi+LtEY6A5AzNBYsKmszG+4GEC0CoosI2+/n3SjtJCMaZCJsGCPKuYQzhXqeErxnaIl6lzrI8FZeA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(376002)(366004)(39860400002)(346002)(396003)(451199018)(52536014)(8936002)(38070700005)(26005)(316002)(53546011)(9686003)(82960400001)(122000001)(186003)(6506007)(55016003)(478600001)(7696005)(71200400001)(2906002)(86362001)(33656002)(110136005)(5660300002)(8676002)(38100700002)(41300700001)(76116006)(83380400001)(64756008)(66946007)(66556008)(66446008)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AU0EgHA+ODEmCLcitLrEMfnPoJLDlBHC4FtPbpjZ2PM5Pnt4DkfBeScMWLq3?= =?us-ascii?Q?Kp/4h0m1METAjJ4eYmdLDtEECYBQleFO/NIijcDIYquRVGZHTei4X2dlwYxN?= =?us-ascii?Q?mQyy65KyyXC1NnfTkWzqVeGPN3OYdugTn/EMpB8PoTQL7Q27JmwYxc0XITnD?= =?us-ascii?Q?6+hBRiXqYZXhn78cDJdlAmt485qn4Q5LH0udSp/a11hFQXGEXOxWCjjdrQca?= =?us-ascii?Q?AoIHCLecXDN7mMVKkjLx4fvXDhPoGK7P8IQsuo9VTLlnqvaTgp/IM0R34zP5?= =?us-ascii?Q?8qlzojB9nPhbGkUjAF1HUtNcNZ7S9lYmodGMdH0BMKhwXEwn/VqSxjkJHj5r?= =?us-ascii?Q?22dGrsdcTCxI8Vxi+KVVo9JRzqCir/1d/XKsHiFYkgq7BsOs5gsaLfSmr6tw?= =?us-ascii?Q?rh06r9oGF26KrBC9UFavzxkHmRT/5Vyjypar75wms7S4yqcjzlBIJG2SD+wf?= =?us-ascii?Q?ZLp343kd+T7CjMtQH4KMzZscQcL+/ZXYtGIJuWHDUUQMQEfFshzajwTtw4KX?= =?us-ascii?Q?34eRdRvqte6EzB+aEs9xM8Qxq9In3CdnJA6CQwxCoAlq+a4EKO8iItm+Hdow?= =?us-ascii?Q?oPUuPRWS2CGZUO9536CZcmLqONSqRCar1aKRFlgNkwycgTMJEiHXWWAWI7bV?= =?us-ascii?Q?bFFnwDk1omHF+ayxI+sDlYaNtDseIlfreyhKXeLdr25Ka+FvcNYZC4ky+uF7?= =?us-ascii?Q?oDR2FeIztuDpydBbwx59rN6CJ8QccmbtbxWqxsUfpGfQ4vfb4TXU6My74WO8?= =?us-ascii?Q?CC55K+SuySI9drsUm35x2HMkiG0pZ3dmCo+zsa28wz2+z5gqgrMdBJpSVTdR?= =?us-ascii?Q?L0TolltixKeCWXXv/Br3LaebCkPLFOsAb9wRgT8ZhHjTV+A2mLbGSiN/kXuV?= =?us-ascii?Q?MwprbIphDFIZO6ojxHAumsvD9t2pWTRjmDmjIDw4BcgimNHud52/y0xzVPoz?= =?us-ascii?Q?yeBWaYE0x+3QobnFpqo5RzYQ99c2DzHSxj/hF2Q7cOXZTfdb267n5cZNNNO7?= =?us-ascii?Q?bp8+HlpUOfoaGMghF+XqJvdgGNU2RidkFoJE9JqMlMJvQj6OgYLalwvY6dQn?= =?us-ascii?Q?pXVeKPDBrYV3+U2w8LmFsB8EHOKrGTfBceLV+Hp8HJ7rlwUwI+rjPbGh5UbV?= =?us-ascii?Q?klBTVY55Rq2xjP6wTfZAHqiSOIU+q7Ok0FDJBc//J6ts7ULWpd/UcrJmS3VM?= =?us-ascii?Q?NvXMiDZgqOHB63Lh5CHHP3T2rk2jWeb/4x4LT81W79pi+gvG0Qd1xW6nr/5u?= =?us-ascii?Q?qHbJB0o4pOvB6YJ6PPkaZiQnmPjllrXPbMM86WJ7ahljudlS3YAHlsqXQYyn?= =?us-ascii?Q?DHmysUIn+y6IwHRz6i3A4TfEDV0GPwF0CphYYsP3naVp8UPvQQgtoXQ88NIM?= =?us-ascii?Q?yEDp8dHdyZQHViaVzKhuUY98x/jUXhQfI0BkXjOu8j+ajtV8b95cS1x2XbPw?= =?us-ascii?Q?iXHcnE4naRreBdIAgDKl34V4H6iNx+OIXqXUjRnnBIFR3MMasFNxIUBLlp7n?= =?us-ascii?Q?r7cOCPpO9C0rrG6FPlma5lAjv2yFv5tjg9yh2JaEkQFxbonDvZschvATP12s?= =?us-ascii?Q?caJMCbiYB3c4/A3b9GZ99YV1piRM/46ks8OJvqYhVtJg9FnQMymET7ufeLLK?= =?us-ascii?Q?qg=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d250c0b6-899d-4c7e-226f-08db18a87394 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2023 09:53:17.5561 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h9oV3qGcPrJFO8jBcsAiIlbbTZdXKn8Lbd1s2Ns7PzEu+Yj3qhJjcHCMyrkNdyx/EQKbRfZ0dTBylP2IDVLAFT3rcg6/vCdy15lFTxMj72o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6101 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Friday, February 24, 2023 8:43 PM, Tom Tromey wrote: > >>>>> "Tankut" =3D=3D Tankut Baris Aktemur via Gdb-patches writes: > = > Tankut> +/* See py-event.h. */ > Tankut> + > Tankut> +bool in_evpy_emit_event =3D false; > = > It seems like there has to be a better way than introducing this global. > = > For one thing, are we sure this is the only possible context where this > bug can occur? > = > I wonder if execute_gdb_command could instead determine if stdin is > enabled before the 'try', and only re-enabled it if it was. This would work, I think. We have the following state: User runs a synchronous execution command such as "continue", "run", etc. --> command blocks the prompt --> Python API is invoked, e.g. via events --> gdb.execute invoked inside Python --> command raises an exception --> we're inside the 'catch' block. Before running the command that was passed to us with gdb.execute, current_ui's prompt_state is already PROMPT_BLOCKED. It seems we can use this to omit enabling stdin. I'll send the change as v2. Thank you. -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928