From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by sourceware.org (Postfix) with ESMTPS id 194693858D28 for ; Tue, 5 Dec 2023 07:39:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 194693858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 194693858D28 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=134.134.136.31 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701761985; cv=fail; b=aKnhnr4JiLlf20Sws5qZL1Cu5x0KWTWleoebPfpb2fMO3JuBGl6GyTMbmXtbFx+TW8M33+znrRmlbhpFauJP3FQH/or4vkbUPOYjY6cryI+EqL9Whfo6ntr8rbGJdhQZgqWJYiwwwQRkdYp9XAvsxBV2jPFPJCgDNfeJKfCv8+U= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701761985; c=relaxed/simple; bh=6Dw9E/4P4ngpoT1MYEIIGCkdy84/ycTLXchkWfwIOS0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=RYu2D7WdOQ+oQ8Lpc6YAKRC8gLLzqyaoyec/CSrVrGLVQ/dUYfAdM0ex9FK8m9rdzUHUkZPeH10NXThqxszItAIYcoUcYKIqH2QF0u5XwBqHmO+77Fi3O7/pUmhiLuZy3ljfqTGwrYUz6cI3xKMQbd6ioa1KI+B2XMy+2TGc5aQ= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701761984; x=1733297984; h=from:to:subject:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding; bh=6Dw9E/4P4ngpoT1MYEIIGCkdy84/ycTLXchkWfwIOS0=; b=RnyhzJ60eLa6ucd17oIsPsdwTaLMP2eDU32JWNq063k2cGQF5YUsbFnb djk0xyT1vlcIVKKZq8GDJ8DpprR924Q6DlVWyDaAPRSe0IFmeGcyqjVlc zzEWLt5g1j7M9Pt3rIoao5yIlAoAGyxq2g2UzOweCpszuMT643IajcTUZ +1tKpHGcZBSBcE0D8mEw/Yg1yVR4frTJ4Vn6pbWUw7C/ToV/nDJXPSiWt wFHX8JeIGxoxjEAQAdatj+6Xig0PksUNtGMMGBz3RwuvFJJd4Yo70btE5 ncrf2EgUudiIHgOyDi1ghfjaYVxN61KhgXmeAZpwlmuSj4OI+cN2rVr/Z w==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="458107130" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="458107130" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 11:21:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="12066890" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Dec 2023 11:21:24 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Dec 2023 11:21:22 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 4 Dec 2023 11:21:22 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 4 Dec 2023 11:21:22 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Mon, 4 Dec 2023 11:21:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HLRADDvHetscAFftPeyaI3xql4Mz3/3XM+XIvaVE3zothEmwuvRn0iRsnCo+BcigESY3BGoS7adx6UZq8jVvDBjFbcdL8yalor1/9RH7aieTjSy/j2DT8/EgU5lYlL+7CxJNPFBawT7gWy4MgaMDJAcfJvxV74aWHliBfrS6oRgTn+DoHXDbYf3J75QymCjVvqnQBPVnAszFkdKpS2Daj+QhpuAvAn2/GcIQg/jVc3f5CKCWN2QI73CxHGqWxP4pLqZHuk9j1Ta4mezLdXlEhbJM1jZL46A/iE122ol+4zXvrYZaoe0N5LDwPlypubRMUku+1EBSICjy7sI8arP8GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I6s8S8HhF9uCyK0zioBH4ogXo2QWxGyKuKX+u/Whd/s=; b=lTg4jRNC3ObI3BUCcmgYMQhEETPRk4jEK+5VxTRp1hEzo8PztRtWnXTyHoaDLgVI4zzG7ABZOZkTd2k+M1jW+NER9Qdm8G/1npjEXo7MdrOGRySKRGu3zcuHABDeeQL37uWqJ9yVh3bHBXNsN4F6bEp2VbiADCX1sJftK1HMQPIYzap6V30F8+LpBp77YGe8s8sShmuPMYXmuXg6yZq9dl1FVMsJhNyrqhLwHrOZbIIMV3xjvXrs3X16j6LbqVik3hgVGgnP7/Jp3+1UjfQMH9QrUPH3ZQo8VOcT2W7qGnU6Lxyquz5dMJOG7vTI49TqZASBGgHYzWxMuzfVi7PolQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by SJ0PR11MB5085.namprd11.prod.outlook.com (2603:10b6:a03:2db::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.33; Mon, 4 Dec 2023 19:21:14 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::b960:9754:455d:b195]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::b960:9754:455d:b195%7]) with mapi id 15.20.7046.033; Mon, 4 Dec 2023 19:21:14 +0000 From: "Aktemur, Tankut Baris" To: Andrew Burgess , "gdb-patches@sourceware.org" Subject: RE: [PATCHv6 01/10] gdb: create_breakpoint: add asserts and additional comments Thread-Topic: [PATCHv6 01/10] gdb: create_breakpoint: add asserts and additional comments Thread-Index: AQHaJQxMlmUf2p8i/0KyXiqViOVBf7CZgfDg Date: Mon, 4 Dec 2023 19:21:14 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|SJ0PR11MB5085:EE_ x-ms-office365-filtering-correlation-id: 03de1304-887a-4389-c35f-08dbf4fe2ea0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9afDroXaPGEfcgp6FgMtxBMEGuJp6hqldcGoVn3o8BATczbRrp6hjrs7en2ONeZhqLirSDcbPFcjaIO0g8UlYZAhLoWOnxrt/m8O7v0SeHzIykkNfW4XbCJQu94ALFTZiHZZ/pYLonixOAZGFIhlSj+8He8SXrtpdKMw0NSJ0fSu5rXf0V61X2HQ/uzjmqQ4c7nzgj/LWqHu4cfsbUon0zXjvKlyZotb6cJHWdppKDk+rafbShEIw6qRk2likGhFzNbiFMlk50KrcbYtLATooaqqtJ5aQYIw6SSVOQS4DgbfDX7wFwi0aWGKawAKx1a7gNdoq2PAx37KKpqqtzeT/b0O7x5nkmwIB1VaxlsWvu8hkTW1+DOkHjwDAsv4BXRq9Hh6ZT/l9IaRz3eSIm8Em7xy5sMSpgztMlmZc+5IbH8Kk3/hZFRoohwAbxcc8I6pC+EOC9Q6DmQsXcMqKa+KZt0szLwnk5FD3i9nDoD+8fl2lWp7XACARNACiolzZm2xHr6iyJ4cOvPweLBTp6caJggtNyHv+lzbYyJogyll++NPwQy2fW/Vos9mbD5NO2/48WxBtYn6FcTSayuIPtNI4uL9CX58tuW092Q/LG0DW0DRBhUh9PQlt3/HA8saaCwy x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(346002)(39860400002)(376002)(366004)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(38070700009)(33656002)(55016003)(53546011)(2906002)(7696005)(478600001)(86362001)(71200400001)(5660300002)(316002)(8936002)(66446008)(52536014)(8676002)(6506007)(110136005)(9686003)(83380400001)(26005)(64756008)(66476007)(66556008)(66946007)(76116006)(38100700002)(82960400001)(41300700001)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g5pC/lk1ypV3ZZEPHb/1LsKMhe+hlpG4J6GmMh6MKTb4xLBSS/SztssZHNE+?= =?us-ascii?Q?3gnbg1oawoDMBgTXgIkKEqpQZGHVtuu387i7NvFJfS8/YpV6ktekICHxykpI?= =?us-ascii?Q?TH0FaJ/Npp9XwUmLXeCwhQs564hbCFSXIsu/yt/p3JruWL5AXNM+gZdPN/Zq?= =?us-ascii?Q?TQQukpJrh/9jsFq4XiXJgu+lDsde40HbBCihtTjO9NVw5BbMNXVBYtHPc6qE?= =?us-ascii?Q?7gtLYUNof65GZ6ZvPZ1zrggFi6lIMSBn7VpF0pxaT0b8Z8qfCRO3Z/mXO69b?= =?us-ascii?Q?rn8V9YMU3JWriys3rfYcOpn50EPooTBvHXtyPHe/4A1Xw+ts2y0MecyjaGaz?= =?us-ascii?Q?OvmKmFvlxFJ/TIf30XK9/9dQQBaKtR7HlLJv526kgsw13siQOyStnHLvIn3c?= =?us-ascii?Q?mG5PWyz3IcLDbt71BMXnB1dNZlB3zKRgwaJjhndyHS3GIpB0cHwZiBHf0phT?= =?us-ascii?Q?Q/H1jd2bSEbGU3jh+e4adqJjLWtp5EWiQdFuu0MTGxbTxdZI9vwPuhaMMP2L?= =?us-ascii?Q?DL8dyh5wXg/5ausUmtC/HJAcaj3cpkaM6WKgiMspavM+pnJZTZ7m5OeCVUt/?= =?us-ascii?Q?wEgu/Q4/uPhziTDDd9EJlDRI0mg9N0ny7wzop3zd/owRGe0jkCHB7yardSFW?= =?us-ascii?Q?exwfvuYIjD6/Y88vTDuDI81YylDuAQskhah3a2pOFGy2lXR2TVD2WvUctHu4?= =?us-ascii?Q?nJsrEUtLEyOTJaVtg5wtnssEYUHsX2v2RhUGq6q3Htpt19Y2XzJwNVSMnuMy?= =?us-ascii?Q?wNmUojXadPSd+odXOmJ+w55o2Qi7mPHpkaYgscsKlrYqr6Zy2T3xAzAL42mg?= =?us-ascii?Q?9WQLKXe/O7tagGiq+7v+9dLbF8wbwYvv4S5ctTSn/YTeASdZxuLQNvRBEOaz?= =?us-ascii?Q?q/ay9Y8cCwFdaO5AlcyxmCpf08IXFjHHel8YTaxzOlQLAmBALOMqAw+foHbO?= =?us-ascii?Q?7USJk0z49zb4wKpzXXMkuJCgtIZJ6ny8iG7RCmAWwgp0e+hjpvau/nNdyXB0?= =?us-ascii?Q?HcTrh8rH3GkwRixua6/64G3Na3xU0I4fJ9hnRYR4NzhBbQmQRlRv0MQ3uqP+?= =?us-ascii?Q?HMk2ydVLvnmI/pFepBkuM1Rr7tjzl9N1mvfAtHTFiHl5WlxquXaFYu/P9Ync?= =?us-ascii?Q?GrHlrCLhdWVjAz40Abk52uQ7eZRoKgQkGSkD0qLevcp7pt3rOCI228Awe71C?= =?us-ascii?Q?Fisxk2Vmo5Dl8dmbK6Nfvg5hHqdDmpjk5gDPqO1r25mVYe9emkdTqjbnm6RS?= =?us-ascii?Q?IPdx4Hgw4pGuG6j7HW65Kh5PHEMdnGyxAl6VeWGnIj/7oUXEZXCEPBsJ5SaI?= =?us-ascii?Q?rxTMp9YCf3jZ8DzgOkDhVZl+v8vq0xCtbuUariGrND20qUfRsHwhkzBEbb7R?= =?us-ascii?Q?mLO3KUiloYntqo7CrP9UiymgG6J/QGqvvUxVekybITiTlrbexCA23FBjvMY/?= =?us-ascii?Q?4wh9pZmp4/VcKjRSWZMMFXmD9Fpl9I1LhhzVh8o463aFuQtc90nCmXdCSBH0?= =?us-ascii?Q?Tt1AMXZXQyxlQmRZ8BSR6uzorpJaccXtK620BnCwdxASm8G8xjETYCco8iDY?= =?us-ascii?Q?ND1OO27LOndzLNpjeTp4JKptcQ6bp1gUfzqijR45ULWk2ITF6fcAcLJ0M84l?= =?us-ascii?Q?sg=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03de1304-887a-4389-c35f-08dbf4fe2ea0 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2023 19:21:14.3680 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ziL0H3kYd4R924qyDKYWHWVMYGi725QdY70Yz7l/zuEMWs1IsXvQ7JDqcaCL7dXS1UpEtYyJm2NgWbUvvqQb0oI+cYUOSGfkKlZ6JI8+3qM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5085 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Saturday, December 2, 2023 11:42 AM, Andrew Burgess wrote: > This commit extends the asserts on create_breakpoint (in the header > file), and adds some additional assertions into the definition. > = > The new assert confirms that when the thread and inferior information > is going to be parsed from the extra_string, then the thread and > inferior arguments should be -1. That is, the caller of > create_breakpoint should not try to create a thread/inferior specific > breakpoint by *both* specifying thread/inferior *and* asking to parse > the extra_string, it's one or the other. > = > There should be no user visible changes after this commit. > --- > gdb/breakpoint.c | 6 ++++++ > gdb/breakpoint.h | 16 ++++++++++++++++ > 2 files changed, 22 insertions(+) > = > diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c > index 699919e32b3..dd415ff42f0 100644 > --- a/gdb/breakpoint.c > +++ b/gdb/breakpoint.c > @@ -9228,6 +9228,12 @@ create_breakpoint (struct gdbarch *gdbarch, > gdb_assert (inferior =3D=3D -1 || inferior > 0); > gdb_assert (thread =3D=3D -1 || inferior =3D=3D -1); > = > + /* If PARSE_EXTRA is true then the thread and inferior details will be > + parsed from the EXTRA_STRING, the THREAD and INFERIOR arguments ^^^ Redundant space. -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928