From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id 4390A3858D35 for ; Tue, 21 Nov 2023 19:53:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4390A3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4390A3858D35 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=192.55.52.43 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700596404; cv=fail; b=pYD1h0FxxqwY9iYrAhLZ/wp6WtUgUsZbM6yL/W5kZ5eilnvPlqqjTgGPiBIwxNWzh35P/GMKBuaQYJnmRdVuSnZg2BR0AoLZGHmP2HdsnCPT95eKK9H+AVTMyAVstxT/g2ocNZfYuN26DHaWYfY0wvO9g2HwW7MvQ1hfA1cp+KM= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700596404; c=relaxed/simple; bh=2WJlgHXzM8jFAC+Oz1eU8qpaaSUMOJW1ZkCqoDgN+Lw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=tn6RaBGk+ZtIrnOMQzdZFW8BBy5w6ziO7XUCU/7vzuQehRIiYOCEtVWwr93zfc0boGbn/CYoUqTz0h9nOBmws47XG9THcN/khUg4cX0z9f9XJy+cbIYq68deGpizuA32btO9uBBjC/VEkX1mM+Zum7j6Dgu4Vd1aRUFg3JDhVbs= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700596403; x=1732132403; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=2WJlgHXzM8jFAC+Oz1eU8qpaaSUMOJW1ZkCqoDgN+Lw=; b=Ncg4hBKVp6s3vcEWyLskLsEtLPWT1BogXkM9R2/ibGMP61bdgypjCU7j ptyk0H4Xwlw9hHtnwVt0RFACbCPfT8U7yDCR6j2GH/WvfD3uIrtEi+U9V t6lNoey6KyR0O+LltTozIaSEFtFLBVs2KSKijgvEYw+i1kLKlz5blnqSt sNAjVe6lvP/0kXMlpLDDGPo0Dw+UdhXQ4+wcewLk6/gglVAma0TyQvKG9 iEO16vRQsILKXa2HgkcPb9+++nwKKDzgM93/d8I+aXifMwY4elzSGwY4O Z0OXdI1lcS6olyp0TkvJVaGKhgp7sJgw2FapLdSDL96fWZJMAMRn/+5Lo w==; X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="478123224" X-IronPort-AV: E=Sophos;i="6.04,216,1695711600"; d="scan'208";a="478123224" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2023 11:53:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="1014016500" X-IronPort-AV: E=Sophos;i="6.04,216,1695711600"; d="scan'208";a="1014016500" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Nov 2023 11:53:22 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 21 Nov 2023 11:53:21 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Tue, 21 Nov 2023 11:53:21 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Tue, 21 Nov 2023 11:53:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FmAl/lVreL6yd/TXIm7poiXzVpryqCnSy/wMu36E1/+IIXclV4iaHhsPIhbJMzeB5CmR/9x75tbAH1AwvvPXWR1DmhRkIlhBIPE/koFTOrHeGkuKu7SC+x7RcvKiYfPM2PDWHdvA3RTgzVvG/aWl4FjUw5x16iCQ1gjbSSC+8RszZSYRQh6QzmRoWY7U7Imdau6Bo3Rn2Zcc05M+XL+6og5HtxzkfXU2CEaOgXHTniV3smkgTl42b3gYH8C2aIi67jFtg71YGUeXJfNNA3sx5XWdXOjj/tKPAZVTQpG0hsEmQRjGR5YXlvQEVyFNgZpzUtBo+ns3I46JS+P6V3jwcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9QpEmEJMgc8RIvcI1iRv94tjx+t0w9iuwgKPF6AOwBY=; b=g+7X/jrGYqVfQDXBWHLQaOo/y/yiTbouCqIEe3wttI/UWFO1l0K5+tyrBZvfLweRJEK8YQ+q4KcCWkVrHwaS+nVyau5HDxAhSRPRHCwcvpoNh/BM9+ti5WzP0v/4MRc/ydPDAjJ7rqxTW2/JgiAZfw4XY6W5DXAMB78V/dZ3lCNn6yHBxJmHjlo3De/3O/2lVB05ngkbsjLSw8TNPrzWMkKyjWmT3bAXXVMf2bvvMnbaa3BT1ZMlWVX3dOif70QcnSW4a+x+3etLmsm8RoVMnrQSQGxApxpqE6pWFPevL90ctfkuZK7MTexfWD/lP8dqAusIKJGm0s5UCelheqYbOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by DM6PR11MB4659.namprd11.prod.outlook.com (2603:10b6:5:2a5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.28; Tue, 21 Nov 2023 19:53:15 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::9597:5d8e:99f8:b993]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::9597:5d8e:99f8:b993%5]) with mapi id 15.20.7002.029; Tue, 21 Nov 2023 19:53:14 +0000 From: "Aktemur, Tankut Baris" To: "gdb-patches@sourceware.org" CC: "tom@tromey.com" Subject: RE: [PATCH v2] gdbserver: dump 'xx...x' in collect_register_as_string for unavailable register (was: gdbserver: extract code out of regcache's registers_to_string) Thread-Topic: [PATCH v2] gdbserver: dump 'xx...x' in collect_register_as_string for unavailable register (was: gdbserver: extract code out of regcache's registers_to_string) Thread-Index: AQHZo4+bWy1BeJMdvkCOe6WZT/eN2rCGIUgA Date: Tue, 21 Nov 2023 19:53:14 +0000 Message-ID: References: <20230620155457.1023518-1-tankut.baris.aktemur@intel.com> In-Reply-To: <20230620155457.1023518-1-tankut.baris.aktemur@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|DM6PR11MB4659:EE_ x-ms-office365-filtering-correlation-id: a247206b-59d0-413e-db1e-08dbeacb7fb3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dRbpy6E1twnW0yc89Ij4cn4pqkIdr2UgrPrPTFdUaAXVlEYF24Jwe3F7o3qb6+DGKIZ2EJXpLALCvJ+HPFmSRpJ9IWzoiOLBaoZdopazsy3i+cedYvO5pZsT/h3vQXyig1LKpXtAXmu5x6qOjq1A+OccGFiwitpJzPV5Qn3FpWmHYYH82U4rxqtPEBUeTdEFGAKdc5VML20J9Lqq8++w6bNMKUsCCcUZSTbMYo0RUGWK7wQznEymDIgE9ErhFagihZD2ucT78BlqSHGTcX9V127y0JAr/AAob8jDOJF8wrYBJc2DkvOMWJVBkqggoGDyL2/1StTmkHlNz9km4gx8ke3emQYrvd9jBScuTkpFy89bdbUVWoqnZC1+G6/2TwFz3gfMJLpdMD28UT8o/WDu32C375IhENFNnSTZoQyPrIeajRDM7RehwjPwv4C9sFweVD4Pao8S13ZPXQxbix1N/bHRKa+4cRzhk71FQahthZvCvnNnJD3PTQ+nmvDdXiXEDjyP1N2KA4iGOcIucMRaHX3WA2e66ie0Ja5Aaavmk0PZo3Lwnjhehfpgf/wgZFPveg4pEXFdAJ5RKkyPKrH+XKmwZNbbTMxDqODNZ9qrmlEIPvb/U/AJIicYjoqX0SXr x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(376002)(39860400002)(366004)(346002)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(41300700001)(2906002)(52536014)(5660300002)(86362001)(33656002)(38070700009)(7696005)(26005)(478600001)(9686003)(55016003)(83380400001)(82960400001)(122000001)(71200400001)(4326008)(8936002)(8676002)(38100700002)(316002)(66476007)(53546011)(6916009)(66446008)(64756008)(66946007)(66556008)(76116006)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xAJ4w1mRvQH1HjKImouuAzwItXovuIsMyHeHk2nrIJz0yKAZF/LRHqh4Q8UF?= =?us-ascii?Q?Ze5LsicSwn1M/63pqRy7j/VxK+54pMRqQfnidqtvvMcCHCo5PzdhYGSRhoJE?= =?us-ascii?Q?jZHknEGL34Y5tyU7MNLmKkelZImKbt0nWhbvaxBmm4wpIQPCTiaIqkkKYGSQ?= =?us-ascii?Q?Ni9sJ/pxvKpQuGsj07Dhz8F9UrEkL+Zbo4Ri5xo1QvU7QeFmx4CXoNQfXX8g?= =?us-ascii?Q?bA0XQ5nOgIJT8TesCThoipWK7mCV4m51srx0mMruEHKIA5iAnv4eCKsGjljR?= =?us-ascii?Q?d/joQc3Kfg1eV+3yvvhSBTloNSD0mWSSrzdfyQZY0CQ0OHjkRt7IPMH3qHug?= =?us-ascii?Q?NZBVoLtoyOiZar5iZR+UHIJX7s/RGfvYauRn7dA7gqdh2khQ2TRrjQx5G2zk?= =?us-ascii?Q?IBI8Ldg6xyr7+QBnz+3Awdr1OxazgtqcjfzDgJuah1XLkkQvRzELiq73qovq?= =?us-ascii?Q?XvuTi4Mp0mrLP7c9Ns6SVmkkiOFmebqm+IWySSginUvIW+YQG2KMoLDB8ziP?= =?us-ascii?Q?SBxKXE/p2J0SQCiQLG93r8RukReX08rAfeK3NaD+XNF59/wi7A/rRqJqogbl?= =?us-ascii?Q?LV3lvfIM9LmbwFA/ZBlOY2KTtwnKCCo8JOJ8ozfWwWGEUktemX9PYJExJdHk?= =?us-ascii?Q?RaliY2/TOTQw2AztH3GaTzm7NnqREqb9LLyqfLJjeSuocxxGCV9NWRX43Zyq?= =?us-ascii?Q?N+rG6BwuqVSOSl2JSyLQat/h8nBPUqWGIrIHNBzZ5EbdWtKGftgiVZQABFQT?= =?us-ascii?Q?b6NcMtzvd1aLXeLlL0HEPia5zkBYSkRkw3xHrYHLPduV5rLAB8dcZLvQUtUV?= =?us-ascii?Q?IhFYQZuAe02L7lZVleejzkJHXycFvl+qj2+b8sWqX1jk4NyXSSnNQ8uM84Hh?= =?us-ascii?Q?f5GrWAr0QbW8zgEf4Yz6pYr6HnxwOy5U8Ibql3K1YOeoqj+1wqyXsxuraM6N?= =?us-ascii?Q?+BH4/aA9YMQEd+tDxJqBAq+eEUHz7vl3Et53LiATK/v4KOFBMFchARS/WEpd?= =?us-ascii?Q?1hSrgEdpLB3RoSEKwyPZh607CmQerSiy4RI3YvpTy8NeY6goaGTcxCLb7swq?= =?us-ascii?Q?Kg6/mmoLEuVv5UIjS6r2qgMfJ7lLqeki26n5qn04IGbtgdT6vt+w1cI50kFI?= =?us-ascii?Q?fZilLEPp5h7e+pqXZ+9K2Wd2PTsHK8rtLv7pp75qXPXwokmxiXSf/5rPY3us?= =?us-ascii?Q?Fu/aORldQlk6npexR5nK/x5I0oEkyWfgSTPm0Nwdv0UBwoKi4K24bcWRviDp?= =?us-ascii?Q?oydVKBvrM9RQK9J+qwnRm0uaX88puA4/yvKTxzRxhnPh2E3whXZ/mG+e8YMr?= =?us-ascii?Q?d/HQAfHusAmZm1EAmUjme6UtklZq00PSjaJAQr16us39quf7ZWuzlNsp8nPe?= =?us-ascii?Q?JID1eSDPnYZdQqCBkQ8JC1Mb55mjm3IiZksw+F/qOhNA+Sn9Y5frCaKKY7UK?= =?us-ascii?Q?Akqj+epDLXtAFeAySSpUndba0DD9XafZBvmjiaMAlzLUFbSHI3GIrp0zM3Gu?= =?us-ascii?Q?xtJlyeaGQRokHOR7nlrVxXYPLKqhFX9yrPTKk9x5ywkOYYhcsEP7/bvbck44?= =?us-ascii?Q?Gl6CMmM9C5dCQBPnq7pXizrODSmhsm97EXt5rh9SN7kxENcHSb7H/UmjRNBS?= =?us-ascii?Q?6Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a247206b-59d0-413e-db1e-08dbeacb7fb3 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2023 19:53:14.4766 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zkipZlGCHNQSQHzIA3IqUwt+4+yGShUOdk7DuIypUL71KSVW4oPi+bXPc7UmILxj10HCbiexafZy+OhsZz/xIxSzlj3GqCX9k9GC6YFXhhQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4659 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Kindly pinging. Regards -Baris On Tuesday, June 20, 2023 5:55 PM, Aktemur, Tankut Baris wrote: > Fix 'collect_register_as_string' so that unavailable registers are > dumped as 'xx...x' instead of arbitrary values. This gives the > opportunity that we can reuse 'collect_register_as_string' in > 'registers_to_string' for additional code simplification. > --- > gdbserver/regcache.cc | 26 +++++++++++--------------- > 1 file changed, 11 insertions(+), 15 deletions(-) > = > diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc > index 0b1141662ac..c0a6d6eb0a4 100644 > --- a/gdbserver/regcache.cc > +++ b/gdbserver/regcache.cc > @@ -210,24 +210,13 @@ find_register_by_number (const struct target_desc *= tdesc, int > n) > void > registers_to_string (struct regcache *regcache, char *buf) > { > - unsigned char *registers =3D regcache->registers; > const struct target_desc *tdesc =3D regcache->tdesc; > = > for (int i =3D 0; i < tdesc->reg_defs.size (); ++i) > { > - if (regcache->register_status[i] =3D=3D REG_VALID) > - { > - bin2hex (registers, buf, register_size (tdesc, i)); > - buf +=3D register_size (tdesc, i) * 2; > - } > - else > - { > - memset (buf, 'x', register_size (tdesc, i) * 2); > - buf +=3D register_size (tdesc, i) * 2; > - } > - registers +=3D register_size (tdesc, i); > + collect_register_as_string (regcache, i, buf); > + buf +=3D register_size (tdesc, i) * 2; > } > - *buf =3D '\0'; > } > = > void > @@ -472,8 +461,15 @@ regcache_raw_get_unsigned_by_name (struct regcache *= regcache, > void > collect_register_as_string (struct regcache *regcache, int n, char *buf) > { > - bin2hex (register_data (regcache, n), buf, > - register_size (regcache->tdesc, n)); > + int reg_size =3D register_size (regcache->tdesc, n); > + > + if (regcache->register_status[n] =3D=3D REG_VALID) > + bin2hex (register_data (regcache, n), buf, reg_size); > + else > + memset (buf, 'x', reg_size * 2); > + > + buf +=3D reg_size * 2; > + *buf =3D '\0'; > } > = > void > -- > 2.25.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928