From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by sourceware.org (Postfix) with ESMTPS id 99A3F3858D28 for ; Tue, 20 Jun 2023 15:58:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 99A3F3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687276709; x=1718812709; h=from:to:subject:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding; bh=4ot+EcquOWdpPglXHYHVgcfCeRZGcmNx8CoLfUbt68o=; b=ivh92XhWA5rEffnBEEM4VXJyWayRFUkY1DIQGb/A4L6BPvIZqAlZkVQj U3JJnD6/w17YNF3AM46ozjxUG+VxVA+dP9b3KemQb9FJiXbqusbxpQ5K4 ycK/i3Wu+NdpWnqiO0g+cYI4x6vE1FywKFFvEAylTSiqFUnf3guxdOSf4 lZV7+TzOl+/5yjhunf214Z9PDOcpwgbuY0bazrhgfpjyW1+XiSsF9j2e5 8svF5w2A1J301OFMR0UuDBKdNd4cTSoXG+UMU9MSrsQwGnAGsnQv6labN 6rdSrSY1/nvCf3VOAQhbVVm+ZeIkJSVQEBFrUQ3E7W9vWyvubunl3tIwk A==; X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="425854306" X-IronPort-AV: E=Sophos;i="6.00,257,1681196400"; d="scan'208";a="425854306" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2023 08:58:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="804006699" X-IronPort-AV: E=Sophos;i="6.00,257,1681196400"; d="scan'208";a="804006699" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 20 Jun 2023 08:58:24 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 20 Jun 2023 08:58:23 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 20 Jun 2023 08:58:23 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 20 Jun 2023 08:58:23 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 20 Jun 2023 08:58:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LeVoIYbbRuB5h8Bq/Xl9xMCuu+2971AwEP61c5aDjdJrdcn1Has2Dg1LlXrB7R69KwamOSIgWUKSZTeRyR3RhpIfcehckXdISD6CxE4h89fd5iF/OPD8WBVNOBD8IcWyAORU1plh8VQD9nWNmNnWuqyRp39ReDOb5ZNWDovrVAUGMVl0oPDsNnS6gbOLQjWSb90myzz9u/DWvguC76yMOYtC+nfJ60vHfuC50jgjMrxA2FpbtCRxcrIu3wNvqbILVb2Xoia/bMyhDrOzMm3sPdTvWbpstINYlA0a3ydgUX/cj7uIN0kB9U9NMkOCr1D5gzFSpWoqvnHd4gSS6Xn98Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=paYvprCTsLClJpXayf7/+t7oN/TZ5txDpfEb75wKZ38=; b=lqRFgNXI1LPf7S4P9CFHLrtgWN1TAPqW3uroRi9jVgWt3nIiMl8wh/ZfZkz9lHJjUnj5+K4P3VISXO+dFcPleXYinFRK0EfyIA/NTF5oj9ZemqVQ6pwiKOz3+mcJXHISi+TcQsXAoiVEKIZiOvG+jlC4PtCUN6nhBDXwDfQ81ahmq0W/C9N3Nx6I4lBrOlnKFzVfpcOjtOhyUeFMmFg78ADvPIiaJtae4DFAO3iY4jTeyptoHGmBoORioJeZM6Lux/HfjLzqa+HvfIreKhyDpVzk0j6+H0HTJnYJ6zJpJyGPBKmw2ukrsrTkHPrTuO1hRWL5yFgRGDSzTkKfzLyEsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by DM4PR11MB6118.namprd11.prod.outlook.com (2603:10b6:8:b2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Tue, 20 Jun 2023 15:58:20 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::e57e:3584:99ad:d384]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::e57e:3584:99ad:d384%7]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 15:58:19 +0000 From: "Aktemur, Tankut Baris" To: Tom Tromey , Tankut Baris Aktemur via Gdb-patches Subject: RE: [PATCH] gdbserver: extract code out of regcache's registers_to_string Thread-Topic: [PATCH] gdbserver: extract code out of regcache's registers_to_string Thread-Index: AQHZo3W0kWFjyhTfp0GWOVAGL7yygq+TvqFMgAAZsAA= Date: Tue, 20 Jun 2023 15:58:19 +0000 Message-ID: References: <20230620124933.2792496-1-tankut.baris.aktemur@intel.com> <87jzvy2oxa.fsf@tromey.com> In-Reply-To: <87jzvy2oxa.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|DM4PR11MB6118:EE_ x-ms-office365-filtering-correlation-id: 6e4b73f4-93ea-4231-3e55-08db71a72aee x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9XZiTgAauMqooAzGUhIqkfOrh2KZ28+miOMW4sCj5M37KUUIv0QPVHyM7Y/cDUs19StYuxq8OTVc573OLjC4R90cShXRTCvUW2oKGFY9qsTUbMXx7asbIKKSulZElTAnabUUdsfC9SchvrMoCAoMU9rX68a3+YCHhWhg8URtkuJqNmr39n5slmfdd2uYOqXvSwuPTsWro9aktmGTHZwA/2EFB/urnAMCCxLEeBPqLqJYB/ed3K3qQ/YAeGg8N9ElJNr1ngXooZAA9b/FoYTePslJSodB5jNutkRRQSPl7Bk1UUQFh9EPuLF/cUNnlKpLkcySbEMftvkOw20k3lfumEGvAoKT9NpdSflKrK2cRu2dcWG52UpuqXnYgfqQ6G1wS/pKJizCYj4LviqkEfXs3Z9P1Z5o99C+Z21Qd77INQ6xRfSG+vvvxgsz72a++piS1p0g5qv56kGG8SB3cJX1bLhcP4y3idD/mq+XTA3J36lN9CoKR0bfUa7PLBsJpIXhK6TPeVEvGZwag+LnEAz33tJ76NUwp34B6Sorw/e/BLmJeMApAi4YV+xyCFr639/kJN9gj+opgyPTntBKQdJFIkeMG1HISCSXmO0aqVQUg9Q= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(396003)(346002)(376002)(39860400002)(136003)(451199021)(966005)(478600001)(26005)(7696005)(71200400001)(110136005)(6506007)(9686003)(2906002)(186003)(52536014)(5660300002)(33656002)(38100700002)(122000001)(66946007)(55016003)(316002)(86362001)(82960400001)(76116006)(8936002)(8676002)(41300700001)(66446008)(66476007)(64756008)(38070700005)(66556008)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xF5f6lkEgr/4RODumb3GLGyuu6IpJv20tdHZNxuwVOR+DL6kV3sMa/PK7NZ1?= =?us-ascii?Q?QdUWSVdTQm1YW7P4RZbzXFKNlKNAjukJKHlo70MaVuBdiT3Nh84SA+DToIl/?= =?us-ascii?Q?EZJuDjpU5pK1vi18MzrSGSefImNOLx1nheAO6JkqRrlZ8NXqj9kBr9H0iHhl?= =?us-ascii?Q?aKb+e7yEMTG8zEi4/bScCtm6h7+K/iIW7PKuhSmCnXBWKxkOZhXOjNcvY1YZ?= =?us-ascii?Q?miZzQdFJOy/EZEbDzoy1ibFFYtRS+D3/XvkQksbaFWHNMHXkrRUhk0rQZW9I?= =?us-ascii?Q?9lwe6IcuOWf/QDukg13OrDL8Lih36L2APYoyFzvShO5d/0hIZxTvfa5iS1/R?= =?us-ascii?Q?rsnyItANc44BqIahwXq9jiws1Hmv3tO0mLZ+LrZGz6WACQTR0Tnfndt0a5Ca?= =?us-ascii?Q?2fxE+9vqjS0A/eFPP2UAp11bkY/TwbrDoGSBym/2M5MQmMJNILLmOOboo5h6?= =?us-ascii?Q?QPk/CBHUPtK2/Ezftqj+xmDvCwEJxEAT0XKGrXhf9XqYTdbrnNvpto63VRIv?= =?us-ascii?Q?cd3a8/DYhHlEU17sEXjR+P9ew67D8nZ83Mf6QafQrjZguR3RZJNsKYharrSY?= =?us-ascii?Q?pPzsWnOWCIMg8mkBewQylRSuYk2nA25IiwFIH99LKMi0czmeSe0VtzU+6NI0?= =?us-ascii?Q?sjsjq+Z7WdQVdDrJwahW07OZHPQzfu6qdyINENZb3iLHDYy6TnyE7H+DxByJ?= =?us-ascii?Q?zlxskTeYF+8gIYfIKoR2zWSfQGHmwEUURIgfNIy8sXFsZUxpjtVUmAOQev8f?= =?us-ascii?Q?laEptky1z8nRBGS1jmq69SiLdLtQ7iaX3yuh/8oHx5mqzgj4z8nce58HLm7C?= =?us-ascii?Q?K3uMYuroJihXZImOEP5WkSCW83DmdJrA9DRmM5SasVriHt9sfO+vVxa8HDa3?= =?us-ascii?Q?UWb6JcYbVJCQyxkKGujUYtdaRL78uEweuHHBAsqcl3jBIQ/ALvkpMB6VDQfz?= =?us-ascii?Q?kOtSsYl9zN5WmrpV3S9V141OTDfczJ4NI+pIh/tDoYASOKsSM+YpuAqSF17A?= =?us-ascii?Q?KKZOmhYV0ICQhgSiWQrBgZgrJdr5RnhpOb/YLcv2oTTkdSGwH4bkvhDo2FzE?= =?us-ascii?Q?6G+sIcFgiHEXNnyLopW6/uwkpcJtaXG726yMq7CnMe7iZQy2XqaRAFOo7iOG?= =?us-ascii?Q?3J1cM41HaXu9qGLgEvCfUHdU0FFtd6QdDR1YQEjHCke77Dr+A+hvwzXPADP3?= =?us-ascii?Q?n0mAF7itTG9RdasP+sq8iwd2ir1GCwIyZ6qIwDk7LPeE156xXi4Lusce3uQ3?= =?us-ascii?Q?SUXseR8IuUdjZh+jKTYADtldghINeh1TkzCqroinF9nzntAubKrsxvPU7LqX?= =?us-ascii?Q?2f7fR+FNequorYSsHKX1vV86MnwjCY07UwbLEHEqXMYfYXtqTB/qeFbyaqta?= =?us-ascii?Q?Z51Ay1txP76NBt27GyXdepiOM0Wpve11cDJQqSJ34XNQvahl+vhWozhed4yn?= =?us-ascii?Q?t2Ow+7m2LsM/6flFyVhq1OxbX12//fHEd50eX1qiP8NS/xouzOZcCm3IhJ4O?= =?us-ascii?Q?aa+lHtYtpcH5jNraVN36w1nB0a9o3fOBOib1UHZ9yQkZw3y3h6EsBStPfzLd?= =?us-ascii?Q?JVLCACHDX7ngIf0wsoO7PMzEnbGAIKya7e0ixxNo0ygkSTABfAV3RUV+tdco?= =?us-ascii?Q?BA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e4b73f4-93ea-4231-3e55-08db71a72aee X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2023 15:58:19.6579 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GxgPAO97uy5QK7XkrBJQjizTho8yyJk7zIkeol1YlM5mAHnR+2ia3qWRyO/9SlClywJ04PO9SoWOZRjb7n5q+54T1ABIwxTlo+YuWIeoH1U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6118 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tuesday, June 20, 2023 4:23 PM, Tom Tromey wrote: > >>>>> "Tankut" =3D=3D Tankut Baris Aktemur via Gdb-patches writes: > = > Tankut> Extract out code from regcache's registers_to_string to dump a si= ngle > Tankut> register value to a string. Reuse the new method in > Tankut> 'collect_register_as_string' so that unavailable registers are du= mped > Tankut> as 'xx...x' instead of arbitrary values. > = > Seems like a good idea. > = > Tankut> void > Tankut> collect_register_as_string (struct regcache *regcache, int n, ch= ar *buf) > Tankut> { > Tankut> - bin2hex (register_data (regcache, n), buf, > Tankut> - register_size (regcache->tdesc, n)); > Tankut> + register_to_string (regcache, n, buf); > = > = > This is just a wrapper now, so I wonder if it could just be removed; or > if register_to_string should be renamed to collect_register_as_string. Thanks for the comment. I followed the latter suggestion and revised the = patch in V2 accordingly: https://sourceware.org/pipermail/gdb-patches/2023-June/200377.html -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928