RE: [PATCH] gdb: iterate over targets, not inferiors, to commit resumed

["Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>]

On Monday, March 4, 2024 5:34 PM, Simon Marchi wrote:
> On 3/4/24 04:28, Aktemur, Tankut Baris wrote:
> > Hi Simon,
> >
> > I see; thanks for pointing this out.  I'd then retract the patch.  Let's
> > keep maybe_set_commit_resumed_all_targets and maybe_call_commit_resumed_all_targets
> > both have the same iteration for consistency.  We can do the change in the future
> > when the amd-dbgapi target is converted to a process_stratum_target.
> >
> > Thanks
> > -Baris
> 
> Great, thanks for your understanding.  We'll hopefully get that sorted
> out this year.
> 
> In the back of my mind, I'm also worried about this for other (mostly
> theoritical at this point) cases where we do things per-process-target,
> ignoring that there might be other targets on top that we're bypassing.

I agree.  From a developer perspective, I think the distinction between
inf->top_target () and inf->process_target () is not so easy to make.

> I recently thought about this scenario, imagine we have the following
> inferiors:
> 
>                 | inf1             | inf2
> target stratum  | my-thread-target |
> process stratum | linux-nat        | linux-nat
> 
> Imagine the thread target is meant to pull events from the linux-nat
> target below and translate them to some higher level events about
> userspace thread.  When infrun pulls events, it selects a random
> inferior and calls target_ops::wait with minus_one_ptid.  What if
> inferior 2 is selected, and linux-nat returns an event about inferior 1,
> that was meant to be processed by my-thread-target?

Would it make sense to fetch the events per inferior using the inferior's
pid as the filter ptid?  Is there a fundamental limitation against doing that?

-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928