From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by sourceware.org (Postfix) with ESMTPS id 1C30F3858C52 for ; Thu, 19 Jan 2023 11:05:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C30F3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674126323; x=1705662323; h=from:to:subject:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding; bh=VkyXMdhXYQrGeYNfYeBy46SIcnjCjUngW2yEiCixGLA=; b=h+YFblq39+8Ogg+jJu0eY3nDur5hHRHbhQq0KzF/9JU0FPpmPbZIj8Fb 5AZr5B0A5ChspZRsbrUUQJtw0gWVpc/hQgIhKiEd6pttHoc5ISQkVwl3F uizP/jg97XK95yQb1JjB1VMjS/vodomOTOMwJvK/73zPtL+8J0tMt/omI cH5c39/rT/qD4p7UyNt2BQMj0t9iPhbCgnQSKKL01TRKsgMqSxEPoVp2i ASjIKBCwIeJgT/DVe+JLOtSEjov3LunThTz2Vt0LXbSAi5Y/A+9q7x0i/ LwWRG6wrsVhHs6VNsxTn9YDbwyydMaWi1nsuTdHaBwToMVWBqC9KY6BDq A==; X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="322943734" X-IronPort-AV: E=Sophos;i="5.97,228,1669104000"; d="scan'208";a="322943734" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2023 03:05:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="637653340" X-IronPort-AV: E=Sophos;i="5.97,228,1669104000"; d="scan'208";a="637653340" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 19 Jan 2023 03:05:19 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 19 Jan 2023 03:05:17 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 19 Jan 2023 03:05:17 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 19 Jan 2023 03:05:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NaMtoAmdLd+SFVd1y68DzkhvmqGJOptlF2kmdMrVogqAOfp0VbrMWMPw7h512vxvcHsEAaPM5gmzPK1Bl/qkVNlFM1CtE9gqPv8+LbPpgL7MSCFF0bhvQtj/0JcGHC50SElVvkRB7xtkuEAj8XlllPmAzXq6ucqbHRGvfj1FsNb3KpVDcoBRq1it0Q5R0zE+nfbFYXE4Yc+v28M81S1dOc24o6c6N0z6jalo2mvQiDb/tEEGiNFe7y5N2Vsrt3n6d1EPWbzKmDd0l46BJ4MlJWBZhtIxMR/MTbv9qPnB1+BtXa/O/mJMMgTO6mZXHzp9HwricxL7yo4UUGiFoXJUvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tmqup64MJ0jTlrbvRrUN3s5s95+9xb1pIsPARtr5HqM=; b=IS/d/e8X1/Y/iW65izoiiw8PU0w/xyPI7u2HtCaDPEW+Z5xVapT6LJ2Jkj9EFoPvtFB7X7IN2qJGChEgEzBtc2YV7eINZmeRqLi6dorlaTNKUD+N4bq4nnA+/dFmifO+zFgmg32WDrH+dLMokOhqxNw5v1eFMn8dBDY1XMOsMaFhCbOviYVetkoYTZpSTx3kGkY7es5ZnUHwyQnL/uinYebI1napqXBAnos3r9dtCh+9WN8m1FfZ40/u+gBVmIaaL8zNEbvlFbXT5nYBYkfp9Kk/zMA+YJ9FQKrRvJ2fCSi8ktg+bcBs/bjZxqzeuROPt7QrvIfhGkx9W++Rj0n6AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by SJ2PR11MB7453.namprd11.prod.outlook.com (2603:10b6:a03:4cc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.25; Thu, 19 Jan 2023 11:05:15 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::d2a1:8dd2:854f:d5df]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::d2a1:8dd2:854f:d5df%8]) with mapi id 15.20.5986.023; Thu, 19 Jan 2023 11:05:14 +0000 From: "Aktemur, Tankut Baris" To: Andrew Burgess , "gdb-patches@sourceware.org" Subject: RE: [PATCHv2 08/13] Revert "gdb: remove unnecessary parameter wait_ptid from do_target_wait" Thread-Topic: [PATCHv2 08/13] Revert "gdb: remove unnecessary parameter wait_ptid from do_target_wait" Thread-Index: AQHZK1igG4RaFVqiCUSFJXqkOEcXHK6llJ4A Date: Thu, 19 Jan 2023 11:05:14 +0000 Message-ID: References: <60af9af218f6b6753fec0a9bca8c78b91d54f41e.1674058360.git.aburgess@redhat.com> In-Reply-To: <60af9af218f6b6753fec0a9bca8c78b91d54f41e.1674058360.git.aburgess@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|SJ2PR11MB7453:EE_ x-ms-office365-filtering-correlation-id: 3bb7d907-1f88-4c88-a6d9-08dafa0d0a6f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M10YtzYaNsBSc2yULGT5mcE/y64HQ5BDUY5QY8H6Jh5ZACumIWZPZ8FQDGHyjVnm787oF3q4jU0esFRQwnwe+WV5QWCxRCSDGgLraBS99SkYrElRLvw/FOQjAK6j02uxcu0odf4cJ0bG5zOmKeOhrV8h/DOIJvaQJyQkNyKuJkRD/4k4IJHQLfn8MxEZNziKOCHhsqM5MQjJ+VNbRIqzsZW7y3y+Oi+m0l/Q6oWb56MeiMiR/5rYQELiD1YDQC/KL0JhN0HHj6xnGpT3awGoljyOLXXvuRSMBLeFOYjKQDQr8Q/4ZhQkSCeYl+crgPNztOjQZJwiuz2xFwGHr+eeaMlV+IRo0i3ozKNSSYpPuetscxGMXY5rWov9F9OpgYyT/we8rnxwHBUGErC/uF2UiyXI4HWy0kOWxgglk89t4eQg3TonE3FbOk+TGRWyc1EQKd9aupj3iICk3M8b4ggOTDTxXkyCPmAujEcCZwLhAZKUYQdDEVUyKNr4pcTCyjVZwfZfPxuGElQtSfD4lyg6/LiXBKEKXA16VWLXqHGxm0DQAOc9Lqi1ZmIkOjWPGV5KU40XPQ+vLXenHU2WU5OsHf3qvz2PQNbgYXlpNNJNIn3Uv4Jg20bkUbgRcx2O69c7izNGv1fhe2mvybhJqW6Vl4zbMj4erEdFHtmLiU6i7VMn+gfNMEk4VOMomYBbODJ7GIynqFrGzEEcb7OIn3HyoQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(39860400002)(366004)(396003)(346002)(451199015)(55016003)(82960400001)(38100700002)(122000001)(33656002)(38070700005)(86362001)(5660300002)(2906002)(52536014)(66476007)(64756008)(66446008)(66556008)(66946007)(41300700001)(8936002)(76116006)(186003)(9686003)(26005)(6506007)(53546011)(83380400001)(110136005)(316002)(8676002)(478600001)(71200400001)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?B0fK65qUX8wbzQhhCs5CbPAL95fOpJxo1/2tXd+RKdWe2SZsE43qvJNGd3Jc?= =?us-ascii?Q?VLDlLmZT3CJ6q2VbOx6pz54d8ird0zgW4v8BvTySx0nkPoCmULP8Mc6PWVIH?= =?us-ascii?Q?X47N01mDfrNX9mpF0o+Jr3U9Ulsfz51VB/YiG1T2ofymbKbdul9ep03y281P?= =?us-ascii?Q?879Xy+LdRs2DO1hmrFl6NSP3mPgQioEcy10Lrg5nVn0CgU8NKA8uxRO6QOiO?= =?us-ascii?Q?8tUNinznEWQ+QDAP22/E7v+MZB7JvggHRzigbh/JvpMzmgT3fpnj2O3veM6V?= =?us-ascii?Q?8xLMV9FZp71ikONTEoHGglZe9Ht4HJV79PAG9sTic1srv3XezHfZfFg9hihk?= =?us-ascii?Q?x2sREaCZhqZgPWg0FcQnd2kBW7T+HM1/hj7J4u3xOAwm6GPNxImnrXZd7ezM?= =?us-ascii?Q?8+VVCE0Orzs7wlVbADD8xWO2/sBsSrbr0WTuf3JxrCSsA8I5jLni9zyJxwhI?= =?us-ascii?Q?0uKm/8NFHNztgdsn8ZwXYF3pNizoaFwwAj/sKo4FsvQamCLSI49y/GdvUJH0?= =?us-ascii?Q?p02vEj5wl1IwlT+NVnjx8+L9GMPxFEpughxN5Buqao5x9j9Ikp4+o0hll4Pk?= =?us-ascii?Q?Z3AxN2tW0DvNgBwxVrGaQEB0P2o9KfB3g355RZtk0ofP72/E2j91v+xJeX52?= =?us-ascii?Q?6ZksGSmHoS8h1M6HGPrvqqMwScA+5vD4kLkoaS2Nw572Uex6wDXKjD6PcLJN?= =?us-ascii?Q?SPTtQWh9aFvzNCYCwky7kw+GoiQim/tPwdwTvf7877rJdRwWmzsfCLrEt2wk?= =?us-ascii?Q?0Zrxq/smJw/beZ5XmL0p3QlQCEYFjOEEze+4ftFhTQdcY2Vmb0RvZzQcAeAh?= =?us-ascii?Q?fXWp6HVFLE4M1oGx58LS8B0tWb16IP66IAFu2AnReMGOkvDPp+SgvcqUhEOO?= =?us-ascii?Q?l7+eOOU/X49BsmOKr2CdbhOwDDWtjJLId1Lphsxf9vpL0uS3mkWMG4ImnsLi?= =?us-ascii?Q?xgF0FbXXkXjHCWOzcepKqDhEIkGQYF3YX+gCYvopJfvVAK9ynhK1SKiviRS3?= =?us-ascii?Q?ldltBbtpj3VPWCx9FyOEzmbvC5gARXAq9xWDMlGeK/4Ck/yVjeWHokiEouX6?= =?us-ascii?Q?pVhNVRTPkDgp4t7Sxz6IbRcjVgO/uKGFhsv+8aI55dg+kykgNDHmZavebois?= =?us-ascii?Q?EemhALQDrrAUxZRsPqWPmR50FrzOxp2EpAjw1Tv8xDZ6gKUfQhxJonyXq9NU?= =?us-ascii?Q?uaaw8f7f84WQeenlvA3RrI7Ys1dI+S5m9XOobSd3zxsdmn88JgD/8pMNRXDs?= =?us-ascii?Q?1/0uZT1CdPvt/zkkxF3Zc26AJoDUcrFylDMMJcdQY/klrmP3udwBJb2tMWyW?= =?us-ascii?Q?zaCM1vY15Lt7YzwjEKArvJP/o4Uyla5BAOmwlzQ3F0x1XxYzfI7Rjl0NtrN5?= =?us-ascii?Q?oQCvcVL6b3Z9EvebUACR+TfYcvQ6AcfeDNgDHMB1c3TKoo0Doto9BjWY3b5A?= =?us-ascii?Q?lWIh0IKR4Iv73g/O6nEvozq5GORCe3qsUR2ra8VUm6d79eKOljKwXzIoAmRJ?= =?us-ascii?Q?a6wIGJeU1F+JiXL0XgFEG3K+3Mlmontal/P7MKmF3/8o3SgOhGRPZ2YooVdA?= =?us-ascii?Q?/johQRGVL+WBHXbi520qyJlMso4SVIjoH+F2SI/XEKlpYHPOtD/uw4pi+Z88?= =?us-ascii?Q?bg=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3bb7d907-1f88-4c88-a6d9-08dafa0d0a6f X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2023 11:05:14.2798 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xUHaopdJ6a0+FlzyQDPx+xHTCm4DodnwsrHIRI35wFR0M7zodu398ktRUhd9GkISRtBhbieIuFxo8a7Neg05Jmf63Fv5Oh9Hs3d/EXCqytA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7453 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wednesday, January 18, 2023 5:18 PM, Andrew Burgess wrote: > This reverts commit ac0d67ed1dcf470bad6a3bc4800c2ddc9bedecca. > = > There was nothing wrong with the commit which I'm reverting here, but > it removed some functionality that will be needed for a later commit; > that is, the ability for GDB to ask for events from a specific ptid_t > via the do_target_wait function. > = > In a follow up commit, this functionality will be used to implement > inferior function calls in multi-threaded inferiors. > --- > gdb/infrun.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > = > diff --git a/gdb/infrun.c b/gdb/infrun.c > index edfb5ab0a91..5af8635a1ab 100644 > --- a/gdb/infrun.c > +++ b/gdb/infrun.c > @@ -3741,7 +3741,8 @@ do_target_wait_1 (inferior *inf, ptid_t ptid, > more events. Polls for events from all inferiors/targets. */ > = > static bool > -do_target_wait (execution_control_state *ecs, target_wait_flags options) > +do_target_wait (ptid_t wait_ptid, execution_control_state *ecs, > + target_wait_flags options) > { > int num_inferiors =3D 0; > int random_selector; > @@ -3751,9 +3752,10 @@ do_target_wait (execution_control_state *ecs, targ= et_wait_flags > options) > polling the rest of the inferior list starting from that one in a > circular fashion until the whole list is polled once. */ > = > - auto inferior_matches =3D [] (inferior *inf) > + auto inferior_matches =3D [&wait_ptid] (inferior *inf) > { > - return inf->process_target () !=3D nullptr; > + return (inf->process_target () !=3D NULL Can we please preserve nullptr instead of reverting back to NULL? > + && ptid_t (inf->pid).matches (wait_ptid)); > }; > = > /* First see how many matching inferiors we have. */ > @@ -3792,7 +3794,7 @@ do_target_wait (execution_control_state *ecs, targe= t_wait_flags > options) > = > auto do_wait =3D [&] (inferior *inf) > { > - ecs->ptid =3D do_target_wait_1 (inf, minus_one_ptid, &ecs->ws, optio= ns); > + ecs->ptid =3D do_target_wait_1 (inf, wait_ptid, &ecs->ws, options); > ecs->target =3D inf->process_target (); > return (ecs->ws.kind () !=3D TARGET_WAITKIND_IGNORE); > }; > @@ -4169,7 +4171,7 @@ fetch_inferior_event () > the event. */ > scoped_disable_commit_resumed disable_commit_resumed ("handling even= t"); > = > - if (!do_target_wait (&ecs, TARGET_WNOHANG)) > + if (!do_target_wait (minus_one_ptid, &ecs, TARGET_WNOHANG)) > { > infrun_debug_printf ("do_target_wait returned no event"); > disable_commit_resumed.reset_and_commit (); > -- > 2.25.4 Regards -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928