From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by sourceware.org (Postfix) with ESMTPS id F15503858D37 for ; Thu, 30 Nov 2023 11:40:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F15503858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F15503858D37 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=198.175.65.12 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701344447; cv=fail; b=c0eZlDcymZS4/gwBU/y/LmK7+IoTkKsnjQpiY7bAGoWBiIfWKRblQ1n9aLt8k/Uxtw/KSzhFFGptnjLs2EW8c8Cd0CHelMPA9nUqw72igxmRVy/gy0w9/P2EWsCAxZtVb08ixTEWt6LWyYYlFPX6fpAsFxeK9bijVtyUJhG/Sxk= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701344447; c=relaxed/simple; bh=pXMQbh4pov7rjQvBSqRJY1TgiidPRsTE0l+F/V8vnbo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=tYEbHoe9UA/GRP9azY/n71jcn0WMBpJPszMt6UF0w3pYQu/yVY2CxlCSmct5XvFoeHZHST5aSYK+3egaC/En6bZm+Ihpl0ia/lcDdH88wW1wU77vlRCuGTXt/0DmteN6ghqjuPNNrZx+UaWuUru3d+wGOXI0WJxuc5VJFaWEXnw= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701344444; x=1732880444; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=pXMQbh4pov7rjQvBSqRJY1TgiidPRsTE0l+F/V8vnbo=; b=frr521jMj8V7EQb5vgWDM7vtuDRjCS3amrXkoF5vpUQMfHtv7E0RBeuT tfXpRl/CfQHNc9OCTrJtK18SwddNFkm8v7oovSRiKeAGNeKNJXjsPgU13 51QUx6gole5FY9lH3GnYwg6NsKo5e4oGpBzO54b9Hmj9QRde6I4HNGwll Q9CHbF04jNiLICeVfZpB8qQ8b2quHwZXLfSIAKPYT3z8JFAFzQWEBJbKl cA/PFDYxp4uI0epcG9yVYQcbtQ6M5h5K10LE+yW6c57lPAqZalz6gUTiK wHUh3aYdx3LZIzCPs6dOAM7iwR/pznjl/E2hbO6vDIX3fIAQqB5r1MrYy w==; X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="299971" X-IronPort-AV: E=Sophos;i="6.04,237,1695711600"; d="scan'208";a="299971" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 03:40:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="839776921" X-IronPort-AV: E=Sophos;i="6.04,237,1695711600"; d="scan'208";a="839776921" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Nov 2023 03:40:41 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 30 Nov 2023 03:40:41 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 30 Nov 2023 03:40:41 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 30 Nov 2023 03:40:41 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 30 Nov 2023 03:40:40 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Go8/qaRf+yvkSqnROnmOVnfmiQJScSvIhgpVF7DtkQBrH6VtSTHTfRDo2LZuxCJTu1/hUEW4cNEjfPjKAkRZ+pa+TY4rtmStZ3QQhKRwExYOwHdw14JtfG6GJN+jOFcGIVSgWkAJ8wnG23H3kWOFKXtYARaM/dE7I5y2RJXbRw9YKNCGemDdfGlZpoZXAPr0P08ShAd4KrBjba32IAfNW8MldJKa+mp03eXtbe7NcZaCRc4WOPWShokfkAmvBYMV+m8FE5Fs7yBdf0MpvFceUT89qr9wGt5c/GZQh1zhZXLsqmR2DSX9Rw7Fz1i1CefArlW9OEAG6TuixG2/BeKvVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zRrggvC+tZ/fZlQ6b8QSZbdj0fCesTSUIhztiLR6EHo=; b=FxShpkn9Aw1+/6zJBG5+sYLCM6C/xHZC8zZICn7+6aKG01qnNhXcoEA8i7Gdu2JWBxSf4ws49jRWi/pMqV3FeGQGff7cFEYMl5M9FBAvQvudvvGlIZCoA8NmqgV7xJUTBf63a5z63Qu0RXa6rMGek7kLSN3Je+3+CrRYbwWBcRgqZ9OJxoYAc+yUO/jYoxKq3W7iDA91290xhxq7ZMYEyjrCFaxbjL9dFD0hVm8LmSSAmHrRGrUONMXt3x//xQQTtDUStYvp8gqcaFdckWOOzVqRX7tGcHDq5VcN7agFz6OT+c7cjgpdJnbfIuan3eGu3zbQI2qpnEddhA0OuBBUVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB7303.namprd11.prod.outlook.com (2603:10b6:8:108::21) by PH7PR11MB6032.namprd11.prod.outlook.com (2603:10b6:510:1d3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.24; Thu, 30 Nov 2023 11:40:37 +0000 Received: from DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::b960:9754:455d:b195]) by DM4PR11MB7303.namprd11.prod.outlook.com ([fe80::b960:9754:455d:b195%7]) with mapi id 15.20.7046.024; Thu, 30 Nov 2023 11:40:37 +0000 From: "Aktemur, Tankut Baris" To: Simon Marchi , "gdb-patches@sourceware.org" CC: Luis Machado , John Baldwin , Andrew Burgess , John Baldwin Subject: RE: [PATCH v2 03/24] gdb: make store_integer take an array_view Thread-Topic: [PATCH v2 03/24] gdb: make store_integer take an array_view Thread-Index: AQHaHx0LNq5EOJr+yUG9c61Cuymji7CSw0+Q Date: Thu, 30 Nov 2023 11:40:36 +0000 Message-ID: References: <20231124212656.96801-1-simon.marchi@efficios.com> <20231124212656.96801-4-simon.marchi@efficios.com> In-Reply-To: <20231124212656.96801-4-simon.marchi@efficios.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB7303:EE_|PH7PR11MB6032:EE_ x-ms-office365-filtering-correlation-id: bece927d-bdbc-495c-a536-08dbf1992bc5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kyCYPyi2bXTu40F5JsTsa7/jFjeNQGp8KKwtn0fD55p723bPhdq82F6nYcSZ+9tVOSZvuDNXjSTqTQvpjBJDn3N0PkEA/pgWdzGGeykRn8p2vxlyY3VmKaKtudP6u4J6LaJQ/BYpG1F2fmsQONNvoG021cWL7W6mXchXFvxGJecVHWulNg46ZeZBcJhtf/XDSoZGFCMmUwC2q7q0UJCN/J516vlkVFhoPuHBHz9uBbLNO64T31GGsbhr+sj0w9ffCXWl+XtB+6xW/LA3WRJjMWs3y2gEntwunprgGpPz1ugXfeo88ij4t1QXuVblEMtofvfiHLRlFs35UPLaB/nME3yk761bw8j90+B4B1WAmT+vbEt9zLu6IOfjXy/gaFGZHJTmxN1bufJMY8E8KFjjbH8clKRnhM8yyOosxIWfvHcqQKE+gi9XFyCyED686g1jhzKAOnYoZBmbQGE4KacXk3C4BMMp6jjJNKe9vR9o9MFyksQ+PjZuUWxHTLAa388BqahB6Mf/Vssr6mQP2oNdv+7S+zXEeovzqI7n9Wu4WtrhTzmnJU+/ZaubDqmGtdUN6CGpkrEqQAr1KLDRj/Z3GVYadtFsFyVQwo7/LrwrSIGQPef5XnMQ4F0aUKllL4RQhS34jHaYUl7TP9CM4J7RnV26tsBifFBHxh+is1Igo9B91mpzQ/8t6NMq3PYPrgl0 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB7303.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(346002)(39860400002)(366004)(136003)(376002)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(8676002)(8936002)(4326008)(110136005)(54906003)(316002)(52536014)(478600001)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(5660300002)(41300700001)(38070700009)(2906002)(86362001)(82960400001)(122000001)(38100700002)(26005)(9686003)(7696005)(33656002)(71200400001)(53546011)(6506007)(83380400001)(202311291699003)(55016003)(334744004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HOcQEaszBkvrQgcBp1ravziz8T0B6u3l1GS/u0GLscA6ujCPeF67ee1RHO3o?= =?us-ascii?Q?iqpiDl5TNkWE7LNldSXEYsOxX/ezzru3exF2gLHaTEHZVY8TRK3d/mvIMjtf?= =?us-ascii?Q?bCngGXrDiRORAIRFAyzgepDAk19hl/NNjMaqBIHukBFsuGibckguHSPkp4pd?= =?us-ascii?Q?s0SgEK4/c7lcS+apdaHDw2A8PjWokY+f05HpLBUYXNZxq3rzDzhkxxQyyGLO?= =?us-ascii?Q?liaYfzNaook6QRkiNnGX8C6qOc+qjQi4azNiMfrkDksl65E5F+fWxwZHNpp9?= =?us-ascii?Q?uLohbcFfWapY/ybxQkMsGG2GLnS6QAh4CCP//24aWNXAv0P0PWh6jDdbG6sh?= =?us-ascii?Q?ma1igonIQ6B35vtgsSZ7+WlnvLHDgXLow3VrlAe5FMm/GjD8h5LK91s0DYLi?= =?us-ascii?Q?zMzB1ThgTIdPR04HlWarOk5JIFJSVg5/gdKimNQJfS8zFid4SSH96I8QNDfg?= =?us-ascii?Q?hG/SAnod3TdpTT9kPAQX5TLVdt7HZHH+0NDK3FdNTJ+J3sGG4pic7YcFfdcF?= =?us-ascii?Q?f1CMWH/B6LCeXMLazcVsL2VvDzxApdaImn/rZYuaHPJt/V7RjXdwAF4URuPK?= =?us-ascii?Q?0uq2uoks6em5OQZkBRIxJaZQcRKGhVaqpUiZD6kCLnl6PhzHozicq9nONXPO?= =?us-ascii?Q?x+mYjeYmh6HmSBItpNK4wlsIvP3PWbOhutzy8YfHsOSanq0pSOVUECzSBDuw?= =?us-ascii?Q?NJsE3FL/vc6sqVYCAknxnvHLl5ZkFIuw2UM5b/Dq7N8ISOZ6daeXPBLF/uLL?= =?us-ascii?Q?K0AJ8Xt/KsU86W7bTFWtYiuFT4DLrwchJ0+HIdT23GGiWzcF69y5IbIzOcQ4?= =?us-ascii?Q?YvNcFmRHPy611iGgN+vGLkRKPfRBRrBYJPcaEJ1be0rIx6SwGPYQj19V1Sml?= =?us-ascii?Q?F5mk1q85b/e8KdJ467Q6Bu7/E2QyZQEqNzwGbLpxYLSqrDn7UEvJiMVO6BHm?= =?us-ascii?Q?NBtUwF6F0FEd2MKiFfAgRhqwlI6EEza0x7gu5jvGLuoW0/niJkUJbEX8Jtzs?= =?us-ascii?Q?9Gfp521r2KQkxhV4i9jYVNnv71lpTxCquRyz4JjDgWQp0S+6HK1JXwU6I8Aa?= =?us-ascii?Q?1ia2/idArPBSTGDdj2oypuCiJlee/4wTeShp9q6TAboHodR5QdmbMy9LSFbk?= =?us-ascii?Q?KHc0fzufd9BgJfqgf10xYuucBTEDf0X09/S4pb2Etqke327H7JOQ24go60bR?= =?us-ascii?Q?+sF9IIbyl0Qai8zIsGjQDKaUI53/PMdVSxxwTUWZmD8dQ1yLU/z1PIk0iEeo?= =?us-ascii?Q?AGZr2WO3SdA1kBE7NcC0NdKUzAJJEXaj/OvfRUFr/X0IUjH++VRDI5edfUrH?= =?us-ascii?Q?4PmLGZ5i0bQm8NwnLnva356Lt7pfEoIPL8KWD7ehtErPAGBRICq2vntlm51R?= =?us-ascii?Q?joOkHH72hwZ74POVpUp2MLio0oYQTrtF0ehTdjsVsXJI+VSbviHKTtQCMb33?= =?us-ascii?Q?7/bP5fnt5RYAS00PNFwdL4RMrjUHDKyfQBGBSZyIGgjD9JGhi0DN13nAWB52?= =?us-ascii?Q?u0WqVWqYmh8ZvR5SMcbpLM+/por26vNKCnqDQ2eAqSSGzw3BYBGvRwwkIDOx?= =?us-ascii?Q?UTlmLl67POKiL8QFDq61sWIyg4yArKXPNhkAl1nKmlyJh5an3QR794luv0Dz?= =?us-ascii?Q?gw=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB7303.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bece927d-bdbc-495c-a536-08dbf1992bc5 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2023 11:40:36.9650 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HPOeoTWWcY3ZqNzj8vrq2h/wqFT3nLWyZCCJ7SmSMfcDWeF8rHegHMC3Tj58edRC3NykP/G8UOtGeGimstuDAuj+HRy44qZIHXESQZxtt3o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6032 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Friday, November 24, 2023 10:26 PM Simon Marchi wrote: > Change store_integer, store_signed_integer and store_unsigned_integer to > accept an array_view. Add some backwards compatibility overloads to > avoid changing all callers at once. > = > Change-Id: Ibb1381228ab1cb65fc7e2e4b92cf9ab1047cdc03 > Reviewed-By: John Baldwin > --- > gdb/defs.h | 39 +++++++++++++++++++++++++++++++-------- > gdb/findvar.c | 16 +++++++--------- > 2 files changed, 38 insertions(+), 17 deletions(-) > = > diff --git a/gdb/defs.h b/gdb/defs.h > index e6dd93e791e3..f6b7a2a19a9e 100644 > --- a/gdb/defs.h > +++ b/gdb/defs.h > @@ -495,21 +495,44 @@ extern CORE_ADDR extract_typed_address (const gdb_b= yte *buf, > target-format integer at ADDR which is LEN bytes long. */ > = > template> > -extern void store_integer (gdb_byte *addr, int len, enum bfd_endian byte= _order, > - T val); > +extern void store_integer (gdb::array_view dst, > + bfd_endian byte_order, T val); > + > +template > +static inline void > +store_integer (gdb_byte *addr, int len, bfd_endian byte_order, T val) > +{ > + return store_integer (gdb::make_array_view (addr, len), byte_order, va= l); > +} > + > +static inline void > +store_signed_integer (gdb::array_view dst, bfd_endian byte_ord= er, > + LONGEST val) > +{ > + return store_integer (dst, byte_order, val); > +} > + > +static inline void > +store_signed_integer (gdb_byte *addr, int len, bfd_endian byte_order, > + LONGEST val) > +{ > + return store_signed_integer (gdb::make_array_view (addr, len), byte_or= der, > + val); > +} > = > static inline void > -store_signed_integer (gdb_byte *addr, int len, > - enum bfd_endian byte_order, LONGEST val) > +store_unsigned_integer (gdb::array_view dst, bfd_endian byte_o= rder, > + ULONGEST val) > { > - return store_integer (addr, len, byte_order, val); > + return store_integer (dst, byte_order, val); > } > = > static inline void > -store_unsigned_integer (gdb_byte *addr, int len, > - enum bfd_endian byte_order, ULONGEST val) > +store_unsigned_integer (gdb_byte *addr, int len, bfd_endian byte_order, > + LONGEST val) Did you mean ULONGEST here? Thanks, -Baris > { > - return store_integer (addr, len, byte_order, val); > + return store_unsigned_integer (gdb::make_array_view (addr, len), byte_= order, > + val); > } > = > extern void store_typed_address (gdb_byte *buf, struct type *type, > diff --git a/gdb/findvar.c b/gdb/findvar.c > index 952ec20c0b73..c7a681f8a890 100644 > --- a/gdb/findvar.c > +++ b/gdb/findvar.c > @@ -159,12 +159,12 @@ extract_typed_address (const gdb_byte *buf, struct = type *type) > target-format integer at ADDR which is LEN bytes long. */ > template > void > -store_integer (gdb_byte *addr, int len, enum bfd_endian byte_order, > +store_integer (gdb::array_view dst, enum bfd_endian byte_order, > T val) > { > gdb_byte *p; > - gdb_byte *startaddr =3D addr; > - gdb_byte *endaddr =3D startaddr + len; > + gdb_byte *startaddr =3D dst.data (); > + gdb_byte *endaddr =3D startaddr + dst.size (); > = > /* Start at the least significant end of the integer, and work towards > the most significant. */ > @@ -187,13 +187,11 @@ store_integer (gdb_byte *addr, int len, enum bfd_en= dian byte_order, > } > = > /* Explicit instantiations. */ > -template void store_integer (gdb_byte *addr, int len, > - enum bfd_endian byte_order, > - LONGEST val); > +template void store_integer (gdb::array_view dst, > + bfd_endian byte_order, LONGEST val); > = > -template void store_integer (gdb_byte *addr, int len, > - enum bfd_endian byte_order, > - ULONGEST val); > +template void store_integer (gdb::array_view dst, > + bfd_endian byte_order, ULONGEST val); > = > /* Store the address ADDR as a pointer of type TYPE at BUF, in target > form. */ > -- > 2.43.0 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928