From: "Six, Lancelot" <Lancelot.Six@amd.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "lsix@lancelotsix.com" <lsix@lancelotsix.com>
Subject: RE: [PATCH] gdb/testsuite/lib/future.exp: follow dejagnu default_target_compile
Date: Tue, 20 Sep 2022 14:16:54 +0000 [thread overview]
Message-ID: <DM4PR12MB57455ABF574A808BF9453E9D834C9@DM4PR12MB5745.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20220905182616.621993-1-lancelot.six@amd.com>
[Public]
Hi,
Kindly pinging.
Best,
Lancelot.
> -----Original Message-----
> From: Six, Lancelot <Lancelot.Six@amd.com>
> Sent: 05 September 2022 19:26
> To: gdb-patches@sourceware.org
> Cc: lsix@lancelotsix.com; Six, Lancelot <Lancelot.Six@amd.com>
> Subject: [PATCH] gdb/testsuite/lib/future.exp: follow dejagnu
> default_target_compile
>
> GDB's testsuite can override dejagnu's default_target_compile if the
> system provided dejagnu installation does not provide support to compile
> languages GDB needs.
>
> Recent version of dejagnu (1.6.3, installed on REHL-9) includes ba60272
> "Establish a default C compiler by evaluating [find_gcc] if no other
> compiler is given."[1]. This commit removed calls such as
> `set_board_info compiler "[find_gcc]"` from the various baseboards
> and has default_target_compile call `find_gcc` itself to find a compiler
> if none was specified by the board description.
>
> On systems with dejagnu-1.6.3, if GDB's overrides is needed to support
> languages still unknown to dejagnu, we end up in the following
> situation:
> - The system board files do not set the C compiler anymore,
> - GDB's replacement for default_target_compile assumes that the
> compiler should have been set up by the board file.
>
> In this situation, no one sets the C compiler for the board and as a
> result many test are not compiled and not executed:
>
> [...]
> Running .../gdb/testsuite/gdb.base/bt-on-error-and-warning.exp ...
> gdb compile failed, default_target_compile: No compiler to compile with
> Running .../gdb/testsuite/gdb.base/dprintf-non-stop.exp ...
> gdb compile failed, default_target_compile: No compiler to compile with
> Running .../gdb/testsuite/gdb.base/structs3.exp ...
> gdb compile failed, default_target_compile: No compiler to compile with
> [...]
>
> We are observing this error with ROCgdb[2], a downstream port of GDB
> supporting AMD GPUs. This port needs to use GDB's override of
> default_target_compile to compile HIP programs since dejagnu does not
> provide support for this language yet.
>
> This patch changes gdb_default_target_compile_1 in a similar way
> default_target_compile has been updated so both implementations remain
> compatible. Even if this is not strictly required by GDB just yet,
> I believe keeping both implementations in sync desirable.
>
> Using board files provided with dejagnu <=1.6.2 is still supported: if
> the compiler is set by the board file, gdb_default_target_compile_1 uses
> it and does not need `find_gcc`.
>
> Patch tested on x86_64 REHL-9 and ubuntu-20.04 on top of GDB and
> ROCgdb.
>
> [1]
> http://git.savannah.gnu.org/gitweb/?p=dejagnu.git;a=commit;h=ba60272a5a
> c6f6a7012acca03f596a6ed003f044
> [2] https://github.com/ROCm-Developer-Tools/ROCgdb
>
> Change-Id: Ibff52684d9cab8243a7c6748ecbd29f50c37e669
> ---
> gdb/testsuite/lib/future.exp | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/lib/future.exp b/gdb/testsuite/lib/future.exp
> index 36dd611d61c..17736ed360a 100644
> --- a/gdb/testsuite/lib/future.exp
> +++ b/gdb/testsuite/lib/future.exp
> @@ -403,7 +403,11 @@ proc gdb_default_target_compile_1 {source destfile
> type options} {
> }
>
> if { $compiler == "" } {
> - set compiler [board_info $dest compiler]
> + if { [board_info $dest exists compiler] } {
> + set compiler [board_info $dest compiler]
> + } elseif { $compiler_type eq "c" } {
> + set compiler [find_gcc]
> + }
> if { $compiler == "" } {
> return "default_target_compile: No compiler to compile with"
> }
>
> base-commit: b9593cb70533f28d276ab8d582dfe622aa4591d5
> --
> 2.25.1
next prev parent reply other threads:[~2022-09-20 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 18:26 Lancelot SIX
2022-09-05 18:30 ` Lancelot SIX
2022-09-20 14:16 ` Six, Lancelot [this message]
2022-09-22 16:26 ` Simon Marchi
2022-09-22 16:55 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB57455ABF574A808BF9453E9D834C9@DM4PR12MB5745.namprd12.prod.outlook.com \
--to=lancelot.six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).