From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2049.outbound.protection.outlook.com [40.107.92.49]) by sourceware.org (Postfix) with ESMTPS id 535923858C20 for ; Thu, 8 Jun 2023 21:13:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 535923858C20 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bdZJ7TUiXgGFbtoWfARNzRz/8XX7K4U0YL8d0o2+bD4eW4XR1K38vQebqVEypIl7Q2QjHCzIyh+ihWr4tFXXrwUfePfCBOf/iFQY8S6IbVI92aSECFZUlKwRxCcrKed09rVYj1qIO4M6HUGj5VOeOeFK22fkSDr0rUGMj4bvg614DxR16p7XE1r2U+/FFXn+n9lSyL/0cEIimP6X/r5zfjPzfgVHa3rcGJXPbqNevgjoI1PLurAmRz8F5agx/A8izalsR/7Vrg1Wz+md3Sdy3GQB+wbUv8emsiHH1mq1Mt1+LtJrYEYRiEzQhApHn1oQdhwLX9zLi5ipogmAqzEduw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6LaBHDsu6QLwNkw7QDH+FGHMUbZyqIG5SGeYzffiQ+0=; b=Ov5BvYRO4At+N2nNr3b/AomyNTIHE30MGKNlRo6m5GxD9GUYaEKmL1ZiWIc6sMHA6GluBLo+tx/b8UlQIl/1RwzI8pxmK8cJyYUow2KLsG7RYVrdTU+Y+G5kl8p//ttf49fLBMlfyJOzwhdGMYnLEmczvM0NOiQJX/IT5X85ibjcwtHmgh0MhbK28VpYGXSyudaf2VGx2W6lUYuoX39gr5nNWbD6Xb9VlwM0mouS8MYuwtgCva1kZXJiNUUgkqwNcnCjYel1GjspKRB51R2G7p/mU/UgiYhUWEA567XxN7/dfnxqzGji87PwjLlF5EJZEY8fClLSjoYysxdzHfoB4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6LaBHDsu6QLwNkw7QDH+FGHMUbZyqIG5SGeYzffiQ+0=; b=1rQXJPaUYVHMz217aEzJiz1Xgq6+eGYMMq6xyeHpxOQVjP4A+qNOS6frNSOv68GD2ISXQs45eVZ7Sskpqrh1tQtE153oygmDCRDdDZwx3PvJ8/HZ056at8Rohz0dVEFKRODAhxf8I3tvxL6aJuATBuIXiLAzLGgDMjs1lE1Ghfo= Received: from DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) by SA3PR12MB9157.namprd12.prod.outlook.com (2603:10b6:806:39a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.39; Thu, 8 Jun 2023 21:13:17 +0000 Received: from DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::639b:9e9f:4d79:7ce8]) by DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::639b:9e9f:4d79:7ce8%7]) with mapi id 15.20.6455.030; Thu, 8 Jun 2023 21:13:16 +0000 From: "Six, Lancelot" To: "gdb-patches@sourceware.org" , "Six, Lancelot" CC: "lsix@lancelotsix.com" Subject: RE: [PATCH] gdb/testsuite: use proper int size for gdb.dwarf2/symbol_needs_eval*.exp Thread-Topic: [PATCH] gdb/testsuite: use proper int size for gdb.dwarf2/symbol_needs_eval*.exp Thread-Index: AQHZmh9vX2iqDwPkSU6a4ATFhwqZeK+BZlPw Date: Thu, 8 Jun 2023 21:13:16 +0000 Message-ID: References: <20230608153842.353415-1-lancelot.six@amd.com> In-Reply-To: <20230608153842.353415-1-lancelot.six@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=37efee6b-07a6-41b5-a2cd-9c74ff6f36c2;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-06-08T21:07:51Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5745:EE_|SA3PR12MB9157:EE_ x-ms-office365-filtering-correlation-id: bebb4637-4584-4c49-2c53-08db68652d80 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: anQnTC+DWpm2JuiNmvq0ZDIlm0O3iX4KcObgBQrsynxbhmwx8Wa113c515iJOcTFyHydjErsk/hIWQtbV57CO0PdbnqB8sP+hpjyqUU6dXx8oNehWU+g7WUCBy0ERhVbumA00BDnfcv+QXrvNUjXhrNG93sLibVG1nYAAQtNhHZ+5TwYtsrtFvwudlUzcfvx9JNLTX9GY2xcq6WKy8jmAt2BAgOgxME9kHgRwaXiE/InsamejMtqCBm2ADTS4IK8UlAqQREtzNYF+QhuR93x/QRCWYyf/VIAJulmGT63xjZT//mHS5C8SUQV8+WYa3qW442eyCukIRJYiCqgHq15xDFzNQH9Qg6fqGYjx/yeZlHrejyOBK5WhQUuMyuogWuCvBYXMP9w1XPkTqYrlFRWKJLubnCBBS7NPVDxW3lXmDHeiBwbluCBOm6uDzImf94E7XetXozs33705Fo2XLqsgsnGim2UbTRsxPcveGNH7S7GYfObND3OPuC2aoGv3zQUfJ6DDKqPv8s8faBkmG0F7QjHr+maHJ/oxWMTEFnavC7hCoSlrNrN66G89wUMNK0ihndc1Tx/Bt56uT4TCtOcku1ufrb6/hbeT+Lipe5Z6ydU8wf33N95LLV9HXRycA30 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5745.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(366004)(39860400002)(136003)(396003)(451199021)(71200400001)(7696005)(55016003)(86362001)(38070700005)(33656002)(122000001)(38100700002)(6506007)(9686003)(26005)(186003)(8936002)(41300700001)(8676002)(4326008)(2906002)(52536014)(5660300002)(478600001)(110136005)(316002)(64756008)(76116006)(66946007)(66556008)(66446008)(66476007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?n+3gWjvQMNZzS2QNEbJuYhSHfMOXfGGlAL9yQk0F6mcRD7qh7mWPEDy+BYWu?= =?us-ascii?Q?BrLCcrqS1sxbFpTXe/EUGos4aCz5tGpSRlLQmHBRzbqqUf7Ww2tpXiDC/Vl/?= =?us-ascii?Q?klYEbfFgIYT0JKeCO26IaEY+U7nMB1Yph14KQoPFhZHMNKZ/hHET1mSqbTJV?= =?us-ascii?Q?kEl+3djLn9ZXocukbap+qpwonHQKjuLkJHChRmuZN+tQutsAAhyzMdfEU9Df?= =?us-ascii?Q?xkRj8EbTSFIFUB1H8YvyvbdJ/4TAGH6CfJEbN/BKtK5hhCoF1diH9gWmuGWQ?= =?us-ascii?Q?Z6mA755DWbjV0Q1U9M9mxzoTp7pS2QS4qDBE5aRVKGV99Ips0mAL/bDk6bdc?= =?us-ascii?Q?B6zx8SxTT94xUdJc5nvxuqcIsfv5oAzShOYoIYEbuUgTsOB52j42OV4ALaBA?= =?us-ascii?Q?6xLD9RijqYIefFwMzeXQ7VEPzky+7Xl09FqL7DIztFBG3fttEbJMVt/8VEik?= =?us-ascii?Q?ht5hex4AKLEWl4NJeaCKgkQXclc8gR0NJaBqWEer7f2q4TkiXl5LxkO3BryJ?= =?us-ascii?Q?rvYHUyY9qrcy5EOL00TbQ2onxJW2g8xUBlfKJjuUzb7Syj1he1cPnuubclTM?= =?us-ascii?Q?N33xHK0eMsExN4art6UB+qPmaJxtlnz8XpETCW/6XsbK/KknlJtfBzYQgJkv?= =?us-ascii?Q?MuBcrCE8KFwUMoNjOuztrixAVRACKPXkcw1xBkM4E5sPyFGXD2CGwODccDbi?= =?us-ascii?Q?4gU8ohd4KCAlWQEsYDjQm4MQzgXfMClLjAxNU8XdFzN/IVTCxVzY1s7QOTEa?= =?us-ascii?Q?qotMA0kjPNQuD/VrCfkd+zltWDmgztfaaZsUjRMHpZz9saavRgoFbmdvQ9Dg?= =?us-ascii?Q?rpBTUipfK4Jgz3SWM6B73ke0Qgda2EJ4WUMuJfxdtO72Nr4a0fHNkLjzps6G?= =?us-ascii?Q?UNnl5sVLu8OUaIfhp79YyTII1PTETfsLny3anmQfvHubm3UvrygsOfKtjV1j?= =?us-ascii?Q?eBQ1/nsPv7KS4NCHuMKNxdtvjq5+XdiBBvzTIevM2YzvJRkHUf15HMAFBRPm?= =?us-ascii?Q?fyWLNjpXIIZe2cUUOdZYhGcxVazaDSUFrYj3XoiCryC7SwnAa9qegLy6jwqc?= =?us-ascii?Q?QdflyCTKcM7+jw8G40XcfVUZ5rdiYDWZm2H7lVCnxngLaxyXpc0bEfBYBQHP?= =?us-ascii?Q?lnP3LbH6ra8LFrL4NnXm9VDnIpRfVYvZ5DhrSbh+EgqhPY+Xqr05tnZeaYbA?= =?us-ascii?Q?5mPfnqZfmSlFVULXtFsPVkmk75KZhcVTOvB1yYrKmus1HeMfQJzj8fvBoY6W?= =?us-ascii?Q?jQ0g+aF5BCQsOE4kjtMQOKZ7CQpAhaXDcAB3P5EG/VycT39/6kp6BtKqzmHA?= =?us-ascii?Q?o4KbtBqpbmFQYJUanfHzds9wZkt6e5an4M8xLGSEc81m5ZP5fU9TV0HaoQpa?= =?us-ascii?Q?xPzWLcRpanvNBSz0IufyOEdH9ANOu36K2/zUw1+43XG6XTXjh/zSpVtcIQvi?= =?us-ascii?Q?6DQN+i5BrWBugn4KvlbOUsHZyJVKrPtGZnz1ROv3nG9bcPQrZFI52kHxJzff?= =?us-ascii?Q?X9AcJ8mYKp1vgMg4i/+e0m9sNxYjIUw+/AOCIBaxH9h47MDIo38xkCESmDv5?= =?us-ascii?Q?rZAX/1SlTS06vulsBlE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5745.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bebb4637-4584-4c49-2c53-08db68652d80 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2023 21:13:16.6659 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uA9X2cSeUiVCMOkaONKIO8BfSg6wwLHOlqO9OX7g/qFOlYf0eRNGoL+RtR3M9Gxle0DH13y7wJ0izxRlgX9r2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9157 X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: [AMD Official Use Only - General] Replying to myself. > diff --git a/gdb/testsuite/gdb.dwarf2/symbol_needs_eval_fail.exp > b/gdb/testsuite/gdb.dwarf2/symbol_needs_eval_fail.exp > index cb9826e90df..c3440d970dc 100644 > --- a/gdb/testsuite/gdb.dwarf2/symbol_needs_eval_fail.exp > +++ b/gdb/testsuite/gdb.dwarf2/symbol_needs_eval_fail.exp > @@ -47,11 +47,19 @@ if { [is_aarch64_target] } { > > standard_testfile symbol_needs_eval.c ${gdb_test_file_name}-dw.S > > +if [prepare_for_testing "failed to prepare" $testfile $srcfile {debug}] = { > + return > +} > + > +clean_restart ${testfile} The clean_restart is not needed here as this is the last thing prepare_for_= testing does. > diff --git a/gdb/testsuite/gdb.dwarf2/symbol_needs_eval_timeout.exp > b/gdb/testsuite/gdb.dwarf2/symbol_needs_eval_timeout.exp > index 0e6ee6112ea..ecdeb62a1a8 100644 > --- a/gdb/testsuite/gdb.dwarf2/symbol_needs_eval_timeout.exp > +++ b/gdb/testsuite/gdb.dwarf2/symbol_needs_eval_timeout.exp > @@ -47,11 +47,19 @@ if { [is_aarch64_target] } { > > standard_testfile symbol_needs_eval.c ${gdb_test_file_name}-dw.S > > +if [prepare_for_testing "failed to prepare" $testfile $srcfile {debug}] = { > + return > +} > + > +clean_restart ${testfile} Same here. I'll prepare a V2 removing those 2 lines. Best, Lancelot.