RE: [PATCH] Debug support for global alias variable

["Natarajan, Kavitha" <Kavitha.Natarajan@amd.com>]

[AMD Official Use Only]

Hello Bruno,

Thanks again for the quick review. I have fixed all your comments. I understand
that you are working on cleanup of gdb.base for clang testing. Now all older clang
versions would XFAIL while the existing FAILs would PASS for clang with this fix.

> > -  /* If the die does not have a name, this is not a namespace
> > -     alias.  */
> > +  /* The die must have a name for namespace or variable alias.  */
> >     attr = dwarf2_attr (die, DW_AT_name, cu);
>
> Oops, I didn't catch this on my last review. DWARF 5 manual, section 3.2.3
> Imported (or Renamed) Declaration Entries, says:
>
> An imported declaration may also have a DW_AT_name attribute whose
> value is (...) If no name is present, then the name by which the entity is to be
> known is the same as the name of the entity being imported.
>
> So I think the check and the comment are incorrect (or the spec needs
> updating). I know this isn't something you added, but since you are changing
> this function, I think it could be a good time to update this.

I have modified the comment. If no name is present, there is no need to create
a new symbol for the namespace or variable alias. So nothing to do in this function
and it returns false. The name of the imported entity is used in this case
("using" statements in your example).

Regards,
Kavitha