From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2067.outbound.protection.outlook.com [40.107.92.67]) by sourceware.org (Postfix) with ESMTPS id EFB303858D3C for ; Tue, 19 Apr 2022 12:46:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EFB303858D3C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UsFI9bOrmTsCnMx/XXKA57DDtptvq+ISIwiHejnlzqTm5cOGysRfHrbNs914ep8YJr3q7uSwTewMyeGGljWTnFlg9Ranv/yN8hmA0RZIP6taSBiDvkP5ij/apDcvLKRHV4sHOaa4StYCbwPk9/aqpaEhVWAPyTye6jR4Lf+7v3A9hbfIRLgRtXBLHncmwxTYrLFiPVrVLWwmJpVJdVZJLS0wV4GR8RW+6nltC4O4dM8+K0dhZCNd8Az3oDw0eWLPu15dMnHXIfq3ai4YMMcCHp+TZhjELZ7xA2cbLf0V0oRLBLuv4XG3WQWkA2bTh36jgfEcHRSuTMBwdYxx6N9Dlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0aaSuk8/s3+xoDX0XYVox/NUiXaMBu0UM6YH0iDi+lw=; b=bNlh+Hyb0NLtPM391XM771YsBDz2aKjJ5vHwm5ONQddo+GVA+AF4gk0PPa4dg5uPPqSzDoFOvbYrvOcGjnWKwzoeMTRPHTg17cEy7D3AZZ415IA/WyWRzLj4bEYm/6raBwwcBsGp9Wac7tj049py7HYUIRHRhSgPV//5Wvmwz6WVjZSgFGeWkONJXV8B4ma5VL3Dl4aCnO1iql4t81wbd3ki3TRhzMesd72qUn6Rr6pK+EiIBRRbhmlyrfMinYZUCEAruMTkdgimCYDsEpBNJ4T5ypPLsF5lpV74JZngrC6PaK9HBfO2R6KlN9BVNMLGC1glBBE/lPtPPHoHQihF5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM4PR12MB5796.namprd12.prod.outlook.com (2603:10b6:8:63::16) by MWHPR1201MB0175.namprd12.prod.outlook.com (2603:10b6:301:50::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Tue, 19 Apr 2022 12:45:59 +0000 Received: from DM4PR12MB5796.namprd12.prod.outlook.com ([fe80::b05f:c760:5349:c2b2]) by DM4PR12MB5796.namprd12.prod.outlook.com ([fe80::b05f:c760:5349:c2b2%5]) with mapi id 15.20.5164.025; Tue, 19 Apr 2022 12:45:59 +0000 From: "Natarajan, Kavitha" To: Tom Tromey , "Natarajan, Kavitha via Gdb-patches" CC: "George, Jini Susan" , "Parasuraman, Hariharan" Subject: RE: [PATCH] Debug support for global alias variable Thread-Topic: [PATCH] Debug support for global alias variable Thread-Index: Adgvx/KC9Ls2FcnvTJeRu5jcNWYisQPvqNcAAMR4mPAAN0esgAApFU6QAAWQfSADLKLJ2ACLGbggAAmV9IYALMmHcA== Date: Tue, 19 Apr 2022 12:45:59 +0000 Message-ID: References: <66ca57f9-c3b8-4aeb-f07c-c3c254dfdea6@redhat.com> <87ilra1gcx.fsf@tromey.com> <87sfqawi0v.fsf@tromey.com> In-Reply-To: <87sfqawi0v.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ActionId=b1cc0757-2361-44a8-91d0-dfe5240f1741; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=true; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD Official Use Only-AIP 2.0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2022-04-19T12:25:55Z; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 71cb2701-1832-4995-1e5a-08da22028e0a x-ms-traffictypediagnostic: MWHPR1201MB0175:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WKQ7uI6OcKzjg+qR9r2OW3wx8khYB0cicxTJZr3xwRMjhFIPOXNK4/9MH+pcV1yIoUiggQWBA8v6JR/vUar8bCLEInJ0m2Out0NWH3goPvp1JWEjFCcX6sy7frPlYsP+r/+E6hfUNdfX4K+F9UB/lJ4Mp6vM/aUWSSGB0yqvpd1HXMm0a0tHPZBSGBjf//RIstCwzIeVQouQhBr1awB2Z7hfpsQgNC4cs2P8UrXKCk0joxb7clmr+bKIUw6pf8IFd2RwPVcszl0b7pccVSoLoZJsKtNh4GhRmLW+9L0jk+FdE7sua+2U18EAwJByRuClK/9NP/wPjDwQoAmW+0zpEH2Rj2eoOkMaQEDnZIGZ2YUXNQqv10OT+7AvRoEKMvGgmLx1sd+C+aKXM2NZYEh6YP1gn+upXhiYl/iDwzIPjIxq1A8OgZbBOhtq5ENuQtuFR5/MpqMGZEgBi+ynK8j9OWXJ052lmWfQDlAuHpGsgBBgyPKXg4JqbrLnqszpNhUCl8MRdhnFrm5sVAtypsCIhJarhcivadgQO1R13bNuXIpcO8amha9nRlHACMZXuVDxDAsP7CRWCfv/fR0cCiUud38VKyNCSNKwXiVQAD7cMqtfn4Fi58cPWPyEccEsVmEsC/V5gX/3mMUNSfZD2lsC47OGiKnHDRN9pbzQxED1uIsHGchSyP/9iR4Frv6W/9UEeMsio3dchiZbLezQjSfSlQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5796.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(66946007)(76116006)(66556008)(66476007)(55016003)(186003)(66446008)(54906003)(110136005)(64756008)(71200400001)(4326008)(8676002)(2906002)(6506007)(9686003)(26005)(33656002)(86362001)(7696005)(508600001)(4744005)(316002)(5660300002)(122000001)(38070700005)(38100700002)(8936002)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lTnllmlTC5G6fgCw11o4qdTSk5NkxLNilyWKTStfdzke5tZUaibyWAZtvBsF?= =?us-ascii?Q?bsA2TRFRnBst6pYNFauNz/fTOAVrB/jj4fH9cbjc/F12GeP9h9gZLeUIk5wv?= =?us-ascii?Q?w1S18AiyMVLQQo0Z7HMX4pEKQuXnvLpn8hJrf6Vszr/WGCwQvTsX5BmqBvdH?= =?us-ascii?Q?SU4xyJZlmzcF9/waa8UFqrqGsHML4aDhOTOX3C8Okwk7YMMnQQxBWImmgZSS?= =?us-ascii?Q?fBeHsCmCh1cUc1Mc8XpPjP0RWb1+1aqmkW/9UZPQwESJmFp7qVlWz00fMs8K?= =?us-ascii?Q?XbCTO9IOxNDuZJLQ7Wly9MaFN37AFC4TmHhfXMMP3JmHqiMnOQ07zK20inlB?= =?us-ascii?Q?CcROn9fLG7RJD2kS252iFX03uxLQ7ULVctkoO4ALdWVxtoMHTUi08yN42d4t?= =?us-ascii?Q?L26YWr3NBaH8NIbsGbzUOUaltwIlZClCC2ReQiBzyrs7uhy6ZBOj1CrvYJMR?= =?us-ascii?Q?0BRxRq2ThhdCSwx20r/MNJu5vf51Arq6b1wOcWQLamoL4HdMRsbN20YMA15m?= =?us-ascii?Q?RnwA0jLz6wurzEhAmW1q5FHYO3nQ8PJAQ+NWS7zUW4LjPU4P6JULPqK94Ii/?= =?us-ascii?Q?y/f5DWNdH+JVVe28Q+0VnASpNGM3z30BTvE56CiQ/fPocpPYRQf+1h3dYXK5?= =?us-ascii?Q?Ln8UbhzTfJNMABseht6QSyRibzW93Qt0Ay8mXGaZpQKtSrwuM11Lu0z9TBWR?= =?us-ascii?Q?rtd79vqHiyjYJk/nzuH2+EoBhXjhgqULFouq/kWMzuQN4HIWB5eRZcSOnX+r?= =?us-ascii?Q?n8odunQAvhUmcjIUmBMn7+Gh8nniID04GfugDOH6SxGfwr/xYAsxsc0N2rBs?= =?us-ascii?Q?YrPV17Sh+iIG0Q3u3kofIrRwDa4xKG8MFJtPoH3/VoONN4aDqG/LghkCbRkd?= =?us-ascii?Q?V7/51Ti0ND9ScqXYg6i8tV8APbJHm5t2Wm6VHOFcUR/rTvTK98pyGc+Fy1kt?= =?us-ascii?Q?Ckj+ILFXgs2X0yoIiOnL45cNB9zKLTmg5v34kGKb6IMNAHXpT7TMaVxHJb90?= =?us-ascii?Q?6zVCh8E7EHhwu71IjoGM5vdtVHA5CkkCC54ExvzrHVNv0+RldDpZ539KcL2n?= =?us-ascii?Q?yCBdkCLOOQXVtt60myzssTbJXmQ9K2ogG2J4teEaL6APOpREKKWlJqtgthlf?= =?us-ascii?Q?ma8HSuZ/AAqQbgyKj5BHealiPuhRoIwr2P4+3uXVqqGgcCqypHpmtPFG04dK?= =?us-ascii?Q?zv/LQ4K9XoifsU/yDjT4C7RObcO+SiiUett/hyF92IKxMJO/HPoFQ1MfxXZd?= =?us-ascii?Q?kwnlg3uc5NNtJrK8cjZ66Kt2KuN6XwECJ5MQ4z9Kc1GFMlRLnjY93W8GW9DO?= =?us-ascii?Q?b5m1rtIY/DOwAe5dHYwMIssA2ed9r3oplyUPLlh8doObUqJMZ7R8k/GtCgGs?= =?us-ascii?Q?W3DwdJmlNBxRBdixWD3P/wrU0oV7wmsivKx2E+Umhx5DEa855KiFWGZwnEL3?= =?us-ascii?Q?gBqU0j0pRYU92sAeR/xuOUsd7ZMc1cSQOxTdggplRuDzG5W8gPL0stQoVkvk?= =?us-ascii?Q?fQjMU4M+KT6dArVJkmPUknxhDnMU2w2fGmxpsh/NQI2plgXYx29222TOIVlg?= =?us-ascii?Q?ek95WP2SmBNCKRmTzgjN17wr7INGbJM+0/hDgh+fjnxdSH0SWQHFM4tbIxHg?= =?us-ascii?Q?COQdUZdRXd0TGcEM9YeaztgZvSCUITWqqEQiWEB12FbGRirUGUB2T4PqW5r/?= =?us-ascii?Q?0930Qg7la4H+iVx+ilSz/HUItIz2We1xdGIbYaqr6COd2tB9br3o4IG1SEUh?= =?us-ascii?Q?AxQWVS8ryA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5796.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71cb2701-1832-4995-1e5a-08da22028e0a X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 12:45:59.3091 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ylnVRGEZzTU+yJLDWiXjbFptnCoVmCSJwxk1EOAs67VjvkDTMg1neag4peqmfOVGHTh+VgVYwklt8JnRB8Id0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0175 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2022 12:46:07 -0000 [AMD Official Use Only] > Is there a reason not to handle other languages here? > > > + if (((cu->per_cu->lang =3D=3D language_c) > > + || (cu->per_cu->lang =3D=3D language_cplus)) > > + && (d->tag =3D=3D DW_TAG_variable)) > > This is over-parenthesized. However, I still think that the language che= cks > should probably be removed. I'd like to get the Ada compiler using impor= ts > like this to represent renamings, though I haven't tried it yet. > > thanks, > Tom I have tested only with C, C++ and Fortran. Fortran doesn't pass through re= ad_alias() as fortran imported variables are processed while processing imported modul= es itself. But I may not be able to test with other languages than the above s= aid ones. This is the reason for not exposing the code for other languages. Atleast, = I do not see any regression with gdb testsuites. So, let me know if it is still ok to re= move the language checks. Regards, Kavitha