From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by sourceware.org (Postfix) with ESMTPS id 7A9873858281 for ; Fri, 18 Nov 2022 08:31:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A9873858281 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668760272; x=1700296272; h=from:to:subject:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding; bh=2xEf25sjmEZsSCDVQvU9pDBS46adgbmTSkxA2OR3ces=; b=NzMZjcJOWfs6UWLrvxSpejHFNQHaK8L0CsnJJBU3toBpMXmS59CJ4UUo 9fu9ilYYzmqbrQ70QgNREzKlPQpDT8A0JPpVSzRCxbRI+ueRbBHzY7kkQ qXidC0ItN/D0rblCk0n/1tvPY9WqEBmbT78zQak5MaXwRsUWKZV6hdvgk pXwO/0mxgUrsH0wpsB77EAg4fEk56gMluCZRybIG44j+uBS3jchvQzTKl LM5/YZw6eI4qllNDffT3DThaJQKftlkH8Gnqp9GFfqZ9RKXR55Zn4ngKy uBiyRIA/A3KLQxC7CEaspusIsQZPL03GxD/HfMdjjO96lECiR5Us9fajt Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="375220375" X-IronPort-AV: E=Sophos;i="5.96,173,1665471600"; d="scan'208";a="375220375" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2022 00:31:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="642430670" X-IronPort-AV: E=Sophos;i="5.96,173,1665471600"; d="scan'208";a="642430670" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 18 Nov 2022 00:30:47 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 18 Nov 2022 00:30:47 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 18 Nov 2022 00:30:46 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 18 Nov 2022 00:30:46 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 18 Nov 2022 00:30:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eeKPffxNS7tNVxWlZpbLnsZpdqJFjeG6G/e00aKo53Njo689gF3YJY3iyJWaTiqRC2QYvcYyvjwBdypg7sDIqCgOXJjPeONbgYFaRJNWbdF/jKw9Tb/b/NDtszIzX1JWQT/5OBMdeWFzr1THH7c8+mxjp8SAGF6mvkcWlwhfHk+rfRc+ZykIfHVxlOp879TNFtdKmDSWdzlAZcAKx/lB7YWmM1Jsv1m1Elg4faeoJAO4TFUQb0EBISFTQfQWv4alME/4Q2dhnMPSDLIT6tJEBND+NLsCtxHtSd+J6FC2Fo0uR8YNrhNSxjHqWLc4pPSfVOB/wl4eIY5erYBtB251EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VVd86nKVvhBJi367AsARemh23LyLN+92cC7IeGYvzeY=; b=nuMrt58SA9+utlQ/klyt3BhNtxKw0myrxOuhA5tgWQiy2ihKcCqKvRvNV1gxmfjBVneyC52Da85De8rZ2nVyr9O4pyMZuDv3HNItm2Q/IdMe3OpNab8RCTuOCHX5k5KZ2HLSbpz46PZiA19bfUmzfmvfPsZM3elScCn38k7gVzanUzpDf85dteDb6ATJ01cU6xaeDVDy3J08jwBYjsL5wEMkGasGem0ucCA0ikUN7aLD6nFtwa+Kz4iY5Mx765CaXzLCNzNLeDOSHTvCmKrvl10i/4eXhkxCBP6vlybAJbtlcDDBdwPHsyEwYhvduuO6KvzbUc3/eV53yANayHmxbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR1101MB2267.namprd11.prod.outlook.com (2603:10b6:4:52::23) by CY8PR11MB6891.namprd11.prod.outlook.com (2603:10b6:930:5c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Fri, 18 Nov 2022 08:30:45 +0000 Received: from DM5PR1101MB2267.namprd11.prod.outlook.com ([fe80::996:26d6:ad31:58ed]) by DM5PR1101MB2267.namprd11.prod.outlook.com ([fe80::996:26d6:ad31:58ed%9]) with mapi id 15.20.5834.009; Fri, 18 Nov 2022 08:30:45 +0000 From: "Aktemur, Tankut Baris" To: Simon Marchi , "gdb-patches@sourceware.org" Subject: RE: [PATCH 1/8] gdb/testsuite: remove global declarations in gdb.threads/detach-step-over.exp Thread-Topic: [PATCH 1/8] gdb/testsuite: remove global declarations in gdb.threads/detach-step-over.exp Thread-Index: AQHY+rzYBP30ZKSwDkeni4cgTEcswK5EWMiA Date: Fri, 18 Nov 2022 08:30:45 +0000 Message-ID: References: <20221117194241.1776125-1-simon.marchi@efficios.com> <20221117194241.1776125-2-simon.marchi@efficios.com> In-Reply-To: <20221117194241.1776125-2-simon.marchi@efficios.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR1101MB2267:EE_|CY8PR11MB6891:EE_ x-ms-office365-filtering-correlation-id: a94acfd0-6d4f-4ef2-2fc4-08dac93f305b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ufg3pt6S5y9d7yKtvx/ZcomYmwjegz05wEuE4fK7k0lQCvoJMXjiLyB1SDmxkfolKvP+zAQNnxl8+SNXCguzU++hvVbdUjvuunAD/eSERk7M7QCGoRM4kAm6xQVlhzsNwV8E6fb4NBxxhmwxSK5Z487fR9j878YtAXsR2PyeEQfgi0ayOajKKI7erXOY3fbLYFFypspM7tJUj5hXT2xjNwrQMkxhDH0akm1q+FSo+fb7D+PPNQy7HDn0ifVRO0ojajAPHhZz7Vv5eb3TVCrBAgpNNxc9nyl2fCcpJCabw6zkahFqH+qgDeG6Usn+rTSCFEJt9oz6BKkU/Tlv7CAreRT+Uj6GZpYP/86IwagnmebqO3cPtLmLkCv8n0yLAjPboGFwc7iAyEHnfDOjY3wK3W574w+3hWa/hrTZK4j9lFR4pvUBW6tfOJDR97wh01GlnMtT5xHoWnE27uqd4/7H5JSTgL3hh8J9jwSW+PeWF09fPnWRQ0Nn/r53yetPi3DFZ/B9CDEYAF7TkP0u1AUFYLjUF+BUdND5c3SIZvkNSGdpg6PpnDRoZHTNz1M47beIv7seoE1MkUNjuqkGy5kVKRceS5dGdZ5VZ+czghrRM02QVDsUXRDBsfxg6mQ+A/aPgiGeGES3N+kLNWROP4Gqi8ULHHibTd8m5YrnDZ3hcXMfumPN9XgkaDaqIBXLRFj8o0d1bSVKr4DfGrGXaKz/Pyski5PE2CfANSO/qW8hX9BbKqXohKuUojsXwggfqn79 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR1101MB2267.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199015)(33656002)(38100700002)(82960400001)(66946007)(2906002)(4744005)(38070700005)(8936002)(86362001)(122000001)(110136005)(8676002)(316002)(186003)(966005)(478600001)(52536014)(66556008)(66446008)(66476007)(26005)(64756008)(5660300002)(41300700001)(6506007)(71200400001)(53546011)(9686003)(55016003)(76116006)(7696005)(533714002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?am2WN+37KcW6A9kxn0i2qcRFg84mJHk+w5c+r7c1KKAns6C9UghbgLwBD983?= =?us-ascii?Q?wm73tyyLuaKnjK+prXzlWp6BnKtpAp+nwpFqZmGqANilItW+s1mVOK7jNCyI?= =?us-ascii?Q?QtCO65O6d5cysRXPEPanUL0Wrinv3Qyyif5cOg6PHmXsEsMcBj6tmhfhEzog?= =?us-ascii?Q?43MCRVwODM+HKeZh1NcpJ05vC/ojXTXhWQrIIKcbo93APRqa+YcQE30ecrLf?= =?us-ascii?Q?X5DZOMI88xMOcGwFr3TR3ADFmXSs5qtLHkPEjSsWwWBYMmkFE4YjqiCPgzZ8?= =?us-ascii?Q?VihgDioeP/fotMHS5OYhDwVwkyAeRM/J6+MNH5eI8BWxeAzvmfwmlnEp2oXp?= =?us-ascii?Q?8CLMYvKYcSi6sHi30pXXzopSZATCAhJMNhrVTNiHYNUHYwVUkhsh2TjFpgz3?= =?us-ascii?Q?cI8TCSPxL8AzSdVsT1niJzRPbdQE+/kufuke3PmpVRZEAzSOAENcz16rkiEa?= =?us-ascii?Q?vGM9Earb4LyqJoWh8jdK/hR6g3fWbRxZcjTimP72x86N7h29LmDHw2KupTaj?= =?us-ascii?Q?xLyLwowJwccIkUK2yMFYbXla/qMx7v/BZEVcLNh4AI+mrNYbXTrxkKYpoJrH?= =?us-ascii?Q?ny2CtDOLSI4i2UeEZG7LoFk+waqJ0U7eq9xvCDO5Go76Dw+3WBUTtSC92Y9N?= =?us-ascii?Q?8jsCT6I5zz0PeAeJIfNNPQJu+Z5mKqL/9nFQaZ4STLKFC1+blkU9UhY5DAUo?= =?us-ascii?Q?D/Py0PAiwjRnSN/NmAe7/Y6a7vA8N6ugwqUMXzL7d9BhxVbqRE7OVDipznoy?= =?us-ascii?Q?nvF4sTuvX/sGMVP4JFj4oGR6hmPSzVdBkd9jSNdHaf1ujzjzSfoDFaeLiEiL?= =?us-ascii?Q?swAPTR1grJmpst9e8cwPN4sf06WTDrr/XYL57omIbt1zILlYzlHWYsheLAl0?= =?us-ascii?Q?vTz9HcxwkevEVhXkKAU0uEnfGC1rH8pJmAs+1VDFog20HyRKC6Z6Y3opivqz?= =?us-ascii?Q?z4f//Nbv0ki1nT+9G7Gs8DTUJxzYIowEuo6J7Fme8FCo5uMhv/VSc89X8APj?= =?us-ascii?Q?9pcnh1ha/I8FyzmKGXTGh8tle6vyqMH1tHdNNfz8DiAUhUuUk/CkpDdweEED?= =?us-ascii?Q?Eunc9l1kw2sYCVeXDGIK2tvBQbxpiPQ7c7iGg8YOSrbnBSVgDi2W7pBb7Uq7?= =?us-ascii?Q?i1gR4SS4rcX1tiS643iig5nhRFUsdDyQCTb0r6NhPBo9/L4v0j9AIE/g76x+?= =?us-ascii?Q?MpIq/KPtEVUoVecf1TRItZn2uOC5a/Qj8us7SRzgNXWpW6yTlM6Cb8wc1MNd?= =?us-ascii?Q?BmUJ999LNtiTupeMsJnB9j/e/7BVg14WZ7LFHmYCL8cYX8WImadRYU49MrIV?= =?us-ascii?Q?mPHxpwvYB1mGO+HN9wyooY/vLHXCNmNzQx1PAtGM43VnubQLLuBGY0j4rFQa?= =?us-ascii?Q?DXDtOrhR7Ygdjad1gJue0Xd1E0jCFSfa4hQC+p+feOB7YapMxvCP2+BtHgdx?= =?us-ascii?Q?cOGLVHFZRlO8KAlhr9tz4hKWZDZhtc0z8wX/d+i8XbflYAczISfFR8xTE89K?= =?us-ascii?Q?zvRjtBZB9LksiHWnVaF0aA86Ui7HfU6fb4vMrJ9gAMr+aSft5p/5Fi3NmMhe?= =?us-ascii?Q?mlzsBhaTNdy93MWBa6jb3GNIgj5794NLNI6sblPYU7RkvaNdIHd2PUUBTm08?= =?us-ascii?Q?bA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2267.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a94acfd0-6d4f-4ef2-2fc4-08dac93f305b X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2022 08:30:45.7595 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FnvX6u1eZhbMFQ8RFalHjpHmExUiyBDdV6W5lyzV2Ec9A/5LFDWduc7lLJFPbt7koPDojhUtS3bhBzx4om/y6K0SvAPp+6k3qvOjmoO5hPs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6891 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Simon, On Thursday, November 17, 2022 8:43 PM, Simon Marchi wrote: > Before doing further changes to this file, change to use the :: notation > instead of declaring global variables with the `global` keyword. Could you please give more clarification about why this is needed? I fear that this could lead to divergence in the testsuite code-style, where some files use the global keyword and others use the `::` notation, similar to the inconsistency of the use of the 'then' keyword [1]. -Baris [1] https://sourceware.org/pipermail/gdb-patches/2022-November/193801.html Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928