From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00154904.pphosted.com (mx0a-00154904.pphosted.com [148.163.133.20]) by sourceware.org (Postfix) with ESMTPS id 66BAA3858439 for ; Fri, 6 Oct 2023 21:28:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 66BAA3858439 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=dell.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dell.com Received: from pps.filterd (m0170389.ppops.net [127.0.0.1]) by mx0a-00154904.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 396GFM4q004032; Fri, 6 Oct 2023 17:28:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dell.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=smtpout1; bh=SS1552aJBmR/b0JzjLV90tyfTUd3Bshww+zMS9696UU=; b=t+LU4q6blHXl2TCxXeG8MuQm4QhfWiopQdMAaZATPQdENQFMNsNCHcNOqrTuFDq+OT3L O9+VzkGG4QF58zQrG3+7CvQh48eItYmMrU4G+2hNA4lrYpfL4zZjMneME/v0FlO8iC1B b7nZ/J/KjjSnKLGochhPyIdK80UWOt6uFPMfNMTABf0QHtM7zCxIqfUX7MfaOjiUvu+O gIj/5tqliVMl7TftMVGjRw+UGDYYNOiWbg/69UJV6yk+hWh8URcD97hxiY+NjpaECmKW RKE3sXcUicqn+nbxhJ4aliq4M9U5wqRnkYiYKZrNv0yUFsLWUFxaos0XJfj+EoASNdRB wA== Received: from mx0a-00154901.pphosted.com (mx0a-00154901.pphosted.com [67.231.149.39]) by mx0a-00154904.pphosted.com (PPS) with ESMTPS id 3tjhvktm41-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Oct 2023 17:28:42 -0400 Received: from pps.filterd (m0142693.ppops.net [127.0.0.1]) by mx0a-00154901.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 396J4C8l022404; Fri, 6 Oct 2023 17:28:42 -0400 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by mx0a-00154901.pphosted.com (PPS) with ESMTPS id 3tjcm75052-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 06 Oct 2023 17:28:42 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ag4IQiKrlFPnFIm8mqmWApgrfdOrJPQ9adqIUNtQToe4bVlsnibin5qtmwPWwmLjmNQdmBmj8WOkmfTjrCLSdSgk9TjA9M7IG0mJ1oAywJpobC8N52HwF+2b9A1f9oL3zVsxK2VzJD7j3IfhSJ8L8xTA1f/l7jiPNY2I27V8tAJx4d9yYCHlqK+qWEFTcSSWnGGHkgLyCTkpM416rmX69UzmPhU0qHRIPydMrf5JNbpz8uc6RjhWtfIy65U2DyqskOXbpufR7doSDuKRrR3DDYIncUTtmYV4nTS3eddIaLnlJAgZovru1fT3CGeLFF5YgtfSGVwEKsWHpLP101l1Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SS1552aJBmR/b0JzjLV90tyfTUd3Bshww+zMS9696UU=; b=W+Dp8hI/YitpHo+oq0L6/Tb9OLVjse4216oRBt3Scs52nV2SQXBdUM7GvJ+Fd5pZwOFKm1gEH9Ko3JxHc/OC4XomU7JNe1fhbrb61RCBZFee0hOpbUSKwPzpnZHOua3Y3vnvYkxnLAFH/AUNYduzsy8DKEc+VKoANhkzRmcIRsyu4sTtvN9wQAVc6tamYjnSl9/zbg4aWLhiUCypbVyksOiK/UW1lLDXBB1U6IqW9+HLrvNhPWG8erNXSXEybgE6b8jjofDkJVxnTgJOy0iTchxL8AiMbxPw6GbwHB2kZkHtj4qadbi6lEzAUmmhLhDj4AGU+kaMdLQtR+UXbmmvbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=dell.com; dmarc=pass action=none header.from=dell.com; dkim=pass header.d=dell.com; arc=none Received: from DM5PR1901MB2150.namprd19.prod.outlook.com (2603:10b6:4:a8::15) by DS7PR19MB4472.namprd19.prod.outlook.com (2603:10b6:5:2cc::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.28; Fri, 6 Oct 2023 21:28:39 +0000 Received: from DM5PR1901MB2150.namprd19.prod.outlook.com ([fe80::c744:e3de:6193:6e5a]) by DM5PR1901MB2150.namprd19.prod.outlook.com ([fe80::c744:e3de:6193:6e5a%7]) with mapi id 15.20.6838.028; Fri, 6 Oct 2023 21:28:39 +0000 From: "Terekhov, Mikhail" To: Simon Marchi , "gdb-patches@sourceware.org" Subject: RE: [PATCH 0/3] Add assertion when marking the remote async flag Thread-Topic: [PATCH 0/3] Add assertion when marking the remote async flag Thread-Index: AQHZ9meCoZViGucN7EuZSt0Pe/zrIbA9SZNw Date: Fri, 6 Oct 2023 21:28:39 +0000 Message-ID: References: <20231004020701.260411-1-simon.marchi@polymtl.ca> In-Reply-To: <20231004020701.260411-1-simon.marchi@polymtl.ca> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_ActionId=598e677d-0c39-4101-bed4-3d9d82bdca8e;MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_ContentBits=0;MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_Enabled=true;MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_Method=Standard;MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_Name=No Protection (Label Only) - Internal Use;MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_SetDate=2023-10-06T21:22:21Z;MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_SiteId=945c199a-83a2-4e80-9f8c-5a91be5752dd; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR1901MB2150:EE_|DS7PR19MB4472:EE_ x-ms-office365-filtering-correlation-id: cdf1a2f1-7034-4cbe-a50d-08dbc6b33506 x-exotenant: 2khUwGVqB6N9v58KS13ncyUmMJd8q4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d54dxvTZCZgYz+kHIXUKRMkH74kr0pp0dWF+3nMKudQ1qrUrt0Wawjxoq7q7KN+jTxm7X9AxXOl5QB3w9jCB/+lmLVwoyZOaVcT8909VfDY5pUxnUkFK5LOie5DH+shdVgUACcp48Q7kx1BxfiswlN9t6eBKkxIOC7gdevebIxNDUvb591VgFTHUzcSQViPeRKyzoeLTIRqNaVAk2boqIhyVl7utIGLkkXTT1XfW0IRvom1aboz5Fsv9VWJ06ZN2kHPNpM2ddeTJmD9x3v0eGaWf9ql2GJ8wgokb+1Bif25rnurWW7oAF4GA3ACqi2WO65xFLh65/g3svMGvbJuLrkD3Ds0Sh1HrEB+zSzphnQZ/j0HZ+kiQHY4GK54CMXK7+LRttRH+iFyU8MkHLHnqvONITQQ2xB1kqlp9HaqALyn9r4Zua4auaVb/mhJfsvs8QoZYSOjQ2V+nBoBp5SdbhZczWa42Fu7V45a+9h+4v80hpsbYysHCDAQW8zJhqsQ91YvU2XT1qeVDsiFyf1kOSuD3wfcM+YKsWZmrMMpnmkEDptKANGhhSfBby5Wv0kDp47rxWsXMEOkNiFQEDeuud5nrw867d/rg/5BimAoz5Hk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR1901MB2150.namprd19.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(376002)(396003)(366004)(346002)(39860400002)(230922051799003)(1800799009)(451199024)(186009)(64100799003)(316002)(55016003)(38070700005)(122000001)(82960400001)(38100700002)(33656002)(86362001)(83380400001)(41300700001)(786003)(66946007)(8676002)(5660300002)(66446008)(52536014)(8936002)(66556008)(66476007)(110136005)(26005)(76116006)(2906002)(64756008)(6506007)(7696005)(53546011)(71200400001)(9686003)(966005)(478600001)(19627235002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SEHM9hMahcq8/XJ2I/jpI84mS0Y5/bVsxxKkAoJqUXAUrfJkBWquiHpY9hSi?= =?us-ascii?Q?TBgWhJvM4TBJKqR2Az5dgbxARyvpPWQeZBXbQwaGyzGIm2KhjZ7tusiEhAOn?= =?us-ascii?Q?RGKlrpw8hr+Biw7HQ2PDArj10zpX6QDvHLkv2U1eayWh1MvvCWX7IRbN7l0N?= =?us-ascii?Q?gaEpbVQsZ6xKAwyXIWMSDo8ZWN7QpcKd36Z2mj0STj2axNuSR6odamB/e9Lx?= =?us-ascii?Q?Gc4UggbEgc9TEuFjoN0DHdTf/mt+lPpPJd3MVBUJzzzVT/2hhWdTdHVt0EsJ?= =?us-ascii?Q?wr+D7FNq15KS8NOxNJxB6uyjq2NoXArET7tUh456b6UWkbOgNC+WcaeIHrj3?= =?us-ascii?Q?Z60U7qrScCP0pBLa+upIRAoe1w5GkfZloq70m4PHDzgrvofSofDQVefkQNVx?= =?us-ascii?Q?1j56GQOlwAh8s1qu2+t1CMQbvQVKuAiFM9O6N6C1v64oDtWXkJXu+CdriK50?= =?us-ascii?Q?WZ/YvWaop+55DjHfabB7AWukbdL3MNXr9p+z3OomY1PRNZFnTaMlax+Mrf8d?= =?us-ascii?Q?J0d4uZA1ZiqPp4ADiUzeMcc5nYZG9ZQvJLNn31NZMf4BoWeF1Igyxh7Ompui?= =?us-ascii?Q?ZOYauitSJ+gQDoYl5HpGemgeyGDY4948ng8nSWiVDbvFThRRD6Cw8gRCN0FF?= =?us-ascii?Q?0xQAozp3EAGfCo6D1IFZ8XQCH/PlDLBJwupqDCff25F3difdjPnMnCrkXSjR?= =?us-ascii?Q?vnfQEqb55rO4Dymr+rFlhjE2D5HaecFfkSQGtAFElqOGwOD/HxO4RtWOBLSp?= =?us-ascii?Q?BZlSz1ob6H2vYmso6pRhFHW9n4dc4D27GNWFUvnaWm2AuAAxLN/0m0rIMp7p?= =?us-ascii?Q?9SaWy9Q3SXevVLc6TZHALAzEsO5suN5/JMedUEXy0CYsCtqiO8DYAL+OQ1Tx?= =?us-ascii?Q?WivJLwVeqgknjbD6SZ24MlUvjkVua1jI4ajOTKeIzkNd5k5wPAnWZu+FNfw6?= =?us-ascii?Q?WNv1Z8f3VME3jq55V1+NAxGdZX7sJMCqFUcRsXZr9Xlvt0XJt6YC+cXjuS90?= =?us-ascii?Q?g0B14A2rksfWve3NC1UsoiARPG+qABpAeKVPl6kmYx3z6OrlsnhoJj0LKS+c?= =?us-ascii?Q?xLaLqaoz1mC5abFb6c6B83FKMJ/9tzSG3j+aOi8fUmXFcaIiCm3lPmIVviLj?= =?us-ascii?Q?Po9FwlowM7gP2XsrA38ioQB86xXc/XHj3zWrhk8n4uVL0duFV6UohM5zZQCm?= =?us-ascii?Q?+5fI9pkJ9fkHiHgsgUCxvH082mJeZptGp3iqIP4n5oUTcyIos24imTFD5Qwy?= =?us-ascii?Q?0U3IuWloxnmgJfj85SuCpxqYDYS62pLu8Moev8o6UsREpttpPKmJtocLYlv3?= =?us-ascii?Q?G493R4tq/M5erb+jrRLHn9wk2Qg9WXrb+tOdb4Q86vFykPCdjGAo010/SbGH?= =?us-ascii?Q?PijKPwMSUlTRDDRPMhjRa5UzOe2415A5g+TxRkFnAz7Z4otN+IXDtJpy5pgG?= =?us-ascii?Q?tQKHrizecqGCU51I0OMKolTlFvXBIo28GCnDnlbQ+NLYTX8wGXB6FE8KofcF?= =?us-ascii?Q?zGUxxyiY0uemtR233VKcQKc42Pqip+71cJ0A/DoG+3ym2TY220618Mm6Gueu?= =?us-ascii?Q?T4SJOdljDY4d3Bi2onwHePZFXzf9rpVSEHkeOtj7?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Dell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1901MB2150.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdf1a2f1-7034-4cbe-a50d-08dbc6b33506 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2023 21:28:39.4011 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 945c199a-83a2-4e80-9f8c-5a91be5752dd X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Gvl4GU7rg8mLvsfOQrNo36rtmAILMENvZ9wYtZMVHBGaIHUXTOvGXjamXcEJPQhcVHH6O+2m+hWUSTO4qlK5u/vRMw8vckdIy5v0IkIKmvQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR19MB4472 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-06_15,2023-10-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 mlxscore=0 mlxlogscore=773 impostorscore=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310060164 X-Proofpoint-GUID: NFBYiyue4tqY1LhDmQD8JR08mfQ4Ug8A X-Proofpoint-ORIG-GUID: NFBYiyue4tqY1LhDmQD8JR08mfQ4Ug8A X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 spamscore=0 impostorscore=0 mlxscore=0 mlxlogscore=842 suspectscore=0 priorityscore=1501 clxscore=1015 phishscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310060164 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Gdb-patches bounces+mikhail.terekhov=3Ddell.com@sourceware.org> On Behalf Of Simon > Marchi via Gdb-patches > Sent: Tuesday, October 3, 2023 10:04 PM > To: gdb-patches@sourceware.org > Cc: Simon Marchi > Subject: [PATCH 0/3] Add assertion when marking the remote async flag > > I had this idea while reviewing this patch [1]. When marking the remote > async flag, assert that the target is actually in async mode, instead of = relying > on an assert that comes at a later time, in the wait method. After applying this series GDB fails in my setup in assert in mark_async_ev= ent_handler right after call to it from queued_stop_reply. See my comment to PATCH 3/3. > The first two patches are small preparatory refactorings, and the third o= ne > adds the assertion. > > [1] https://urldefense.com/v3/__https://inbox.sourceware.org/gdb- > patches/3d728a6e-1cb0-49c2-a4c8- > 0a974be39fee@simark.ca/T/*ma1903117423ae09c3574fd45ade2dd4af528063 > 3__;Iw!!LpKI!kBSMETr5QzzmvTDT4A0kxAcpgnOpWd2ZyualTzxDwp42So5Om > byWvIb9bglZjsO4OCDKV_fIXMUj- > Yh5Q6PUPj26WV9J$ [inbox[.]sourceware[.]org] > > Simon Marchi (3): > gdb: make remote_state's async token private > gdb: add remote_state::{is_async_p,can_async_p} > gdb: add assertion when marking the remote async flag > > gdb/remote.c | 93 ++++++++++++++++++++++++++++++++++---------------- > -- > 1 file changed, 62 insertions(+), 31 deletions(-) > > > base-commit: 1181bcd0d2572aee2c0947040e56bc1f9af634e3 > -- > 2.42.0 Internal Use - Confidential