From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00154904.pphosted.com (mx0b-00154904.pphosted.com [148.163.137.20]) by sourceware.org (Postfix) with ESMTPS id 8B8DC3857352 for ; Fri, 6 Oct 2023 21:10:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B8DC3857352 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=dell.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dell.com Received: from pps.filterd (m0170395.ppops.net [127.0.0.1]) by mx0b-00154904.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 396GmTZb009363; Fri, 6 Oct 2023 17:09:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=smtpout1; bh=6XTJ+KjUAevNlElhw599vCS7wFMBz6zECo7n0enABGQ=; b=oIZk8N0B3mKk8YxRGeQs4xmqnJr1JR+eRGqsUSi6hVHpdy3py6Z+dYZW2bMntuy4qq7t P1YhSxYYogPiBJv8WOmMRaGBJk/qnY5MGx8ZOlErXCV/S0SZFsMob1x0/jMxisDEzYxP xVKfjfu6yCboHBDT0/CAGQ989swhM79xo4sC94eLZpmOrG30Z5Az+RS6B40BBeINNpd+ r/JMtA8oGkaZrqtoMa6kltcJncHoWWinx4JLrf6Y4UIVlOdiGOW+ZhSx69NcZcbxB1Ij SzmGUjjIAJSlPdNJUPsByWE6wqtnDy8I1r9JAQO9PdC2xLOSV6IBIBgjUbyuR2qW8Ltr cQ== Received: from mx0b-00154901.pphosted.com (mx0b-00154901.pphosted.com [67.231.157.37]) by mx0b-00154904.pphosted.com (PPS) with ESMTPS id 3tjguwjsn4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Oct 2023 17:09:53 -0400 Received: from pps.filterd (m0144104.ppops.net [127.0.0.1]) by mx0b-00154901.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 396J49Qg009640; Fri, 6 Oct 2023 17:09:52 -0400 Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2047.outbound.protection.outlook.com [104.47.73.47]) by mx0b-00154901.pphosted.com (PPS) with ESMTPS id 3tjk8ymsc7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 06 Oct 2023 17:09:52 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U9ZnsnLSQuZ5eFnAjRcQVoMi98yB5wcA1bPHX3ieVj8Z9qJurCS9JpH5WapRuA3rkVqE1g96LrJ/lzKRQgP7vVSDvZ4COTEf8cA8sNBqbJqvUXuvBw+5sUbevnYnx+7b35tYC7PN0zLLy3wBaBZyG7m+tDihAHa7W4pCdexujfEQXqMP0u6E66yGQY/HVlThQDbF4MwPhCqJbT4cvuaCnR7nZ44h1+aX+KXzuidZVt7vKxCHpgXpIKllCedNbMcLrQf1wyZCjOGyv/tv9WsbmTu7JcN1cnGVRaug/cD9lgAzNLixFlJKty892IEoxhw8XdX7mqM7TE7LE+GhRvkZvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6XTJ+KjUAevNlElhw599vCS7wFMBz6zECo7n0enABGQ=; b=bfS3yCZWy9QYw7WdrjYobDnWTGjYo2Olv6fRVbNpovF32FuPHzLkQLzgmf5Vk/6tRqeAChbgzjl0clTFo0Lram/m37InnLzM7H6/b9cObUXvWk65DcArhNmbF1WgVguUNFgYcnpNFenAhAg6npPV6DW3t0hf9/jLyA1gf19E3sEn2ExmdOBt/55CdtX9wlKfl/72l2zGX6dNrOFCOIwPask7OyyoiLebV8UTuSFI4yKwvmzHhcFb8PRKln2BBLCVMtLyB6admxUeDU+q9XfP7bHIz/tgb40rrwtVEvIHuKX6wNqgxnDAYV5KwTmnbrK+cjaAa24TjARQCruhmYBs+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=dell.com; dmarc=pass action=none header.from=dell.com; dkim=pass header.d=dell.com; arc=none Received: from DM5PR1901MB2150.namprd19.prod.outlook.com (2603:10b6:4:a8::15) by BY5PR19MB3729.namprd19.prod.outlook.com (2603:10b6:a03:22d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.29; Fri, 6 Oct 2023 21:09:33 +0000 Received: from DM5PR1901MB2150.namprd19.prod.outlook.com ([fe80::c744:e3de:6193:6e5a]) by DM5PR1901MB2150.namprd19.prod.outlook.com ([fe80::c744:e3de:6193:6e5a%7]) with mapi id 15.20.6838.028; Fri, 6 Oct 2023 21:09:32 +0000 From: "Terekhov, Mikhail" To: Simon Marchi , "gdb-patches@sourceware.org" CC: Simon Marchi Subject: RE: [PATCH 3/3] gdb: add assertion when marking the remote async flag Thread-Topic: [PATCH 3/3] gdb: add assertion when marking the remote async flag Thread-Index: AQHZ9meH2TctPSx3rEypivdVKYqdYbA9P6wg Date: Fri, 6 Oct 2023 21:09:32 +0000 Message-ID: References: <20231004020701.260411-1-simon.marchi@polymtl.ca> <20231004020701.260411-4-simon.marchi@polymtl.ca> In-Reply-To: <20231004020701.260411-4-simon.marchi@polymtl.ca> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_ActionId=01ab67c8-b0cb-4aae-a54f-56d1a9b2c4a1;MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_ContentBits=0;MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_Enabled=true;MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_Method=Standard;MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_Name=No Protection (Label Only) - Internal Use;MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_SetDate=2023-10-06T20:46:55Z;MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_SiteId=945c199a-83a2-4e80-9f8c-5a91be5752dd; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR1901MB2150:EE_|BY5PR19MB3729:EE_ x-ms-office365-filtering-correlation-id: 66d6ba40-0cd7-4278-7d4e-08dbc6b089a7 x-exotenant: 2khUwGVqB6N9v58KS13ncyUmMJd8q4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JmvGqQx9XWCvxbFzjAznthVc9alAVX/Wsm5IgdnAc1Mh7QIB773scDB07dwaCc5rh8z7/tlkVTKGEhYAyzKxar3iWbHgWmlDzgYWDNmm9qPG0Tlzz4hWdup04iKRLlSXv1vP+X1CA7FxGqKm7aLA3B1RMrWbZ4ZxqQ6nNhykPX0T/xK82c13bRXQ2QG7FiWlcYl3UQmfP56BKw9Hw5SsnCsd06/v9w7Qp43j8OkXzaQOh04uv43vDImYeJUnedatjOkqy239alKGtNBSXwWvQpteXt75kME4z9hWa+j5zQLzDqeQM6VO0P9ugRdr+BOBxUQOI5VD9BcJjINwx5L9fj47hcNsrwVD2bdq/WQ8Gv5bmQ/qIDumGnU4HJiz3alyD02wJafw7OUGf7b0scM9+qh5KyAymRF73xlhdXFp+apUkxJO1D28K1KZgqPX1sbOck7KZCb3ATyMN7N3mg7D0khPbwd48T3yw3XQ89hRmNTHLfNJ7/nIpWO8QHOUCTwfPtL+xhiIgnJRgFVfe2our9WkIoLTQlxRUSNCoMq5b6Xsi2HShNyOvngpMTjPn3eXOB8NSjvP9W8FT8nwMWucNFVZ3U81VoE9CWthyUP4ze4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR1901MB2150.namprd19.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(366004)(346002)(136003)(376002)(39860400002)(230922051799003)(64100799003)(451199024)(186009)(1800799009)(9686003)(55016003)(33656002)(478600001)(7696005)(6506007)(53546011)(71200400001)(966005)(122000001)(2906002)(38070700005)(38100700002)(82960400001)(86362001)(41300700001)(83380400001)(5660300002)(26005)(64756008)(66556008)(66446008)(110136005)(66476007)(8936002)(66946007)(52536014)(786003)(4326008)(316002)(76116006)(8676002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Q1n7jki0YCROTwHZYNop8HDyLpIUv6EWxxn0uvr40+XzjOOXjagqfb+/JFsx?= =?us-ascii?Q?SE2ud6kDkfmzMzBP1XlsmP/NZKRX1NIAhEnq8tmNNdKVowJAYiCez4t65pfl?= =?us-ascii?Q?B+NkJv6C740zoYRqS9Zj/A70g0Vt/paWtaz//rA3daGepHMHoL4viQ5wBj+2?= =?us-ascii?Q?jITtqdtXGWjPzOTGxf/ZhO4L8jJhs6JSHZfGLMaBz1yaEW96uO2R0Ivoul/u?= =?us-ascii?Q?2m7qtbmPpVdy1O++AGMcTTppMi02z6f5nQLUbDqKZ51g8kSbgeVQGX/UA2vQ?= =?us-ascii?Q?61R7WzjYalEAmo8fIhigFxqTPNoIehhY4zdQwIcI0f4Ny+J8vRZypT9YJPC4?= =?us-ascii?Q?U/K0K2mjuMUwtLDHCJ1o+I+XDgG58noWX2kBZX75DXv7TC+rlgvTJkNQMzXW?= =?us-ascii?Q?sz9f9gehPICotGXUN85c75T8OdPx7bRPqlZ6s5taWv9FHXvkQ1c6v7JOXONi?= =?us-ascii?Q?GdRBAlJqYFfLe5r911ZD8k3dsT2WfW1yXylc30fEH+XzDJtL8E69T0YzfQnN?= =?us-ascii?Q?5Cov6V1A9DjUqXabAbaRDHuMGI4NdD79b5qojczcziPyDPBXjiVYAGP2hmM3?= =?us-ascii?Q?n6N5eevjZlYJ7N6IdsWVbwUjCQZAdTcyQPctLNlqTATiX5m+bsuo6SZzdhOd?= =?us-ascii?Q?TrDlh/fcraVCWMUgwiRibkZcpa7NkdAFkjlzX43U0YGG30YNByorcDIvNPkx?= =?us-ascii?Q?TI2UuyYB3rlH2id6vASgev39eG17/FVXdsODoQF5pa2Gvs9FR4XWQg6nqnKW?= =?us-ascii?Q?700mWgECy6JTyPzi0CcyoNW6OvrcK+fmHyCGabQjEzm4nZs3Od/+jQX947wj?= =?us-ascii?Q?IcwHHP5SVDdgMdhiQHZarw9jK54MhU3qecplbDd78kV/LADQ75lPBLIMGdfD?= =?us-ascii?Q?bywsNwjDU+Dzl1ExvaNCcJpu3BL6sOxRBtuEJ1MrH8VvUcvWmb36+jdiNKcU?= =?us-ascii?Q?goB0kErODCHYAFptGuka4jQvUa3ka+q/Mdfg+BAi7owp5Ey9RFPvb4ZaVJrD?= =?us-ascii?Q?9qgwSzUWNqR55Fdef8EC7SWDxlVhfwU2Ce87Y76NUCynm6iLsMVmb+5OcvZl?= =?us-ascii?Q?sPajDQQGW/cR/L8h4tnezVhYVHGm5gSUqC0A5aiVhYx/L8ZwFCzPKHQz1UC2?= =?us-ascii?Q?26uiBRGuELRuXlmFGe2PKEUbQsDB8fGWH85cnZvJV4JbFRnsHHeJf75JVi0l?= =?us-ascii?Q?KmibbYbISQ/dHph7g/fdoz2RZvlm8W2Th2ueUV+QsrisBMTWTHkGtp31Dmxi?= =?us-ascii?Q?AsaF4+y30nnMwlVE+8UvNo5fjsx/Ja8upr+Av4i8S+GAcoe6wjnLNvYYYsBe?= =?us-ascii?Q?mdBhHVksU3DoUCi9xghD99lKnbHRn1Tqdnhxr+MmA1xPFrrqBMlxKKE48F36?= =?us-ascii?Q?xUI1yba0yYoNWCjcCcL3BYsMS0zYP85rztUOlvCYEyJF+xwwcL3aFb8wu+dT?= =?us-ascii?Q?Jk4UaY7xkfM4rNB1kbcL9sXGm98FLA41UASTEjBE++jNkbrbDJQtwUryxemz?= =?us-ascii?Q?Mvf2WT74ktgPyLFus5f0bYYE19hCqEa1/+JjRFHgEJidRr/JTiDYpFa5ZZlU?= =?us-ascii?Q?mAjS445QlGiuitG5a//gFjA+xjelLl2KUK590IJd?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Dell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1901MB2150.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66d6ba40-0cd7-4278-7d4e-08dbc6b089a7 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2023 21:09:32.8654 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 945c199a-83a2-4e80-9f8c-5a91be5752dd X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jyx2iFffijessrDxedZRAm0Is/omtYlPYWHfXYypRubb3PHyL0+6Ww31sF6Kd/ez6FxhcQrPXZjaM1b/QUs/egsW1/zrhZlB7IijTFzX3mI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR19MB3729 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-06_15,2023-10-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 mlxlogscore=999 priorityscore=1501 adultscore=0 bulkscore=0 suspectscore=0 spamscore=0 phishscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310060162 X-Proofpoint-ORIG-GUID: waidS67tt4Zh25j2PeNJPjWQmC6Gkau- X-Proofpoint-GUID: waidS67tt4Zh25j2PeNJPjWQmC6Gkau- X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 mlxlogscore=999 clxscore=1015 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxscore=0 impostorscore=0 priorityscore=1501 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310060161 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Gdb-patches bounces+mikhail.terekhov=3Ddell.com@sourceware.org> On Behalf Of Simon > Marchi via Gdb-patches > Sent: Tuesday, October 3, 2023 10:04 PM > To: gdb-patches@sourceware.org > Cc: Simon Marchi > Subject: [PATCH 3/3] gdb: add assertion when marking the remote async fla= g > > > [EXTERNAL EMAIL] > > From: Simon Marchi > > As reported in bug 30630 [1], we hit a case where the remote target's asy= nc flag > is marked while the target is not configured (yet) to work async. This s= hould not > happen. It is caught thanks to this assert in > remote_target::wait: > > /* Start by clearing the flag that asks for our wait method to be cal= led, > we'll mark it again at the end if needed. If the target is not in > async mode then the async token should not be marked. */ > if (target_is_async_p ()) > rs->clear_async_event_handler (); > else > gdb_assert (!rs->async_event_handler_marked ()); > > This is helpful, but I think that we could have caught the problem earlie= r than > that, at the moment we marked the handler. Catching problems earlier mak= es > them easier to debug. > > [1] > https://urldefense.com/v3/__https://sourceware.org/bugzilla/show_bug.cgi?= id > =3D30630__;!!LpKI!j0fTzubsC8RVdwinGn-r82- > mX7hLUvNffNCQWwFTCYyR9EWj0CtlY9ERyT_AXgqsNQ0ZjS4Ls53fdBnUrLhWIw > hIBW9P$ [sourceware[.]org] > > Change-Id: I7e229c74b04da82bef6a817d5a676be5cf52e833 > --- > gdb/remote.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gdb/remote.c b/gdb/remote.c index 38d0027dbf9e..7830b5cec33f > 100644 > --- a/gdb/remote.c > +++ b/gdb/remote.c > @@ -424,7 +424,10 @@ class remote_state > } > > void mark_async_event_handler () > - { ::mark_async_event_handler (m_async_event_handler_token); } > + { > + gdb_assert (this->is_async_p ()); > + ::mark_async_event_handler (m_async_event_handler_token); } This change made the need for fix suggested in [1] more obvious. The assert in mark_async_event_handler () is stronger than check in remote_target::queued_stop_reply(). I.e. mark_async_event_handler () should not be called in remote_target::queued_stop_reply() unless async_handler !=3D NULL i.e. target_is_async_p() !=3D0. I'd suggest to merge in fix from [1] into this series. > > void clear_async_event_handler () > { ::clear_async_event_handler (m_async_event_handler_token); } > -- > 2.42.0 Internal Use - Confidential