public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
To: Andrew Burgess <aburgess@redhat.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH] gdb/testsuite: fix gdb.python/py-events.exp for finding process id
Date: Wed, 12 Jan 2022 15:22:11 +0000	[thread overview]
Message-ID: <DM6PR11MB388473CD34103D6FC0F10EF9C4529@DM6PR11MB3884.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220112145027.GQ622389@redhat.com>

On Wednesday, January 12, 2022 3:50 PM, Andrew Burgess wrote:
> > diff --git a/gdb/testsuite/gdb.python/py-events.exp b/gdb/testsuite/gdb.python/py-
> events.exp
> > index 4df012b943b..4b411999588 100644
> > --- a/gdb/testsuite/gdb.python/py-events.exp
> > +++ b/gdb/testsuite/gdb.python/py-events.exp
> > @@ -81,12 +81,17 @@ delete_breakpoints
> >
> >  # Test inferior call events
> >
> > -gdb_test_multiple "info threads" "get current thread" {
> > -    -re -wrap "process ($decimal)\[^\n\r\]*do_nothing.*" {
> > +set process_id 0
> 
> This looks good.  My only suggestion would be don't initialise
> process_id to a number.  I know it's pretty unlikely that `0` is ever
> going to be a valid result, but it's not impossible.
> 
> If you instead initialise to something like "invalid" then there's
> even less chance that this will match the actual output.
> 
> With that change this is good to apply.
> 
> Thanks,
> Andrew

Pushed with this fix.

Thanks.
-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


      reply	other threads:[~2022-01-12 15:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12  9:51 Tankut Baris Aktemur
2022-01-12 14:50 ` Andrew Burgess
2022-01-12 15:22   ` Aktemur, Tankut Baris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB388473CD34103D6FC0F10EF9C4529@DM6PR11MB3884.namprd11.prod.outlook.com \
    --to=tankut.baris.aktemur@intel.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).