From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by sourceware.org (Postfix) with ESMTPS id 393573857C5C for ; Wed, 12 Jan 2022 15:22:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 393573857C5C X-IronPort-AV: E=McAfee;i="6200,9189,10224"; a="241310451" X-IronPort-AV: E=Sophos;i="5.88,282,1635231600"; d="scan'208";a="241310451" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 07:22:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,282,1635231600"; d="scan'208";a="623476700" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga004.jf.intel.com with ESMTP; 12 Jan 2022 07:22:14 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 07:22:13 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 07:22:13 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 07:22:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R1jFMALUi4nAb2TXbQ2tt244Mc6a/fv+XM22p8vaHdBpiFQj5JiFMriSUeK1USpo++FHrZ6d+i44h4o5a/l+6LdF5i6eUUq/a8Efum76e/3ZkJjb8WHDo3SJEGt+keBRzqNMV5/ZJtrN7An59aD5D+T0ep+qFB9HzFxKy4MEaJ83VJ9QIuhPUXFmnxqZbGT+5dTK3RhCeR8COnw3A7S8PnWNsO6EnZFXa2TSdANZQHVpfLj0jekS4tMe4nmXt7Of8rruzVzhSfWSwoxW17U+VO33JwOoEA+079KSxyV0XrAqvgflyxFXv64dO2axPJO02JX/m1CGGzfCDK9nFomlDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c+lL1f/HfM/KKJYgsqizMZ6NyrWVVD4gZMD4BjOy+7g=; b=FO3zRnpKN+fEyqHJQuR6MT/j56O/4fFjUWK5uJd4zqoyATvjORSLuwV4qLaTf6agdetiMizsAvwQx0mzvaJczdhZZC9VozT1HSWM4tr4WBA+6OGi878vuabZg8anUk+8Oa0yQEkV75pYAu247DiYWfvXSRjBKyUdqVpOnLEamc2taj1BFpkSDiXJpAhuARNJrGaOBBD/Cqv8baZFcvbzbCSl48lYbhnV9/y+8tSL1F/fHCpxVzP+ZA711KqzBgjDy20NeGEauZ3m8ZHeKYnwrkV6a72JqkrwKw06UI8UofwPhYobzBv03ww/qekDjpC9APSPIEmYm3mqJNV980lfyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3884.namprd11.prod.outlook.com (2603:10b6:5:19b::15) by DM5PR11MB1834.namprd11.prod.outlook.com (2603:10b6:3:113::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.11; Wed, 12 Jan 2022 15:22:11 +0000 Received: from DM6PR11MB3884.namprd11.prod.outlook.com ([fe80::690f:41f8:9100:db5]) by DM6PR11MB3884.namprd11.prod.outlook.com ([fe80::690f:41f8:9100:db5%4]) with mapi id 15.20.4867.012; Wed, 12 Jan 2022 15:22:11 +0000 From: "Aktemur, Tankut Baris" To: Andrew Burgess , "gdb-patches@sourceware.org" Subject: RE: [PATCH] gdb/testsuite: fix gdb.python/py-events.exp for finding process id Thread-Topic: [PATCH] gdb/testsuite: fix gdb.python/py-events.exp for finding process id Thread-Index: AQHYB5oMBrRevjB6fkSPwdtrU/6JuqxfeESAgAAIK6A= Date: Wed, 12 Jan 2022 15:22:11 +0000 Message-ID: References: <20220112095151.5793-1-tankut.baris.aktemur@intel.com> <20220112145027.GQ622389@redhat.com> In-Reply-To: <20220112145027.GQ622389@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f8b7836e-e974-4dd7-8773-08d9d5df4e61 x-ms-traffictypediagnostic: DM5PR11MB1834:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xYooz21hkgUzLDlXH3vgUIAeBOvgum+L9FKG/48tzXuavpsjBLr/KtFqtU9GVs72muXW/kKrxVdBqjcIQymQXQEh7xoEPf+3qBsiuASJVwfi2nlqVthTu8/YeZo8zqHGYGKD7ej+r01I8frwXhKqqKXzP6P5kXNQa9rkv0JDepTvwNMKyHwqvyK5Ec/35ca4B+imlsb1/SWFJzW84Fy1NsDun1KIV5nWWaAvtOKSP4QSVVU4wYXgRLaBskERuSCQzpaBqc0kTMBtcDnbzN2x4ENqKvWUNPgSjFVBFySitm2DUjul+LrUJBIsUIKv2V5pp89+n8tCQDN0vRA4QFZA0nByDYl++8TDcIMJofvxXzM350NuOEFZRloYAC41ow0eVFj3D6sNAL/g07s4ig9GW8KNRE6r/YP49ImwDGqfXq6zGvmruDPtX+ZFDR+K4nmgFRousFm1+PgiRwIZM+2z+YgbtNFKmRYCVfio7L5TkMS21HABu9Ggoswua5I7t2/F7iPkqocL+Qdt0aq/nkyYv4wLAUHSsVaKDdUBQuJwGAQkjySkFbF6ubewid7Fyyi2jBDaqKPaCIBw1f34S6LO4A1N33JfNzD5My6j3oCTpeli7z6IwDkVRtZeLfoaQl1nxzuH5a2d7oFfP33uc/XKUdEbC+d9UlE9vw71jHnZf3aMxNe4oE+usCwM4WXsZ86CGCq/Xzi72fSwgAvTZSgQSvG7vebF6Xd8m5wDV7YWyOJprMonU1ITVn6k/n7eUcapRb7BBHoyPdmhJNxZ6OeULsPeSCbZ3h26hLfWKlmLuOI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3884.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66946007)(71200400001)(8936002)(76116006)(316002)(82960400001)(38100700002)(8676002)(122000001)(186003)(110136005)(83380400001)(66476007)(55016003)(2906002)(4744005)(66556008)(6506007)(7696005)(33656002)(52536014)(26005)(66446008)(5660300002)(38070700005)(53546011)(64756008)(508600001)(86362001)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WYCLqHCBx7s72svOF8+HA8zHpcVzUzCVEodwREqoj9SNRaHdyZFDGeSiiPge?= =?us-ascii?Q?Mq/6d67RWYeE/Wu/l/D7zTSAqx+I2eG5mso+ODyp/9PRvK70NWIYMnb8Q1Dt?= =?us-ascii?Q?T2nHFwEGcNloEanmxmJ9gDiGfFWRSOA636HfsgDP1XYpLW36xxTeuR2BrWnY?= =?us-ascii?Q?dQzl7Agk1M7ULH8V0/dOBydV2WzQfg91uV5dogIv+r4sG2S2ytRqSwrwuC9I?= =?us-ascii?Q?qEShnNuu++cDO6KucPTSUOHBUhhGn4KKi84Zeleq3bFuLTEzCMekcGoizfDL?= =?us-ascii?Q?h8teDlq5Ud29OxCK/6Cr7vQ9ltAdGH5UyUbmcLzH3dvDOTXm2W3BPg5Ik8a+?= =?us-ascii?Q?v4yJxW/Hu8vskujnKcEpobduOvCuFrWpYigeIao6DfqHKFgaF0jUWsrJmeBJ?= =?us-ascii?Q?LrG8q4Bl3VVcadTddRrzwxwLHg4qAo82moGvCsqHnom2ZRY4KjOKKR3+IUDs?= =?us-ascii?Q?T2tW414Z1FghlneAwWW1DqtkLPjl/qtQUnEbjaFp/TwyDcENv9eo5GGaEpT5?= =?us-ascii?Q?Lqb250iBS1aKX3eF935rLjOc989nXO+ymb4MffrhHohZfTwcV4k9zPOp/mQl?= =?us-ascii?Q?KM4G3TqCiYjBRHS7hPlVjsZ+uQEYVl6VcQ/9ZJnOz0bqRg+fMRsaKtMyFZMa?= =?us-ascii?Q?b4gsyKBDQt4aQMeFezkYB45yEHgDs8TH+Hdu+bR9ZHmCx4DZY4+ChuuTfzNH?= =?us-ascii?Q?tKapY8IOxzjYCsQ03fYtJVOvL+R0XSjH7UHsoBap38KUjDXZydOI6gQo+ZjQ?= =?us-ascii?Q?zXwShb37zH84KXmPrQbX587jRXfKta4us6NCGDyt2LCk7HFP1Ta9u3G+N1hm?= =?us-ascii?Q?zSucFg5/Z4IZNiJpbf8cgDNRKxRfHCOh08APdvQFkId2tbD5f4HGftqRvwfc?= =?us-ascii?Q?YKzPEE5oQ9EX7jCyRcb+u3AN3AYx6HecI3iwrQ00t3dpZ95k/ZnYILQhEWPJ?= =?us-ascii?Q?yWEgjJd2ciFCxIfVZQt3t+NxJXFjdsNNKRxw0m1QfrHkoJQX6xIigj0xgTGP?= =?us-ascii?Q?Q2eyjPaEcMr8O2eYEOjyiIMQoS2fm+viFgLKFujKU2z43LbM4VmE+arZKYHY?= =?us-ascii?Q?jqNAeK2GJPnGvmsDB2w8aYBp/XPqv01zEIX/FZHdbnTelmDuDzbhyVEunbON?= =?us-ascii?Q?SqOMyLWuE21G9hxSVvWpsQwBzkerNaXT42rFRm7k2g1H3aFq56Rf2cJuByVA?= =?us-ascii?Q?v+sAYTWmM8Ljte/slhdsgFh6siixIdWDCBr8vqPXFc2kHCcEh63F/P1qr5Gy?= =?us-ascii?Q?WVTEKn3LR/Q/y5/bOa3ulJvdwaIkqs8Ar6WaoZnwkG77xpBi7Iv0oo43Oaub?= =?us-ascii?Q?d45rViLgrHtzbUruivpd8arNi8jWCPC0cn5Fo4kD7/fFSaKAONn4SoXgwAsT?= =?us-ascii?Q?SLEaHejOjNnucpUT/QyM3IbBhf6/C+lE88t3thL1F+bDI4eEjyt7chf7rtXb?= =?us-ascii?Q?oNHw2eVX+OSNuyd+J4COk57oHN544hbDB1rr21TEV8me1P5z0XOLau1wq9SJ?= =?us-ascii?Q?ngFaFh703SCV2OG//+8uWJj7gJZ/i1ftaKPA3Jt98mxubxU2k1pIv1KC6Cyp?= =?us-ascii?Q?kz5SQoOK/9m2sG1v/dJrE1agmwVqmxuWqH5IuytCIHf7b+7EtUKoWnlR/NUz?= =?us-ascii?Q?wOaCT0VsV7bPfeQhJ/DVQDl+0iqiD+Yij15ySnasBYBp8upbypUk1zikLhaU?= =?us-ascii?Q?waGj/w=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3884.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8b7836e-e974-4dd7-8773-08d9d5df4e61 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2022 15:22:11.7667 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IiZ0IIMubwmgzEnyVDDKNM7BmSnbpxnCWwqEmSU4fMaGkYYCVMPP7zPWTUW8z1PMPYLD44QEobEcAGaxRD6t/cSwtRUxW0Zv+J1nkhUAQZg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1834 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jan 2022 15:22:19 -0000 On Wednesday, January 12, 2022 3:50 PM, Andrew Burgess wrote: > > diff --git a/gdb/testsuite/gdb.python/py-events.exp b/gdb/testsuite/gdb= .python/py- > events.exp > > index 4df012b943b..4b411999588 100644 > > --- a/gdb/testsuite/gdb.python/py-events.exp > > +++ b/gdb/testsuite/gdb.python/py-events.exp > > @@ -81,12 +81,17 @@ delete_breakpoints > > > > # Test inferior call events > > > > -gdb_test_multiple "info threads" "get current thread" { > > - -re -wrap "process ($decimal)\[^\n\r\]*do_nothing.*" { > > +set process_id 0 > = > This looks good. My only suggestion would be don't initialise > process_id to a number. I know it's pretty unlikely that `0` is ever > going to be a valid result, but it's not impossible. > = > If you instead initialise to something like "invalid" then there's > even less chance that this will match the actual output. > = > With that change this is good to apply. > = > Thanks, > Andrew Pushed with this fix. Thanks. -Baris Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928