From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by sourceware.org (Postfix) with ESMTPS id B16753858408 for ; Wed, 15 Nov 2023 17:31:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B16753858408 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B16753858408 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=192.55.52.151 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700069522; cv=fail; b=fGDw2PWUKpvsvjI7pfWDI361H15Uit+38CrCGXAHPIb+kOaUKR0l8oyVLk5NsZg52o3xDK5+5Rv7vmzjfWjVXwN4cNpMUg8CFhv0MmyxzT03ziscfXQUA9Y2XBVZLruWjW/+P1UIP6L3RPFNOUawRX70IPQjfQtUnd2uH3/uHS0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700069522; c=relaxed/simple; bh=YEf8DQnBlICPfKAumkax017irED4PA9b2lUbGq2vY9I=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=cwr4a67+coxMGhHH58y5sSMMZQaTe+1Yr3Dvz9TLv2mT20m9OtOEakYemFvWa3u/BRXzYGD5DhJEEmYZ9a/Mxm76P54BE5Wj5Le0BiI3PS150z1NrReis1G88H1rYLv4ommInjKfIrwLnrbCxiq8hYncVenW31pCC7NEFB8CAcs= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700069515; x=1731605515; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=YEf8DQnBlICPfKAumkax017irED4PA9b2lUbGq2vY9I=; b=ao5aZN2osEseN1bmVcUstIkdrythgLD+FpOzF9dJ0aNAe8y4FTQXKy4w E6xvZHTmtEw5K8N84X7isWcfb8Os5OIECqUaMeyxR98WKJhwB8Y81FvrG bFlQE9AtPIwqcAEdGkdJecur8XUY0WNL+Q9AmEdD28//yWuhO5wDtngWm vDTmiMVKnyxAH/dH4L1tR5qgy4r4JICHdmqn7Ql+fb6Bo0lk4I639MMlg 4btK9b1JjkqOX/3E/8tIznw/y6+2+Hd+IsocTl0e0+eMJy/TsEXUXzOBv CJUKl42OKH5KAw5cIlAFHQy6obAtV0G9S32Xo0LjQAXZtjTrJB+xZwY3S g==; X-IronPort-AV: E=McAfee;i="6600,9927,10895"; a="371106618" X-IronPort-AV: E=Sophos;i="6.03,305,1694761200"; d="scan'208";a="371106618" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2023 09:31:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10895"; a="835460054" X-IronPort-AV: E=Sophos;i="6.03,305,1694761200"; d="scan'208";a="835460054" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Nov 2023 09:31:48 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 15 Nov 2023 09:31:47 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 15 Nov 2023 09:31:47 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 15 Nov 2023 09:31:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vqf4aHdlDajPoPm/2NBYpxbgSo6CM+cFdeecfnYxF0LB0eR+Wpdtu+r2wdqxC12ARg0DJl5yizhSt96tvIGvBehWJalWcKOUrqHIwRw0twHboFBAV0arKL60KzZ8/m5sjJm6yRWIkddAX9UeikQiXadD9514sqQhmMYK2UNw56jZNwSwMWfdS3fHfDcg6289IM0TzttOFH/lccNR/8emmgUJYBGV2gcPgNEDeZbyFa+lnehBsDwvnv5SHr58xNw8hzO5/rkL7LW/tz92ycY+EkcNrNMhzadIBsm8NrFJWmbZtGXyxd8SvRj8WMfy8aGs8qxJAbBqiKm/8BybGIL/Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lBlf5N6z6GixlHvlj7Bmn+HE3HCRkDRyOCHnyIonxgM=; b=WwIVtWdc8KglzMBx3krlSt953l6aHN1A8FomrOdeyzcIi+yJhNp9cgU39706jYQFF6ncbeLm9C0YzjzI1idpgi8SvwNfPEsSvVeU+PMl1rL/FCQNqEpwc7M2hOnhcFhiedCok+6pyuFBh1rEwQL2OfPlBc1p2AM3VjfSjeUWqZ24VwUcy50JK/wMytMUve4j0ZVxckO/x512bmBxeAoQYzXrfs9qwBWOZ1p0uCAuoQom8c8YQG6avWGgzlCT6oO+g5YTVhSmAF7B8UQHNK37mNbeXyGf+AfVwgyq52Q5QqXFazJ8DA5su5eqFTVKG3gLSNgqDN4TNJ+XfTZLdk0HJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4457.namprd11.prod.outlook.com (2603:10b6:5:203::22) by DS0PR11MB6519.namprd11.prod.outlook.com (2603:10b6:8:d1::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.31; Wed, 15 Nov 2023 17:31:39 +0000 Received: from DM6PR11MB4457.namprd11.prod.outlook.com ([fe80::2b71:bf15:fd60:a53e]) by DM6PR11MB4457.namprd11.prod.outlook.com ([fe80::2b71:bf15:fd60:a53e%4]) with mapi id 15.20.6977.033; Wed, 15 Nov 2023 17:31:39 +0000 From: "Bouhaouel, Mohamed" To: Tom Tromey CC: "gdb-patches@sourceware.org" , "blarsen@redhat.com" , "eliz@gnu.org" Subject: RE: [PATCH v3 1/3] gdb, gdbserver, zpoint: report z_point support Thread-Topic: [PATCH v3 1/3] gdb, gdbserver, zpoint: report z_point support Thread-Index: AQHaFv+Noo0IwIJ74ky9pD5YE/ao6bB54eqZgAG+skA= Date: Wed, 15 Nov 2023 17:31:39 +0000 Message-ID: References: <20231114133532.3877-1-mohamed.bouhaouel@intel.com> <20231114133532.3877-2-mohamed.bouhaouel@intel.com> <87jzqkqu5e.fsf@tromey.com> In-Reply-To: <87jzqkqu5e.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4457:EE_|DS0PR11MB6519:EE_ x-ms-office365-filtering-correlation-id: 2c466710-7df3-4d69-79bf-08dbe600b9dc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HojNGpT40UzXICWwshazf3gpCwAQesJfrmKhC7kcjeaHRonPTN0hLD78hXFx9HEfX+V8VAbBVBYNtPvTa76+lUhN5XVInqpjOceMrvQtHDX2uvyKzRzhWZoKa41T5zuOdyijpaLWdojKN3YPs5hjteRNJx16Ua3GdLeWoZ4X0xalaC1ygVsCLOFW4sFAhJcYJjEuCXtwiZV34sOZWnsV1tNnZ2SrCfyY4airngB74bGJfeBv4trNQjUbBW3FwKiToGIHfG4FuKuPuEmojYfIOTmNCTYZh8pQqvjRkADQx0KQDaD6ErJYs3pQeFzNcLZq4k3MZn6jId3pfEvuYReFfotCJekNeBGKPOdw+XG5tcL+IFVcxEZ5wv/oUdcGN0JRjoO81ZA16lkre/d4L1C26iDqEGehRHDoNo8y/fibusa+1i/61WBHtOdU70dn4DgvPb3MyUOfaSfxvxfRgoyr4NcCRksWIaaeXSoeI9Vz9Z9gp899EUVYEwaTm9XuM+5k6e5hQZtMgJnl51TEJWWQgkFrLW2OIs51GuQJTi/d1w6HaMWF556sM0ZucDFSVPLcHBcYIW0bQc3WdUfxDfjzCVbWY5piG13Y7Q4fNRreDNsbqSf5wZ4kwuktLyrr3Fme x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4457.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(366004)(346002)(136003)(376002)(39860400002)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(76116006)(52536014)(8936002)(8676002)(4326008)(83380400001)(38070700009)(41300700001)(33656002)(2906002)(86362001)(82960400001)(38100700002)(122000001)(4744005)(316002)(5660300002)(478600001)(55016003)(9686003)(71200400001)(66476007)(64756008)(7696005)(6506007)(54906003)(66556008)(66446008)(6916009)(26005)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DjFP/YGlOWaxKzHbEX04wMSE2KGf3CODPPvBT/QFmXRkfkPXrem/JsN51HkL?= =?us-ascii?Q?HQJEiLFABSm9OoNfwuxzEYLoInuS43whPXZYKxPIm0lcY7azsjiAVHUsvtFg?= =?us-ascii?Q?Jrye5ebbVlPAddj6juZSGcnXcCIpICVC96FmP9vVDxbqeNhnCGX8ucCXZwxm?= =?us-ascii?Q?wggKS3/hWEuSvV+ELL3BkdGWEXpFPi5jKvFrx8stC5GE09FYnUbbratONH7n?= =?us-ascii?Q?0WnbfTJd/T3KvQAXYf9SKL2vVBj47u4LSX/TEnScvAdzLqRQY7sZRDCY3gwl?= =?us-ascii?Q?8VAW5a3XxjWujHKFuYwkLxGshFUT3L3UAdbIGdFTe8HC4oSCtKPjdcAJTmd+?= =?us-ascii?Q?Fk/tUbuh/BE1f9ORjSMu7pDsLDs/3ZKDFdJ1WLyzZUmjyWJ3604T0M7XXJE+?= =?us-ascii?Q?CHcoYRmMtuL+mPFWBKOlzFgNJKh3koccC2UeoSIeuNw9BxJRqo9SjU0ncZ94?= =?us-ascii?Q?b4qb+h/8JH5LEvvrEHyQceAKoJR2/tPjbLbpgLxP8HuF7/SWKz8aB7rSs3Iu?= =?us-ascii?Q?TPEFeB8vEgcG78Y6pt4Yoq4cFCQc5pgEYyHBBI9wKif0F/Hr2LuATAexYYf8?= =?us-ascii?Q?nmHqRGH1R1gMMOr43+iPU+p7s95FhzmTQNXZqIYpRD5APF1lcDT+TJKZbtdF?= =?us-ascii?Q?dpaH3FQR1eVvof+npX7jbByO6OGfFFTiShHHZ2yxgPL8guLRmdeVRw3ff5jL?= =?us-ascii?Q?evjwGhStX98If0lhCdYuGK5Qt6sBmIANIxF3e4nJMzwZtArQKySJGmXc9bqR?= =?us-ascii?Q?8973zoRTojLPCRBmusu3utSTX+ApUGSpsuFdlMwtawn6+cZ177LSdMLeLHd3?= =?us-ascii?Q?ofzfVQGHz6JHto4BzVqL1nP++AcoHgHL67C/GJ7xcI7nFb2H2tRRx7KsQoXX?= =?us-ascii?Q?LMNWqEU7E/0JfBxW5a8g+TJzblF5Z3wJIPGwVq/VeKoPuZEhuA2q9+R33M1q?= =?us-ascii?Q?eGeft5T8gkpTn5X1ZeCY2qEbcI4EIo5Rv8HcCwTWR9GxUF37i7vzq4c+io49?= =?us-ascii?Q?qapis69LNNyGvyEHmaI/0VeDh8kHbs7r1EYbqjrzdZ0VKUi22yZLXLTjCQyQ?= =?us-ascii?Q?NmzfkYqd1RHsLr44EFtKPf5EzwS27JM7PI0G0AOPgV93/Zdd+9JDp0SO/qs2?= =?us-ascii?Q?95johz6qLJcm9jUS0Cf+ZotQVz0vZHR8gi00/6QLaHulzWO2WZV+SEft0FzG?= =?us-ascii?Q?QFCAk8U5SyFPpq3lqHeHBqvunnmOG4erGvIsgdopS7yay9wkw/aWqtFN7nky?= =?us-ascii?Q?/bnvtcz79WpuX/3OybefklQedDD6zkwanU82jpgeouFae9ZKY4cTeNRWuZbl?= =?us-ascii?Q?IY5USI5IVjp7eUIhl8kJL3VztQ7GxuzXWytiaDMEWgvf8pKBVz1J6iqTF7dX?= =?us-ascii?Q?Hx9vG6SfrFG+T2DA564lzIZ38V+ll/FYCg+keBn3DOs/xy+DgGmHpnKUt71w?= =?us-ascii?Q?3TWIp4i46rX4Fda0MKdNvY6fNNh/DZRXAfxo1Kj8xjGmKZp+761GuKaUf3t6?= =?us-ascii?Q?Yr3CM/iQ1W7meDWJ+G5z5v99y2kPRBC8YxdSoym3zvIBqr8puXUD/vXi8SGN?= =?us-ascii?Q?0ahUTmFFZ+rZR5HaPfLCCo6ZMNNE0QmCTqPd6t/9cjSfNviThwG8/Xfc/X2q?= =?us-ascii?Q?EA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4457.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c466710-7df3-4d69-79bf-08dbe600b9dc X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2023 17:31:39.5632 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 72sZL2A0yMYXRlUDOKKg1Me2E1su37P0lc6Yl0LG2jhG/xvN1DomZOadGxiK4RD0HvcZlwRISwA7GxWi1p+L/g9L1V63/f1OzOzVGm6Hl34= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6519 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks Tom for the feedback, > I suppose the idea is that this work can't really be done on the gdb > side, because gdb creates the watchpoint and such earlier, and only then > tries to communicate with the remote... so errors come too late? Yes, and the error messages keep popping up on each resume command (`continue`, `step`, ...) until the user manually deletes the watchpoint. > I think this part of the docs should mention that the 'Z' response > assumes that both of the corresponding 'z' and 'Z' packets are > supported. Right, will be added in the next patch update. > > + return (m_features.packet_support (PACKET_Z0 + packet) !=3D > PACKET_DISABLE); > = > Too many parens. Will be addressed in the next patch update. > > +int z_type_supported (char z_type); > > #endif /* GDBSERVER_MEM_BREAK_H */ > = > Should have a newline before the #endif. Will be addressed in the next patch update. Regards, Mohamed Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928