RE: [PATCH v3 2/3] gdb, breakpoint: add a breakpoint type converter

["Bouhaouel, Mohamed" <mohamed.bouhaouel@intel.com>]

Hi,

Thanks for the feedback.

> > +target_hw_bp_type
> > +bptype_to_target_hw_bp_type (bptype type)
> > +{
> 
> > +    default:
> > +      error (_ ("Bad breakpoint type: bptype %d."), type);
> 
> Can this ever be reached?  If not it should be gdb_assert_not_reached.
> If so then it should have a better error message -- this one won't make
> sense to users.

It can be reached by mistake, e.g. if someone passes a wrong btype to the function.
I find using "gdb_assert_not_reached" is more suitable in this case. I will change it
in the next patch update.

> > +extern target_hw_bp_type bptype_to_target_hw_bp_type (bptype type);
> >  #endif /* !defined (BREAKPOINT_H) */
> 
> Newline before #endif

Will be address in the next update.

Regards,
Mohamed
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928