From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by sourceware.org (Postfix) with ESMTPS id EBA423858C41 for ; Wed, 15 Nov 2023 18:18:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EBA423858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EBA423858C41 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=134.134.136.24 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700072306; cv=fail; b=CMly9OP2mTxpAqL+d5XHOPr9Yse3n4VXTH+eSctRnO7xnA3Fq4GQsaaS7UVkPx/BdYN7l63+4SHhQVYmsc57NnCPecPsJ1taifNbTG+48Rn0TLf+/rtfwpJiJvWVUyBxgBU15Et89tvK9uUcU7OH5OJs9Vy6ojd1cCeETLGRan4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700072306; c=relaxed/simple; bh=xW4fwtDDDmVayezXGVxiI1CLZPcYfoZ0eVoKTBJvUvg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=TAqVAWPQARqeuLZzyxdaAmyqwPa/w0kMErU5MvqdSFbq6rXuJMnDoVu5C+SQHt447GQ81g1Mm/MPq+CHNqdlwrVH9IWXRHi0t6Dcv0DMYETEUJT0tj522xzzKNiYHWmB7XsN58ZhiwkxKKky7u2KbYMiGeFXwn3PAdBUk9/RvGU= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700072304; x=1731608304; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=xW4fwtDDDmVayezXGVxiI1CLZPcYfoZ0eVoKTBJvUvg=; b=bkZQxAf2KqGyyUGSrXd4j/hYXvLDAyy1k19tuUNo6CRBRRlbuZCmg2XD 90/YAe1FD7lkO5Q2kIB4UuwHzKREhGAxY45ofgQFvNmFvgNHPUOKgNya9 zxcBgWmXmPcTICe4w1rPlmnhgLidmfj12r+DGSuFO8KzmUHmetzh2FEC0 ZC7qjDd/YX7IDvF1qmdnWsO2egO0gacA67CAEyslIhSXyXm5xVYvnWN4Q 3oJnZkSDgr6pY4N/2Og2HLsn55v1zNRt/Ft3KaoTz2pvN7Dq7wnrc/SLl 3FJOLeHrMTFGatv62jvIVi9weaIQ9MQC1FZ8cETfsxC7w0kJR8KWGzdX/ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10895"; a="393781886" X-IronPort-AV: E=Sophos;i="6.03,305,1694761200"; d="scan'208";a="393781886" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2023 10:18:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,305,1694761200"; d="scan'208";a="6473807" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Nov 2023 10:18:23 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 15 Nov 2023 10:18:22 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 15 Nov 2023 10:18:22 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 15 Nov 2023 10:18:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aWH2bZ/9p5riMqhsCh+AhDtyRtJ231rwOTZD0iiJEHWfpr651lc8tYrRz3Cey6WWsSii4V/zaE5yH3z+roGIAGXIMw9ev8u0typmF1wUXJOS2hZo1xlhQAaivr0GKyyPgjZPd7lgirdIN3sUaI1132lf/hlPgzNKCkTOuIIclqJH1BqNrKxdp0VbrBr1750l1OOe/lCS/bVI0l/AsmMlKXMi9sOC5NLN2GNF54Jid1KE8UbjetKU5NHmZu8YqTGJaD1AVtklxEFXSJiz7BQY2ir/eepR9md/OuGJ1PpmYA+W/a3xKQo9omEl/nTZMm8RsBgSbJfYq09V9yAelz5Bkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F6nepF2gIeqWQT98aqkJW8onyHHNyMgwa2Bsnpgezbs=; b=MPzQ6kussaIV00zhTEu1qiOmbHzTOZ2FI02SiFLEgj0S9wFq9nlboco0nu+jyN5FVGJslsD5wvGcB0tk0zRUfoT/EL4lxMt4Ya5nK2cOmrR2h2Pi/INx02P9UVHg/TDqAW3NiugdEuQL7TqjOSWkTkAiHEsExWdxqG/gFgtF1jE6m5wCLpzs9hjNhA/StnWk0lEkTeb7kraAvxaIv9y3GJJMId5lrOL8qIgaO+ujJUlM+v4JW0LByrkW25T6scN2TutvDe9c2VNjqOZgXqdykQ/KH9kYkdTONrR7PCtXv2AmDptbHMPETVEOI0y0o7dHQREKhQ0Y277dqKzbPvzswQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4457.namprd11.prod.outlook.com (2603:10b6:5:203::22) by BL1PR11MB5413.namprd11.prod.outlook.com (2603:10b6:208:30b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.20; Wed, 15 Nov 2023 18:18:20 +0000 Received: from DM6PR11MB4457.namprd11.prod.outlook.com ([fe80::2b71:bf15:fd60:a53e]) by DM6PR11MB4457.namprd11.prod.outlook.com ([fe80::2b71:bf15:fd60:a53e%4]) with mapi id 15.20.6977.033; Wed, 15 Nov 2023 18:18:20 +0000 From: "Bouhaouel, Mohamed" To: Tom Tromey CC: "gdb-patches@sourceware.org" , "blarsen@redhat.com" , "eliz@gnu.org" Subject: RE: [PATCH v3 3/3] gdb, zpoint: check for target hardware breakpoint support Thread-Topic: [PATCH v3 3/3] gdb, zpoint: check for target hardware breakpoint support Thread-Index: AQHaFv+YNiualNA5wE6x+TPmCSdT07B55Gx3gAHKWQA= Date: Wed, 15 Nov 2023 18:18:20 +0000 Message-ID: References: <20231114133532.3877-1-mohamed.bouhaouel@intel.com> <20231114133532.3877-4-mohamed.bouhaouel@intel.com> <878r70qtqe.fsf@tromey.com> In-Reply-To: <878r70qtqe.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4457:EE_|BL1PR11MB5413:EE_ x-ms-office365-filtering-correlation-id: c55baef0-75dc-4388-a968-08dbe6073f13 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QckQ9JY3V5dGpSh4EBha8P7Zof9ttEJqCYcvXSWhokLFPBO812J+JTBIVVbxaEkz2JfZW2vTu25cNK7ufnoRILQtDdgizfwIi3c6GF7QsZA+1IRnHbOQdayObsLHe/WhePmpt67SrP+GhPD+Qtux2xnG5tiVb0SRoPR0fgg1srAnwI7EO8Oa0gQwYJ7VHtlqYZmRK83Rnpo4QMOEG8p1nEJm9zIEC9lqWEFB5nTzshJJ+vr1mir+TmfePmRMiCrNN1TnLkAFZne7lJm/hT76xGFEYWCVGY5wJnWKoe0FtSaaT1iIRIIVtRyWkt0jIlEBDnD0tQATDYlNDBo6d0cfqbJ3xbfo1b7w+BKfNJRSrlAQ4Nu5n9xjPDjyqPmN0IjS5lzt7IBQ8dMedVRheqyDDc6y4Fq4mbXDk+OgeZKbMk0lR+mfV9c8/jzVNdejJyiPaZ1FYAXh/IhPz4MzP/eDtExs2o8USgjwdKHrqPJT/lQ6AlzH2SqSLEoGfHuzM57QsMt2eEqkKYCyvIRy4QFIUm4ZMHWa9tSBC7165jBkfqmRI4oWZ7hU9Yo8oEz7TJ6RG0zZWstoKhoHmloIsKoV9uHtmQKWQahhVWQU79ulfGvtOHXVVb/dAZL32val9K/o x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4457.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(376002)(136003)(396003)(39860400002)(366004)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(7696005)(76116006)(4326008)(66446008)(6916009)(8936002)(66476007)(52536014)(66946007)(66556008)(64756008)(54906003)(8676002)(71200400001)(316002)(478600001)(41300700001)(33656002)(5660300002)(2906002)(4744005)(86362001)(38100700002)(122000001)(26005)(83380400001)(9686003)(82960400001)(6506007)(38070700009)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?y7b42bab7PnKV1OK4o9EG/O+zBYjBygDA3EDeNWdIaCeAxz9sZAcP+RleyNJ?= =?us-ascii?Q?V0F2aNeUaJkNoWN5S+M1MHnliEiFDMZwU/5SBag7c9hXzPxR7aZ1kcufYQ+d?= =?us-ascii?Q?eHs8ZqsKQXWLOU+kAp8Y0DI3UG8g+vAoDWCq2GuT7cvz0k8tXMoCzGJVjCpm?= =?us-ascii?Q?ZcGGmfgaK34yd5lHNz8T6zxXf49ENKPw4dAnjSp+s4Ve3c4WKPtM0qUW5qcR?= =?us-ascii?Q?dTAvFL/T8oGn/anJIZcpRX3PbpvVGJer1UuoroV1FyqpBd7u0T7UdNEA/iyB?= =?us-ascii?Q?NX7kpem+cgI1kTDKy7QuxCyuNa4A/TSef1uDdaIV1SPMSTsrNdcu7a7+CmEt?= =?us-ascii?Q?VVJfrdnCXF3Gtnef7+mOZ0oWFJoK7htIqwI1MNgklxzVbHTViBoblprxYtVw?= =?us-ascii?Q?lqsxEuOamI8YaINy6VMU3WGrA5YxEJrAiyUw6mH5p0oCscEnpGqpBQqophYE?= =?us-ascii?Q?mxGejduSNRKW6VwgPWidcVk+5XNlirCfAKEbvNlxGewFcfM7jxkMkL5t2YFX?= =?us-ascii?Q?9LKmArbCNV+Z1QvxmQf/n57In90LIlO8eoSR7rKSQ4kC+vtVOBg3egHXUflB?= =?us-ascii?Q?48pJnnwf2fvEtog0Su0LbolSmuVXeM3EqZEbJDGpWIc6Z31EdFChr3oiPtQG?= =?us-ascii?Q?zSr84LSEOfWRPRCzPoMhzHp8MNktY07e9gByu74mMlJkCOjuvk6ADH/RcuR9?= =?us-ascii?Q?a2qAhayYvnpspwt+oQ9u1iff6aTlGlirevbovUSyMiJ3PxttkUIY7ZodPScH?= =?us-ascii?Q?F2IwQzAKGudVZlzgFZ5bjraKxsk5gA+5/4sCbO0/vUjns2ENBJBM/gT2u7R7?= =?us-ascii?Q?sPguvAM9y6kAAGGhL5uqsiYkS9YpqpxzSjYPq2Hp0Zef1q7GQK92OD4OA+s7?= =?us-ascii?Q?sN056PKqxHCl8jbSMsUEEVVlLTKo+azHSjApsvkR/uaBasQTTjHqyze1CxW5?= =?us-ascii?Q?Xfz6pHj6x6EBxqHKtNxugjBnphiKc40qjwrTeiImCwvzBAqGnN0w/NaBLMRy?= =?us-ascii?Q?iJJlCH1RlryBNrBaTTZUrl9YhpTlxzFO1MNExxVi5ISzv0JAbI2PHJAg1dSX?= =?us-ascii?Q?oEPCfmjYr8GDD4iC0FgQkbiXn6dSElVPXDfQsX7bPdOjZTfUvcMU/wlMHRGP?= =?us-ascii?Q?sAFWKUbrcwUiLRcPu74bXVOZO1RlTJLvMTlIBFLylvvyVPocfVosD1HNsq6R?= =?us-ascii?Q?BQnz+q9KxBNR7fBVZ/uEzk/smreVpx0gFACWl7TFEgCbXoe2mEwgaOm9jnRr?= =?us-ascii?Q?XkgtbSIJSgLjMjEMzGxYj1Tg1qf7ypB/EBkydYXs9tyS4dDX2Qqu7lTb7iIE?= =?us-ascii?Q?CBY0mchS8Hg8orES9iF53S9zh5lHyxVFutfLGRe1aqaREiCK3KjXL/m2eqnL?= =?us-ascii?Q?w9SLA7j6r6ENc0LbD1uUtVw7Jt4bPXkkylOPjdsW7sh56auGv+Al1xnDv01m?= =?us-ascii?Q?4PF4KDEjD0LD6x6/CYNdrTLJJcXMxnS22Ko/UxGkUEWLvwEiMojT1fTH2Qzi?= =?us-ascii?Q?utKv1G3jK8KZN2vircbXvC6JVtYws0TRKYfb2CJ92RawtVUqft3h6yJL3YEZ?= =?us-ascii?Q?Rh5nfJe1YqaeDhdpJGfs/xZVd9UPIHHI+2ZoxhBKwHQ2Ja1Hn5KmQd5ETmAd?= =?us-ascii?Q?8g=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4457.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c55baef0-75dc-4388-a968-08dbe6073f13 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2023 18:18:20.0389 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Cbbq9b8XuHZsMhyZfC35B/mr44MrO/CqFaU5CbLeaEqSNIfXsrmGlDJbPCXD/fHXJvKxwtY1g3aezSywFeuizuIrZylQRp8vRljU59kKQgI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5413 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Thanks Tom for the feedback, > One question I have is how this is tested. We would need a remote target that does not support hardware watchpoints. But I am not sure how can we build such a test. > Another oddity is that supposedly a remote can reply '' to a z packet, > meaning it isn't supported. However, insert_hw_breakpoint (at least) > doesn't seem to record this response. Could you please elaborate? The remote can or can't replay to z packets? > > + /* If hw read watchpoints are not supported while hw access are, > > + GDB will try to insert the watchpoint as hw access. */ > > + bool access_support =3D supports_z_point_type ( > > + bptype_to_target_hw_bp_type (bp_access_watchpoint)); > = > Formatting looks wrong here. Hmm, how else can we format it? One suggestion is to use an additional vari= able to store the return of " bptype_to_target_hw_bp_type (bp_access_watchpoint)= ". Thanks, Mohamed Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928