From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by sourceware.org (Postfix) with ESMTPS id 033053858D3C for ; Tue, 19 Sep 2023 11:38:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 033053858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695123530; x=1726659530; h=from:to:subject:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding; bh=ybdiesIP5F5ukZ4ZIsx172jYtkXi+j/ZL52RoW4ogmk=; b=NPOqC+/ZFhrFX63RP3TUYd2KcD4WsoCGi27xHIabaO4Cx0wZlWS2BccW bwpUXMvt97vASk6YK47WzNB4Vxc1W4j1otL3c2qfgoilS6QjlazbabYNC kkj0RSXrVMGFxOYLmAR83TLUCjeO4G3YrPLklT5FMj8MOY3IYVJZIVhcZ TRCsfTQolZIGyOY0TXjAsgUvXJ20kisMoboC8gLsiZznc0QmsCSM3nJCN fNT6mUwPpXhpM5/hgukzVpvE106l5xsJsgHh3x6BWSbyKNOzgR/UtqUON qb2mrWICsVPRuECIp3ldFdU7kcOz+0/BtYnnPL3B2b9zl/+4lO+WJgVMg g==; X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="444002429" X-IronPort-AV: E=Sophos;i="6.02,159,1688454000"; d="scan'208";a="444002429" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 04:38:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="775516827" X-IronPort-AV: E=Sophos;i="6.02,159,1688454000"; d="scan'208";a="775516827" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Sep 2023 04:38:47 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 19 Sep 2023 04:38:46 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 19 Sep 2023 04:38:45 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 19 Sep 2023 04:38:45 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 19 Sep 2023 04:38:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L6KsIS3C1YsM2bCo3csSgvVkGF5Wj9mfrIlvnmIqUxMfCMzkHLyt1w2GTTQ/XGJlvNg0ObnrOBShN4NHfMJurBg8HXXBgldsyCOfyS7CpJKztw+PaOA9NiJq/4QyBYG6zLugZyoNRTDjMgva6IiiE+1aEKQlHY3KC82gBQGdddGILDTi1N5aayDIr+K3d1RsGydOCeVzQ+mxcY/CgOUmWZ7l1mEk7lB83m+Kf11W5uT0ikHJy1sn61rHCDulb98y7+38d/i7q/RGtmkhG+eqPz0OZBhQAUVNZ4flee+c3MlnyZRs/8pFAmDIsR64cFG/PtEYO4A1kMzRd8FEcEDdBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4QyFcQBeCQPNgJCOgtNujIlTB/n+Fj7WuMKmI3WSObI=; b=JNI3BZKTMmd8dhr5025MdvWLQgTrpifMQ/qaDgAw1ZOFjarQWkxGPK4cvKdR7ls3bXhb9mjvJDXU8nxg7PLMBtTutHhpsDSLmiqeBjAH/Ch82Tak5DtISEE85SlILr5FkFrPpe2u2WWiZp6est7Wy6HK/MTGlpt0j5YW9Pgrgx1zGnMvy90kpe5U4cuSrYicx/PzO06RTLZ/71k0M6m56b5UnBbUlaUMq9VEyvV92ywDkbFLHox2jXP4hoxiTkwxEz1ASW8LsYqVHCkRsNDwBNNoU2BUyQt60Ehyi9s0FjrqZh8IMo0LFZvcOVn8b1EcS48ZGtuMjLgAu10FPjmsvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4457.namprd11.prod.outlook.com (2603:10b6:5:203::22) by LV3PR11MB8767.namprd11.prod.outlook.com (2603:10b6:408:215::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.27; Tue, 19 Sep 2023 11:38:43 +0000 Received: from DM6PR11MB4457.namprd11.prod.outlook.com ([fe80::3207:2893:cd81:30a7]) by DM6PR11MB4457.namprd11.prod.outlook.com ([fe80::3207:2893:cd81:30a7%3]) with mapi id 15.20.6792.026; Tue, 19 Sep 2023 11:38:43 +0000 From: "Bouhaouel, Mohamed" To: Tom Tromey , "Bouhaouel, Mohamed via Gdb-patches" Subject: RE: [PING][PATCH v3 1/1] gdb, breakpoint: add a destructor to the watchpoint struct Thread-Topic: [PING][PATCH v3 1/1] gdb, breakpoint: add a destructor to the watchpoint struct Thread-Index: AdnnqaZSWxDKiDocQ+amjPHyrTKZAwAUugY3ALvoI9A= Date: Tue, 19 Sep 2023 11:38:43 +0000 Message-ID: References: <20230630081015.17380-1-mohamed.bouhaouel@intel.com> <87led79vol.fsf@tromey.com> In-Reply-To: <87led79vol.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4457:EE_|LV3PR11MB8767:EE_ x-ms-office365-filtering-correlation-id: a0de551d-1ba6-4f72-2842-08dbb904fa22 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: l/VptQEaDKeJZvfmlyh6ke1ezTZao4OL+bS9kwP6WC+aRPj205zm+Y6QqdKqIcf46Oll6x1xs9RACoMLVYQcZTM11kWb/93SKyrKuOlMcDG90lLlJR3Rs/XCYxnzv0KrVfZ6CHvVYxkmpHm/u4G4f4i1EsW5Jzm9RawXEFbLvsLhsm5OV2Tzju7ivNL/uPn4DEuoreVzHkrwSIE92NObYQA9pPm1PJ4ysxvKUzlOlyzT7t5SCJWJHMhafVNhTykYutH1NZMFUMoRBhvpBFjFmYQnShmmrWlBMA+HS8s9G+QdtCWERCSEIyvtTaIveLwplBz6VzxFjfl72Vlf4Z5NViMRkXratbboCzemmfNWvPFssrw5nimVmRYm1gz7bbeAiHtBCyfbvubwjy7yO7oM7ZyZKj2yL9GqcoibjSALlfrritIOArHYigp283ki0sYjnZrTDDDy97TWVb/1KC9xJmQkKnPFD0kIGaNlRfxptiW5g6WQCAcOmi6bFTyT1SQQouWyczNyDToZdjBaENqEHe6ErQyAo3skqA+oEDQqWF3h+y8uUOEx3diqRvRKZgeYybQOtC34Bqlmsd5lX3UEbxkAnd06x0eMoSkALaT2dlA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4457.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(346002)(396003)(136003)(39860400002)(366004)(186009)(451199024)(1800799009)(55016003)(26005)(82960400001)(2906002)(33656002)(38100700002)(5660300002)(38070700005)(66446008)(86362001)(122000001)(8676002)(316002)(41300700001)(76116006)(66556008)(66946007)(66476007)(64756008)(8936002)(83380400001)(110136005)(478600001)(966005)(71200400001)(53546011)(6506007)(7696005)(52536014)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1SGG35clW4qDMLcEDCnDo94aFPDNVsLJhgEkdq4P1OS/aImBhbBAsGAfjUSA?= =?us-ascii?Q?7+eAbKpSiMi+hPJDNx03SMkUeChmqeGQwtXBCgDx/PPs0AbB/rD3IgDTpxi7?= =?us-ascii?Q?lUpDOI1yuU6b1NnGumePE7RTz+DyiSdVz4uuWmtuevDPPBnJhi9PGWye3viH?= =?us-ascii?Q?JVV2hdcubWGlqrGAIHbgwu0fve8LsrQ+wajNJ44ZhMDth8oIaBpyvcJQ8H8G?= =?us-ascii?Q?LxG+L28HY6sWX9j1Sn1R4jmQOG0Ph4FsoMHM3FBOzALlcp65wyrtgJRm9mOa?= =?us-ascii?Q?ZchHcRfWRjgiq1THkepMc1aBRSyMCVeaf1JbwkYyioKQzu42GLrzSe2AI3rf?= =?us-ascii?Q?ya23kVNEyuPbobR/jn02vyfcEeSjCJvvmdRjPy/GS4diSBUM1d/8M8rN3kmZ?= =?us-ascii?Q?fATmnVeU3tELQ/8uX1FjifbddnP8PTJhvsL30xNJOTJzdtUiPMfOhvDVxXVT?= =?us-ascii?Q?TKxzI6YVoYmHdk6AImcSzVr2YD4/4wPzpm1/C6TAjfU+cqhPP30i670ecWIa?= =?us-ascii?Q?gJwcV17so7M/FYj5KxkBox1+43SkyNY502s5BiKkO/Kr834obYKkSAlfstKO?= =?us-ascii?Q?JjGwQdW7Ja3G71ahX9qUg60UnTUU1/EMH2QpwEeQ7Ffa/eo/OpLYbzYZjn7d?= =?us-ascii?Q?FF8VjERljACQfrrBvdsBRodLk9tQpw44yYEGiE6LVwnIvCCVmbnbKfvN0NIL?= =?us-ascii?Q?ghsIA16gHDIa2Yr/KnzfsaA54dZ67g92/VA9rJ3fjJAxH5gFQY+ZuVxQE+Zc?= =?us-ascii?Q?jJ0PlOl+ALGGftBJfJAj9RItx+K1Quxs58cFEryV2hMD5vDVtE42RLzXFlUa?= =?us-ascii?Q?S8tjfMwnq8c5GNS1Kxuk/Ia9/otLZ/mh92dE3clfgjSKXpwqYgfLCLLmeaUd?= =?us-ascii?Q?3ddOTZZIoPQnwRdv8fn9drcAYt8leRMT0rBMa0pLsF07hpnmav98fXPLgDei?= =?us-ascii?Q?CgZHXfnIWHl9CXQGEwcstDhAiP3mGZQGhCGkWAlUx5uaw2HDSv1G1hcM2D0j?= =?us-ascii?Q?l7BHQM/p+Dmk5CiTJpuFLDrABGDdcf6J6ldryapPpe8F5//XmTwdJFLI3vts?= =?us-ascii?Q?bkPMdR8n/iRg0vI4USs66vrTf542uABn+Iz+jCAbw6wSTWG3q822I4VpsjWx?= =?us-ascii?Q?dKGlZAlNVqqAB7+erPCpiAFwIioLoRW/+k8YXXjxhFi4g+KmxWKBV1PWMwoZ?= =?us-ascii?Q?nqurRjRd0DeNsTOXVKM4ySFccCpnPFnRRX/rySOIN0nb6Pf/pb7ANFW4ADW7?= =?us-ascii?Q?Au5lvxypT84HhZReuK6whNzzuvNVJ8cLR7yeX35Ms2ZNr7dJd3Fm5yuljabC?= =?us-ascii?Q?Afn73c8ah2ECyxKcCQEDNMvOfhpn//cEuca5X9nbUiMyfEXo/gECx37BB7GG?= =?us-ascii?Q?b00nNPB61hfIBoT945yosleIjtu7C2OmSPNbw+AFdxy2+4pKrFHqP4615iO8?= =?us-ascii?Q?7wTHsFNHmSPZnReu4hWoZWC2nsdgMPFbdW6Gp8+A1xfuFE5YaMc/kz1Wb4pU?= =?us-ascii?Q?HClloa6nIbFpSCYsdalBGkHQRzT1ZbhImiuLFOTa9HuF/IzCUevoNvRzUKkl?= =?us-ascii?Q?jlQl6nTADj1mmXyNoQBBNqv0QFdmMLULkRqhJDM2hhvpzvG4/6Ll9FEd+ilS?= =?us-ascii?Q?dA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4457.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0de551d-1ba6-4f72-2842-08dbb904fa22 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2023 11:38:43.0554 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LE3ypzabbUI8uupjZ3Xij0udW4QJWeDa/wwUnpToeUD0JcLeNQz9uPHBHxliLCq0AOiWs1M4i7ePB72jJYrr5NX+ySxDsbB5xKD33+IIMH4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8767 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tom, Thanks a lot for your review. This is my first accepted patch in GDB. Can you please push it for me? I don't have any write access. I plan to upstream more patches in the future and would like to have "write after approval" access. I guess I need to apply for access in this form https://sourceware.org/cgi-bin/pdw/ps_form.cgi, after my first patch is pushed! Thanks again, Mohamed > -----Original Message----- > From: Tom Tromey > Sent: Friday, September 15, 2023 7:46 PM > To: Bouhaouel, Mohamed via Gdb-patches > Cc: Bouhaouel, Mohamed ; tom@tromey.com > Subject: Re: [PING][PATCH v3 1/1] gdb, breakpoint: add a destructor to the > watchpoint struct > = > >>>>> Bouhaouel, Mohamed via Gdb-patches > writes: > = > > I kindly request that you review this patch. > = > Thank you for the patch. > = > >> +/* See breakpoint.h. */ > >> + > >> +watchpoint::~watchpoint () > >> +{ > >> + /* Make sure to unlink the destroyed watchpoint from the related > >> + breakpoint ring. */ > >> + > >> + breakpoint *bpt =3D this; > >> + while (bpt->related_breakpoint !=3D this) > >> + bpt =3D bpt->related_breakpoint; > >> + > >> + bpt->related_breakpoint =3D this->related_breakpoint; > = > It took me a while to understand this, but I guess it is just the same > as the code in delete_breakpoint. > = > I think this is ok. > Approved-By: Tom Tromey > = > Tom Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928