From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by sourceware.org (Postfix) with ESMTPS id 9441F3858CDA for ; Tue, 10 Jan 2023 09:34:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9441F3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673343273; x=1704879273; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=qry4oTRS2eL3n1b+CGmhdiHECn2TH73Dxnnq8G6KX4c=; b=W/M2ZVQ6BxIMo6MqzB88/jQhElES3fLdN2wFlT7N8uTwod8RwdgpWNYo tC5jT9cRCiRyLYeYi/HyPz1BmJK3TYud1gEI6VD7CgfnypMh5Z4OvpWGb 4LzoECHYcjB1A1MBnfYp4xb0pB3AyYeDfQraV8QwRI3a7p52Q8nbrfGKv zMHW1h1oidUm7A4F3Bv8LQwqEHr1KLXQwXeLQEsrcf07e3pT8ciBaA7dX 7sdIaAJy06sGXNrFrpn86vsXvm/ZLjWvJgB1efXFAdVt24SselvBEQgPt 93yWaoa1/5RVBjoXZ+/Bz6j4L8mwq2/lwd6itKeS6ybJMlFNFa+28uR0V Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="387556629" X-IronPort-AV: E=Sophos;i="5.96,314,1665471600"; d="scan'208";a="387556629" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2023 01:32:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="687509589" X-IronPort-AV: E=Sophos;i="5.96,314,1665471600"; d="scan'208";a="687509589" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 10 Jan 2023 01:29:22 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 01:29:21 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 01:29:21 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.42) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 10 Jan 2023 01:29:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dBC0u6RPggm64K1Dtoeo17ou93/KRqkqXgNvQJb0P8X336Mwsk/aVjK0E7uFESOw0tCiWvsRQSQmsdMbN5YgY0+qCfibKNzLpIEjBp/PkNRIUSIwCtOMKBJhgCre2e9vB2ZljnD1ur16aZ+89zVNM4S/Ubh+mWLY+47YoCu0Zzaq7vS7HvLFEphLQSyToNmoj2JRSuJKg8PqqTEwduZDUW0Cq5bsISJaHuDdj43klWyfBLNKGjaJQMM+CUKx2JVV0f8+3HU1YU+HOha3IPSWtuXZIpW+J23mD3hucq4F3/dfNEcf95+ijE6xlRlRwMK6T/EleKzk+3pbUVFbrnl3dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FaaKsax2Ug2eEC/Cu7WfHGEO92tzZS4bH9Lpwjm3oiU=; b=XFpvo0PVC3GESvLZZHqkmR3Hxkz0sKVx+qvOIwIlrSaop8r/YDzb0di0CMpX/4K4kzMTbBAks+RW5gE3mBN4CxdX0Vs0KsHcqkpHhmmiH846xNmj5C3t4/nfBmGi51Nwgso1IdZNDgFbMq9r7I+TRV7AGstGKUu1dCN0kc84+JuYgv+zFwEzXjgD/igu4V49yBCI3MXNi4oArMdDqsbFTvb6u3W9ArAj62/LRN8BZSocRafNs6Once2cuedZCvugj+XjPsTOBRItLIh2cBZRFJCWT36WSXQqbtrGqoQ+CQjsFmfXcpLKD0kQ+3u9CklTYB5Yiu9YJlC1NJH1cl48XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4564.namprd11.prod.outlook.com (2603:10b6:5:2a0::7) by CY5PR11MB6306.namprd11.prod.outlook.com (2603:10b6:930:22::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 09:29:16 +0000 Received: from DM6PR11MB4564.namprd11.prod.outlook.com ([fe80::f3ee:1ff9:af37:b9ea]) by DM6PR11MB4564.namprd11.prod.outlook.com ([fe80::f3ee:1ff9:af37:b9ea%3]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 09:29:14 +0000 From: "Rohr, Stephan" To: Tom Tromey , "Rohr, Stephan via Gdb-patches" CC: Simon Marchi Subject: RE: [PATCH v3 1/1] gdb/dwarf2: Fix 'rw_pieced_value' for values casted to different type. Thread-Topic: [PATCH v3 1/1] gdb/dwarf2: Fix 'rw_pieced_value' for values casted to different type. Thread-Index: AQHZFT34N8WrT8UwQE2lWykOr7gFDq6QVDACgAWCd5CAAMAZEoAA6OPA Date: Tue, 10 Jan 2023 09:29:14 +0000 Message-ID: References: <20221221131244.1287706-1-stephan.rohr@intel.com> <20221221131244.1287706-2-stephan.rohr@intel.com> <875ydkep2i.fsf@tromey.com> <87tu0z8q3f.fsf@tromey.com> In-Reply-To: <87tu0z8q3f.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4564:EE_|CY5PR11MB6306:EE_ x-ms-office365-filtering-correlation-id: 611f3625-80f3-4f8c-d3cb-08daf2ed23c4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VK0T7MXHWM2YWCjWF1YNoh+qxmHDvlonjc/72Sq5ITC62mQ1VSzYFce/NlMiMX3y0enHX8NNOKtHt5xYD9Ehvx9YYN96JeU2491OGJdRG74HNbgxL3xZTziDdd1rI97dDY5/gMZ9H86y1Ke0y+8SRrk0MiCp3AnE57wzJzo/Z2bbFB7XgJPgBfE6KP1qttKos9g0YmEiRhlHG+Pfm8sabMajBDOL7DxuTNjzzZdDcG+P0TM3zJwoOA+3M3LqOOqeS80a9Y0WvbfXHuNz8hmdlBBrDBOzVrYTeqxXL4haIiHxqCEPiMmqNdaogE+W8FZSfbcYLp4PuRHa53OUKFea9o+Hqv395cs68pW0zzuFLzjcMzIjJw6Sk0kzq5v2+/ZvqYVmzxCLBmjnBHZMjhBI867F0UIIERKrJaQ3lgrPnfin2DYQjIqOMltfng8R3tgEPwGdla5c+tTAYMhuR1PzlioPKt+TbfaWdOhrNybvI/bBD4a121mm41UvJiGeUW2i54racwKnLHSQslA51oLpu2xxEi30ImAoExa3OtDM9ZPJbkfy52/u2xqdyeQ1Q0MCBP/rDlp84ocxUGdDPWcOQjq5/aNgic0yRSKkr43a9WNmAf2Bx3hifXTKKJrHIiCHK7GVhM54p5xhBbk7d2bG/mU2YbJULJKgnTOzhtZZiJWFUdxxFDoDHheS9yHt0rj8DiGDoQiVkmZkR0GDKv+y3YKfqp00Io3baieTXJyWq0g= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4564.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(376002)(396003)(346002)(366004)(451199015)(33656002)(110136005)(66556008)(5660300002)(316002)(8936002)(66946007)(41300700001)(4326008)(66446008)(66476007)(64756008)(8676002)(76116006)(82960400001)(38100700002)(83380400001)(122000001)(86362001)(9686003)(53546011)(6506007)(55016003)(52536014)(186003)(26005)(38070700005)(966005)(71200400001)(7696005)(478600001)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uFdDNEZPU62wxz0VhkwDpY0QOslkPvi3KEMscE5OUiOkYH/K0+h/Ax/9YT1n?= =?us-ascii?Q?iu5++0st7dXHqxUpMqV4TFMKFpZ2YZV+/f9rR3cjYwklPkQGeuCb/eUvQ/dI?= =?us-ascii?Q?KCPXwaDpPw40T2/KTkIY/tYUr1VB2N1Lp5qtnoMGNCD9VC5GmVBGoZna3zZ2?= =?us-ascii?Q?Eg8BV4YfH1iAyw9JKlu0uo9MDFab/yjgGHTS8emsuB1vKDMiNQYT10EyBtbu?= =?us-ascii?Q?IA9PpN0xMuGHzt4BhIX2TaAlAT00Y0O99ZIGXnXWvkC7ubcgC7ceZZzWaCm3?= =?us-ascii?Q?fO7ZSh+F/xdvK9lZeHKq+M5VE/rTCcu0uxO86Cftv9bbjIimyERDRM0mYzJL?= =?us-ascii?Q?VK5c3VoGzrLARwTaD8hrltMI+hvjft1CUIqdlQ0riI0vjA034uRChZEtjEae?= =?us-ascii?Q?kyIyK7JTfPfWe/SUf4cKaNcNds2mX+n3pYRpBFWld/y+DYiqpNz0hTvXcXLf?= =?us-ascii?Q?sHs+QA6p6eWkpPYs+ANl4d86fSS9Oa2jpLRWhnWfDpLlEJkruQIxGD+knPBE?= =?us-ascii?Q?arVnbnjNtcyai476Tp50DrBSCrQXmgVbfCIKALs+dbUJcCRwdkkP2a2LdBcz?= =?us-ascii?Q?RgY1HpaZqBvn1ymK31gN2XnK7+YfvlG32/8w0OOOIWtSk4h5Cv/d1jmYr9Tl?= =?us-ascii?Q?7+9MOjh1mDJUH8fAA/dQnnyuXKHfAw1V2/gKIi9OKJUDxjRQ0SJXgl+Z01xK?= =?us-ascii?Q?VsJtWVvaIDm/hIz+1pn1hLmYtpWuRfuvLnPeVW60VrWQ8Sj320AzL8NYai3i?= =?us-ascii?Q?y+1WwOqv1DITnyv2qU2uWilfSd3ATSU3RwQ/wwwCOs9SmcbEOE3rW07HmnEY?= =?us-ascii?Q?I3LBDDh0/G5sCgrmQrWqcs4sSO2rf1u0bTY7xJE+XyQHVnmcJRNVPXxGLBTi?= =?us-ascii?Q?2G0CrQKXiECJ44DcOqnsjO6Ni6P2EsK+2vQSnz2aKa78pyTAMwroI7DPaoLK?= =?us-ascii?Q?x99w/MrUwwak6hqfawMr0rUV6VdcL//ceG4GTNrJW2h8h/XzLk4MIYd0ElOz?= =?us-ascii?Q?7z8lOViKZdu1rUlq4+T3sQk3xKhBD8StSCmOzbd7hI9vX8D80ZXE/c9y5ZZC?= =?us-ascii?Q?wcis5mkaU4wZAC1s2st/UHkIKAMJQUOc2jeUX3QRSUhdBTAfkI7Xd33o1LcQ?= =?us-ascii?Q?mHcNSeAM87IalvVnetGw9+RG4cS+cyQKyRpWEwbOooeVX+w5isL9MSXvDzJT?= =?us-ascii?Q?5NCppuzKFxEFLSl32JIAJBq9+5pv8qTy1nzEbXNgW2p8y8J/YKQujNsmzC/E?= =?us-ascii?Q?wREK2bMQvCdXMOO7i7ORzciA/xMMhN6PfaM4hIYEF8kxK9dLCu1K8waeZTux?= =?us-ascii?Q?7PjQodkEdR7IlIvYNu4n4ZPZ8s19eciO52Yjg+0R3BJUtIw/x7KRNNAver87?= =?us-ascii?Q?QlZvySUVj4BrvxWgIK6ZiWr0RawZG+3lJjgK5bg1wvOkQtwBobWE3zHJgWvL?= =?us-ascii?Q?IFZIrBp5UKPSD7m0r3YkqSXLlyPlb/jpF86ikGoSe7LbW9xwlTDC/S8JGdpw?= =?us-ascii?Q?OzCJCAN0KeIIfyu92JQ55a/U7X6O7gSuuV1bNGrLw7ocHzbtRk+9wmK4q1Io?= =?us-ascii?Q?5cfXl/7B56FHelNLtsRTN39uF08oWXpcEdZYOAjp?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4564.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 611f3625-80f3-4f8c-d3cb-08daf2ed23c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2023 09:29:14.7301 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AxKw69tV3q2/EHA7fO87gapY44BCBIpz8vboD1G34BTtIzfEUsmaWaVZOxRDhO7QKV/uktKcTr2yv05ex4UN9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6306 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tom. > -----Original Message----- > From: Tom Tromey > Sent: Monday, January 9, 2023 8:29 PM > To: Rohr, Stephan via Gdb-patches > Cc: Tom Tromey ; Rohr, Stephan > ; Simon Marchi > Subject: Re: [PATCH v3 1/1] gdb/dwarf2: Fix 'rw_pieced_value' for values > casted to different type. > = > > There was a discussion with Simon whether the value cast should update > > the enclosing type. Simon tried it out but as I understood he's also > > not clear on what the right answer answers are. From my point of > > view, this would also be a separate patch. > = > Ok, that's fair. > I think the patch is ok. > = > Tom Thank you for your review. This is my first patch. Can you push it for me? I don't have any write access. I plan to upstream more patches in the future and would like to have "write after approval" access. Could I put your email address in the field which says "email address of person who approved request" in the application form at https://sourceware.org/cgi-bin/pdw/ps_form.cgi ? Thanks Stephan Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928