From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2061.outbound.protection.outlook.com [40.107.220.61]) by sourceware.org (Postfix) with ESMTPS id 7DD453A19826 for ; Thu, 12 Nov 2020 21:29:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7DD453A19826 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=Zoran.Zaric@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Thgm4delSBrQYe2hihMt0zs2rvOr2epm02Y2TaS3EVbKLKySkG61Zb84LrF27//arorRjyLjis84ZqAO2E24zSezXVaM0bQ95ZL8qDhyt3lfmjjQPiy4i0MakoYBOZDnsFNtM6s9LLEE3CQYkuL+n2gLDDoDcClhzZoU7LXG4aODSEkncSN7LAikokPNyuGEbMweJD1BEG/7V9j1UEV0WGKah6za4Qpnr2X/ccXM/U2RqA1CyCWM/2XGsRvuZ5k+XQk0zvXc3xwxwgiWQTTUNrkEYo7YN2ZaSVL4fpTlbzDFJs8I+cv9iq1GqAyk6FZGGVqgCdA2Izn8EEcArNOgEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C1FsFqG8F4vriSUg4bJZOhLxxhmFEvWtnwQ5niUdUOE=; b=HjYxCvm3gear/TvE+LKQMQtOLAFC2H2ilrqvG52aJlt3CPFEOhPAMxUp9jUUYnqw5o1blSVuF0ePHgdgy+d8ufW8d/PYXJEAtTjfxv1cwlBcu5zh/90XlG45hvTYrL6ezH6Ve94OLwFUCvhIbRJa/F4PqvrMJDN920Kxi80vGOjXY3R9yI8smIdkjdABxEpZjtlx0biKW4FktI/7umHUBTREMfJX3Q0RnG4GLdcxVLnD9ReHm6cXmi7alizLXjYuLMe5MtrureTHm/cnWnBCAKGT+Xf69VsmxqrHtvbsPidWS83K7xL3Lh0TLUH81bYQfdYIxACrhck8pyIEd/m5Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C1FsFqG8F4vriSUg4bJZOhLxxhmFEvWtnwQ5niUdUOE=; b=PBUosLhMzD/SSmS4TvQ+Fch9m0S5G9jfuAd5HhizZvHtPQF8Fpljk5hCDhWLG2AM9gb6nh0Glnf1bLaBKbw7cYlP6urWYqWumbdi5KEr3c1LuFyrBVX9noCmN0p93bK6SAdxdkEcFZxg/QR20zGKavJ9y/d1CT24Afi78EFxCE4= Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM5PR12MB2344.namprd12.prod.outlook.com (2603:10b6:4:b2::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.24; Thu, 12 Nov 2020 21:29:25 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::d85e:8fb6:ec3c:755]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::d85e:8fb6:ec3c:755%4]) with mapi id 15.20.3499.034; Thu, 12 Nov 2020 21:29:25 +0000 From: "Zaric, Zoran (Zare)" To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v2] Replace the symbol needs evaluator with a parser Thread-Topic: [PATCH v2] Replace the symbol needs evaluator with a parser Thread-Index: AQHWnM8BS9sMk1Du9UuvdFT6FSm/xanFJnFzgAAIqnCAAAuroA== Date: Thu, 12 Nov 2020 21:29:25 +0000 Message-ID: References: <20201007172613.21868-1-Zoran.Zaric@amd.com> <87eekycp3c.fsf@tromey.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Enabled=true; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SetDate=2020-11-12T21:17:14Z; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Method=Standard; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Name=Internal Use Only - Unrestricted; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ActionId=245ca809-b265-49a1-a059-00007903ed1f; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ContentBits=1 msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_enabled: true msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_setdate: 2020-11-12T21:29:24Z msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_method: Standard msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_name: Internal Use Only - Unrestricted msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_actionid: a67563f6-5c29-4616-b64c-0000a1689b75 msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_contentbits: 0 msip_justification: I confirm the recipients are approved for sharing this content authentication-results: tromey.com; dkim=none (message not signed) header.d=none;tromey.com; dmarc=none action=none header.from=amd.com; x-originating-ip: [2a00:23c7:5a85:6801:c060:8992:cfbf:e80b] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 18ccf5b9-e6f1-4512-005e-08d8875207aa x-ms-traffictypediagnostic: DM5PR12MB2344: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V0WusXZPUw4LV6Fw0B6TvI1L7cCg13UtsYwY61KS9TVUkVuXxbZhLGi3AhvrLxLQpM0H3rf55P7dqp1wjEWOhnvhxBd7w3CTOLMln1M/DG9kyA6E1AIOWuUUTXe2buuIearApwTUNxBkLYTAR23OBSLjUo0R7GiWGjUu43PqupXoVvTI1VO5dfobZ/ebnLzyYKN0va/Xrsc2oAIyeTz7ZR1jmyLdJj9eAVkZgPDS55tW1+44bTjLlbkdzRU2cVfR8k7/v1ChrMvpa9DGEImq75es0W863mVqE/qz8cAcbPYER8PKoudIt9jSISK5d0rXXjIs8EiAlzCSQbhdYOZ+GA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(136003)(346002)(376002)(396003)(478600001)(76116006)(316002)(33656002)(9686003)(186003)(6506007)(8936002)(55016002)(5660300002)(8676002)(71200400001)(64756008)(86362001)(83380400001)(2906002)(66556008)(4326008)(7696005)(6916009)(2940100002)(66476007)(66946007)(52536014)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: tLhLBSZLjF1VBbhGI8yoj3YX4Q9HhD5eWw7Di/ZI+W7N2vdE+PwAhGHRNypVU6H1gKlQ8uoyU2CLdUaYo1o+yY42sKUtYDXjYR3ye3fKV61X3HnJzzgYmrnqJuVOVq1WM1e07ssCPgdx1mUs93+oxTTfzEi1uodRPawEz7D9rirwemPk6q9m7aKK/HiPZXCwv5+bwKa3oWAd/7COaRSV3iA1ntSLLhiAD9S04iItVAOEclrhTb5ITB/dl0WyGLehnIfvDKgcOn0yM7nhD1U0jtq16STYnXYqn/mq09DHVsNTKtVFHEMCWHBJ/4+fIxh2Ri4EYktfN8MsdOXc56MBfAsWd2dYVWf+YiAGsLwkMvwGo7bDXD1jEJ6ONjusu5lJvq3qOolYjlDFSrhj1qC3lNDGX+KsFOr/YrA7i3t5/atkElSSXxVsLvFLiA1xc3mFNhp9iXNGUG8y5+r9jk2I2LoxN5EkYkjczlWKAmG0cQpj7yhtt4T8KqK8V5/wqtiVua79Qne7Pi8lgkAn7zIeyhIIlhSe5N54nM9xRUQ4FcX6/K8cpsPDDMrUbjCrKIBOQbam2TbD+7zCnsBmXpdvQ4M5CfDSoOsbVqoSA9NPXFAf/e8559MijIfFUU6p6psSg7jRT3pS32VW8kNTQ2CSWUfEWoqhibP4g9OWP+KW4zhRRmh6l26jVfbFsn+qwgpwSI36Gugi1BHTKOozNZUU/A== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18ccf5b9-e6f1-4512-005e-08d8875207aa X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2020 21:29:25.7895 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 39KNDUZKZDAI2ylmsPn3GSEe+00hbOHQzD++3fGbbeo7Lso8Ptlm0jixFDRskTLa34Qvhlh+cP9DosUKaC6c0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2344 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2020 21:29:29 -0000 [AMD Official Use Only - Internal Distribution Only] > > For gimli (again) we have a maximum operation count to avoid this kind > > of problem. gdb could do this as well. > > > > Meanwhile, about the linear scan -- it seems to me that nothing in > > DWARF requires (1) that the expression not contain embedded garbage, > > and (2) that it not be possible to branch to the middle of some other > > instruction. (If there is text along these lines, I'd like to hear > > about it; I looked in the past and couldn't find it.) >=20 > I am not sure about your point about expressions not contain embedded > garbage. The DWARF expression is a byte stream with clearly defined > content for every operation. >=20 > Regarding jumping in the middle of another operation, this is true, DWARF > doesn't prevent that or define what is supposed to be done. >=20 > And I agree it would be really useful to have a checking mechanism that > converts that byte stream into an internal representation, where during t= hat > conversion we could check and report all kind of things that can be wrong > with the expression. >=20 Sorry Tom, I didn't get what you were aiming at by the 1 and 2. To late for= me I guess. And yes, my scanner would have a problem if somebody used DWARF like that, = and it would behave differently then the evaluator, but the previous evalua= tion (without accessing the target) would hit many the same issues as well.= The only issue that it wouldn't probably hit is if the absolute jump would= jump over the garbage. Zoran