From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2057.outbound.protection.outlook.com [40.107.243.57]) by sourceware.org (Postfix) with ESMTPS id 773BF3856DE8 for ; Fri, 15 Apr 2022 13:33:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 773BF3856DE8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kmqLSdfis7K7I1HfT3rMSyZcYNgEtGeD/HmpzTz9qFUs3TwSAqepNGyftwBui6pI7IQ+lb3e3iIq0nQRXfD818iO71nb2plUZqkfjWKvHuORvsLPu0E+zJ4Jph8g9EDPW5mIf6zHsdAYH7zrRJ0LIFIHHrej0CLocHwBEdNLyWoenfCjyAJjBRG76DAK8fCBApwurOSKGYnl3dlwp7oF1BDHmiFZgKAASzsTVULre5qVpCjlgvWhrc2fwnAyOWdQ5Wh5goluWj/7SMeHbB7WsEqII507SEIkLa79GrsLiZz+zpxzn20QJKYzRTSU2sKKr7J/XEVwH9HuVbM2ToL7KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6rI7IaYHw35LUcLumL9f3d4BaXvEXOCd76o5ttSztgI=; b=jHmo2sQ5GyYcFVFnQwQKVf8uUGC5+BasFMNya9sUyWQ7myecLPiocwoydv9c4Z2yNq4TJtJ74Jr9NNaI7xsmcylDlDFaM+RYMjXgtIWg3D0W00kMlWfyZ97d+U5/jrasAqWmnuWDt8sv7CW0kE4pYulSEwrHpyvDTg4a/hKWRY5hU16dX5eAE8gkEshAkBJdgMW7nhrPLRqWRkCunfyFVUhmGeX4YHadRMeHxKFEwX/komcFs/DfzibHDpWOdZs3xkIPKZR8PRdXhb87/o0wmmpknE32wr7+TL/cudc2B1Ny9qhxg8ONx75NNYd6/j4TvDELk6FdR31a/T1iA8S1Lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB4219.namprd12.prod.outlook.com (2603:10b6:5:217::14) by DM4PR12MB5149.namprd12.prod.outlook.com (2603:10b6:5:390::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Fri, 15 Apr 2022 13:33:03 +0000 Received: from DM6PR12MB4219.namprd12.prod.outlook.com ([fe80::1811:c817:6ced:7312]) by DM6PR12MB4219.namprd12.prod.outlook.com ([fe80::1811:c817:6ced:7312%4]) with mapi id 15.20.5164.020; Fri, 15 Apr 2022 13:33:03 +0000 From: "Potharla, Rupesh" To: Kevin Buettner , "gdb-patches@sourceware.org" CC: "George, Jini Susan" , "Parasuraman, Hariharan" , "Sharma, Alok Kumar" Subject: RE: GDB/Fortran: Support for Assumed Rank Zero. Thread-Topic: GDB/Fortran: Support for Assumed Rank Zero. Thread-Index: AdhPHIhtItVA7FXxR1mxw9qPo/2AqgAR6eyAACFjbwAAFzg+gAAf2jGg Date: Fri, 15 Apr 2022 13:33:03 +0000 Message-ID: References: <20220413112753.4c6f1128@f35-zws-1> <20220414142845.281b878d@f35-zws-1> In-Reply-To: <20220414142845.281b878d@f35-zws-1> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=true; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2022-04-15T12:40:47Z; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD Official Use Only-AIP 2.0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ActionId=12efecd2-28ed-409a-af2b-46f8b79391cc; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=1 msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_enabled: true msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_setdate: 2022-04-15T13:32:58Z msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_method: Standard msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_name: AMD Official Use Only-AIP 2.0 msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_actionid: 0d324fd5-058e-4833-93c0-bc2da084eca9 msip_label_88914ebd-7e6c-4e12-a031-a9906be2db14_contentbits: 0 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: af58c450-b27e-45e8-8e39-08da1ee477ad x-ms-traffictypediagnostic: DM4PR12MB5149:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Oxjrfm7RERR25Cczlzk2rn/SqoCFI9FrIiNCQAvurbXC8KZMxRQbmVsSOH3I8BlJkjc3TD4jKdUOnR0llLDAK9bpMKQamNdeklIYsZbsuuJGzZaqvWbVsUsVKyuGTeolcS7qvrwYazsK3tShCy22p21a4MRF2avbtx/9R+sCru6dfx4WGDhhOWTYkbelB/f3IovpCzKhpdNg395ORw+xFdx0R0dJj1OmSWu4KlyOjBy0Kd0TdMdsH4OE4V/JA6uYV2vgi5TodUmqmhrGuFKAU/Dk8JvmJvDSre8fzb8nqesLGN4w9GdhLZ7yY5jXqOQdiw2LD5DAkiu8cszHCW0ZVwmIsmWBlCf7BHME6ugsD6m/Tts2TY+YJb52Ikr1hPjGp5u+IFcMVg5Wnzc2kqmcjNTIN3US8Hb+WlZVI9uZFDI5C/rWrHEWCEddN/zrul4ejeQg7mfJxHHO6bPBjj/MrmKx3LmyMAj9kLnFsHkwu5h5PBNRKCEmAmYVQrx8Bu32lUBG17SM4uMxIgNtwaZXHNtQyZUd1RvQLuJ0rO29BkOgGsMFj5ZbFLFuWplnKz8bptPIdKpXCRuHcB177xv1aVyuXpq6e7Vnydno45HujvzgtUehFh+GKLBSAJ2Ua/eftM5eh5w8yjQY3Ew7bGskms6dzCiJhUHc3v2MovUSpThX6TU+vH0sb07m0JY9xzRZOddWHJLofjIaKvEvNQ/AJsbGE4qoe8qlfUfDjmoXnzr77xpdpUThqKKr/GyirqV/Wyp8i9MM6efsApei3dUMzqBrg2bInHXEk47hu58UrHHg8/24crdJgNx9lif26BVHb1MhsY7yvxWLh6kFUSX/fw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4219.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(316002)(186003)(76116006)(66446008)(64756008)(66946007)(66556008)(66476007)(33656002)(2906002)(55016003)(86362001)(45080400002)(53546011)(52536014)(8936002)(54906003)(8676002)(4326008)(99936003)(9686003)(6506007)(26005)(122000001)(55236004)(110136005)(966005)(84970400001)(83380400001)(38070700005)(38100700002)(508600001)(5660300002)(7696005)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VHTV6f4/t+qwCWcQuwBT4CeJaZPmnr0fhtJdM5/HpasxC3K5T9Zgw5cV8NFW?= =?us-ascii?Q?35tAdm/g9k/n4xewx7MI7qHKOFO/dMuhrPLI0QO5z3GOLsk+B/FrOLT609rJ?= =?us-ascii?Q?pmeex6S7Sg+d/NSWo3tFE/DEqenNrkEZdncHA3w12U0a1lMNp+Uqq5npNcds?= =?us-ascii?Q?wCTNqQNcn6rBFblv9sR6x2up9bQpzrCjDiP+mjFzYRs1kBkXI8TH5m5RMYkY?= =?us-ascii?Q?Wiv9xxEuXT0CrKXpVMgUUOYusdRjU4KZAQtE/l/EFzIVpdv7+LTl5ZdgS5o0?= =?us-ascii?Q?ZpPC/uzU3d7Y0IXtBPwOZbf+e2OOpksVf/DPzpazS+djOWg8h2tTqV1Hmple?= =?us-ascii?Q?gXzthjkK/YwDrs3aBH07x937cDQBBetb4BLu7R4G8jfnHtw7s5vqkoCy1rZm?= =?us-ascii?Q?CjY54eCvwR2dwJaKoMQY0FFTZNfRIS/D8p17TQ9QkbSw810hkzO4aYfeo0A3?= =?us-ascii?Q?gTuk/82nZVyPKvc6f7YgmNqTx2DpPJKEbfPE+a+i9pVymHbPA1ZxVFIZ434b?= =?us-ascii?Q?Py+xdsj3vtqTXls7AcywcxsXsvDLQ7IjMjNiXvnKtgBcuOrzgsCHXvPap4FU?= =?us-ascii?Q?273/js/ffDi4GZTGRX6S7Pbkq7bxQhChEjgmJEGsg5RWxHl/Nfk8Q92S4kl1?= =?us-ascii?Q?nVekyZPmnwTqb91lOpIVakXfZ1JbaBbIENufXT+356I25F3Fe16sGIYTDzZh?= =?us-ascii?Q?qAF6Sx1NwlUFA94hVVa1CxUHykDjG8WcDKsmIHmIzOQmfmArDgb2IMd7cwmA?= =?us-ascii?Q?ayYZftQO5YfmPrs6qvPi5yg4eYZEsnDriy/YwXhRfMRrLlLVQbguYtYYuhYt?= =?us-ascii?Q?hznSuZy4YB6UL8ahOeIPtLk1HBblK9/s4olsgBdhPwiHNWzr+r/cMrW+Psw6?= =?us-ascii?Q?ZamKC3td3+G6gmnjzuPt895bRvBTH4xaYGUQ2gaH6DXhxLFHFbH3gOSb3T+U?= =?us-ascii?Q?2OF8WyIh8NXS12QdNw38RCeaFcQUJg1OfoigXtVvB9ef1T53JQPkfNkIrsun?= =?us-ascii?Q?MI9cjTNUZ7ZeCShTVnHrbRSspR84UMSpp1WHTm/UoOfJ/8dh3Pa54cxVo6iN?= =?us-ascii?Q?u71Bzt9WOtQzFQeoGWwsxQ68+WZn4oUDD8Imsui4xx5Wfe1vQkPZbRtsQqog?= =?us-ascii?Q?E8DcvHO6N5wFRZZZTlhPl/+CioyLPfic/bChJOIqiamtWowQX1vm0/RH0jCe?= =?us-ascii?Q?/UsP2U9rDRVaac8Ym6wAnsYv0us03z6FcLYRK4UpDJgMJ7jDE6vtzoxSlYW5?= =?us-ascii?Q?oRYDs8I7Q8FrCngaWSW2XvxW0/2UPk4Gj8BrWa8k9s/XigCPMqvMDE3ydp3z?= =?us-ascii?Q?B7HaukNYQ+vIe4DwMhx85Ni0bAyRjw3EbIyrzF5s/kUCEPq46LsXksI9sGKs?= =?us-ascii?Q?K7ltkSWQK72mz/Vf9go4P0y7B2nmlO+LX7foLwLDZNYl12l/1ZEhT+3ALK0b?= =?us-ascii?Q?9Uu9Zm5ItjEvjyX2+12+yuGU5NIWz/h4QALIvwBMmMTuan1Y7B/l+YA4yY1L?= =?us-ascii?Q?Hro7LUmP5s9nnXcBvL59bocefURWQR052KAjlrPidXHpyLImDLwH71tLaegi?= =?us-ascii?Q?nVxU5B54CEeZrE5geCAD0w+A5M0OFIM6XLWGdlMb+NaMlsKFoQoDmvFVEUBm?= =?us-ascii?Q?g0u3H1dvVjnBBtMKrNKRjyMy21oN+w7GFX2G3MauCVCoOyF0qeYLj3tqj0N6?= =?us-ascii?Q?7VtD953wn5x0lEF4cAyVkz8vwA47TJnNy5ZetC7KkCjeoBmV?= Content-Type: multipart/mixed; boundary="_002_DM6PR12MB4219E59D02C742BBF43B749EE7EE9DM6PR12MB4219namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4219.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af58c450-b27e-45e8-8e39-08da1ee477ad X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2022 13:33:03.4804 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7tDIGJTlYOofcQoKyjDhxDVY0/MUccejj0rumhkYuSiuVQLZ52OyPc6LPhjPNF5r5L3DZanSPO5V88GrggKA/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5149 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2022 13:33:09 -0000 --_002_DM6PR12MB4219E59D02C742BBF43B749EE7EE9DM6PR12MB4219namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only] Thanks Kevin, Apologies for missing out on these minor things. Followed GDB standard for = comments and updated the attached patch. Regarding XFAIL for flang, I looke= d at all possible cases in the testcase where this can be handled and came = up this solution which will not suppress the actual failure case. As the is= sue will be fixed by the compiler soon, added the condition based on test n= umber. =20 Manual testing -------------------- ./flang -gdwarf-5 assumedrank.f90 -o assumedrank (gdb) br test_rank Breakpoint 1 at 0x2024c1: file assumedrank.f90, line 46. (gdb) r Starting program: /home/rupesh/rank/binutils-gdb/gdb/assumedrank [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Breakpoint 1, arank::test_rank (answer=3D...) at assumedrank.f90:46 46 print *, RANK(answer) ! Test Breakpoint (gdb) p rank(answer) $2 =3D 2 (gdb) p answer $3 =3D () (gdb) ptype answer type =3D real (:,28827820490920:20) (gdb) f 1 #1 0x0000000000202380 in arank () at assumedrank.f90:34 34 call test_rank (array0) (gdb) p rank(array0) $4 =3D 0 GDB testrun ------------------ make check RUNTESTFLAGS=3D' CFLAGS_FOR_TARGET=3D'-gdwarf-5' CC_FOR_TARGET= =3D"/home/rupesh/STAGING-BUILD-2787/bin/clang" F90_FOR_TARGET=3D"/home/rupe= sh/STAGING-BUILD-2787/bin/flang -Wno-unused-command-line-argument" ' TESTS= =3D"gdb.fortran/assumedrank.exp" Testcase behavior without XFAIL for FLANG=20 ----------------------------------------------------------------------- Breakpoint 2, arank::test_rank (answer=3D) at /home/rup= esh/rank/binutils-gdb/gdb/testsuite/gdb.fortran/assumedrank.f90:46^M 46 print *, RANK(answer) ! Test Breakpoint^M (gdb) print rank(answer)^M $1 =3D 2^M (gdb) PASS: gdb.fortran/assumedrank.exp: test 0: get valueof "rank(answer)" print answer^M value requires 3516574024176 bytes, which is more than max-value-size^M (gdb) FAIL: gdb.fortran/assumedrank.exp: test 0: get valueof "answer" up^M #1 0x0000000000202410 in arank () at /home/rupesh/rank/binutils-gdb/gdb/te= stsuite/gdb.fortran/assumedrank.f90:34^M 34 call test_rank (array0)^M (gdb) PASS: gdb.fortran/assumedrank.exp: test 0: found the name of a test a= rray to check against p rank(array0)^M $2 =3D 0^M (gdb) FAIL: gdb.fortran/assumedrank.exp: test 0: p rank(array0) print array0^M $3 =3D 0^M (gdb) PASS: gdb.fortran/assumedrank.exp: test 0: get valueof "array0" FAIL: gdb.fortran/assumedrank.exp: test 0: answer array contains the expect= ed contents continue^M Continuing.^M Regards, Rupesh P > -----Original Message----- > From: Kevin Buettner > Sent: Friday, April 15, 2022 2:59 AM > To: Potharla, Rupesh > Cc: gdb-patches@sourceware.org; George, Jini Susan > ; Parasuraman, Hariharan > ; Sharma, Alok Kumar > > Subject: Re: GDB/Fortran: Support for Assumed Rank Zero. >=20 > [CAUTION: External Email] >=20 > Hi Rupesh, >=20 > After reading the comments more closely, I found a few more nits; see > below. I apologize for missing these on the first pass. >=20 > I also have a question about how you're testing with clang / flang. >=20 > Kevin >=20 > On Thu, 14 Apr 2022 10:30:38 +0000 > "Potharla, Rupesh" wrote: >=20 > > If a variable is passed to function in FORTRAN as an argument the > > variable is treated as an array with rank zero. GDB currently does not > > support the case for assumed rank 0. This patch provides support for > > assumed rank 0 and updates the testcase as well. >=20 > Please put two spaces after the period in each sentence. See: >=20 > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fwww > .gnu.org%2Fprep%2Fstandards%2Fstandards.html%23Comments&data > =3D04%7C01%7Crupesh.potharla%40amd.com%7C0702c595b4bd4a5c196e08d > a1e5dc536%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6378556 > 85341831678%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ > IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=3DZExuLy > keRrU7AyRd%2FAMW3FAk3RPLdsBa2GfPz%2FoMLWk%3D&reserved=3D0 >=20 > > Without patch: > > Breakpoint 1, arank::sub1 (a=3D > failed to resolve dynamic array rank>) at assumedrank.f90:11 > > 11 PRINT *, RANK(a) > > (gdb) p a > > failed to resolve dynamic array rank > > (gdb) p rank(a) > > failed to resolve dynamic array rank > > > > With patch: > > Breakpoint 1, arank::sub1 (a=3D0) at assumedrank.f90:11 > > 11 PRINT *, RANK(a) > > (gdb) p a > > $1 =3D 0 > > (gdb) p rank(a) > > $2 =3D 0 > > --- > > gdb/gdbtypes.c | 11 +++++++---- > > gdb/gdbtypes.h | 1 - > > gdb/testsuite/gdb.fortran/assumedrank.exp | 7 +++++++ > > gdb/testsuite/gdb.fortran/assumedrank.f90 | 3 +++ > > 4 files changed, 17 insertions(+), 5 deletions(-) > > > > diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index > > 49ecb199b07..21db5aafc88 100644 > > --- a/gdb/gdbtypes.c > > +++ b/gdb/gdbtypes.c > > @@ -2398,10 +2398,13 @@ resolve_dynamic_array_or_string (struct type > > *type, > > > > if (rank =3D=3D 0) > > { > > - /* The dynamic property list juggling below was from the origin= al > > - patch. I don't understand what this is all about, so I've > > - commented it out for now and added the following error. */ > > - error (_("failed to resolve dynamic array rank")); > > + /* Rank is zero, if a variable is passed as an argument to a > > + function. GDB considers the variable as an array so discard > > + the array type and return the target type which is of > > + variable. */ >=20 > Two spaces after after each period (end of sentence) in above comment, to= o. >=20 > > + type->main_type->target_type->main_type->dyn_prop_list =3D > > + type->main_type->dyn_prop_list; > > + type =3D TYPE_TARGET_TYPE (type); > > + return type; > > } > > else if (type->code () =3D=3D TYPE_CODE_STRING && rank !=3D 1) > > { > [...] > > diff --git a/gdb/testsuite/gdb.fortran/assumedrank.exp > > b/gdb/testsuite/gdb.fortran/assumedrank.exp > > index 69cd168125f..49b03e2f87f 100644 > > --- a/gdb/testsuite/gdb.fortran/assumedrank.exp > > +++ b/gdb/testsuite/gdb.fortran/assumedrank.exp > > @@ -14,6 +14,7 @@ > > # along with this program. If not, see > w.gnu.org%2Flicenses%2F&data=3D04%7C01%7Crupesh.potharla%40amd > .com%7C0702c595b4bd4a5c196e08da1e5dc536%7C3dd8961fe4884e608e11a > 82d994e183d%7C0%7C0%7C637855685341831678%7CUnknown%7CTWFpbG > Zsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6 > Mn0%3D%7C3000&sdata=3DVRqHxcI9QcHWJ3sAPo94R0HPoz%2F6ti4cLsi > WyQWCIw8%3D&reserved=3D0> . > > > > # Testing GDB's implementation of ASSUMED RANK arrays. > > +#Until the assumed rank zero is fixed in clang, XFAIL this case for cl= ang. >=20 > Given that you've already put a comment about this below, I think the abo= ve > comment could be deleted. However, if you prefer to retain it, then inse= rt a > space after the '#'. >=20 > > if {[skip_fortran_tests]} { return -1 } > > > > @@ -58,6 +59,12 @@ while { $test_count < 500 } { > > } > > } > > > > + # xfail rank 0 for clang > > + if {$test_count =3D=3D 1 && [test_compiler_info {clang-*}]} { > > + xfail "clang compiler does not support rank0" > > + continue > > + } > > + > > if ($found_final_breakpoint) { > > break > > } >=20 > I'm not convinced that this is the best way to xfail the rank 0 test. > However, after I applied only your testsuite changes, I couldn't figure o= ut > how to test with flang instead of gfortran. Can you tell me how this is = done? >=20 > Kevin --_002_DM6PR12MB4219E59D02C742BBF43B749EE7EE9DM6PR12MB4219namp_ Content-Type: application/octet-stream; name="0001-gdb-fortran-Support-for-assumed-rank-zero.patch" Content-Description: 0001-gdb-fortran-Support-for-assumed-rank-zero.patch Content-Disposition: attachment; filename="0001-gdb-fortran-Support-for-assumed-rank-zero.patch"; size=3893; creation-date="Fri, 15 Apr 2022 13:31:02 GMT"; modification-date="Fri, 15 Apr 2022 13:33:02 GMT" Content-Transfer-Encoding: base64 RnJvbSA4MTk4ZjRiNDc5MmEzZDM0MzM4MjBmYjY5MTFjYzA2ZmQ2ZTRmNWM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBydXBvdGhhciA8cnVwZXNoLnBvdGhhcmxhQGFtZC5jb20+CkRh dGU6IEZyaSwgOCBBcHIgMjAyMiAxNjowNTo0MSArMDUzMApTdWJqZWN0OiBbUEFUQ0hdIGdkYi9m b3J0cmFuOiBTdXBwb3J0IGZvciBhc3N1bWVkIHJhbmsgemVybwoKSWYgYSB2YXJpYWJsZSBpcyBw YXNzZWQgdG8gZnVuY3Rpb24gaW4gRk9SVFJBTiBhcyBhbiBhcmd1bWVudCB0aGUKdmFyaWFibGUg aXMgdHJlYXRlZCBhcyBhbiBhcnJheSB3aXRoIHJhbmsgemVyby4gIEdEQiBjdXJyZW50bHkgZG9l cwpub3Qgc3VwcG9ydCB0aGUgY2FzZSBmb3IgYXNzdW1lZCByYW5rIDAuICBUaGlzIHBhdGNoIHBy b3ZpZGVzIHN1cHBvcnQKZm9yIGFzc3VtZWQgcmFuayAwIGFuZCB1cGRhdGVzIHRoZSB0ZXN0Y2Fz ZSBhcyB3ZWxsLgoKV2l0aG91dCBwYXRjaDoKQnJlYWtwb2ludCAxLCBhcmFuazo6c3ViMSAoYT08 ZXJyb3IgcmVhZGluZyB2YXJpYWJsZToKICBmYWlsZWQgdG8gcmVzb2x2ZSBkeW5hbWljIGFycmF5 IHJhbms+KSBhdCBhc3N1bWVkcmFuay5mOTA6MTEKMTEgICAgICAgUFJJTlQgKiwgUkFOSyhhKQoo Z2RiKSBwIGEKZmFpbGVkIHRvIHJlc29sdmUgZHluYW1pYyBhcnJheSByYW5rCihnZGIpIHAgcmFu ayhhKQpmYWlsZWQgdG8gcmVzb2x2ZSBkeW5hbWljIGFycmF5IHJhbmsKCldpdGggcGF0Y2g6CkJy ZWFrcG9pbnQgMSwgYXJhbms6OnN1YjEgKGE9MCkgYXQgYXNzdW1lZHJhbmsuZjkwOjExCjExICAg ICAgIFBSSU5UICosIFJBTksoYSkKKGdkYikgcCBhCiQxID0gMAooZ2RiKSBwIHJhbmsoYSkKJDIg PSAwCi0tLQogZ2RiL2dkYnR5cGVzLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxMSAr KysrKysrLS0tLQogZ2RiL2dkYnR5cGVzLmggICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAg MSAtCiBnZGIvdGVzdHN1aXRlL2dkYi5mb3J0cmFuL2Fzc3VtZWRyYW5rLmV4cCB8ICA2ICsrKysr KwogZ2RiL3Rlc3RzdWl0ZS9nZGIuZm9ydHJhbi9hc3N1bWVkcmFuay5mOTAgfCAgMyArKysKIDQg ZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9nZGIvZ2RidHlwZXMuYyBiL2dkYi9nZGJ0eXBlcy5jCmluZGV4IDQ5ZWNiMTk5YjA3Li4z OTViZDYzYTI1MSAxMDA2NDQKLS0tIGEvZ2RiL2dkYnR5cGVzLmMKKysrIGIvZ2RiL2dkYnR5cGVz LmMKQEAgLTIzOTgsMTAgKzIzOTgsMTMgQEAgcmVzb2x2ZV9keW5hbWljX2FycmF5X29yX3N0cmlu ZyAoc3RydWN0IHR5cGUgKnR5cGUsCiAKICAgICAgIGlmIChyYW5rID09IDApCiAJewotCSAgLyog VGhlIGR5bmFtaWMgcHJvcGVydHkgbGlzdCBqdWdnbGluZyBiZWxvdyB3YXMgZnJvbSB0aGUgb3Jp Z2luYWwKLQkgICAgIHBhdGNoLiAgSSBkb24ndCB1bmRlcnN0YW5kIHdoYXQgdGhpcyBpcyBhbGwg YWJvdXQsIHNvIEkndmUKLQkgICAgIGNvbW1lbnRlZCBpdCBvdXQgZm9yIG5vdyBhbmQgYWRkZWQg dGhlIGZvbGxvd2luZyBlcnJvci4gICovCi0JICBlcnJvciAoXygiZmFpbGVkIHRvIHJlc29sdmUg ZHluYW1pYyBhcnJheSByYW5rIikpOworCSAgLyogUmFuayBpcyB6ZXJvLCBpZiBhIHZhcmlhYmxl IGlzIHBhc3NlZCBhcyBhbiBhcmd1bWVudCB0byBhCisJICAgICBmdW5jdGlvbi4gIEdEQiBjb25z aWRlcnMgdGhlIHZhcmlhYmxlIGFzIGFuIGFycmF5IHNvIGRpc2NhcmQKKwkgICAgIHRoZSBhcnJh eSB0eXBlIGFuZCByZXR1cm4gdGhlIHRhcmdldCB0eXBlIHdoaWNoIGlzIG9mIHZhcmlhYmxlLiAg Ki8KKyAgICAgICAgICB0eXBlLT5tYWluX3R5cGUtPnRhcmdldF90eXBlLT5tYWluX3R5cGUtPmR5 bl9wcm9wX2xpc3QgPQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHR5cGUtPm1h aW5fdHlwZS0+ZHluX3Byb3BfbGlzdDsKKyAgICAgICAgICB0eXBlID0gVFlQRV9UQVJHRVRfVFlQ RSAodHlwZSk7CisgICAgICAgICAgcmV0dXJuIHR5cGU7CiAJfQogICAgICAgZWxzZSBpZiAodHlw ZS0+Y29kZSAoKSA9PSBUWVBFX0NPREVfU1RSSU5HICYmIHJhbmsgIT0gMSkKIAl7CmRpZmYgLS1n aXQgYS9nZGIvZ2RidHlwZXMuaCBiL2dkYi9nZGJ0eXBlcy5oCmluZGV4IDc2OTMyOGNjOWNkLi43 NDM3ZTFkYjhhYiAxMDA2NDQKLS0tIGEvZ2RiL2dkYnR5cGVzLmgKKysrIGIvZ2RiL2dkYnR5cGVz LmgKQEAgLTIwOTIsNyArMjA5Miw2IEBAIGV4dGVybiB2b2lkIGFsbG9jYXRlX2duYXRfYXV4X3R5 cGUgKHN0cnVjdCB0eXBlICopOwogI2RlZmluZSBUWVBFX1JFRkVSRU5DRV9UWVBFKHRoaXN0eXBl KSAodGhpc3R5cGUpLT5yZWZlcmVuY2VfdHlwZQogI2RlZmluZSBUWVBFX1JWQUxVRV9SRUZFUkVO Q0VfVFlQRSh0aGlzdHlwZSkgKHRoaXN0eXBlKS0+cnZhbHVlX3JlZmVyZW5jZV90eXBlCiAjZGVm aW5lIFRZUEVfQ0hBSU4odGhpc3R5cGUpICh0aGlzdHlwZSktPmNoYWluCi0jZGVmaW5lIFRZUEVf RFlOX1BST1AodGhpc3R5cGUpICBUWVBFX01BSU5fVFlQRSh0aGlzdHlwZSktPmR5bl9wcm9wX2xp c3QKIC8qICogTm90ZSB0aGF0IGlmIHRoaXN0eXBlIGlzIGEgVFlQRURFRiB0eXBlLCB5b3UgaGF2 ZSB0byBjYWxsIGNoZWNrX3R5cGVkZWYuCiAgICBCdXQgY2hlY2tfdHlwZWRlZiBkb2VzIHNldCB0 aGUgVFlQRV9MRU5HVEggb2YgdGhlIFRZUEVERUYgdHlwZSwKICAgIHNvIHlvdSBvbmx5IGhhdmUg dG8gY2FsbCBjaGVja190eXBlZGVmIG9uY2UuICBTaW5jZSBhbGxvY2F0ZV92YWx1ZQpkaWZmIC0t Z2l0IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuZm9ydHJhbi9hc3N1bWVkcmFuay5leHAgYi9nZGIvdGVz dHN1aXRlL2dkYi5mb3J0cmFuL2Fzc3VtZWRyYW5rLmV4cAppbmRleCA2OWNkMTY4MTI1Zi4uYjkx YjViMGEyOGYgMTAwNjQ0Ci0tLSBhL2dkYi90ZXN0c3VpdGUvZ2RiLmZvcnRyYW4vYXNzdW1lZHJh bmsuZXhwCisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLmZvcnRyYW4vYXNzdW1lZHJhbmsuZXhwCkBA IC01OCw2ICs1OCwxMiBAQCB3aGlsZSB7ICR0ZXN0X2NvdW50IDwgNTAwIH0gewogCSAgICB9CiAJ fQogCisJIyBYRkFJTCByYW5rIDAgZm9yIGZsYW5nLgorCWlmIHskdGVzdF9jb3VudCA9PSAxICYm IFt0ZXN0X2NvbXBpbGVyX2luZm8ge2NsYW5nLSp9XX0geworCSAgIHhmYWlsICJjbGFuZyBjb21w aWxlciBkb2VzIG5vdCBzdXBwb3J0IHJhbmswIgorICAgICAgICAgICBjb250aW51ZQorCX0KKwog CWlmICgkZm91bmRfZmluYWxfYnJlYWtwb2ludCkgewogCSAgICBicmVhawogCX0KZGlmZiAtLWdp dCBhL2dkYi90ZXN0c3VpdGUvZ2RiLmZvcnRyYW4vYXNzdW1lZHJhbmsuZjkwIGIvZ2RiL3Rlc3Rz dWl0ZS9nZGIuZm9ydHJhbi9hc3N1bWVkcmFuay5mOTAKaW5kZXggN2YwNzdjM2YwMTQuLjdmN2Nm MmMxZjNlIDEwMDY0NAotLS0gYS9nZGIvdGVzdHN1aXRlL2dkYi5mb3J0cmFuL2Fzc3VtZWRyYW5r LmY5MAorKysgYi9nZGIvdGVzdHN1aXRlL2dkYi5mb3J0cmFuL2Fzc3VtZWRyYW5rLmY5MApAQCAt MTksMTYgKzE5LDE5IEBACiAKIFBST0dSQU0gIGFyYW5rCiAKKyAgUkVBTCA6OiBhcnJheTAKICAg UkVBTCA6OiBhcnJheTEoMTApCiAgIFJFQUwgOjogYXJyYXkyKDEsIDIpCiAgIFJFQUwgOjogYXJy YXkzKDMsIDQsIDUpCiAgIFJFQUwgOjogYXJyYXk0KDQsIDUsIDYsIDcpCiAKKyAgYXJyYXkwID0g MAogICBhcnJheTEgPSAxLjAKICAgYXJyYXkyID0gMi4wCiAgIGFycmF5MyA9IDMuMAogICBhcnJh eTQgPSA0LjAKIAorICBjYWxsIHRlc3RfcmFuayAoYXJyYXkwKQogICBjYWxsIHRlc3RfcmFuayAo YXJyYXkxKQogICBjYWxsIHRlc3RfcmFuayAoYXJyYXkyKQogICBjYWxsIHRlc3RfcmFuayAoYXJy YXkzKQotLSAKMi4xNy4xCgo= --_002_DM6PR12MB4219E59D02C742BBF43B749EE7EE9DM6PR12MB4219namp_--