From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by sourceware.org (Postfix) with ESMTPS id C059D3857B8D for ; Tue, 28 Jun 2022 09:16:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C059D3857B8D X-IronPort-AV: E=McAfee;i="6400,9594,10391"; a="343376066" X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="343376066" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2022 02:11:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="732674828" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga001.fm.intel.com with ESMTP; 28 Jun 2022 02:11:15 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 02:11:15 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 28 Jun 2022 02:11:15 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 28 Jun 2022 02:11:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cirhyFqIYg5CUsiDIhdMzCdL7js7HBzQJPCcrog0d/ahECZSrUn7leTm+DY8mRjB+vwarj6Pz0nl3z+rQhLZss4JkDlFXGhE5A2+r+HsuIfkopp3kdhfKbbstFlSQeNPcneDE6W0tI73Nokg608hzYrjGIKvZKHL2CqFfrrEwYmNBZDCK8OXeGSd/UpEiM+tEtKZJGtBpqxK4j4SZU+G/uW454gy7NeurKeWS9kCXg/jeR1FyvzmkpSVJ9ulSWJaJMmisZVg4s2NVmIw8NDot6grP11OPapyGFk9AFWztaG6bQSR5yMmIQ4Tf7kZGyS6o1OpyVKefWIb6+P7ztyIfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/LUSR++R1DCSflW1z0evqz5PJMA/kDYuozfxFfwbqfE=; b=W75QoIbw7a1LRc0RYY7tz3lmVP2pIZy//JZPktzRkxKpcBzJqPTswRLRBm6/2qmYgoP4c0YyHVz/dMbZydJ0oFyFxODPfkmzT7f1Za/kcA72ZucyyCVRIEqnUWPPgHMcuAJ15IR+OUrhusMSVb0s4iuZWXZBcMvQuLP+8vud0TEktW3JV2xDT9XDr83tFfgkXsucr//n9JRJw3/EuW1GvHk9syWVjCFjxV4sB9p0FunJUsJY4o4UN+/EHLPlJVnnTKFgjrCquibMcHuqXUWHcW5LJblGQKfijXp+KkI9npWfixhApz98STq2SjZYu2DLG8+NKoC90A55fsQdTXqnLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by MN2PR11MB4680.namprd11.prod.outlook.com (2603:10b6:208:26d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Tue, 28 Jun 2022 09:11:13 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db%6]) with mapi id 15.20.5373.018; Tue, 28 Jun 2022 09:11:13 +0000 From: "Metzger, Markus T" To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v5 05/10] python: Introduce gdb.RecordAuxiliary class. Thread-Topic: [PATCH v5 05/10] python: Introduce gdb.RecordAuxiliary class. Thread-Index: AQHYhi22Yf4bVeIPBE25Ts2r/u0B6K1kd5BQ Date: Tue, 28 Jun 2022 09:11:13 +0000 Message-ID: References: <20220622114340.55830-1-felix.willgerodt@intel.com> <20220622114340.55830-6-felix.willgerodt@intel.com> In-Reply-To: <20220622114340.55830-6-felix.willgerodt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a71a8f52-30a9-49a5-0e12-08da58e62674 x-ms-traffictypediagnostic: MN2PR11MB4680:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dfquzRgB8jN82VzA1PD7hGTQo1V4eCidqenOlQeJAnCOLsu2z2PKXGlxwU6SAPVxOzNEo74gORAZvO/V/Ckmyvit5ofvVrhDYKL7vRYAi6ow9yOA76NvvjxixGp4apoAL1iF7lVw2AFxxysNg60yiO2LkNeEBvlwSO1CODA6ecNAJMZjXKv4HUTrxXCAK/ZbTIOzrPidUhVSvj79WjobWV/GZARENJFpvrXvzlO3RyiVl4xv/giLaNvBKoVeiYvdism+7DOmx3aQmjHbWB50g5nGi2itlGLmealJKcSCr39D3J4V+mOUESOcamPOIOthOHuZywocNdYmJka5kOO4+OxSkN+uV2aIw/nlhmQRVIrPD7Rhif/VW8MUjREODvgdodtWy0o1EVvj7p8ffJzGl+IdDcOPYRkSQyW7L7aHCuXYtwu5wd8Ev/WStCw6/aBfeyK5bggDjnHXFZWRkfNuxEP0a1ss4dOrjN6OGEV56V7KYLzaW/3Blt/6s1MSPPFYxMLHEBt94X3RSRHnUlb1u1+kEOHkedXF/7LX5lt6uGTa+ylDs77cym/2A3l9ISU6AOXbJVcflo0HeUEhnmLhrOEuPo414URjpl4+ZT5hcobyV8zgnoy5KIexrm2tPNeTsnqZTjuYTYezG9Y2KKA7I2QiWcfkSETh2IGqjk4hVH8O444pgy3dmKRoFL39zsSLjHDqFrlAT3wcryB2x0uiDajEN6Nt4AYAEXmYOp3vjr40cRHIlQJBxlw/f5vz+kPTAGVrWTXyEUIBclY0YXbCB7zd42mQQGd9Qj1h8Iq7/kc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(136003)(39860400002)(376002)(346002)(366004)(478600001)(64756008)(66446008)(8676002)(66476007)(66556008)(76116006)(4744005)(2906002)(7696005)(316002)(33656002)(186003)(82960400001)(122000001)(8936002)(52536014)(86362001)(38070700005)(66946007)(110136005)(71200400001)(55016003)(9686003)(26005)(41300700001)(5660300002)(38100700002)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5WX5pBP4VaEICBq3rA7kYMRNT7PkF6TN67385hN1krkMImWKcArcRilXqozU?= =?us-ascii?Q?vFfPWkzap1g2wvuFXmhaBlGYUiI8Xuc8IYgOc7yFnuAhX97/2ymatAPC98RO?= =?us-ascii?Q?y1NSDJuVPNr1+hWgprAeZLWX0C93VVCrxOiPweQYdQ3pz9x2sqQ84H3/TxQ0?= =?us-ascii?Q?v0wwUfI90IebVNzuJ02eCNb8+LocFWdkrzpbeYnFC7v8wQ3qbjQd/b5pjjNZ?= =?us-ascii?Q?UKPRY1+NKMQl0g+sob21LLu+D2m1JEHtQENlQ1e/zMIe9g+pyYVg63ABTScw?= =?us-ascii?Q?2KU1sjHhq6DF90iCBcTG7hboJE3qbJzi7+ssWRp96Ymzsd01Uh4kuI5W1Z4b?= =?us-ascii?Q?S+2Zd2cg1EJgyATXbSrXtGzL8785Nu3FD6BngMFqgOXKi1Xd+Gpxe5cixv3g?= =?us-ascii?Q?KlhfwghmZx95gbHhNNgOp6gAUeK3C6oM9ZgeW5E7GsbMRjkWeZze3cyQE/B8?= =?us-ascii?Q?aP4dz+d6OVSHV4U8fwSZH0w8OdKPj52mlDjhW6k9MTbeh4E4AtsG3+JPUi7J?= =?us-ascii?Q?+nhSV0HMIyKpl+BqOMWEPWZXuXS7uX4TonyhVlpjLk9xGUCnrz89zscov9eD?= =?us-ascii?Q?D70zProfTnWB9sJNPYVAUqCQCDAaVlH9bvjgmWi0aYOHLTgU2Xob3xTTfC7A?= =?us-ascii?Q?d4rmPQNJyWHwC74y8KOjcgX0LmcDd4sEZF6eV/+m9HpOgKJVd+Jk4jxnXpXl?= =?us-ascii?Q?EyVl9ModydKA5EstcGc2FuaBPrXqW8T+ky/F1FaYnNaEv0bP+YBrjA5Y4RGp?= =?us-ascii?Q?i4KxktLVmNIe2jcWrzeQnftaHMHn4KZzV3cT5Y/C391csPljOKdwgoaOSe/F?= =?us-ascii?Q?IP4WIK6On3wCfJWa2YAwuAZmQt+y+vZlQycGtRl62XwqNqmoJQgT/JDXmNkr?= =?us-ascii?Q?9dN15UT95F4sPf8uK1bS20ZuTaJ5SQmNejSaV234NMnjlmAze+rN6N/ObLzR?= =?us-ascii?Q?DsbtzglDxTLxlGM9aznrVzABH+1Y56hgtYFvRocBOSGBqe113lRYmu+W7rk7?= =?us-ascii?Q?yQO2mCRd2GyZRUw72VaPiuRgHbzwDmXd3nNr2/xvR4G9GhdctfvoZnEVWOVY?= =?us-ascii?Q?iOgQwul36JD/FuqrP61jHD5mZ9Nru+DIRp5bLQiHQngLs/67UBJ6CWwk6skl?= =?us-ascii?Q?g53xCq15y0HGvpo+2KwS995fgd85S4odaMb5GIbnbdMFtYFlWtkX8Jom6a65?= =?us-ascii?Q?oc+HomxiQc7IrGQpiMVYyOmcIRRvEfF6q0ujDhX7u2eTTMvQi6fQXpu09LnN?= =?us-ascii?Q?MhN9yGM/ANMjvJOwIDqt7XQ2GfI+vpjnbeul7IaGyKlZZqrRIoQasQ7aRH2z?= =?us-ascii?Q?4rDwyeLDojPFsS6frUtoMQfL6M4Bcby+XiXk3S9RsRjzzcxIdYlw3vOwjNcQ?= =?us-ascii?Q?9bTWoW0K2YXJ42FQAuwwv0+7n6PuFWJ9FKHT0RDytcOZTaqjXdjq8/j8PtyF?= =?us-ascii?Q?y+ytIToPRwYlHYks0c4edjEe46QarqnApsHpB/dNguVF7Lv5/kjB93LzmQXN?= =?us-ascii?Q?8FIBZbDx4bLcvToV7rrgIGDt378uYLxELwoIrmg5+/C3EpAL1vmUoX2KbRhS?= =?us-ascii?Q?rAu3qnfla0ucFkYNbxJOVz4X1cHXV1KriM1A4p6L?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a71a8f52-30a9-49a5-0e12-08da58e62674 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2022 09:11:13.6896 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RRfcGq9ZqnJuarlxGzaV+dPLTxU142JoFZYjJqRnIarok32eEQOzzeMGodtOUyCCq5SaRrN5yZvv8/+V4fQCOc4bhzQHXdj638yaTh9lyT8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4680 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 09:16:40 -0000 Hello Felix, >+ if (insn->iclass =3D=3D BTRACE_INSN_AUX) >+ return recpy_aux_new ( >+ iter.btinfo->aux_data.at (insn->aux_data_index).c_str (), number); The formatting looks off. It should be broken at the 2nd argument. >@@ -64,6 +70,18 @@ struct recpy_gap_object > Py_ssize_t number; > }; > >+/* Python RecordAuxiliary object. */ >+typedef struct >+{ >+ PyObject_HEAD >+ >+ /* Auxiliary data. */ >+ const char *data; Should this be a std::string instead of referencing the C string in the AUX= _DATA? regards, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928