From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by sourceware.org (Postfix) with ESMTPS id 9B8803857803 for ; Tue, 25 Jul 2023 13:30:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B8803857803 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690291808; x=1721827808; h=from:to:subject:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding; bh=ckaevRsP6eO0gUP1tAWzxcN4YTmEiX/GolIU0xvLbOI=; b=kLKStm1CBZusYHnH3NYf6ShouSrb/qeoAVtIQle86L9XCbFfad/xAcdP Lk3ySTfgE0qORhYJO+1lixVZzBVjYmqjbIoosTiHdWFHvMTeE8xailFSQ zg4LQ9MJvQuNe8PbKakDpkuUMyLgoL2ghL9c2muVRZ6MurzBKGXmKjlnF xjUH2DR+CMjigYeBuGU7RLz2A0OuM1LrY4yf/QbXq+yvFoNlFydSXEagR rdQmrww9qjPeuCOsKIKlOsuEdy9HCr8rOkRAYM97DjFfWgahCWSkkichj 1FoUncG0IyU0shYKAv1YiLGMNwbey9OYDozmzAfSCEwl2T23ScgkVr8kh g==; X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="398634683" X-IronPort-AV: E=Sophos;i="6.01,230,1684825200"; d="scan'208";a="398634683" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 06:30:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="839865376" X-IronPort-AV: E=Sophos;i="6.01,230,1684825200"; d="scan'208";a="839865376" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 25 Jul 2023 06:30:04 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 25 Jul 2023 06:30:03 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 25 Jul 2023 06:30:03 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 25 Jul 2023 06:30:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EafCEZik6zIIHQEK4xEMolklwSZfpjmFkpN0nodwcPFenVfVEmjdsZW3P6dVKVy9GL7cufGxWcxAaYjAKzABuyrQq2ZFkJocNlFkiI3I4kyCuGjO3P3QmvIAFfCbzVb/9aSX8iYpKqndgU5t/C7xn5WImc2I+iRWXHjgBcQ26pm6I36xfIF3fb+pRi2RsOVp0fS1tJNQJz2QQ35nkFACrMJIxSHNGqh/oqrpkO3a+QLsW0n0yKIAVZ8m+Gj+4G0g6jlmVgDmvO6yWEhNlLnWNVMIyUgWQIXPVKSMWQylv1UJfVI6VHkQ4lbr29mnIqiAUChsgghVMybbr9kiNkuKLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bAgqlL7ZGKjfXF3Sy0hl7fmUcPnYHML/bln2gjOpP0k=; b=LF3HVm9ouJVGzWQBwZ7dTgWj9ZeNFFYXgUpV1E2RIigJiyQWuX6UsxJS8ok2jQHdbBpZjWf5w0X4yDDdM2jCHcXF8VMW/8bppICvjxMLdoYXefBBYfURhPe5Mb6kc8ObPeeMHxSHYAojyyiFT+VxWLhhS9GnmguXgx1XUDeaf6XPFvqKq3DkZhxVLdDy9Kw8rIy+dD83iCRJn53NnyJmSfT2ENVtPK8wqKehnI8PAQeputFece7BGadlsnWZ5vLoDwg/+4wOxxQTZhSgsWEaduBr4CFjk2aWUwQlxGulTGPvni9kljfHjiorI5+k9iTTD49/Bqf1BRuH108nxQhvHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by MN2PR11MB4517.namprd11.prod.outlook.com (2603:10b6:208:24e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Tue, 25 Jul 2023 13:30:01 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::dcf7:d957:e9dc:2c64]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::dcf7:d957:e9dc:2c64%5]) with mapi id 15.20.6609.032; Tue, 25 Jul 2023 13:30:01 +0000 From: "Metzger, Markus T" To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" , "simark@simark.ca" Subject: RE: [PATCH v10 05/10] python: Introduce gdb.RecordAuxiliary class. Thread-Topic: [PATCH v10 05/10] python: Introduce gdb.RecordAuxiliary class. Thread-Index: AQHZuW790s6vYfLVjEqxNXJw6Dc3fa/KTVeg Date: Tue, 25 Jul 2023 13:30:01 +0000 Message-ID: References: <20230718115637.3531-1-felix.willgerodt@intel.com> <20230718115637.3531-6-felix.willgerodt@intel.com> In-Reply-To: <20230718115637.3531-6-felix.willgerodt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5749:EE_|MN2PR11MB4517:EE_ x-ms-office365-filtering-correlation-id: 5002344a-aa94-476f-cc2a-08db8d133fa3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pPk8NBmXtAz+NOsKnHekQSo3Z1nnYYRzacUYuGynfuJv/sIig/qt5FkYdDPtDzOoahBQLX+6vl7AcCDWHKFvL4j9hZ7i11g3ruUw/lJ/mjjYBZOf6imFoL8vzA5O06YD9lUuTP+kZYgKB1XKwKR8fFkwMyAjlKHT9ddJsW1kDeuSzeZma5m9NVd/JaSIJxeMnNsUJC9pTlO7HmICzHU0A5hAk692o5CHMhpN7aIzen/LbsUxfW1GJTbJ24glufqJaQZftfqzW3fMSi35ouhFGroZ7ajeBvWzeCMLgc0LQf//dAKcUJxomQkDxgrBSg/1fzLcav51tF0jOEypY7ydChTvyrP/0tm4VcishJSDkdMlhwOOggaqKHhDJcOIDSM/JiM6MeOeqTY2o9NW5xCOFQI8NgSwiVY4e2gDq6n1pgUVFCvC5Za+UiTHaN1od56uGKG3/AOYef7JwbvVYNovWn6DDLwut/CHZyWOVj3RbCHJPFZLyHi1CdRkJOvHo2ePkkAvp7rAARH959QYbAYh7xM0f+JS/3rsUUgGK//Vdrw9cXBpEfC3xyDdZXP88cnsS3NT0+o+WzP9fpUWbufVP0OV3Lx/wCcH4cncJ9hmvVuVUHQXFXaiObd9J6mAVyaW x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM8PR11MB5749.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(346002)(136003)(366004)(376002)(396003)(451199021)(8676002)(8936002)(52536014)(5660300002)(41300700001)(316002)(2906002)(66946007)(66446008)(64756008)(76116006)(66476007)(66556008)(9686003)(7696005)(26005)(71200400001)(478600001)(186003)(110136005)(6506007)(82960400001)(86362001)(55016003)(83380400001)(38100700002)(38070700005)(33656002)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MmitZXrF+3jwzP82ZZoTfRsVHzst4ZhofWpC/3tZ6QDSRbKCHPu7FR5dz7oM?= =?us-ascii?Q?QQ6MEVbA3XxLfXunIpNnlp/w0kZa9OajL1/6MaGzcNhf9ZrI+aubJNg7VOKS?= =?us-ascii?Q?6r6DE09iKQnHGCUd4XfawkcNyO3xRR6bZUr4EKlWwn4/dQDNHFdb2pgIZGao?= =?us-ascii?Q?FS+nOMGPxv+aVOYKR331pjM4536asT73AxKvfXt6YxjyfNj1j/x61ZSRkQ2D?= =?us-ascii?Q?rZYNvgy+22D5KTVYgXgRuWr8rzW2nmbITOFzZ1onXvVMCyJg2WP6R8IAu0XC?= =?us-ascii?Q?o6MTzDOIe34h4W8iRTfZ9EW8Tdj8THqBG5g1noL78hOWUcrokNXLaphbVgjE?= =?us-ascii?Q?naZyBwyEsoI7v1YgQHwUdgq8PBYY6qgF22+ZxZ2YtIO+jcrRdLOtEDydPonw?= =?us-ascii?Q?+uKmoSUrE+ShHoNjnjuhonOCFCH7ZWOSy57mm4Y/ogOa/wWjDVcA8TIv+v87?= =?us-ascii?Q?DnhrcJ10xqLvzd9hQqXrvkzlgjd+c/8/+QDHGCEk9XwpdqfZM6Sn3yBlTUaq?= =?us-ascii?Q?Zjlmc8BTppy58qMx1W3cnOCuPyCZtsLV2vB/MhGktrUqos7rk6wQ2z1CJ/VC?= =?us-ascii?Q?/TZ3x/vWPkwblYN0/2H3kPYRkXcOXnon9R8y8VuuN6jfp/Hdw5rV+qwxSPsB?= =?us-ascii?Q?5v4MAzZKFzpntNNzEhEOHxfwj+k3ByDUPCJASdnj6O6FCnG+vV/j/AbZQm0k?= =?us-ascii?Q?iq2iLD8Gf6YEFppHw/USVRKkqY+4Mn0YKh7qkT8dLHWdAVkDiksS8pHtHO8L?= =?us-ascii?Q?IYxAH4jGSRK9pOFGr0jfwKEmGLV3R2JT/bfu46WvzMf1kjiHP7egHhGAxzvB?= =?us-ascii?Q?/eCQpzCc9nT5GA7zFDplUbWRRN75Co2j7VTJPJZ+lwFfTb1Y+SibAWA+3LPm?= =?us-ascii?Q?k7VVPnPvyoE9NO1vCoivUPR7SR0FKNj3cgZLGRNU41UvhIM2loQ0o+FkhQ/V?= =?us-ascii?Q?9pcPpvXfA85Mv+HFn3rkNRdLFmLG5GuVohE/VEoTH73r+8hMRMFE68egJGQL?= =?us-ascii?Q?CvevM73rBDIZA6ebRP9iL/HfNxHr4J0kt9G1u0ShZ89e9BNRmXXwO3ssW0pn?= =?us-ascii?Q?RTS/+ehQLnzOPBlmC7I6N1c8ekB633n9HuNrLd/UrLVJxoqwTx83nBfNiKHp?= =?us-ascii?Q?8ZiujF0rtzotzZD5lux4a0eWqrQbxiGHSzqBwWUbmMsi4oEPsPUkHjEBBuT6?= =?us-ascii?Q?fhikY7o+8jMFojW2jLadiidd10xSTcigXxlu/Zzuc016Df3qBVFf5PMR0XrO?= =?us-ascii?Q?0QA8+B0VFpKO2DKA4/BrM4Dq5Et+pvNnqaEBBD5RmpPPckzRr4WYcsi2jLF1?= =?us-ascii?Q?eULkcTuc3gwYeD0AKrDUdtQPsi8bdHPVHDGs9yhkuDz0oE5zo8YbYn0XIrvF?= =?us-ascii?Q?TULuRkFhzycVKEv/xK/FluIvJOROY7Ss+2AAxyttwx6cIGSWbPuQn94Y9XdI?= =?us-ascii?Q?8t7i1O00IbmJ3NgGU6z87wxYlKgKAhhEcCm+UPS5mWXHO9DwqDY9SmBqG8ox?= =?us-ascii?Q?ULPy4GKpzP0+FjSsOrFtxMzh6EMDfFvJ5R9Ouq8fpoIMIExZfB3uvkvqd/Gt?= =?us-ascii?Q?DFGqWknhsv2bSIsOlNTDLS7fILFvVoz03OhDXT/quGcXME99c5BmtFBCZGlM?= =?us-ascii?Q?3w=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5002344a-aa94-476f-cc2a-08db8d133fa3 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2023 13:30:01.4117 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: R6Kfdh+NX9nQNzA+YgjoXHZXqT1oGtgvU2s5Vv9f1Bf5snORVWH+ERs+4Lig+AMPTIrFhiK8LZATAaxKQgGmhRL6PyPL7b2IGfHfYorviAg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4517 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Felix, >- btrace_find_insn_by_number (&iter, &tinfo->btrace, number); >+ if (btrace_find_insn_by_number (&iter, &tinfo->btrace, number) =3D=3D 0) Nit: how about storing the result in a local variable to avoid side-effects in the if expression? >+ if (Py_TYPE (self) !=3D &recpy_aux_type) >+ { >+ PyErr_Format (gdbpy_gdb_error, _("Must be a gdb.Auxiliary.")); >+ return NULL; >+ } >+ >+ obj =3D (const recpy_element_object *) self; >+ tinfo =3D obj->thread; >+ >+ if (tinfo =3D=3D NULL || btrace_is_empty (tinfo)) >+ { >+ PyErr_Format (gdbpy_gdb_error, _("No such auxiliary object.")); >+ return NULL; >+ } >+ >+ if (btrace_find_insn_by_number (&iter, &tinfo->btrace, obj->number) =3D= =3D 0) >+ { >+ PyErr_Format (gdbpy_gdb_error, _("No such auxiliary object.")); >+ return NULL; >+ } >+ >+ insn =3D btrace_insn_get (&iter); >+ if (insn =3D=3D NULL) >+ { >+ PyErr_Format (gdbpy_gdb_error, _("Not a valid auxiliary object.")); >+ return NULL; >+ } >+ >+ return PyUnicode_FromString >+ (iter.btinfo->aux_data.at (insn->aux_data_index).c_str ()); Shouldn't we check the insn class, too? >@@ -455,10 +511,10 @@ btpy_list_item (PyObject *self, Py_ssize_t index) > > number =3D obj->first + (obj->step * index); > >- if (obj->element_type =3D=3D &recpy_insn_type) >- return recpy_insn_new (obj->thread, RECORD_METHOD_BTRACE, number); >- else >+ if (obj->element_type =3D=3D &recpy_func_type) > return recpy_func_new (obj->thread, RECORD_METHOD_BTRACE, number); >+ else >+ return btpy_item_new (obj->thread, number); > } Why do we need to change the order? Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928