From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by sourceware.org (Postfix) with ESMTPS id 35C69383D824 for ; Tue, 28 Jun 2022 09:16:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 35C69383D824 X-IronPort-AV: E=McAfee;i="6400,9594,10391"; a="282422763" X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="282422763" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2022 02:10:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="565007385" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 28 Jun 2022 02:10:49 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 02:10:49 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 28 Jun 2022 02:10:49 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 28 Jun 2022 02:10:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SaIGcXaMAP5B/viEgRGJRNJDs3vYHKs+VGJHeW7A61FKxpXIXqrf7DkC/fks7P81xxqr7LLw37Q258Ymu/CeJYFXR9vTmaVmF0NWGMOmCWlhlGWDesbK0ftXCaJjNsvPP5Tvg+NWkvB4ztDYFb0gEzo9U7iIr5c2UBtTsCBY7KsxkBsLH/LwTK7cIoqwU60+osb1hcxu5wdNty/aYSIOTBK1mlW9joB+dlTo+Zttxu1dkTdgDcpBCNmpom+S2VqClIxdOhp5rI1DQ64izoGwG1ZsSX+Xb1kctwOBZy4T7CP76Ne646F+gVe8fdPVf1DFnKXeRjMDpd44HQPprl5uZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FDKLUVw9fSjq3+4Rk27rvgksMefYH7eyibGx/Cv/ZgE=; b=EGcEixbSbhTgZEnIsilphxy9tHi+FkeqefhTs0OvBOjD70DGR7+niB6xj/WKnYIUx47PbzxSHpV+rM1byiqpM/DdCvp13GoI3eFowIQE0E8zQ4gmQMkjFGGOzuwUxPZ7jkSbPs5COVfqckSzHRw2D3oDIcdGfZ6HP0+02Dkrcg7x9NX3ymSL5vZQiiBy2RDdsmgEOQubhYpqFFxy6G57hb/YZl+ev37wsm0SDcyuR6TbYs1Xql1JBGsHvHzvudbTTxA6YdMuVTLPmauDq2RM8eVnKnYCH2uh0jSgCSIdlbWLX5aeco1EWBju6RE4Dwi5VxaHwnRKmcPTgY40kvtG1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by PH0PR11MB5610.namprd11.prod.outlook.com (2603:10b6:510:e9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Tue, 28 Jun 2022 09:10:42 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db%6]) with mapi id 15.20.5373.018; Tue, 28 Jun 2022 09:10:42 +0000 From: "Metzger, Markus T" To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v5 03/10] btrace: Enable auxiliary instructions in record function-call-history. Thread-Topic: [PATCH v5 03/10] btrace: Enable auxiliary instructions in record function-call-history. Thread-Index: AQHYhi2q1GjH+C+LgEydgtFOIqB0aK1kbXJw Date: Tue, 28 Jun 2022 09:10:42 +0000 Message-ID: References: <20220622114340.55830-1-felix.willgerodt@intel.com> <20220622114340.55830-4-felix.willgerodt@intel.com> In-Reply-To: <20220622114340.55830-4-felix.willgerodt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b7497672-959c-441c-1a38-08da58e613f8 x-ms-traffictypediagnostic: PH0PR11MB5610:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: X9eoxavT5b+/Nv3IReQB3bjo/A7kbrdXnc4bXSS+7PktJJiK5nc982ThbEHbXtQKtOpZLAZywSqYKAwAC335iLnK/vJnsBytKzQr8GvwZH2ThX8BXZWnv1BQhjply9bcpN/lOXAZU1f9KLlkVrH8D1ZofBR7Rm+pMBQiFt6Ow6cBizaxbTUFqxGqiOcCiLbnvbAjGc4GKKvfNyB4WIoYgNWbbO4/NsKGR3kxlxgaKawKZ1JGCiageUF+FgvrzhHYyoEX2aSEWTMaflU87AhXhkSkrik0u4CSG2VoMgz0ExNSK1JRWLbrSt/D6HeElNH1qCpu1OhS0hjZ7/POmStoeQ3TuRl1ZgD8xAyZPt4H0U+2LjEPBw3zIldBZrZo2vMaE1PqnD1JQCDllG5gvyHHMLqHW3IanjeeS75l14UTs1w8oIu9Oi2xGXlPtI+ktSpsKEALqTy+XL53XCD5hqjf6o4vqJEA/NJHuBc5XvKjF9UM8Okpmpf8Iu5AAfn2ArrILf5s68rnW2C3XYV+uFqnZi8vv75I/qaG3JXBd88Ab4JiwL0eBbq65JKtICkdB9/dZ7WfcI0M57WJ620iO7OwM/7DSQd6kkKjhcj1IZ72WcrWcYIrZIUakwntC2GwA8eiwL5wwtCvNXqFFE5Xdr5TKP3jlDTf9n07JrbcyiQo1JGQfeiHrMAlaf11Y8lQixw096lc+bkkzTZ1vaYWpbgXRMNO6gbilqoq+YIR+w6Je4lr44WJ/PZzuOR6nhunrQVHRI8PMgHP3xoaV9PBeJejHW9zvEo8uw544UpRjYBFgx0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(396003)(346002)(136003)(376002)(39860400002)(82960400001)(8936002)(9686003)(6506007)(5660300002)(478600001)(26005)(52536014)(2906002)(7696005)(71200400001)(316002)(110136005)(55016003)(33656002)(38100700002)(186003)(66556008)(66946007)(76116006)(86362001)(41300700001)(66446008)(38070700005)(8676002)(122000001)(64756008)(66476007)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zlUEHSKE7vlyx61/A0unwdHxJppl19dAAG+eVnVwydewBgnnabHcUaafpc8a?= =?us-ascii?Q?vvq3mo6oJSMyeuuvPiadzjCp52eFbrEKtM7crZYEcuTXhrTgyR0kJxzw10E/?= =?us-ascii?Q?EF2wJcAC+aaFVaQ4QOhzW8GD1hf7MHTG2t6KUZ1bKL/EW0GEb2bbGokvbLZA?= =?us-ascii?Q?mymJxCRtE/F+CdBytCkIWIAuwCdWp3KxsqF/YYt9BI7zrtjV+WAiaNbBi81T?= =?us-ascii?Q?Vdbb759bkpIphjFwtwza6eRVIBZava+RMxWh7dklbnvuvYODgvPkEXRiGWi+?= =?us-ascii?Q?9CoeNTvWuu438jGve/2E5tshYUwxq/V1Be/pN9cW0EoV67pwEndZvJfUlpOq?= =?us-ascii?Q?4DTTkEXwSEQUlWVZdznGphpAcfomcANrhn8lEav9QBLluj9OSCj1oEG54U3Q?= =?us-ascii?Q?aA4YipazYajENLTx48/+RDamDD+xPI/j8Qp2HAlVKUa1Fzt1ZAlTfGjwBqTd?= =?us-ascii?Q?lph8/0xDpw69VZpAHael5MweEMVvgvorQiimbpawx/w9OwJQAy7GMFglIWa+?= =?us-ascii?Q?DrhF6TkHy+ZBgLA48efBKBpVTUq9o/vGQ7hJsT+W2BlX0I1QLOD2fyHpj0sU?= =?us-ascii?Q?qwLrCJh23kiaQIVwRIqkFmB+j2YIVr9W3P1BqX8xK+0hMUQCf+nVn/9ptvAP?= =?us-ascii?Q?b/YcWdPbSqdVB23da9reXTD+ZUxSbizxxK7iCZgle5QrtrsIYGAqa1XM5npt?= =?us-ascii?Q?T+vBflLI8vc2w/sXeWsfUIUHd1u6JsIUCKMmXPUkVAtIs4HfL3YRj72MOdue?= =?us-ascii?Q?R7dgu07I4JawviSe/q3ZOjxP9dGrS1Klbn3NgNGqBeRpsI71kSdNG3nCxdfL?= =?us-ascii?Q?GHQ9MntC6y50nQKVLY+SvO7EcCaZkMuRYkG0qHnlgx3XbEAA+Wjl+GIAwO2X?= =?us-ascii?Q?dj2I6X//P53nW8BKg/roWOGhMHVrrkvMfbzJSxpG88g/5tgXnbL40IEaPqH6?= =?us-ascii?Q?Dci/wC+8e6pQSEifi+fonB2ObZSoTKNpolrVWpIm3mqhrBGEhv15err2zFKa?= =?us-ascii?Q?kC1lLNsZdrjD0sr1mmZWVucrNYTiufYRPfHqhnLxQY5+1smeh2hh/ZNQrgES?= =?us-ascii?Q?DKLbAfFHXvLopFBqCbffkukVZIYWms8+Uzkoc3aHLDfyD5b9OjtLhEs/U5QI?= =?us-ascii?Q?RTW/0DcmAYFioFmpCtUKPuf0yHrZEFVZwkj1y7Gx2HRhE3D2adT1PR1fjmeE?= =?us-ascii?Q?Hm5txeTvcbRFqp97NrMb3gcpMs5jIeZu2ig/plGS0V9e2n1pNozvQ6J4AX9f?= =?us-ascii?Q?4Wcz5pjFaSSOKZoNxBo8k5znSwdVcIs89sQPHnoIxwjUjl3FxyWHgN253qlS?= =?us-ascii?Q?HBxI4h05YKvXQ+C+749He1zIzpqsJ2+0wwnGhsk85a51Be4PSp+O4emUwpes?= =?us-ascii?Q?ORDLAlbMVgViUwiTzrt7q0d2Xg190Dfq7qBbGKHUbpWIzaggvifY7YGx9p8O?= =?us-ascii?Q?4k6LhgGQ/tuATuqFEwAPC03BeFSd8WIjObO9VlXBG9bdH9//yX53YhxkMfHl?= =?us-ascii?Q?44W4bLMPTfi+U2wQWgUwCwrrGgvI2YnBjgxcajEHCSjnpfY5MFcYYw94+QkG?= =?us-ascii?Q?aKsZGQbAf9SGtuhOGrJCOTfSE+/H7CHYsOH5+3K0?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7497672-959c-441c-1a38-08da58e613f8 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2022 09:10:42.6939 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gxKdm5xiDJM7S5uFyYErsn/gUa8nO4pIA0A8oBGRkRxwq/D4pJX4uIMmLnxuYmzqNialw7H+t+EpHkue1JEZnLkvkJQuUbZnfww4amrOL48= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5610 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 09:16:48 -0000 Hello Felix, >Print the auxiliary data when a btrace_insn of type BTRACE_INSN_AUX >is encountered in the function-call-history. Printing is >active by default, it can be silenced with the /a modifier. I find it a bit strange that /a disables some output instead of enabling it. Should we change the default? I'd probably always use it, but then, I also always supply /cli. >This patch is in preparation for the new ptwrite feature, which is based on >auxiliary instructions. >--- > gdb/btrace.h | 6 +++++- > gdb/doc/gdb.texinfo | 5 +++-- > gdb/record-btrace.c | 21 +++++++++++++++++++++ > gdb/record.c | 5 +++++ > gdb/record.h | 5 ++++- > 5 files changed, 38 insertions(+), 4 deletions(-) > /* The 'up' link points to a tail call. This obviously only makes sense > if bfun_up_links_to_ret is clear. */ >- BFUN_UP_LINKS_TO_TAILCALL =3D (1 << 1) >+ BFUN_UP_LINKS_TO_TAILCALL =3D (1 << 1), >+ >+ /* Indicates that at least one auxiliary instruction is in the current >+ function segment. */ >+ BFUN_AUX_DECODED =3D (1 << 2) Should this maybe be called BFUN_CONTAINS_AUX? >+static void >+btrace_print_aux_insn (struct ui_out *uiout, >+ const struct btrace_function *bfun, >+ const struct btrace_thread_info *btinfo) >+{ >+ for (const btrace_insn &insn : bfun->insn) >+ { >+ if (insn.iclass =3D=3D BTRACE_INSN_AUX) >+ { >+ uiout->text ("\t\t["); This should probably do uiout->field_skip ("index"); uiout->text ("\t["); regards, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928