From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by sourceware.org (Postfix) with ESMTPS id 4ADD83858C2D for ; Wed, 14 Sep 2022 08:45:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4ADD83858C2D X-IronPort-AV: E=McAfee;i="6500,9779,10469"; a="299186954" X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="299186954" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 01:45:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="720506863" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 14 Sep 2022 01:45:34 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 14 Sep 2022 01:45:33 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 14 Sep 2022 01:45:33 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 14 Sep 2022 01:45:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TfcZ9wLN15sMNYb02wYcDjqamHfAJTUx72MfQpoppfr8CE0AgQm5p6gREw00X5FfYH5HZseY3jHlV40J64byMfcSgS6IUGDVBvkqL/5CEaEGQuDH93QYZHDffWB3hDMO0SKHVwZytV4ZEUtirmHxLnBt/ujNU5GpCl0zoyNuMZ25a1IzbZwEXXw3cHy83isDl6s4zK7IngJ1XUWboGcPVXt1/Uz5lnsT5nEw7mY3hwN5bzyHTsxcysMXNMGCkwnqlqyk9wA0j/nzoMAYxp/6UK6tlqkHDr3qPrT6rURZfiWDtFdDF/QAmlEfHS5ecgMmmpExm7p3PRnciV+GP8Z21Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dT2gahQ14FMqQknvO8dXy7bgHPT4vbVRY5nrc1T7+nk=; b=FnmEf1gZND3JCJeSkiYXr/ub9aVFatXdk/mlyTPLiK4hHvigzhNGTsN28eUtoCt3GSRPJ42aZv4AWUTEqRfNNynfQtfk9D0pI9CX+O8JLznfOqUT4uNjMg8r4s6GBGWbctZjQMx28TpsCE85eU+FoKvhGqVI4n4JfWaH4KuLOU7N96V19gNL5B+j3Vw1qjY+m6rcDWbN1vUzwThEbc8HLZ6D+U5AJo2h4bCoxhg58Fwcncor8+c/5L5uIyoIGND76hbvYw03bVRBd6H9c6kIvZwG+fxAGuCNAZuIs61rgFCtPomjFqnnmhqg7JEG6vDUkageir+C/Ty03UXWH8dL7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by PH0PR11MB4952.namprd11.prod.outlook.com (2603:10b6:510:40::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Wed, 14 Sep 2022 08:45:31 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::31a4:5c1a:9107:3ba6]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::31a4:5c1a:9107:3ba6%7]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 08:45:31 +0000 From: "Metzger, Markus T" To: Joel Brobecker CC: Tom Tromey , "gdb-patches@sourceware.org" , Kevin Buettner Subject: RE: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all objfiles Thread-Topic: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all objfiles Thread-Index: AQHYdo0jKz6X0SPP3kqfqbf3DASq362D40hQgFtU7dCAAAVHgIAAAdIw Date: Wed, 14 Sep 2022 08:45:31 +0000 Message-ID: References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-9-markus.t.metzger@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5749:EE_|PH0PR11MB4952:EE_ x-ms-office365-filtering-correlation-id: 4874ca5d-d816-4f52-e7ad-08da962d7b55 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dRebHvJpV9aPAFgH8ukfgZfHM/++KMwPonDIEtdXaOcqZsDAc+1cSwJ48qyBTGhGFkm18gqyDlVUIALI9prfhQ4pR8rw16cPxBMY1xl1PefnPI0MPBN3ry6yYFf4EoprjF3nMvmXfahL7xM74AmcX39f7LvIZOx7D4lakLtxiOudvO8Am3DCpCHfAWqCWp4D/cWyOf+k9gsf2D2JYbJw+9M/eidll0kSiJRdweaZjkYN6aYySr65VY1NJm1iLzpURSKo1P6c79Kl/hkPwCEXM3sSy0ccFLzOsptSOpFxr2MvxxhZ9BTuhLYO6dYjTTFrFCnoDi4FHe010+zpERqLw5uAP5IUY8t5UcA8pvM2aP0h2dMK9gdNopjmchZ6Qz78prHXQIyiVM5W0pTAcSC9DT5um85YhPaP6dj7YdyMmBAQGf71i2dPTykPkQ4LQhn+uB9MMKwLdfyF+qU0dlisgVq4PfuCijS9oYK018fY/K80ldWjSORman2lOHIoXMydfL7BAG46e9ZfQvHChWX51UvnbYbuDoyiBzbtlMsBOjK7CdHLI2dwofZA5cQaaC29Wvl+kuP9G1jv8Gh1mF9UYfEFAM0pMeqdb4OnWFnnioE3hdR7b7dNFeQt+Rtkj/X8dm2AorFBAAei+QZj2jlLskFT7V4+pnXwdomGUVVvujhWU1SrZE5U2og14WxGHd8YExVTVc+Buk1+sHcpNmptvYyIuAfCJvWa4+YxySeyySIQuBwQMucAuj48EowAs1rmZSRd7rtSoKVnacrib7i6fUDtk+XYuNxoyqJYuCZG7Q4D45TICYwnOjhDAnDeOOdz9QFBTylEryF/2A7lPnX2UA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(39860400002)(396003)(366004)(376002)(346002)(451199015)(82960400001)(52536014)(38070700005)(186003)(38100700002)(478600001)(76116006)(83380400001)(6916009)(4326008)(6506007)(55016003)(122000001)(54906003)(8676002)(9686003)(15974865002)(8936002)(66946007)(26005)(66446008)(33656002)(64756008)(66556008)(66476007)(71200400001)(5660300002)(2906002)(966005)(316002)(41300700001)(7696005)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XlfSkoUvgQmd8nhIhIHvg47xvrsaVOZgGxLXzST+JrnirONo9ZPOs0WNr9tF?= =?us-ascii?Q?nCGRoc49mXzEIw06CH7b7Hv6pXCtGe8q7AQIvEejtuW7jkvHc7DM92loLFt0?= =?us-ascii?Q?fckHLLkw3pJQ72BYpXMCnMOgP9ZfF9RVTdvoGAPxVgBxlZayHNX067hEe6o2?= =?us-ascii?Q?QRM/PS8NUGpYOUQkqQoQFMMT646+d57ELVYdV9yq8QZh8pywb0SNncyq3iH3?= =?us-ascii?Q?yZGVZDkBjhIaLXx1p7znystFBMJOOzhRaXYzt56jCWpnMR6b6MW4r5s4EmTn?= =?us-ascii?Q?YnIYtXiandBqFy5cBCfo2aDSco6+rAbdz80P2lYa6q3PmajFV7I5Bj7AtEOo?= =?us-ascii?Q?4f43BogvQdXnm+QdU67KVCYOTiEe/ejQv+WFUgkqqC6zi0WJF4dqKrhMAO58?= =?us-ascii?Q?saQug/S8r892b3QcMMSZXy9knOM1v6A1TwYHN3y4MNSW6jhAGvBJQcvDp7c7?= =?us-ascii?Q?cYE1azGOlxHjUlOCkep+kyiC6ltph3z2NIpZwzYrL9702E2lxVVQBcjbZ26B?= =?us-ascii?Q?F0snQphQEyRGTcq5dEjxxJLFUav5CWDjgfs/zRqXxAOhtQw8rSiBPMnm0JUu?= =?us-ascii?Q?Hd1aoqzyM0N8a4UYt8aGcCbOxsoPEfdL5I5CRss/2G3/lcnHHGuZNL/Hd0oy?= =?us-ascii?Q?UoONsdWxS0Z7GYpOjl4HMVSnIdw/9ANlbjpCfeUsw9UAdFcixAzW8Ao89Dae?= =?us-ascii?Q?34MMJhytW2lrdePXJXuo5/L3pGXWyHzJS3BRi4RyMx/9aRdjaq0aD9Z0ZGnS?= =?us-ascii?Q?YMQNe5tE5FWaF0a3VqfEJaNBplWJDONEiHqlUl3dOE46iRdxfSUg3aXK+9dN?= =?us-ascii?Q?bReKvXv/5M6EfkzDMoGOi0N8TTJfPH20ufM4qMVDjW3gfXjC0hNFDGNqO02J?= =?us-ascii?Q?APIxDiKx+btOV3CFRDaOb/bZ6SO+t5mJiT7q15JnNfbrmnpgFVXZN7PuFR6s?= =?us-ascii?Q?iC70+7aoIw2RT1WQILHxicKJHHZ9KPRe6+OKpLDMY/g3EQA4rDzYAwxvOx6N?= =?us-ascii?Q?ir3dE2ml4Ki1dgTJVSlVsF/6QeuGlN0FYlTFB5czFQK9Zdai4jDOLDmUvTaE?= =?us-ascii?Q?ycLcjDqc1aEIMgy3mUTBXR+Eg+cekpJVJTgyHlivAqkDsm+cmirQsZZBzsOX?= =?us-ascii?Q?KjvyUDUC+8qL8S0krkhyAoiOfqqWuW+20f9IjBwIq9gVkxMlAmL73j1PlARC?= =?us-ascii?Q?kDhQ0WMjQCOrtCvNWUC+GTlC0R/3CG38W3U9vXK7XO5x7FYwvbm/7VX/ygRo?= =?us-ascii?Q?iM7MFTvz8AzHMlAj/rpLjxO1CfA1ZNBYwT9lAuqdym0fAuaq1BhtW6Jdn39x?= =?us-ascii?Q?qpFbqMFW2TJ5RSHSsl36VKPidbkg0zfsvyj1FB36LTSmq8UtZC+WAlhPTF22?= =?us-ascii?Q?nL9A57YiTyg/Lpyf/DifE2RgCYO7vdcVv3tPMz0d21dD2YOQ5GDkMVZJneRC?= =?us-ascii?Q?pvXdxugFI/O1/6p3AQSxSdQx3g5D8YEmnVxRs794WeMAW8ByIqTw1jxVjU7k?= =?us-ascii?Q?nt8InfbIZvVFCeMbpVTRt2ul0lt7c8bnPEWrQuIQ+YUHt+3evRU5gQHuKDzv?= =?us-ascii?Q?XMB+Rw7tcYlnG6DORTPe3915WCoSVcbf/XBcNHbrvli73s/vnOaXvXHYpT7T?= =?us-ascii?Q?Kg=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4874ca5d-d816-4f52-e7ad-08da962d7b55 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2022 08:45:31.2956 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6efm1RMispSJ0aOEYELYaOwYxMCIQeUsd1d9YLm7yevuJbQs9CKOYfda84By1BIK6nIGhkIwvAi7PZI2pjDq1Mkj5WLaI+Nk73aXnI7j7DQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4952 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2022 08:45:39 -0000 Thanks, Joel, I'm not getting some emails, it seems. Or they get filtered away. Let me = check. regards, markus. >-----Original Message----- >From: Joel Brobecker >Sent: Mittwoch, 14. September 2022 10:38 >To: Metzger, Markus T >Cc: Tom Tromey ; gdb-patches@sourceware.org; Kevin >Buettner ; brobecker@adacore.com >Subject: Re: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all= objfiles > >Hi Markus, > >> would you be able to review this patch? > >I think Tom already reviewed this patch (back in July), and he said >it looked fine to him. Here is the link to the email, in case I am >mistaken: > > https://sourceware.org/pipermail/gdb-patches/2022-July/190855.html > >> >-----Original Message----- >> >From: Metzger, Markus T >> >Sent: Montag, 18. Juli 2022 07:36 >> >To: brobecker@adacore.com >> >Cc: gdb-patches@sourceware.org; Kevin Buettner >> >Subject: RE: [PATCH v5 08/15] gdb, ada: collect standard exceptions in = all objfiles >> > >> >Hello Joel, >> > >> >Would you be able to review this Ada-related patch? >> > >> >thanks, >> >markus. >> > >> >>-----Original Message----- >> >>From: Metzger, Markus T >> >>Sent: Donnerstag, 2. Juni 2022 15:25 >> >>To: gdb-patches@sourceware.org >> >>Subject: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all= objfiles >> >> >> >>When searching for standard exceptions for Ada, we lookup the minimal >> >>symbol of each exception. With linker namespaces there can be multiple >> >>instances in different namespaces. Collect them all. >> >>--- >> >> gdb/ada-lang.c | 30 +++++++++++++++++++++++------- >> >> 1 file changed, 23 insertions(+), 7 deletions(-) >> >> >> >>diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c >> >>index 6ab01fd27d4..2b251693b72 100644 >> >>--- a/gdb/ada-lang.c >> >>+++ b/gdb/ada-lang.c >> >>@@ -13016,15 +13016,29 @@ ada_add_standard_exceptions (compiled_regex >> >>*preg, >> >> { >> >> if (preg =3D=3D NULL || preg->exec (name, 0, NULL, 0) =3D=3D 0) >> >> { >> >>- struct bound_minimal_symbol msymbol >> >>- =3D ada_lookup_simple_minsym (name); >> >>+ symbol_name_match_type match_type =3D name_match_type_from_name >> >>(name); >> >>+ lookup_name_info lookup_name (name, match_type); >> >> >> >>- if (msymbol.minsym !=3D NULL) >> >>- { >> >>- struct ada_exc_info info >> >>- =3D {name, msymbol.value_address ()}; >> >>+ symbol_name_matcher_ftype *match_name >> >>+ =3D ada_get_symbol_name_matcher (lookup_name); >> >> >> >>- exceptions->push_back (info); >> >>+ /* Iterate over all objfiles irrespective of scope or linker >> >>+ namespaces so we get all exceptions anywhere in the >> >>+ progspace. */ >> >>+ for (objfile *objfile : current_program_space->objfiles ()) >> >>+ { >> >>+ for (minimal_symbol *msymbol : objfile->msymbols ()) >> >>+ { >> >>+ if (match_name (msymbol->linkage_name (), lookup_name, >> >>+ nullptr) >> >>+ && msymbol->type () !=3D mst_solib_trampoline) >> >>+ { >> >>+ ada_exc_info info >> >>+ =3D {name, msymbol->value_address (objfile)}; >> >>+ >> >>+ exceptions->push_back (info); >> >>+ } >> >>+ } >> >> } >> >> } >> >> } >> >>@@ -13122,6 +13136,8 @@ ada_add_global_exceptions (compiled_regex >*preg, >> >> SEARCH_GLOBAL_BLOCK | SEARCH_STATIC_BLOCK, >> >> VARIABLES_DOMAIN); >> >> >> >>+ /* Iterate over all objfiles irrespective of scope or linker namesp= aces >> >>+ so we get all exceptions anywhere in the progspace. */ >> >> for (objfile *objfile : current_program_space->objfiles ()) >> >> { >> >> for (compunit_symtab *s : objfile->compunits ()) >> >>-- >> >>2.35.3 >> >> Intel Deutschland GmbH >> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany >> Tel: +49 89 99 8853-0, www.intel.de >> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva >> Chairperson of the Supervisory Board: Nicole Lau >> Registered Office: Munich >> Commercial Register: Amtsgericht Muenchen HRB 186928 >> > >-- >Joel Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928