From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by sourceware.org (Postfix) with ESMTPS id ABE853831EF7 for ; Tue, 28 Jun 2022 09:16:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ABE853831EF7 X-IronPort-AV: E=McAfee;i="6400,9594,10391"; a="343375897" X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="343375897" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2022 02:10:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="622873256" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 28 Jun 2022 02:10:27 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 02:10:26 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 02:10:26 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 28 Jun 2022 02:10:26 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 28 Jun 2022 02:10:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mdg9+MoG7z3HhucvpSnBHe/INRnzOZMJnmgd3XiGIWudODrwewipY8K0Od1ztrRicv6SRaMNr8kuLuGuYvy6nkccNtb4b7KYeKNtC43NqrV2gvmkDTg9pGqXXOdNOUF1NpNq9/Jz9U0Lzp0M4GLPlTFA5JWwfuAbT2rIzBu+2Ki2rEJZ3XzhC0bDWQuQL8ukTfQS3mc1Dlerz3ukeKyEts9P/sOgAHDtWiVuzsqtelhmeCvkNzs9+E3pA9b2aHXQQMj1oIctvzSDIScxAmeqM9U4sDmGoqrCHwjbEIqRCxeIpo4q4z5OO2rgXhAxfq8d8XIKBR5iyOyFkZzgeYWVqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fNixFzS9Hebwh3yA+pjd1OtYgldRa2bVz2tFZsPGKYs=; b=Wcl/lM3wnQjbQE6e9/5eBUtUvIH8pGI/f37Zyji7TRIPkYXnF6fnCppNREaD8LcrYilJJ6xv5el2kQTbdHcpWU1RIRb14x3ZQAvyXbOv54QvDwCd89ucFPw11zLk1gUNHJGjxBQwFRPtrARmz+LZShFAk+ZYiJwuSbykOoEPVs/dgAlROfhq5hqa6fPgJHSiW7/AH0fjPPu1lDEJwvuqUut4fAmlaKOj9LWSagq5gAUPTTpQog2oyBG6EyxX1EBpkeR5qBn0xoFuasqPJp9Ghc/qYKCspWCe5KYwFdm0ZUnWI6lkSoK6GfpHOZDi2eyypRVRQz0EFo2Dij2Wn2G9Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by PH0PR11MB5610.namprd11.prod.outlook.com (2603:10b6:510:e9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Tue, 28 Jun 2022 09:10:24 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db%6]) with mapi id 15.20.5373.018; Tue, 28 Jun 2022 09:10:24 +0000 From: "Metzger, Markus T" To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v5 02/10] btrace: Enable auxiliary instructions in record instruction-history. Thread-Topic: [PATCH v5 02/10] btrace: Enable auxiliary instructions in record instruction-history. Thread-Index: AQHYhi2nnwb1FoM0EEOgXmIvpFO5g61ka7bw Date: Tue, 28 Jun 2022 09:10:24 +0000 Message-ID: References: <20220622114340.55830-1-felix.willgerodt@intel.com> <20220622114340.55830-3-felix.willgerodt@intel.com> In-Reply-To: <20220622114340.55830-3-felix.willgerodt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d2adf6dc-b067-418c-92d8-08da58e60946 x-ms-traffictypediagnostic: PH0PR11MB5610:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EEgYyDSgLRDFvZ+U4wIonffPltCceozMlJN0RTWMqIAH9cwHuCQzuF7rx5iEA9QOQGvVb481i1h4W5IH0TAa9HYT80v8rFbZ+NzGxHfVohlLRtMOYXyZexJEXG0wksL2+WdqCoZ1+v1cpXSbeyRF3Vf7xW67OZZQAhmSio7SvZJ3VHfmSHRcsMkY7g3BNtbiE2vWJ9xVDb+97rNqk//xznxiRYmUu8tKn5nA3yjC77DHUgETYrykmR7szjiKCvHUxZGE/mkDAPSIo7OxHkX94CofBiSvEfDT3/zPFHhoeRqqmkWnoHexBYK/1RikhlWNLPc4HRwVO1svT8m8mSZ3QtJs6jirjGcdFTgyYu0hOR7jIWluoBVytbV/4XOADJM6ibY50wuXEVuzP7qW988uJ39B1++hszibd839ZsnPGTCJ/sBZrJgZ4PesBG72mRoRPay7wvthpJRq9U9SJJOO3OhycYZEjCsMcfG1wx1nc7tW8uCuZOdg+OY94FUyctGG3J2VSElB/whnTA4Xl8OCDmJfzUbQiDt/kw1h5vHz8gZxvoY9bDCSk+hEbgUYSkOuixBzPFaQ84KnVpYx8fS56ghV5haFTsZT+ysKgqKap7+LCKHZ4m05mtUHgn5gl2QMtaVq10PT8Jw57BnBT/5WVW9IF0WuhXdBcpli3jLPWV7pXF1xBSbRFct81fSEUnfYEsOSda8ZQD2dYW2MCp+I+FyYpevybnwD7ITX93XPVCmW71x3/yPVQgqmrch5zSSxWHqmubRdMXK4wkAx3+Hy6x58EC/wv1I8RA40GBRGyqY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(396003)(346002)(136003)(376002)(39860400002)(82960400001)(8936002)(9686003)(6506007)(5660300002)(478600001)(26005)(52536014)(2906002)(7696005)(71200400001)(316002)(110136005)(55016003)(33656002)(38100700002)(186003)(66556008)(66946007)(76116006)(86362001)(41300700001)(66446008)(38070700005)(8676002)(122000001)(64756008)(66476007)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EbMEXVB6zb2D3nIqTkGDo+0bSEh/IE1e3k8/9Q4Q8Q6dgYZR7qIYzv0bctOR?= =?us-ascii?Q?1SV4c6AOvgKAIsIYE7O+2c6hu7bCyRI1QbUKovTOe3Cys8ptp69XSc/QMBZ+?= =?us-ascii?Q?fxgPSoekdUl9Ga468Du1iOYFXz/PYpaZxHhkASBdVCebRQIXVGC3qrvCEP96?= =?us-ascii?Q?T+BiPAJiXVFQDutYmbwbaRfoZ+OYroM8srvc65AVdft0MURCnvKN7qiVByQx?= =?us-ascii?Q?YKPX6WLj38XSLV4FZ1XMGNEYef4m3ujZ9p0ghLhFUdwI2tD6G/SbFD6rgiyg?= =?us-ascii?Q?ogA9wuXMeQr8U5OEzLgFXn94DD950sciOqeGv57tplRHGo+lQq7nrIO3+7dD?= =?us-ascii?Q?ykDtJzBjPLKxA9EfyjuaL1Go7jcwmRe0vQQ4z+jpZFN66NJ7IK0bV/x5zUpd?= =?us-ascii?Q?6qlzfwMNYdtig9fke3k3nMZSF1TxAuj1vWKsjKDzr7mbEB7aSMVq94OOuOD7?= =?us-ascii?Q?7sxV2PPRHQjj5drdFVi7ULkNJQBggOPAb6e976P3ImASQ6NHN7JXDMOy5yOC?= =?us-ascii?Q?JmPcRI40av0+RG1xy/eEao4fpcVx6nM2TN0UQcpdIinJD7x2hB4hLtcZEPr8?= =?us-ascii?Q?1RyKh6ssrQWw3eH7rgAYeX5P/SzKTip9Gfx0dq2E9zK1ngQxOar9YgKhm/xE?= =?us-ascii?Q?ylMj+tiLZE6LkXeEHMc9U7xLRzXAOHDGTZ8354nlEvq6xgSviVsiJNEx2Zr2?= =?us-ascii?Q?aB8ouOMmHvorM7k6RkLu9oaHvN/0OBVW9I7h5iwuCKi5JKhyT5lrWccYpJWi?= =?us-ascii?Q?S4w0BPiRry5rJse1ll4WhR3neD9dmkLb2qiOqveqiopnf/XEh9aoWHuGSLdt?= =?us-ascii?Q?07HLPLkl/s0+UYOiiSct/LfFPelHCyLe8OKNYpRwhvn9dL+SWju3pIbhTgTp?= =?us-ascii?Q?P9lv1YpWFQU0jXH38GMYCVeooDfWO7DqETfmspGaSpQrH8p7jzKK+RTrEY+s?= =?us-ascii?Q?fdM7upDrBICdH2mE9wfTdDKcKxUJNwQ/PWI+RHaJfu4H4IQ3b0OmA0loKH0V?= =?us-ascii?Q?tTWDdKbEZPRG7m9MvBC69QWmURAkaDfa3nz5ZfkpXeWpYWhuLx7aWSvqe8+N?= =?us-ascii?Q?Fr4m0P3QhNZhPkw9SOM1bxhJh30tJeH73UHqbQTDaz8e1vITVziHnxqNebh8?= =?us-ascii?Q?FMqxftI2AngJIYYAROZkLt080FmK2hSa+y0gwL9TugPL80QeI2/kiRul538Q?= =?us-ascii?Q?w2QW7bhkus+pcGKGONIC30TkDNB0vhSesNRT4GJt4UXL4AfGG0tIV1Lvmybw?= =?us-ascii?Q?Lp8R/sJ/VkYfifbwlATDAD7q8MK5e1A8eQQwSAhFDwK3caHMa620hSoToWlU?= =?us-ascii?Q?RHNpnxc23XgO4NN/LsT3XH0xlXGvLI0eB4dKUVdGLhTM39+2QCmCVbt4035F?= =?us-ascii?Q?yKo9Y9k8IHgff5IZfwm+gkyIedGbxbTD8dWDmE2C9J8IuXsk9A+yGKU/OglN?= =?us-ascii?Q?h60Sqhs9WUdCkeWWO9NpNxShKEk0jT7gnsjrPPNfjcgSi0q7Llhb3vWXta/P?= =?us-ascii?Q?LPFuk8wsYG8k2tWKKDT6+xBSieyI//kNy2L4lArDlkhCIF+67HIwic9Ao+KM?= =?us-ascii?Q?WhGBqtz10u0K2tu8qadnRGwGasodTVj8uD8hRZWR?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2adf6dc-b067-418c-92d8-08da58e60946 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2022 09:10:24.7073 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B1CVdohNzvPT9Yr9DWeJgZBDg79jge/oYHeN+DkmpCwlCRztPBvz69VFvwTqHOjHKtlHF4U3UGIIM1TI7m9xA4K5uOd3sDqtk4F/p+GFBMM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5610 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 09:16:38 -0000 Hello Felix, >Print the auxiliary data when a btrace_insn of type BTRACE_INSN_AUX >is encountered in the instruction-history. Printing is active by default, >it can be silenced with the /a modifier. I find it a bit strange that /a disables some output instead of enabling it. Should we change the default? I'd probably always use it, but then, I also always supply /cli to 'record function-call-history'. >This patch is in preparation for the new ptwrite feature, which is based on >auxiliary instructions. >--- > gdb/disasm-flags.h | 1 + > gdb/doc/gdb.texinfo | 3 +++ > gdb/record-btrace.c | 14 ++++++++++++++ > gdb/record.c | 5 +++++ > 4 files changed, 23 insertions(+) >+ else if (insn->iclass =3D=3D BTRACE_INSN_AUX) >+ { >+ if ((flags & DISASSEMBLY_OMIT_AUX_INSN) !=3D 0) >+ continue; >+ >+ uiout->field_fmt ("insn-number", "%u", btrace_insn_number (&it)); >+ uiout->text ("\t"); >+ uiout->spaces (3); >+ uiout->text ("["); >+ uiout->field_fmt ( >+ "aux-data", "%s", >+ it.btinfo->aux_data.at (insn->aux_data_index).c_str ()); The formatting is a bit unusual. regards, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928