From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by sourceware.org (Postfix) with ESMTPS id 29CBF3857820 for ; Fri, 20 May 2022 07:45:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 29CBF3857820 X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="252415337" X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="252415337" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2022 00:45:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="715408221" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga001.fm.intel.com with ESMTP; 20 May 2022 00:45:12 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 20 May 2022 00:45:12 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 20 May 2022 00:45:12 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 20 May 2022 00:45:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RVQwBLddLaIALg677Ag7Cvm06C+xGvREXDCzquIsNevvMMmbk0/13fcyT6AO66rrhi77M8qgxGeO07jCaTkSE++noK3caqh5/cWbWYyZTAaZhMNdI5cMVQZHVrvW5LTwMwaNIctPjbOK9408akGe0tATMbbSFiDus0i0IeLFBvI3E0e3C+ZC+xYgxfLXNuV24Gc+PR0TXUqZNqm9G7U1K6CY8SiX5rXCFmw4WJlmerZaA4ckKM499d58LgNhG+5uqqrl55EsH4H2RBAN9wwXRRYyEd1qbheWaTXPGh0gDM19BDRdfLyN4L1TwKqDdNz4Pt9ugKKcXCxPD3rRDbNKNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bZskf6+4uixe+sqloGyz+8EhG+8YdaWuVQZ1NJNeXwg=; b=Gm/HqpDSDQdo4QC491u+YfxSxEfF+KJwOaOwwi5aCMTrZZs+imzdT0LMYTwURFGYc+IHJbIwr1tkTwbNi2cC4q3Ty8KZB6+uKnbSoRK75jlk9joN/l1Zy74res342bVoKcv2mD+YTqfXLPVGpGMZlWWPPjzWiKiNT54+aAfvA9V+pTHn+KKvY/csb16PqFXxelJtJN2z0o3+yGEtbX1ZGWmbM4c3GIsUUuQsBj5ASrM4i6bLyOWl+quLjcUlbbBroJ2wuCEQ0TB2Wrv1J1EzrBo2wLnKHj0NTPRKC710RdyEuye1uXmfChigBdonQP28nH3g3xYyLlVX0gCVPUrgZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by DM4PR11MB6017.namprd11.prod.outlook.com (2603:10b6:8:5c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 07:45:10 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::4c:7f74:797d:837e]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::4c:7f74:797d:837e%4]) with mapi id 15.20.5273.016; Fri, 20 May 2022 07:45:10 +0000 From: "Metzger, Markus T" To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 1/2] Always show locations for breakpoints & show canonical location spec Thread-Topic: [PATCH 1/2] Always show locations for breakpoints & show canonical location spec Thread-Index: AQHYa8t3EEPdx5gDV06ZOxFfG5S/gq0nWOAA Date: Fri, 20 May 2022 07:45:09 +0000 Message-ID: References: <20220519215552.3254012-1-pedro@palves.net> <20220519215552.3254012-2-pedro@palves.net> In-Reply-To: <20220519215552.3254012-2-pedro@palves.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aa73eece-2858-4428-a8d0-08da3a34aa81 x-ms-traffictypediagnostic: DM4PR11MB6017:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: o/qnGWloJAw1V0jT7Z8dIaHzZ0ubSxCjpLbkA8t5jYoACc8ehSSqDnFhkrIdZHySyPYB2ZfvR8f3+Q7ip91La+A7P6bSulke8oMTZNu36EdinPn9gzQ5jQBaFEv7pFUS3W54QMjzjVs09aAY7McxAC/0KlSy6k6XqGKQxaCUywaqLsalDgESNG6TsAqHm3UleDOYT/WzSSlaK9ZO4vWi5DQ7lP2SI0ekIOgzBOxWUc2VBQmBlPOGU3uLNzjcPLKxYdWPZEYM7lZZxOwY4GutpWxL6WZw9HSdGKPrHTHZGl03L7ZjmNpjNCKAqYCMH2e6BBay6rLVZeOePcP6BTHRXRP368TgT2YoDTbJpvLZ/v6aMycXe58Z38ymlr+S4dB5T7M1vWDuLC88QNBVwgBgWHl/8SKfjlZgWUHHwJk7nXiu3+fko8DJHvnXqKP5phXpWjr3r2QgnPPifNmYAQjOkV+HdoXCuEUPnfqD06hKpjlyLWWfio+GxZdAZ/zIdMQHDT0asBByBvueEZ1/y2x2W8mqOL+RaaZy1qZKJAacsraduwDEDZ646E8vYBGA57f1vtvYKa0DbnwYAup10gqn2E4IrCxzFNiBIyUQa+/RrIsoAbZGKq6u2m/Leu20L/QbNE4+PwZrFPKe6QmS7W1ynjwdZ4B6DGqSbID3iMyMxYTm6rPEPanF0VcEUybkWVp5OEjvlO1tMV2DrSUJmz0xpw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(9686003)(55016003)(33656002)(4326008)(122000001)(82960400001)(8676002)(52536014)(66476007)(66946007)(5660300002)(8936002)(64756008)(66446008)(66556008)(76116006)(71200400001)(508600001)(2906002)(38070700005)(186003)(86362001)(6916009)(6506007)(7696005)(38100700002)(316002)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1A7RkN+bBskyYcjNtVVhseho/R8c4uxXilyyzAHkr5wKRxadCnxYh/LJIGC3?= =?us-ascii?Q?azysrcJzN6vP0zYfgiYGvsCv+xh3Uafj28vj/p9etOUNx2yph2fiPwTLxQW5?= =?us-ascii?Q?mKkByCmbqVKKNtIgvtFFbWKfRB2Mody0sUBSeHXIwnFSUGAY/rUCzRfP2IHA?= =?us-ascii?Q?WaFGX6ia4ipcPIFbHo6cFqA43t7AqZr5gcl/KBQ8zdBhOINZCGrpBglDyHFE?= =?us-ascii?Q?ETXZ1+zvSfj5r2brc5H/dXKBozJX+Rqg3UqtaPyw5m+wzZauXGt/VRcaucfA?= =?us-ascii?Q?M4Q857fF9arU4ZVpzVxk8uYgiKWgcCOFNbkyVWsFjzkbZvqMO5jttAr0CHMt?= =?us-ascii?Q?SvFKCAcB/968b9ljIQNTpkFmdXyHehtC6jFc4ecrv24zj3wURhprKICzicon?= =?us-ascii?Q?5cEbPGpZRAkL1QN1DXGs1sqqbjswLDE8zbfrQpgDIEjBnxREBmmTVrTP83yQ?= =?us-ascii?Q?eClIjv6BvXWiU6Iey7eK4HgLlnzDXGfeSHtygcH8MYxcacEkio8VzMsQuccX?= =?us-ascii?Q?Mtjn++a55L5CIvdF08Dnn+6hm9szKq6GFuEmWkKeil7t+sdkTdRtEkRzFZ5N?= =?us-ascii?Q?dURx0ROZ43sPDmAk/vIugjrBzhfNRp/gXqxjxL17IFic/qGowWZO3dNNzh0k?= =?us-ascii?Q?s0xKi5gKjSilWT7I8Q62fCAfIucmQm4v8wmzWTi4yHjUD+fe7F6sKTmlCGQ5?= =?us-ascii?Q?0zKWzILU4/IRmMyF/rMdgfBr2hZSQIwSyrvLlnX08B+611dcBjtbqMDp4Vy2?= =?us-ascii?Q?kjd4hO4UowBEGJIHjx5dt+lp8KLnY3t/MMAytxvLRWJPjAJoH1tzf5OJqMT0?= =?us-ascii?Q?DV2D+DU2ogdYHk6p+gUW/97kFcgH7drqbw84URpB0ag37BVrL5OtHjgNzw1j?= =?us-ascii?Q?RP9AkkAss+AxfO6DWHhfgNR1x8V19cmVAdNE620tO50vUN/ClSxEC1A5GFRY?= =?us-ascii?Q?K0mJbhDnNRqTF2zw7anjVJSzY1xC5veZ4U8P5A0vEe3hdwHD8L2+66Y0lj76?= =?us-ascii?Q?t1u9A3dyuctKdjshGAos7Nf9dkxW3gmmQUHrhYG1V9BI5A/DcSyjtLcKku8t?= =?us-ascii?Q?lb5asvz0I3FEXkHNqWFSzfYfgBFTEuVZpIUNBw2c0B20k9mHZkrI8gIIkX+/?= =?us-ascii?Q?hFdlKIy1TvLZ+BSSlBE6MEjalBHHQKG8S0mxVIzwyHk5mWeqnJjbf+cyArwo?= =?us-ascii?Q?zJdjcFUdxjkA6ONAHxgtzrDhNiQPIGyyI8ytAJ9ElrUJtk/2a6BE9X/OnAPD?= =?us-ascii?Q?M23N3YmnCgQImuazq/rMPnn5/W15Yw9NtyFitF2xhNL9U20d4dbsWJMp1my2?= =?us-ascii?Q?in9NS0CI1fBVD5Njkxpe42wxTatQYaW2G4UxYOqi0O2ClmGJcjav51Sc7Fbv?= =?us-ascii?Q?pzin9ZS4L1rBBqjzX894GJfbsUKTtEYTp8pNboz54H6wL5LPFzvwDCMX+M1K?= =?us-ascii?Q?Aj5UsGbqvb0RSV36YiB76Z/KzbVSh4mfTqZm6ylvPWPJjdXmxEelFMkhwwHG?= =?us-ascii?Q?FR2OlErSymtJ3w3uZ+yZFFbTPzzBJk1mGNgNxjBVQFuLVq7q2wCBLR3oaUhc?= =?us-ascii?Q?HCquUa7RX1cZYmHJXmWQzeTbpTSRknV26mnMZExYzFtuvd+iIubTa03up4tc?= =?us-ascii?Q?q9/wZCFgbTzU3gNvI9unqMpbI8rs2QTn6YJiCJcRe3gNeTlGbdRs9kojRL6v?= =?us-ascii?Q?uO/XUCmv5G1RkrHQf1aNN11CwBl2UBnwnsZKubykcvIJAX1Td4AxOzrJIbuG?= =?us-ascii?Q?yzG2bEYtl9sqZOxadT5UWJxu29gkIZs=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa73eece-2858-4428-a8d0-08da3a34aa81 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 07:45:09.9056 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9BOvxM5GxaG624AEdRmi/BNbcnEb3lJeaF/dk+P78c9fg84q/iK/tiYyXmtDbxC2uQY/8Ss6YPOtXTRP96OioZ/CEFX59HzAxkSSfk5CAU4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6017 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2022 07:45:17 -0000 Hello Pedro, > (top-gdb) info breakpoints > Num Type Disp Enb Address What > 1 breakpoint keep y internal_error > 1.1 y 0x00000000005755a5 in internal_error(char= const*, int, char const*, ...) at src/gdb/common/errors.c:54 > 2 breakpoint keep y -qualified internal_er= ror > 2.1 y 0x00000000005755a5 in internal_error(char= const*, int, char const*, ...) at src/gdb/common/errors.c:54 > 3 breakpoint keep y errors.c:54 > 3.1 y 0x00000000005755a5 in internal_error(char= const*, int, char const*, ...) at src/gdb/common/errors.c:54 > 3.2 y 0x00007ffff6d50410 in PyErr_SetObject at = /usr/src/debug/python2-2.7.15-4.fc27.x86_64/Python/errors.c:54 This change looks very nice to me. It will be very helpful once GDB starts sliding breakpoints per function and we end up with different source lines for different instances. I wouldn't indent the breakpoint instances, though. There is already visual feedback in the longer breakpoint numbers and the fact that 'type' and 'dis= p' are omitted to separate the groups. regards, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928