RE: [PATCH v4] gdb, gdbserver: support dlmopen()

["Metzger, Markus T" <markus.t.metzger@intel.com>]

Hello Pedro,

>Should the commit have a Co-Authored-By: tag for H.J.?

Definitely.  I didn't know we were using such tags.


>I'm wondering whether ideally symbol lookup would be updated to handle
>different namespaces.  I'm thinking of for example
>svr4_iterate_over_objfiles_in_search_order.

Do you mean that we should restrict the search to the namespace of the
current_objfile argument?  And use, say, the default namespace if that is nullptr?


>Can you describe what xml changes were necessary?  Do we need to update
>the manual where the xml/packet are described?

This patch doesn't change the XML so everything ends up in a flat list and GDB
doesn't really know about namespaces.  This prevents incremental updates
and would also prevent things like the above.

I had planned to leave support for that for backwards compatibility and update
the XML to pass namespaces for future versions.  See also
https://sourceware.org/pipermail/gdb-patches/2022-February/186135.html.

If we need GDB to know about namespaces, however, this wouldn't work and
we'd instead need to conditionalize namespace support based on gdbserver
features.

Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928