From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by sourceware.org (Postfix) with ESMTPS id D88973858C27 for ; Mon, 18 Jul 2022 05:36:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D88973858C27 X-IronPort-AV: E=McAfee;i="6400,9594,10411"; a="347825766" X-IronPort-AV: E=Sophos;i="5.92,280,1650956400"; d="scan'208";a="347825766" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2022 22:36:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,280,1650956400"; d="scan'208";a="773613446" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 17 Jul 2022 22:36:01 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 17 Jul 2022 22:36:01 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 17 Jul 2022 22:36:01 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 17 Jul 2022 22:36:01 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 17 Jul 2022 22:36:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A+V6jGh0YvdVJBcC9cL8wynslllFLQ0NudeIB8ZcDWLST0zyZ3BZts5Xe4ppjUOFrr/1kuZQuaqlaWvN0wffJRcoKIn+XWPYtTdd18Gb1xMiVLkqHzX+nsdQxZM9iFuudl8mTPtNMqKjRo2DPLco5c5u2JLBZGwvBNlSUTKdSud+TDTuYcD2/37MiQtTSMPQRtx0VXCvE9ytCKYziSD5doEOoJfQeZwisnPC2bmtT6nohE3HiEL7BBykbqWHiahTq5USruFRrUX3Tq4pO3Zzf/fqcd3Vov7fDmn5pGY7oe+XixVp0zXKuRyJ26faPXqZGVvHiIkWdwGEtAmgtETVkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3M/c8r5D1bvaBUPND+EBlru2KLHgc7ekCDcxOBODNC4=; b=Olthuw9JnDS7g45j5V2MAiAFY9PZ3ZXL/Stg/VBx+Vl3Giyfyq2pFvwxxTLrssHAgoCkE9lHqBvK+5Gb4/bM22OQnm9kufgAlOnB7Pshbz1ZqdkHrLzTBUkV4X1hV24mzU4WckQAHpwcw/6nzF7+/SPa6w2GlIQkD1vtWuar4eDjknDvzPRN3np93NmKlsqZOkO8EJnFa2ylhnLmhpQppuinFJbjWSA7dduh0iqDigwF3wK3mJGNheaqjr/f4X9Ho628nstdE5ie5wtif7EhQwru5pMLZvrJxEHSmMC/kfarSQx+QSVZ0Ja42U2aPqdaC7tYfZYESIXeg59zfo4ZEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by CY4PR11MB1432.namprd11.prod.outlook.com (2603:10b6:910:5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Mon, 18 Jul 2022 05:35:59 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db%8]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 05:35:59 +0000 From: "Metzger, Markus T" To: "brobecker@adacore.com" CC: "gdb-patches@sourceware.org" , Kevin Buettner Subject: RE: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all objfiles Thread-Topic: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all objfiles Thread-Index: AQHYdo0jKz6X0SPP3kqfqbf3DASq362D40hQ Date: Mon, 18 Jul 2022 05:35:59 +0000 Message-ID: References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-9-markus.t.metzger@intel.com> In-Reply-To: <20220602132514.957983-9-markus.t.metzger@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0dda5ff9-472d-423d-761c-08da687f6534 x-ms-traffictypediagnostic: CY4PR11MB1432:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Zbz4t3Vwn3HqD9vHS6U5Xgt4/W0rHF4gefdiqZqvyYuMGaEHpsUlu+SL7XAnh2380lHo4ftcdPTg0Ng2GZ5WiXdHnoXYscqxxl2KRYpgsLBAgLfKbygl6WFR4zKvGQsIRAKcyFWibyQDlHjWHFb3J8mrs+O6ecbIA7mOMeEfC/BOP1oxF1Hx0Wxv7cLyRFr5rVZSS/uZRIOwKlEnk5xKpZqOTufAa6EPSTPfoS+iF4hBePI8d2WzUCzKVsr2XCnVDIkQpi3JWbj/3aYX1aGb5rfgksYy2Zcs8n+4kfSq+q079joX4Xa2YVdOOkut6b0rfZY+OdbAH1Y8ypNFCYtRUe1QT9hxuD40vZiEmqTCo/vIjYwEF0mNoWVPpFrHynazpGFyKUzQTnctg7SRk5wHYx5fdiqPLrlG/kWDcCCx2LEGjXdBXEHTj2HSugvbaleAyg5CA3/opUwvcvgIxdDignmx36DduEfOspmF1sFfCHhEKoX/IIPJSwlkmZX/ndiOb37OOyF5ID3Eb4kpEVOT7sboMWCwBYtv4/blbA8bZdVge6KR5ofx9wKxPqzzBxuO1oxfzX+8EcvI42q2lWZv1THFm0LjsVcXzinrx2O9KpGJGuBhBYp5Ji8Q+RMfxvceYhvJ+mEI3zaFVO4JRPuI0f7hIJcjcRnz0ZRFMMFyskuQQu1IzEO2wU/TStWUOKyuE1dxnPTY+NVz9FgM5UkqtRf4dSCWE18Z5JoMrClS8cT3EXaGA+/OkwSH72IKFSckNV9o508rTWFsteX50s/BD70m3NVt163+F/8YK0WWIjw4hULMI7fbnKwUsZ84vo6O x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(136003)(346002)(39860400002)(396003)(366004)(71200400001)(82960400001)(38070700005)(41300700001)(478600001)(26005)(6506007)(7696005)(86362001)(9686003)(54906003)(316002)(6916009)(83380400001)(186003)(55016003)(76116006)(64756008)(66446008)(52536014)(5660300002)(8936002)(66946007)(4326008)(8676002)(66476007)(66556008)(2906002)(33656002)(38100700002)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q6Jpnhr1nlJHiW3HjLPpQIcf9sKwP0KBYtoTRGg/VjNQZH60zGKDYLZ9SkrN?= =?us-ascii?Q?gHDZe669EPPIcPJ4hmlE9PTOYvy3PW48YaIuACTBbBZVB3CIWqR6g0xJObdE?= =?us-ascii?Q?705H7TBYSAvfTfsWtIEFnuuRAoakGwQzr3GPqHHuzgRkRDuCdjyThbtfdEf5?= =?us-ascii?Q?wELIyIABZlazFfQQRpUEpbwTG0U/KJrTNkHkVWCl49GVzRQS8ke5Hm8RZTV0?= =?us-ascii?Q?Thae3mDfV9XqOKEbRrC+W7ryG3RTW3Ih78K8QODif7PF0oFdSxti1IzDuRlH?= =?us-ascii?Q?XTVrHvo+gqP79IPIT/CG+ji/FHvPCd5a4mM9XJLNd9q7K9s+J0AEQMWnCquH?= =?us-ascii?Q?SFJEnGYos4hcpGwDTP/j1jCdXzqZd1k9X0tt0KtjzPWrjaisSzBhdHrHBNss?= =?us-ascii?Q?RQUywHF0PRMZ5VULOpdkY40Wvd0ZKtIMAf1f4lPTKvPQg9vQkWT/dAhErMfe?= =?us-ascii?Q?OXAV++AySDzv2iyAXwSDBilE2hZm9Jj3b6tEKF47NsV9EJdjcGeiNg8eG0Ni?= =?us-ascii?Q?4DI9uSfZk7GjaZgaU9wCwA6QUr81yCB3MSiQS9vY4v7nDcoaFArCFFTQ+ob2?= =?us-ascii?Q?COKMJU0HQ3GnnCfcAmnz/cSDtwV1AM9clW3wUCCBED2Payf8hrh6zLbwghXe?= =?us-ascii?Q?7XMyhDuUAYBnqKVH4HaFSOc5zvjzTS1EhQ0tdVn22MJZIWmUufRW/Mt65lkK?= =?us-ascii?Q?acsWotLWc1K+pbHeZz2rWmrB31K6ezYsMX2Wy3n1a+0w4eAaOgPNfVyzF9bS?= =?us-ascii?Q?17X0UYsa9OZ8xVDnVPH5UM9JGCuSgZIzExthe2LgHOhyCJ11IwXh/lp5kFh6?= =?us-ascii?Q?1a/LSQLvJ8JtCebrxq0+EPiLKi03rcPWbhEzTK63EpHWBBJ3lTF6dPNH+UGp?= =?us-ascii?Q?IijNwX/6ABipDqnR3Wuhm6ZHIgpuGoXgR5ZJOGGmVeJexh4fzb19DIDvb8JJ?= =?us-ascii?Q?c9XWAlk7obHy64gYs30nUNcmBJMA6t0CYDFHho6OZHf2wedUto63ebM3u89A?= =?us-ascii?Q?aeBayTqfZ0FOGFn5QdKWLzds+p7FKveMNfCSu/H20ExyBWqzpAYCKgBcewSr?= =?us-ascii?Q?vcnADxthjjAibVPHm25lYQRmcNeUow4x9+xXrYugcaensJQoRCTRrnby7PcM?= =?us-ascii?Q?9LkCT3/1o/w9LAV6ISzPT+8K06mXvJ/TTa4kf5OtEej5UzXGS7VjK5DL00Qd?= =?us-ascii?Q?pVbMUpDMUD2h++HjzqYFQWuw4OF4KsrHb4qCaHhVRbA9fwZupgcZsoffRzOF?= =?us-ascii?Q?32DNy40HOUnA5KRi43ahi6xYJQeq+M2DGpAZqQiP2BKq2IqKu4OAA+Gm7ADw?= =?us-ascii?Q?Hu5MVbExqSz17Rc+WnAl4Nb4vUUwioIVK+mrYtAhWL0N9YJDLcDgHUadPhgA?= =?us-ascii?Q?LnhzQDj12RSJ/LoZMjujT6eUcWMl12Q0TRPWzx1qaFNjQ84MmFpi9LA84MSo?= =?us-ascii?Q?YNolXZu3kdwZiEo2J3gv0JFqVFtVUXv6UeD6IeH0c3jeQ+Eyclt4e66KON/2?= =?us-ascii?Q?3JZe8yCnDl+qBCTsqLQTaKhwpkjNHyZA4UH7XmTuUKaY0DqyyXTxlFt8XNBG?= =?us-ascii?Q?qX/eWD4vQVe17KFOE7PFjGmGc743FMzk7VHC7qYi?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0dda5ff9-472d-423d-761c-08da687f6534 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 05:35:59.4261 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s+6RlfMzj2nXUp6WSC2BFqEIsLPAexP9hqKOXqMEi9bVPDCKEVpzgdciuX4jPir0Egnf+6vm2xbcC0OF1xHXWBWyyCwzkDoR3k2PIFTYUuM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1432 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2022 05:36:09 -0000 Hello Joel, Would you be able to review this Ada-related patch? thanks, markus. >-----Original Message----- >From: Metzger, Markus T >Sent: Donnerstag, 2. Juni 2022 15:25 >To: gdb-patches@sourceware.org >Subject: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all obj= files > >When searching for standard exceptions for Ada, we lookup the minimal >symbol of each exception. With linker namespaces there can be multiple >instances in different namespaces. Collect them all. >--- > gdb/ada-lang.c | 30 +++++++++++++++++++++++------- > 1 file changed, 23 insertions(+), 7 deletions(-) > >diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c >index 6ab01fd27d4..2b251693b72 100644 >--- a/gdb/ada-lang.c >+++ b/gdb/ada-lang.c >@@ -13016,15 +13016,29 @@ ada_add_standard_exceptions (compiled_regex >*preg, > { > if (preg =3D=3D NULL || preg->exec (name, 0, NULL, 0) =3D=3D 0) > { >- struct bound_minimal_symbol msymbol >- =3D ada_lookup_simple_minsym (name); >+ symbol_name_match_type match_type =3D name_match_type_from_name >(name); >+ lookup_name_info lookup_name (name, match_type); > >- if (msymbol.minsym !=3D NULL) >- { >- struct ada_exc_info info >- =3D {name, msymbol.value_address ()}; >+ symbol_name_matcher_ftype *match_name >+ =3D ada_get_symbol_name_matcher (lookup_name); > >- exceptions->push_back (info); >+ /* Iterate over all objfiles irrespective of scope or linker >+ namespaces so we get all exceptions anywhere in the >+ progspace. */ >+ for (objfile *objfile : current_program_space->objfiles ()) >+ { >+ for (minimal_symbol *msymbol : objfile->msymbols ()) >+ { >+ if (match_name (msymbol->linkage_name (), lookup_name, >+ nullptr) >+ && msymbol->type () !=3D mst_solib_trampoline) >+ { >+ ada_exc_info info >+ =3D {name, msymbol->value_address (objfile)}; >+ >+ exceptions->push_back (info); >+ } >+ } > } > } > } >@@ -13122,6 +13136,8 @@ ada_add_global_exceptions (compiled_regex *preg, > SEARCH_GLOBAL_BLOCK | SEARCH_STATIC_BLOCK, > VARIABLES_DOMAIN); > >+ /* Iterate over all objfiles irrespective of scope or linker namespaces >+ so we get all exceptions anywhere in the progspace. */ > for (objfile *objfile : current_program_space->objfiles ()) > { > for (compunit_symtab *s : objfile->compunits ()) >-- >2.35.3 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928