public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: "Hannula, Ari" <ari.hannula@intel.com>
Cc: Tim Wiederhake <tim.wiederhake@intel.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH 3/5] [func_call] Fix MI output for function call history.
Date: Thu, 17 Mar 2022 17:58:59 +0000	[thread overview]
Message-ID: <DM8PR11MB574947C7539324130535EECADE129@DM8PR11MB5749.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220210135243.3127629-4-ari.hannula@intel.com>

Hello Ari,

>"record function-call-history" formats its output as one single tuple with
>the same keys for every line.  Fix by turning the output into a list of
>tuples and the indentation into an optional "level" field.
>
>gdb/ChangeLog:
>2018-12-27  Tim Wiederhake  <tim.wiederhake@intel.com>
>
>	* record-btrace.c (btrace_call_history): Emit individual tuples.
>	(record_btrace_target::call_history): Emit list instead of tuple,
>	fix field name.
>	(record_btrace_target::call_history_range): Emit list instead of
>	tuple.
>
>Signed-off-by: Tim Wiederhake <tim.wiederhake@intel.com>
>Signed-off-by: Ari Hannula <ari.hannula@intel.com>
>---
> gdb/record-btrace.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)

LGTM.

Note that GDB is no longer using changelogs.

Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


  reply	other threads:[~2022-03-17 17:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 13:52 [PATCH 0/5] Functions call history patches Ari Hannula
2022-02-10 13:52 ` [PATCH 1/5] [func_call] Add possible spelling of linker error message Ari Hannula
2022-03-17 17:58   ` Metzger, Markus T
2022-03-17 18:45     ` Keith Seitz
2022-02-10 13:52 ` [PATCH 2/5] [func_call] New tests for a btrace crash Ari Hannula
2022-03-17 17:58   ` Metzger, Markus T
2022-02-10 13:52 ` [PATCH 3/5] [func_call] Fix MI output for function call history Ari Hannula
2022-03-17 17:58   ` Metzger, Markus T [this message]
2022-02-10 13:52 ` [PATCH 4/5] [func_call] Add function-call-history-length command to MI Ari Hannula
2022-03-17 17:59   ` Metzger, Markus T
2022-02-10 13:52 ` [PATCH 5/5] [func_call] Add function-call-history " Ari Hannula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM8PR11MB574947C7539324130535EECADE129@DM8PR11MB5749.namprd11.prod.outlook.com \
    --to=markus.t.metzger@intel.com \
    --cc=ari.hannula@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tim.wiederhake@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).