From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by sourceware.org (Postfix) with ESMTPS id 9BC6D3858D3C for ; Tue, 17 May 2022 10:25:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9BC6D3858D3C X-IronPort-AV: E=McAfee;i="6400,9594,10349"; a="253187653" X-IronPort-AV: E=Sophos;i="5.91,232,1647327600"; d="scan'208";a="253187653" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 03:25:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,232,1647327600"; d="scan'208";a="660545856" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by FMSMGA003.fm.intel.com with ESMTP; 17 May 2022 03:25:41 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 03:25:40 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 17 May 2022 03:25:40 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 17 May 2022 03:25:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hu39IuuJ/jaPLJui3AdvH4XvlxhvU6ca4E12S/xTUmyT3rDzatzJVYoX9pP72hrJwW/Gnb00Di6pZi89ElzAfva6o09lHMzwOH9LROPyH9D9x7aYsVwfs6II7m2t0BG2RkqQZ5YBotPUfmB/tmY50g9RRgSyMXGHJ5wMvCqZwzdF5F6W8JEd+TDWDQ01llfxhL73qokBTygvIcR36EhktP5PZXPLfSQVPkBwhLPzjX/WOaOwtcE03IAsxv2OQuxRDy52Kb/7mWUfv+M1JZGwkKFf78UtsulvBhYEjJ7Y4KbDK0+mBgO7NA489ZnBABbFIoB/tM8rrOsvkZa3XtveFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TnuqT3+KUSLlj7bNXp/BJB58dNijVTY/Xo/V131qlSM=; b=JSq8IeSusjAKJwd6ztrypVbvKhI77Hn6ZvjiTbe+Jrx/LZiwqDcF2uw+KxBOXl2O3EJmrqEkbaX+sgfSXsGW9XJZiV1CQQJE9UrnhQvdDuhnUfdyPSnfqw+bdvpzUOqobpDcQsSgB+reUKeVcWslUafr0bOL+6TZhH62RNnfuieXDQ3ima9wWAVaBPfhBJlu3ObXATSMReDFH0u/w/yoPbrBE4wcSpwhATrbzQ8ifKnkkYYOTMlHNysH2aLOGLiljaaXs09Gp/+x3rj2I2IHEsqPPLv2o1C6ILrD24uGrifk/JnKKDMHyeW+9UPzhRnQi4q95RIVcEcpajJzNQj9Eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by CY4PR11MB1863.namprd11.prod.outlook.com (2603:10b6:903:121::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 10:25:39 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::4c:7f74:797d:837e]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::4c:7f74:797d:837e%4]) with mapi id 15.20.5250.018; Tue, 17 May 2022 10:25:39 +0000 From: "Metzger, Markus T" To: Tom Tromey , "Willgerodt, Felix via Gdb-patches" CC: Andrew Burgess , "Willgerodt, Felix" Subject: RE: [PATCH] gdb, btrace: Throw an error for empty recordings when replaying starts. Thread-Topic: [PATCH] gdb, btrace: Throw an error for empty recordings when replaying starts. Thread-Index: AQHYZQ4sETMOevbuZEu3XCHC/NlCXq0ZakEAgAAHhYCACDUY2IABP2Ig Date: Tue, 17 May 2022 10:25:39 +0000 Message-ID: References: <20220511080707.726213-1-felix.willgerodt@intel.com> <87ilqcl8gh.fsf@redhat.com> <87tu9pfqse.fsf@tromey.com> In-Reply-To: <87tu9pfqse.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 410016ea-aa78-4ff3-4c54-08da37ef96e8 x-ms-traffictypediagnostic: CY4PR11MB1863:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZrLIP3wpxvKDn3ChWyzRdfYB0TYJJTnIshVs3qxmdMA/UtBx4UOEuEtg6neYhqEIdkTne+DO2BGlidk0GjCbBz9cE7ezL3EDbTWI069syW4l3PpYOGxIay5gc9gf3J19gD0kBJLlki9R290CSCVFXf6H4jKljXiDPXQgtmzCE5sMPRqCY/dbsDLUiM+BDgc5EWpiuyDg9LjD7r+UrLldD+jtgHu9R2qMNl9/+nGZGrqEM8WZaUk9KYhkbkm5dvOKMHu/JeOAokMpwiVNeCL7HsVFu0i1JpZxggJaeknznN5UPtXdK6MGKMNRbNpwKNsj5nb9IC0zoXdDu/D3ZltVRVG3h7JuZ7adpeQJpw9Kapdb86HdFXBbrm5tlT7OZaKMs5eLUIdTZ8Fn2ldPL632IHFfN+dhOuZyIIfZgUvh4P38UJHGoMDvNyYGEQXgbhPOEZ3e3FSHwA+HN4776d1HA0KUQJJUxJ7mcpQQQDHUH1TeP0/Oitj3s1rg2AWA7lDEHV834RhXRVe2k9vff0bW8l/qELrp+EMs4nxnva9xaTADBo4GZCuHXteFXMyKyu7VyWgS+nFRy5F2Hlak1dlH3nsRscvX6c0yaKGARTb6qrKFHt9YPUldjMkzBNg5qt0/6FqiUmbIp72/23Iq1v8e3v0xxn6REOGdWdMeC8iQSf5XvUj59kww2B4f3vGkR58DB2IomaXbnDO0xXLMwqYE0g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(508600001)(6506007)(110136005)(38100700002)(54906003)(55016003)(316002)(2906002)(107886003)(5660300002)(26005)(9686003)(66946007)(71200400001)(66476007)(64756008)(66556008)(66446008)(8676002)(4326008)(76116006)(86362001)(186003)(82960400001)(7696005)(33656002)(122000001)(38070700005)(4744005)(52536014)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ccp7ZoY/z3/704xCDf6+1rXYpnrI/aXK6OZAffZVjv3o2SOyUpHFFBvlhKQA?= =?us-ascii?Q?FhPnG+KRzp16WaGggU7Zdf3Om/LTM/lTfEWhcaTguP4EcgY/DsH+jh3eqb8s?= =?us-ascii?Q?SQEdekQYJvUlXmIXZwrUUr8JRYT51pjltS3roURzsPgQMc3EMoUhYRewZUYd?= =?us-ascii?Q?JDqGODcT9ZxPiy3Dr54aSLSO6SleSy+oU+9rCZRhtjk7gSFXBmFLURLX6aLI?= =?us-ascii?Q?8nKNWxV+W1AwgXB8hMpNnaA20QaQYG4HYEQmkiOY1cd2QyHRB0ai7GVordoC?= =?us-ascii?Q?yjkBhz1QgBggAnPrYfVq5svuKfLvJsUXmLa8ZmmAvaz1Uk+gtxbov2MjXNie?= =?us-ascii?Q?Ss9AQo5WdsDFbSd/LCNGOpeKb1bba/c4xcXzBf6neNiChqa+zFzypusKTV3r?= =?us-ascii?Q?0KQJpSATmBKjIK/MAmUTC2vOY2Pkad9kx0hlgTtz+ZqfVdpXk385/sK1LDi0?= =?us-ascii?Q?7/u6m2PgYV5LyXPAjtNGjnD41dSPLXk6ObcOsnCuawXZHYoqVeq11UToQCfL?= =?us-ascii?Q?fwFTFU5yFb3EHz6vE/ZK3pAnI4xayg+8XiqXhSSKL7lOFlQQtcK8YrIzj4mf?= =?us-ascii?Q?ggfvg1KDE4d918KIsln29Qm5vZgHZuqiEhFqWnsZFx7tQK9Fm1ptrN1zx360?= =?us-ascii?Q?DDEwwmeNWW0688BxVvQvEM7l8nm1DFgK/m267Ek8eC1IIKLTx10xWUPGC5Uh?= =?us-ascii?Q?ZVhbDqXy3wQW7hwo2OblTYRctqdC2hO5sbKW4ChchBD+qqokchr0vhcJMLni?= =?us-ascii?Q?9Mf1g+ly4bYbnOm+tUV7EreFykNntvWsVCmeUEgV2uxhloAESk3gGu7GNKX3?= =?us-ascii?Q?JkG+0e7tBDGD6e78jx1pWvYhigcVaogaMlNXdPP+nsOtcELjIelwHBIiAjBd?= =?us-ascii?Q?+F+odpR6Bw3XEFMVzYvc4IvRAx/XCRXxAK75vyEOJR/5xI9wPeyL3+FcpffT?= =?us-ascii?Q?Tbg4VPa5qMV1ASpwRYXPOIYdlEbC2OENLhx/0cdMu1V+b/WLODeLNkEJVRzQ?= =?us-ascii?Q?HifunTT8bLYzS+8UdbyKNuP1yQqCwQ2XV7SwHFu7H8D/5iE2f+yEPwJHA0B3?= =?us-ascii?Q?3M/WCZlwUf+FmFGIzT7EXF6MSBsjDmbC++b64fUGMjYXo0AEU3kzPrSDFiJz?= =?us-ascii?Q?lkL3uwiLw4yQFZY83Q5gtklBienlY5m74kg5CTfXPAjw5ZTjeh0W2U/Ek/O3?= =?us-ascii?Q?rH8JJD6wgdrHelYI40wlmr2NI9x06ZKUpj5lLxZEClBHS5MIAsgErV2HIu+3?= =?us-ascii?Q?n5e8OeqB7TdI9z9O4kDWk2W0heVgBuNnk38uwVKhvbxlP3gQ6zDaf0drBBPX?= =?us-ascii?Q?LY8WVZiheXj+8mf/RqRgws4oflIvOx+am2sIeCV+Lq0ie7g5BHo+WR2H1SV/?= =?us-ascii?Q?a00crkE1aISOL13P4+UTH2sz7IA4WbLAHrrb6JBPVrVUM0SGirt1cU5pyfZB?= =?us-ascii?Q?mYBFDzMXQ+q7oFYxrCFz+Go4MBD6V47afgzMSa0ho7QZhFNFcAidt4rYR3p7?= =?us-ascii?Q?gxOetUHPfdLXfeZBhTzOPMtzhHUkwIt7NgvPcxR557Wpvu9MR0OZ1xkmDfe+?= =?us-ascii?Q?cLo0gv5I7iZHaD71N8oVa2raikIjvH7/worOCysQyxvNduflWtO+GGcwjclN?= =?us-ascii?Q?bHdxR17ahp0+BHvV05ANXJfHPKqmDcRRk5BAeOi92KsB4sJXNE44C9RA88GH?= =?us-ascii?Q?kixZJpu9ILmjb666QnzfOHBnKjJ1ZcuBFC0TLYdzkT2MISdR3O2bVAhFB78/?= =?us-ascii?Q?fMOhFxliwYtU5DUl/6J6NGC1gkoKx6g=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 410016ea-aa78-4ff3-4c54-08da37ef96e8 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 10:25:39.4707 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d0KiuXTRP53N1bPuhZaPNTUs0vKD6RDBVQ+5QFL2xqiOv/Oz7SfeQQ39LFtNpwY7sOOfY+kyqF9Zqv0f2TwXsoIBG4GId113UYnbBvxEtDc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1863 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 10:25:45 -0000 >> Mhm, I don't think there is an actual test I can write to trigger this. >> All callers prevent it from happening by checking btinfo->replay. >> I am just making it more consistent, as the function already >> errors out in the case of just gaps. Another advantage is that this func= tion >> doesn't return NULL anymore, which seems better for future callers. > >I think the patch is still fine, but at the same time it seems like an >assert would be just as correct. It would. But the proposed error matches a similar one a few lines below. LGTM, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928