From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by sourceware.org (Postfix) with ESMTPS id EA9CA3850855 for ; Wed, 14 Sep 2022 08:19:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EA9CA3850855 X-IronPort-AV: E=McAfee;i="6500,9779,10469"; a="299182233" X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="299182233" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 01:19:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="647296451" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 14 Sep 2022 01:19:46 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 14 Sep 2022 01:19:45 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 14 Sep 2022 01:19:45 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 14 Sep 2022 01:19:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vqn/T9enokss+jHbqEKFS8lhgGy9wSLNTFIQHcpbmWwoo1vggcuarqeXaAaZbrxWXgMyTYCXuX98W1UHBbzDDFoQR0jk8Or2OwYsfOXu7sGlLTlsf+oNbN6wHtCzxL6h+/2MOnnCy1Ugb3Y6iR0ACMhl/jLmCIuEhoXT2FiP81/KuNCzKBjiJJ4bhy8uCu242VZuAuJn1I9LYVa3IHGompUF9EUt9WsW4KB75+ticOf5UD3osqDzPXr2Z8PqqKTQNUI+EMs/tXPxzXi5jkj6/AWXqe9MaKPew5oWpUw6b+Y+aopESg9Ba7mUfIveU4tDceZWAI/LTDU2v12hKNCIYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aqQiBdls/dTWNs8GbkcYeQGxgPoeNap601M4UYf96ZE=; b=mguV0ZtjsrL1yv43cJwzGMOpeA8T6ebl6e0zHpL7bhHWiE6uH2JZWX1ibGMibiT8c6gmLFsrsf7WphXi0QXURlARb9GTqVKxrK+BdXmm1CSi2LNJyexLPJiPUdn5Vib40jqB937cI8ZD7RyFbN2G8j4W9YXdfyjrUjfZAQSeLLFabjKXIDda+jbuyxGAzX7hu4GceEY+DXISBaQmRsH+6Y4fjxFUfhhXwYjOoZr5pnisecOdQ1GKf8Bw7Znm9EGKHVmBiIOd3FjWUm/6oO6NrF5calIsYZkaN0Usu6L4TgaJce5xO+NpzB/4waU2+SEAW1TiyfT7LNVFgDxNoq5KbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by MN2PR11MB4614.namprd11.prod.outlook.com (2603:10b6:208:268::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Wed, 14 Sep 2022 08:19:42 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::31a4:5c1a:9107:3ba6]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::31a4:5c1a:9107:3ba6%7]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 08:19:42 +0000 From: "Metzger, Markus T" To: Tom Tromey CC: "gdb-patches@sourceware.org" , Kevin Buettner , "brobecker@adacore.com" Subject: RE: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all objfiles Thread-Topic: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all objfiles Thread-Index: AQHYdo0jKz6X0SPP3kqfqbf3DASq362D40hQgFtU7dA= Date: Wed, 14 Sep 2022 08:19:42 +0000 Message-ID: References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-9-markus.t.metzger@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5749:EE_|MN2PR11MB4614:EE_ x-ms-office365-filtering-correlation-id: 067d61c0-4603-4ae7-af7f-08da9629e05c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TnnAUKXCPj8ko0ZNS53M2zbe5gpwu6vAnh7OTAogbKBp/KlZmczBWWMPoz5Tc5Fxr7MJU/81mEPLSH+Dff8pjdSbenRGB55gUyNFyWypcsq0WDVngntCAQdhrd1NcLY0yCfTAiuw1R69GIfrg0aoz9f7WAOuRZl7/yXbfD+EI35YzBawbLQK3mW13wRD2Sz2g4KPb9fL6K3nqqESeWDJuNAbArX0UcFqseJqOVbAjXKjCbGihm3LpECozdaxU3dfKINa7FE2u89iscBZA86X3ctGoJwb3xFSGQMlo2Xe+SXFCwT22uG0ngFKtPPqvlqE4Afw0ECOcqn+81pbSBDdivg1l7+bXPb3VBli7eFKk15446s0rJ7xoP522VROOFvGaYzsDlIwb69WDTUnXEbA567fg+kwP05kWitbDB0+Ke9H+jG3JIXzUp42/wLH3Xp5edFBx+WjcnS/xJnWxD1/GKyvLOV0Fi0lDwHUWDgkoWubuAEMGIDQgVDub35+eGJnkJicQWspcEXR7fIyRB0OBS4Rmd+G1z9pvFzZEKjRP3XQQwbfqUMDCO9WkHt3Yr8jhLV5G2bg2MMblMue5hUs6fC7ZQ71PA25zDixPbYTqWwPvJ3SzuQdLq5TjimAcdtJL0CeI4lUN57MLTsCNe61JkjNqXKRadxjlZBJYD2bI7H7EALeBOpQN2+3RfWVzl9pRRUnZ+6n4rHOcgQC1sTdu3FCFPwHCV5/J351dT5pD77YkWCeYKE/cctVFJn6uCC4A/3eBzopEYgPc0hvPuNPWw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(366004)(346002)(396003)(376002)(39860400002)(451199015)(6506007)(316002)(2906002)(55016003)(41300700001)(5660300002)(66556008)(9686003)(478600001)(82960400001)(38100700002)(8676002)(64756008)(26005)(71200400001)(8936002)(66476007)(38070700005)(66446008)(186003)(6916009)(76116006)(83380400001)(66946007)(54906003)(33656002)(52536014)(4326008)(86362001)(122000001)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x3+YLK3c71QC7I+vxiHSmk9zhGWMxA6F9WhKUZlEPax6XsuHOwV3ZwIhZWZA?= =?us-ascii?Q?V0o5gM5SQptAQJ+DAYeGa+5LrD/TxN9WeEExlmljAmjewIIlzczXZnYp/DoC?= =?us-ascii?Q?gCLC8OYBTfDG/nANlnqETV5jK1HFJBDQ0OUJvPTPYhy4OY191lDZ8cxddGfd?= =?us-ascii?Q?YWWrnxeAzqCC9d43ZTlqrB/uHnDFLEvvlZxpckYhanWKutQRFReEC50EBQpw?= =?us-ascii?Q?76nOgu89TdL45aHSs1XIhoGK+VM+pqwAEQfuIYahzMFo8+N/vRvp//jboFhc?= =?us-ascii?Q?uKOpPXhzMnC1fl5QkQmqlTPR9pjFBoH1sM4FGCY/GqMgcPcz0J/Rna3bUz0X?= =?us-ascii?Q?hGZRJXIBeWiUIv/pO0smaljqY1hvNnkA+E5yMPHZSlgAsjFWpvWGtuya1YFk?= =?us-ascii?Q?g0GkPAGhnAfxzYdGISpsLt/Wb/p7xVzwifAYpqrDi3kxlK364lAWq6b09Uf8?= =?us-ascii?Q?R6nJ0dd0HbZerqO4VgR6jou+z8hnOIWZLCBSgwZHjrMOiC6OV0JDCHW/PVql?= =?us-ascii?Q?8IhKwboRTWL3ik/wQu3WOvbPHJdmJ2QZ07JkTLjeObfLr4C8iwWhvwqN7RqM?= =?us-ascii?Q?kl7qh/obr62gY210SqabhsHZA46Q87aE91y4BWGq5YvHX6wNgy8/B3GrmjLJ?= =?us-ascii?Q?Zyo05bJf2WNEt0xDjFV5m5Bz0gXPNVo0llDo4sgBumeRqI2Fbv2jLD4vBiWN?= =?us-ascii?Q?trZLHEP/Y8K/wyswEcGunwY9RI5b8EHdp18DtpfRFANYPmd5PWSgxa7+vxRA?= =?us-ascii?Q?c3m9BFNsLxZ7OZZyIQnnVL+/38byDEj/y0jKMb2Cb/5eHDMSpYj+OPMs0JbS?= =?us-ascii?Q?jtwufMdGQE6LL8FIKC8oOBdX0kh2Sg+sHxZ6p/psgLwZhjwONOL7duLUldpr?= =?us-ascii?Q?GGbjaq4m95jsmQyuXvSNHDhFWIXMBgH4CSechwyCoL+cst/KRz5fKgO5czEg?= =?us-ascii?Q?dkRU+g+dCZHs9S40XHjK6IVG49uFnZk1WEjlnEgszfIL/HnYmF8Koq6a3n7b?= =?us-ascii?Q?hHde6kTUbF2KwfKGYji0eS+JhPXfS/gR526PxyuQvTqdsIL54Ty9wIMDoA1y?= =?us-ascii?Q?A8BvNofVurRcdKqJuFjIqMPVvgnyrY38Sgii2IQ7XUqV7U867DU4HRMGHKbW?= =?us-ascii?Q?A6B7Q9yRmzU2aEFhMXU6qa7qpx+W7HMYRkQa1+AOipnmdXdghGJ3MtgBrZsY?= =?us-ascii?Q?VZi2dQYSXZIRwBHRpjE+xeC3MoUjGRg/b4DUO4d1ZcFxRHB3NrME1gpxv/pT?= =?us-ascii?Q?0QMDpOCwu+fU33Ih95UelPkDnfmQgrVV0Kt63gT7rNT4/YctzEPDHNGED+t3?= =?us-ascii?Q?WuebGYydQIr1FhmsP4QiipB0xuDAMTUggnGW3bJ7LtieJ+G0NqpBr7FwSMhL?= =?us-ascii?Q?W8IgQ5nLa2ysSNwizSdInQsfFF2BY7/M3IvMK8mMTU7H+015VSdP1mevYAYl?= =?us-ascii?Q?2jqv08J2UKCnFc3+Q1Z7BNNqB9UohrKGFggxfLFiM9gXlBSvR4VmrHxuiiJd?= =?us-ascii?Q?ooc5MfQoAyz/cqKJP3cWDeRLgHjeqxXrTIoGi8R/XTcrB2Pw338H4cIkRR03?= =?us-ascii?Q?lC5q9hn2tT5m3qQ0C246b54553XTVx6zbzQBVLiLLoB0GCJPeMbOxhleE35H?= =?us-ascii?Q?UQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 067d61c0-4603-4ae7-af7f-08da9629e05c X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2022 08:19:42.7873 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I9tmQUBTk5soSsGQqBmWBGEIYbeGNJ62gDg3Qc8aSE17uDnc3/IpRGrz8iU9S3XAES1D3AEAvWQku0Y69zi23th72yZMzsKnITftNFoOvYc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4614 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2022 08:19:51 -0000 Hello Tom, would you be able to review this patch? thanks, markus. >-----Original Message----- >From: Metzger, Markus T >Sent: Montag, 18. Juli 2022 07:36 >To: brobecker@adacore.com >Cc: gdb-patches@sourceware.org; Kevin Buettner >Subject: RE: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all= objfiles > >Hello Joel, > >Would you be able to review this Ada-related patch? > >thanks, >markus. > >>-----Original Message----- >>From: Metzger, Markus T >>Sent: Donnerstag, 2. Juni 2022 15:25 >>To: gdb-patches@sourceware.org >>Subject: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all ob= jfiles >> >>When searching for standard exceptions for Ada, we lookup the minimal >>symbol of each exception. With linker namespaces there can be multiple >>instances in different namespaces. Collect them all. >>--- >> gdb/ada-lang.c | 30 +++++++++++++++++++++++------- >> 1 file changed, 23 insertions(+), 7 deletions(-) >> >>diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c >>index 6ab01fd27d4..2b251693b72 100644 >>--- a/gdb/ada-lang.c >>+++ b/gdb/ada-lang.c >>@@ -13016,15 +13016,29 @@ ada_add_standard_exceptions (compiled_regex >>*preg, >> { >> if (preg =3D=3D NULL || preg->exec (name, 0, NULL, 0) =3D=3D 0) >> { >>- struct bound_minimal_symbol msymbol >>- =3D ada_lookup_simple_minsym (name); >>+ symbol_name_match_type match_type =3D name_match_type_from_name >>(name); >>+ lookup_name_info lookup_name (name, match_type); >> >>- if (msymbol.minsym !=3D NULL) >>- { >>- struct ada_exc_info info >>- =3D {name, msymbol.value_address ()}; >>+ symbol_name_matcher_ftype *match_name >>+ =3D ada_get_symbol_name_matcher (lookup_name); >> >>- exceptions->push_back (info); >>+ /* Iterate over all objfiles irrespective of scope or linker >>+ namespaces so we get all exceptions anywhere in the >>+ progspace. */ >>+ for (objfile *objfile : current_program_space->objfiles ()) >>+ { >>+ for (minimal_symbol *msymbol : objfile->msymbols ()) >>+ { >>+ if (match_name (msymbol->linkage_name (), lookup_name, >>+ nullptr) >>+ && msymbol->type () !=3D mst_solib_trampoline) >>+ { >>+ ada_exc_info info >>+ =3D {name, msymbol->value_address (objfile)}; >>+ >>+ exceptions->push_back (info); >>+ } >>+ } >> } >> } >> } >>@@ -13122,6 +13136,8 @@ ada_add_global_exceptions (compiled_regex *preg, >> SEARCH_GLOBAL_BLOCK | SEARCH_STATIC_BLOCK, >> VARIABLES_DOMAIN); >> >>+ /* Iterate over all objfiles irrespective of scope or linker namespaces >>+ so we get all exceptions anywhere in the progspace. */ >> for (objfile *objfile : current_program_space->objfiles ()) >> { >> for (compunit_symtab *s : objfile->compunits ()) >>-- >>2.35.3 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928