From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by sourceware.org (Postfix) with ESMTPS id 4AA6F3857004 for ; Tue, 19 Jul 2022 13:49:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4AA6F3857004 X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="266893481" X-IronPort-AV: E=Sophos;i="5.92,284,1650956400"; d="scan'208";a="266893481" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 06:49:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,284,1650956400"; d="scan'208";a="687117123" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by FMSMGA003.fm.intel.com with ESMTP; 19 Jul 2022 06:49:47 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 19 Jul 2022 06:49:46 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 19 Jul 2022 06:49:46 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 19 Jul 2022 06:49:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G42pRl8Nlyxu6A8BMfRoBfYA00MLzHAwi8W4XWkUkTK04Remat3Gheh/Ge+udKZ96nK0vHRG1OPVMbVeICEwLbdvYATF2s/yGG2wJ8IRKmxCWXAwiJxsPSmVsIPuZL1pkJdcMoFjvnrf4qzDm9qOxUCHfeRrrzxJEANNaoN5A9/u/RokkH/CQpOGK6VXYnA/6bJmug+08Q5DZSyoHjJDV8znTpllsD9WZQxkLjuNlNurzp/SuVfaF3qNp0ROHdxWv/3ACRnF3x98zJ3UTgHg2yfNKkMHvV1f8wlMWSGGNAGBZ5Woe9owU8+zY+2tJThvLKrdRY+SiS7aBHnWvKcpPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X+El8FIUhlED8wB9qtOfABuzJP6Qjv7fiVGjqu7KdfI=; b=Eo/5EVATxPTSmMka5p+NlthMniB/Rr65YWbMLd8IaIWQTg/hJmhWo2M45vK5g2X+wuzRsxBn2oNl737fY1eDq+QJ6c1vfEOc4mGH3IzUac4prnEy5hMKBOu7Gu1Hg+FBY3gzJn0rgYigCc9NgJ0duzTySmTr43atoOp2EVWOH1QJb+nma9/DmIE/3d5sJRNTUEhNPhIKAjRDjpRfm6+t3HHDzFj1VebnfgCd9kGUZtHwwOyI+5KSbd6TFr1y7L4nEN/TjYP7qYbjMuu77Fr/TP2sAyBFjIidDudZBhzUb2iWRTDpXOhR9i0pA630csZmSM3zXKqyc94b0gNF3UIgTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by BN7PR11MB2867.namprd11.prod.outlook.com (2603:10b6:406:b9::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Tue, 19 Jul 2022 13:49:44 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db%8]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 13:49:44 +0000 From: "Metzger, Markus T" To: Tom Tromey CC: Markus Metzger via Gdb-patches Subject: RE: [PATCH v5 10/15] gdb, ada: update ada_add_all_symbols Thread-Topic: [PATCH v5 10/15] gdb, ada: update ada_add_all_symbols Thread-Index: AQHYdo0ndIJn6EeTUk2Mt3QRO5uR662Eoba2gADPglCAAHaeGIAAFGqg Date: Tue, 19 Jul 2022 13:49:44 +0000 Message-ID: References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-11-markus.t.metzger@intel.com> <87fsiyl5pp.fsf@tromey.com> <87tu7djnpl.fsf@tromey.com> In-Reply-To: <87tu7djnpl.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b5bc84c-9978-4f9a-39ec-08da698d899d x-ms-traffictypediagnostic: BN7PR11MB2867:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MFitBYrQrMzs3QEVOVzk5Mh80RUziGrz0fWkmWu77tQNJwlQZCSNQT/vwRxpQTSEnNm81QGDgpHG6IxkBP+gi/qFHhDMx92YDTly51PiM2IkP4nnMyBuvhTfLvPp0c3Mcazj3Nq4r0AwbirSt5KryoEqKw/c+INknI8dOUP0u9p9nkLj1oQmhEc2ykiO1xaYcV/29iEUyAbWgjp9J4v480U8OxoG6puIAePGGl0dg9Qesw0RVldcY+z6hCtCIwHkp7ioGAz5M2s4jLcRLcpvK+9snxuLIynNnOJw4raQiamG3LL3Ff29vGbsxMv0N67NtRX7yssUvBMBtfOpfIBEb+nShDlHP6l5zIsXx6eu4Vw4Gm7M2Kf8US5BDbbCoUSmAcu9hwxqC4UyJrqmrIDUn/S1ZoXBwfhf38vv0Hf1fi8rraNSwWBVAmxvDnt2op5mwruVz330iY6poLl2cM6S/pqViYraFGdwN4EMWCqMza5QAxl4ICRlWguedmhfsrB/uuimYVWaA69QoOAAKAck0nUBXuBLyVZUm7zZi7ilBtT7MSAH96nro9lQ0mYuCrXEuvagCWWzl1r3zOTQ/hmlkrFGQ1NENnSOryzsycCP1mx46BKtUqzFCZRLhvz8i5/vY+pGVzxnQoZcRgaVoYngxq6z5Qr25pPEOADLbYBoVG5xWULFLD0jOQSE9U2xb7C/9fqUnHGy7EoAwSvd3vhsE2MQdzB30MVJP+ZwUX2rCaRl8teqI6YLb8jkXJC739MvRMQPHaRBAer8Fu2SRJNeNfCOtXcOyURI+air/WNdJt4d0zIa7UJqKz1i6xJqslmd x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(366004)(376002)(346002)(39860400002)(136003)(316002)(82960400001)(55016003)(122000001)(38070700005)(6916009)(83380400001)(38100700002)(41300700001)(4744005)(76116006)(8676002)(66556008)(66476007)(4326008)(2906002)(71200400001)(66446008)(66946007)(8936002)(5660300002)(64756008)(9686003)(186003)(478600001)(33656002)(6506007)(52536014)(26005)(7696005)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yAeXIPBWvgQflY4AbblIrPLe7sfWSyGWOV8XE7hMCqUJYksI8KOMffoO5n5T?= =?us-ascii?Q?qIFVH/2CTcaY5LXyWkXXQ52xd2fWMEIOTT8pCLCpiEbs9CNBS223jptQ03CN?= =?us-ascii?Q?ILZ3d0MGDOLvMCivvGVksaoJS7j7ezH0EVq3dprTwIok0U1aKLY5ReEPYs70?= =?us-ascii?Q?dKLTsZFmiH4hL8Enar/yNIsctXOebigQHJvMHyAyz3acAQ0yQCNCCfm2aDVU?= =?us-ascii?Q?ATXxBkRkoyGAwcDBQOLzu3Dt0ZgxbzcBV9k4u50ScmBcKbzeXCGB6helYt3y?= =?us-ascii?Q?RHiuI3nr82fdxoa6g7yzYEmbgEhlIGxekoI8+x8h+8zDmmPK268hXoEGGkGT?= =?us-ascii?Q?VD3dHEXZEWxxq1ho6MSPNpSkp9q770tGXH9VBhvyUO4nqLNMu/TJ67W18bB5?= =?us-ascii?Q?8Mz4pzPxA7awmIYwVxSRCy3j6Hv115VAOGNcFZN520HhR4E/VQ9+K+GiFCex?= =?us-ascii?Q?B0SzFbti2bOQM+dCWYeKDrQDoqFbF0r6X/d2dYLcezZBuNgmFKp0YodyJLBv?= =?us-ascii?Q?uWY/7E0gHeej22axrj+DKf491+mDkTcWjHFb4LuFDRthpz6qPK/WZvRotNwQ?= =?us-ascii?Q?mQEzRpuRUb7N/41dVlU6Bsxj6jt7E/pOHeOgsH/x/BT/8x1SEsvP9VgjIneK?= =?us-ascii?Q?iXeOwaTjh7M85KsNC5Zi9HUEWrmK2Dr06VtOCg33KJbA98vT6n/aGVofQ1zB?= =?us-ascii?Q?z/YD5j3DCZMuQ94WNYCETtFrd6OJTLzIoxCXYm/Q0L0k6tj3vhOwrFwyTixP?= =?us-ascii?Q?cxqyWXS3+tO94k80RmceGbn5CGz+6v3wyHGINiMyEqQgMCVcQZ4KWU3gkrD+?= =?us-ascii?Q?JLsXCc4RY6fPky2C/NOp4Y+wk5/tTUwPe7TiA6sLbMWhQz4NMW2t7IbsrqEW?= =?us-ascii?Q?r4SSDDKWbswQQFBICRWcWy0aEejfXW7IIFwFOLLX7Na4xlE2VUtWFyRfzfbk?= =?us-ascii?Q?+4epsgpDbsTvJtUr/Gd9wAxwbaBJ26My9c/wpc4/pLe45OePrV9s7czJMdxo?= =?us-ascii?Q?aCmRH+P4Fi8wwVvGNciq/zmnXkXxZV+gmU93iQ/GlKnVTssGJ+nkiIbqQMIT?= =?us-ascii?Q?DpMx1rTNVYD+KXF5yYZNgQAhS1yL2HjcvA4Y+vpIBMhvYn4WpFInefOZ56LI?= =?us-ascii?Q?iZLPbK9yxtX5muciWJ4Vb1XqM6xxoAJeDiao1zODJ0M+cTGqiB0TY800N0OB?= =?us-ascii?Q?1V0YJdy2xtZ2b5N2bIemAuCBT4FU3lAd/035TWhQNrFt17UxRuP9c0dYQn8b?= =?us-ascii?Q?E9ynpbk+DrZbbkS2dvudlLnnZf93nMmoe/Ic1xcPZgVfADmfwasvlNfOGbjI?= =?us-ascii?Q?O3QIsnpAi3O6gnlwUtvimcJWFtYeQiYBEzA3teO65vGjVjuLN4XrnUusHPDi?= =?us-ascii?Q?BDl2F7lAfm89EUAv8PfFOys4p5EdfuX4K9KU9J7doqwaDIMt0rEHcroIskeI?= =?us-ascii?Q?/bWOVYhSii0huX5PAj9a5sLsIh3LmxFZLhYeYsfjuqf9btz2nG929m2GL4/t?= =?us-ascii?Q?h2gsr3vMTvi1xx8SZ5jZF6vdPQpIpp8K0uJ9eHr9xRLQi6jhqJixpIcu/iNQ?= =?us-ascii?Q?L+55+0yZBZtlfsLieWEo6INL8Jv07EVXo1N4yn2nAUf6WKM1GKfxM3bPjohP?= =?us-ascii?Q?+w=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b5bc84c-9978-4f9a-39ec-08da698d899d X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 13:49:44.6278 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BCUsb01LwHDkYolGHUlLMr2AKG+PoHtx9QjRFqG4BC7XIMsVrniYC5O6WPZFUM88S4xmYnc/oCU6MTYTRT+KXXq+r5ob+3YjV5VUMNqsHlw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2867 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2022 13:49:53 -0000 >> I was simply trying to preserve the existing behavior of not knowing abo= ut >> linker namespaces. > >I didn't really read through the rest of the series -- was this the rule >followed elsewhere? I think it shouldn't be, because in gdb a linespec >should find all the matches. The patch series adds a C test that covers breakpoints on source line getting set in all DSOs in all namespaces. A handful of patches, including this one, tries to replace direct objfile t= raversals with gdbarch_iterate_over_objfiles_in_search_order. >> Would you want me to drop the patch to keep the objfile traversal and >> collect all symbols from all namespaces? > >I think so. Dropped. regards, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928