From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH 0/4] gdb, btrace: infrun fixes
Date: Tue, 21 Sep 2021 09:45:24 +0000 [thread overview]
Message-ID: <DM8PR11MB57496593408488F211BDBBC4DEA19@DM8PR11MB5749.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM8PR11MB5749B5C3573747241B91B05ADEEA9@DM8PR11MB5749.namprd11.prod.outlook.com>
ping
>-----Original Message-----
>From: Metzger, Markus T <markus.t.metzger@intel.com>
>Sent: Wednesday, July 28, 2021 8:42 AM
>To: gdb-patches@sourceware.org
>Cc: Simon Marchi <simon.marchi@polymtl.ca>; tom@tromey.com; Pedro Alves
><pedro@palves.net>
>Subject: RE: [PATCH 0/4] gdb, btrace: infrun fixes
>
>Ping.
>
>>-----Original Message-----
>>From: Metzger, Markus T <markus.t.metzger@intel.com>
>>Sent: Tuesday, June 8, 2021 11:06 AM
>>To: Simon Marchi <simon.marchi@polymtl.ca>; tom@tromey.com; Pedro Alves
>><pedro@palves.net>
>>Cc: gdb-patches@sourceware.org
>>Subject: RE: [PATCH 0/4] gdb, btrace: infrun fixes
>>
>>Thanks, Simon,
>>
>>Adding Pedro and Tom. Maybe they can help review the infrun changes or
>>recommend
>>someone who is familiar with that code.
>>
>>Regards,
>>Markus.
>>
>>>> This small patch series fixes a few issues around reverse/replay stepping that
>>>> result in hangs.
>>>>
>>>> Tested with record btrace on IA.
>>>>
>>>> Markus Metzger (4):
>>>> gdb, infrun, btrace: fix reverse/replay stepping at end of execution
>>>> history
>>>> gdb, infrun, record: fix hang when step-over fails with no-history
>>>> gdb, infrun, record: move no-history notification into normal_stop
>>>> gdb, infrun: fix multi-threaded reverse stepping
>>>>
>>>> gdb/gdbthread.h | 7 ++
>>>> gdb/infrun.c | 87 +++++++++++----
>>>> gdb/record-btrace.c | 19 ++--
>>>> gdb/testsuite/gdb.btrace/cont-hang.exp | 47 ++++++++
>>>> .../gdb.btrace/implicit-stop-replaying.exp | 105 ++++++++++++++++++
>>>> .../gdb.btrace/multi-thread-break-hang.exp | 92 +++++++++++++++
>>>> gdb/testsuite/gdb.btrace/step-hang.exp | 46 ++++++++
>>>> gdb/testsuite/gdb.btrace/stepn.exp | 56 ++++++++++
>>>> 8 files changed, 430 insertions(+), 29 deletions(-)
>>>> create mode 100644 gdb/testsuite/gdb.btrace/cont-hang.exp
>>>> create mode 100644 gdb/testsuite/gdb.btrace/implicit-stop-replaying.exp
>>>> create mode 100644 gdb/testsuite/gdb.btrace/multi-thread-break-hang.exp
>>>> create mode 100644 gdb/testsuite/gdb.btrace/step-hang.exp
>>>> create mode 100644 gdb/testsuite/gdb.btrace/stepn.exp
>>>>
>>>
>>>I went through the patches. I know next to nothing about the reverse
>>>execution mechanism, and don't really have time these days to get up to
>>>speed to understand the problems and associated fixes, so I hope that
>>>someone more qualified can take a look and approve (although I know that
>>>this area has not been touched by many people, so I don't know who that
>>>would be).
>>>
>>>All I can say is that the tests look well written and adequately
>>>commented, such that if I ever had to debug them, I would be able to
>>>understand the original intentions.
>>>
>>>Simon
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2021-09-21 9:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 9:34 Markus Metzger
2021-03-16 9:34 ` [PATCH 1/4] gdb, infrun, btrace: fix reverse/replay stepping at end of execution history Markus Metzger
2021-11-03 13:11 ` Pedro Alves
2021-11-22 17:23 ` Metzger, Markus T
2021-03-16 9:34 ` [PATCH 2/4] gdb, infrun, record: fix hang when step-over fails with no-history Markus Metzger
2021-11-03 14:51 ` Pedro Alves
2021-11-22 17:23 ` Metzger, Markus T
2021-03-16 9:35 ` [PATCH 3/4] gdb, infrun, record: move no-history notification into normal_stop Markus Metzger
2021-11-03 14:58 ` Pedro Alves
2021-03-16 9:35 ` [PATCH 4/4] gdb, infrun: fix multi-threaded reverse stepping Markus Metzger
2021-11-03 18:43 ` Pedro Alves
2021-11-22 17:23 ` Metzger, Markus T
2021-04-13 11:43 ` [PATCH 0/4] gdb, btrace: infrun fixes Metzger, Markus T
2021-05-26 2:49 ` Simon Marchi
2021-06-08 9:05 ` Metzger, Markus T
2021-07-28 6:41 ` Metzger, Markus T
2021-09-21 9:45 ` Metzger, Markus T [this message]
2021-11-03 18:52 ` Pedro Alves
2021-11-23 11:33 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB57496593408488F211BDBBC4DEA19@DM8PR11MB5749.namprd11.prod.outlook.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).