From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id 76CCB3858439 for ; Tue, 19 Jul 2022 07:14:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 76CCB3858439 X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="372720995" X-IronPort-AV: E=Sophos;i="5.92,283,1650956400"; d="scan'208";a="372720995" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 00:13:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,283,1650956400"; d="scan'208";a="665321147" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 19 Jul 2022 00:13:59 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 19 Jul 2022 00:13:58 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Tue, 19 Jul 2022 00:13:58 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 19 Jul 2022 00:13:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vx3ba+m321xnTGYgq7uxgymuUNjXwynv4Dzpmr4UOyoGnKcsP50mzxITkEjwYe3gZ8M1iEOX+Uy1hLRsBrRaZwsjU3GshmhqmEUvgOxZJPhO+25h05dLu8DI9F2mE7/e6FdH00qZa1NC91TOdxaoUzJMNyIz9NCfxJz6X5+USPEHxV/fHKE7ldvASJQS85wJcoeke9Bt76xzJK4Y8tA5ttkc9MITcLhiO3ICFPuAIE8vIZWTlOpn4/zjzuoiRTePwFRp49SASP2CD5LmppNG4H6uo3X5Dc8Narha0WmnlMr5q48NyFLTgJw/nK7A/FMbZQfXMS3RG3HyznDuyKaSTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T22DSHF9frDkixxiNDIbDGoUXn3TGxv0rYDC4FRETjo=; b=DNLIoii5qf4VAUh+9mB+N++mPjOikLXl5TAA7Ve0IiLDxlRPfLbHn9/fA82VGMznCMYqR5DQjxAyS8ZpIlP40v2k+9RVfpo3OCNMcreyG6zrZA12/EN5JTrnKfb3N26x792+xOiYJD5fUG9Qti7SampNlOwwRAakXjGaD59C4KB55zVIJ1lxRIIS4NmPo2DU2sAvb7WIw+p/UClQRlqEBRyNg6YoXKy4oEBZ5p/G/79Ct5VC/Om4AUDzSDl+ne6H+dbJselbuHuQYgjg41KeOeV4+DdZ1CfLvl73uBlixmmTGYgKZqfVhLwoJQMQuzrsBaKBaWg0FMjbeMKKwmcTXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by BL1PR11MB5383.namprd11.prod.outlook.com (2603:10b6:208:318::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Tue, 19 Jul 2022 07:13:57 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db%8]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 07:13:57 +0000 From: "Metzger, Markus T" To: Tom Tromey CC: Markus Metzger via Gdb-patches Subject: RE: [PATCH v5 10/15] gdb, ada: update ada_add_all_symbols Thread-Topic: [PATCH v5 10/15] gdb, ada: update ada_add_all_symbols Thread-Index: AQHYdo0ndIJn6EeTUk2Mt3QRO5uR662Eoba2gADPglA= Date: Tue, 19 Jul 2022 07:13:57 +0000 Message-ID: References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-11-markus.t.metzger@intel.com> <87fsiyl5pp.fsf@tromey.com> In-Reply-To: <87fsiyl5pp.fsf@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4e2ccece-0c32-45b6-6a2f-08da69563efb x-ms-traffictypediagnostic: BL1PR11MB5383:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0qF6+PZcvsgCqh4xXsvIN4V8bkJBhy5Wq4QlGyfkJk5pulPLCckzAmL0AdhJHtzGjZTJEP17AG9bz7L/hZCzOmx2Hsv6E1R71lnGPYsCEHHA6XMAePZIKGteAUETjclcGXRkSZ8CVjcHtMbyRQFApUW5rR06mD+iwUsPcD43vpr9IYk/RknytI+jsnHlM3RHL8GjG0Y0TuM8VrRq7l2olf0MohlGWQ9u9cUyuCJSd/k/CKldcshQTvolpAumee920NX9Us5rSGVB9iPDf/d5sAuqXu0sCSX7kgKPZVQD7n1wYM4N03xUdp9W/Li2dnErx0/osaRdNsmrpNMqhx854rPEdTQgmP79JUX8NPL5ipvhza/qOiOn6LjHE+Zvw2neEosODs90tpmYJtZRg+rlqT71Y8fcMtcCnpKuAoxxaxxq9+/VqHhk8tg2++lCmKbyGnbOWTg7U3gOuvBEMci58zf1WkIo+SG7+hwzmeJmsq+i5YB2rpniZXAPzZIwjZ3i6aKbnt7W+XL4pcGynhJ8cjg2kt+SWCLK0zE/ajd+NOg9bhFkOcIJHcXUoVazWEpb9VNkeoR49oHVCU+qCLi7kHdykkQw+/aG9qVYdiqtofGeq4uolwrrXoFYIVVCTlijkzDcf1u4uztkFp7doJWJyNzxkCexdV16qJjZxPb74/qgLyZ5ViXwwqb9D0vdOXkd1d4j4ZNWdhdd7ov6BisJiJA/k5Iegh9V4ii528IxJsQQAeUqD8znf7eWuNtu00XoAsU1Hd9jnITp/VwjnUl2N58C5jI/nskkqUJPH0T8iNdh/dn0fkkH8LmjssDuEC/y x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(346002)(136003)(396003)(376002)(366004)(52536014)(478600001)(8936002)(66446008)(66476007)(4326008)(66946007)(5660300002)(6916009)(316002)(66556008)(8676002)(64756008)(76116006)(86362001)(4744005)(71200400001)(38070700005)(6506007)(41300700001)(83380400001)(82960400001)(38100700002)(122000001)(7696005)(2906002)(9686003)(26005)(186003)(55016003)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JKsRHt2wUZwxOt7oFoX/qdkvGFRrTktzSt+UKfXYQnC9JSvCI5HAOpHiKG5d?= =?us-ascii?Q?6issFJUmoM+b11aUV1EY0R0n4yKQawQPoWxYwrs845C0qWNQw9MUZ2r8RrYy?= =?us-ascii?Q?fG6Gow1xy0zoMmZHf1NVTuc9WDYC6aKGyNthf9OJgF7h2aDzmBMfvU3yICVj?= =?us-ascii?Q?stY2Vd8STSgUbHK6Z5DIs4Y8Ksf3tvvRdwzggVZMtfeJe6Y+7Ua53mv/yWeM?= =?us-ascii?Q?mWxTaZJCC1cVTd9R30RQw5StRDmOg4+P8oW1rwW3iETkr/N/EHHRmyjEQC9O?= =?us-ascii?Q?kwWGnMMWwgPg/uW/23ZJrcE34oaM6sou99dudaQc9jjo8H8FXFvdYAdWQmxN?= =?us-ascii?Q?YVbkhLwsYKMTVZ/xg7jf35Ls1GewoDeAcBatXZVos7Zh/+NBTLdwA9A9EiVE?= =?us-ascii?Q?GRLwrOr/mo3NShaeK6Yi52iWkyPIpjdsCdFxQMI8XvKiFdwwn7FXSitvp7m0?= =?us-ascii?Q?OmHdoz9dANMPxsePjaqQnc0OtjUbKe3v6/u950ElpztOZsbW2IITtGD4ed4Z?= =?us-ascii?Q?qS59MKIS62jCVtC5za/egYQBrMekcKGwU6j9FNI20OxZRAikd4KW0Fpx4/e+?= =?us-ascii?Q?qJDEqxn/TG0HdPEWtjv7l0wC5tugLloUIfOl4q8nbS2GSFGrTWSF1eORXLV/?= =?us-ascii?Q?kUa2BJmnVX+3ifCeDteo8d0FLNV0Bn4nUnHp/th75+TQmaHC96wv/mwyTwLm?= =?us-ascii?Q?vpd58Uv9wZPdYFxn6zWFIUHpbaVjPFwfSUlQOvzrq1KrH0RqnvPrnMy93GkF?= =?us-ascii?Q?8M5611pwOE2Tj/F39ZIkTfiWAyoBL0THvNvonnAsQo3m0x1vpI/2QK+8L4b+?= =?us-ascii?Q?srybgx2b8HVFZKr0t+hzJfyrItsaGSO0/v4s+MaeXngXSBp9+395LpVrQgN8?= =?us-ascii?Q?QZUOKqLgnvNXJ1Uy+qUIYFLN3hksu6xboqUql1Y3+nqT5LqMdiFRKyvF3Yn0?= =?us-ascii?Q?/Q/gLefX64YJtUqkjFscH0Qp2yF0C9lBFZIIg193fwrBD26F0uoxPYO28RsS?= =?us-ascii?Q?zbTYo+syupBPIJ45UpWtGM0wqUPlTiHgfTMjMK64tJ/Z1g+fgoICupTeVnoR?= =?us-ascii?Q?PxGBVqtksUWqu51BcnHNiUnTpaG4hvZ3yIbmSqGWYGaQRp/eJq4Z+NaADiW8?= =?us-ascii?Q?CUaFt4/2w82I5Luhcwi4vd6czlo1mNTBllHiUgZxEqG3xeRcw15BMQvL9lOl?= =?us-ascii?Q?kCQXPyYBHe6Gu3JuSjH4ahLvSL5mfpXzVS9vLS3z8D4mPrHU2rZMmXw78VlG?= =?us-ascii?Q?RXO4niPKnSp5Bmx9bSdfLm8G08c2hlNmm1Ue2uvgOD5iEYDOv2AQ3KBflg+o?= =?us-ascii?Q?E9Si5pUPaPxtZXTxzt+2LrDL2HHUdzaJducXNnWvPJL+D4ClfkVOtApC5NXm?= =?us-ascii?Q?hqei7dgbRY09SvnD7zeKwCsmeyMf4WUtYPi/DzIN/eFGL+VBbnkvBqFVd+pY?= =?us-ascii?Q?WUg21sC+09Qu6hjOLHyvrG0o2iCp4ijYjnlhhH7wLbgDfNPOplr2gDFFtte4?= =?us-ascii?Q?xTeYCF06YpaUysBeLyLvTEc5WcxoqW4Uc7Aq4urSQisKVF+7Kia74rhma17A?= =?us-ascii?Q?7L11z9GhYjE0ebJa634HI6X7sS7FJnzZmLrcgOko4QGNUxH3WedZMIvSmHM6?= =?us-ascii?Q?rA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e2ccece-0c32-45b6-6a2f-08da69563efb X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 07:13:57.0489 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g11Fm/xhhEF/+Oa658Os+BOfGqOHBTG52Kr+ylDWwrdaS8zzW5/4qvQRLpZP+jUosugXdW2pS5bWAiI47d2n1yC0Cp2k98pQ524SGo6mct0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5383 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2022 07:14:03 -0000 Hello Tom, >Markus> Iterate over objfile in search order using the objfile of the cont= ext >Markus> block as current_objfile so the iteration can stay inside the bloc= k's >Markus> linker namespace. > >I think this function is used by linespec, meaning it's called when >setting a breakpoint. So in this case, limiting the results to the >current namespace seems possibly incorrect to me. > >Was there a particular reason for this limitation? I was simply trying to preserve the existing behavior of not knowing about linker namespaces. Would you want me to drop the patch to keep the objfile traversal and collect all symbols from all namespaces? regards, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928