From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by sourceware.org (Postfix) with ESMTPS id 47E08385AE5C for ; Tue, 28 Jun 2022 09:16:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 47E08385AE5C X-IronPort-AV: E=McAfee;i="6400,9594,10391"; a="282422971" X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="282422971" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2022 02:11:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="732675243" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga001.fm.intel.com with ESMTP; 28 Jun 2022 02:11:56 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 02:11:55 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 02:11:55 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 28 Jun 2022 02:11:55 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 28 Jun 2022 02:11:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XRAROsffX6h4VuDNcVDkNW1tE+4w7z93epckQqTmCr1xX4V9lOWMLP6qTveZ4IsV3MCEVE5VQ+W9Zu/m682TmpnYgzBZC/L7b/idUykpIeBXAJXHUYoj9bAlmjS3C9pc9tdvYOJXJSB7gyW64f8I0ASDI7oWjM9KvvtbEmMMG8WWijrNHjKMwlSZWwBepBmxt7iiEFJBWlk0gV/UHt8EYVrZAAPbUeutJEx67E0jMQJB/JfJlQ8YbQeIqs3ZQesdF/x7lZamEy2JOHsMixn+mhwroysW2ZySnNXnK1zEUTlDw3CjjvoRrCvmRP1RWWYrVyyoaKAPW4OO5wGE9AMr9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y+PG6F40SKUwEACyE/mdd7nrS+4pOvvqTG02kgQXz9U=; b=QPRtL2hX0Amq+GGHgHh/ME41spwxEhIDN9qR3mX9MU9zhLqTkz4fLvzylVZgfSg30dtGnMCbeULSnNoPXTTLyWYQHqILVK1pIhqP0+Ahr+3R9LAV7azH0ZhmIQWeeKwClOk/ydGwf6snMyp+3FeoDWU8TvgWyQs9+R/Rmgj/nh5jhTLWupxyhamZ+L9D+sQ7scGvrxwKvTxJtyLjTzy6nwc77OxdhliAI1SMHHVKGrN7yiCWJ8N35GtC1/HynH1ZjSmlr4oVWz5ZUxCZFeXZ6JzABi9AfEZo0rXeLOGuEeN3PcRAU+wo8daLokh9HlJw17nrtpjGFAVsH6m7vXJooQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by MN2PR11MB4680.namprd11.prod.outlook.com (2603:10b6:208:26d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Tue, 28 Jun 2022 09:11:53 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::f9d8:e8a8:94ec:58db%6]) with mapi id 15.20.5373.018; Tue, 28 Jun 2022 09:11:53 +0000 From: "Metzger, Markus T" To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v5 07/10] btrace, gdbserver: Add ptwrite to btrace_config_pt. Thread-Topic: [PATCH v5 07/10] btrace, gdbserver: Add ptwrite to btrace_config_pt. Thread-Index: AQHYhi26Q4hFa3uFeEyFNCwdvGTKMK1kirPw Date: Tue, 28 Jun 2022 09:11:53 +0000 Message-ID: References: <20220622114340.55830-1-felix.willgerodt@intel.com> <20220622114340.55830-8-felix.willgerodt@intel.com> In-Reply-To: <20220622114340.55830-8-felix.willgerodt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 311ebe70-1008-4dee-b574-08da58e63e2e x-ms-traffictypediagnostic: MN2PR11MB4680:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VY/ttt8kIay2YjdBsYt7xvCqIXyWblWYGMGgQyOgAyKQDGW6tlncUVo14ixlLlWcQFGdBdMEUImmzQTNO4abYiGqwfjE+64kEVhNkCLniIONT3FLhRUGlEh8RORUUbD6J7/OIYaYfothNmOKLJTPS/vp6RLuX3DoZSPQqkzMB8PNma+GG1BengkiyysYZGEfl7/dByjx95sT6TPdtV1T3hY2dMlTZdBykXOUvTjXYsfWaNh5Z54Rr0ilhUKPBnt26Papq+BrRG8vQkEWC63hhKxsd77reTf4XY88UgtRPs1kdQf+cnvLPYQd1vNeoq6R3Ja0DrY0eRbKuwkrndc2spXLMxZKSinDZ33Mx6BoQ2Scg7XtWqExyLVJPKPISvg5VuzucgFMgPKl+qkoG+c9IOUWBusH2W35KJFIDSmuU9YJd3xoCZhusJYqH/UhkyMqCc6u3JBCqWVGb4Fgw8FIG07iTMFTbtDjCHzGquqkEUz8BFz0SVex49kdyej3QF0q0c6t2bv58Vo6f+oiZX1QHCT9U6dPRmvYK074QuHBhGD5ovdq/455gAn4D/Si/djm0ZFJN5myefxvfV0zXfmTF2wKFqppBNRcPQJOOhGC9WaqDooFTa5zmVTsT675m6s4XK9ZnBB+UzLXon7lByYEDSFSCrdqve85pf3WzQkjYcbOMWYKzhRX+IAdx4qWsoOOq0IuJw2f+BZ6s8Zq7grIHWOlgEXS10v65VI70pGAt0xZz2gvNproVIyVHUPws/xkx5EfnOASBNklMW60dU5g2TnN5uF15IxY20oZT2w+pXQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(136003)(39860400002)(376002)(346002)(366004)(478600001)(64756008)(66446008)(8676002)(66476007)(66556008)(76116006)(2906002)(7696005)(316002)(33656002)(186003)(82960400001)(122000001)(8936002)(52536014)(86362001)(38070700005)(66946007)(110136005)(71200400001)(55016003)(83380400001)(9686003)(26005)(41300700001)(5660300002)(38100700002)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?205rC7gHLrDyOmUe4sDKZQ9DfsPo2PYEBCpWac5LACf1FitjFiaBC7/s6WjX?= =?us-ascii?Q?1U0PEgo+w0gAJnt17WGD5l03k5ofEb8gpRBX27c9hyaNo9d7O8NT8Ugx4V6o?= =?us-ascii?Q?m+P+Hx92Iw9JrWbxHwZDnjTAoxKoFaRo8sU1SB0wQ9OspY5X3SeAzLRJVqoE?= =?us-ascii?Q?crSO4Wq1aX9ds/ehE++yAksU1KA5XlL13p8eD8mRL/f98VdHWpwEqoGo08Jy?= =?us-ascii?Q?TLF2y+VmegpcWBoSTFhExS2BewlBguKZFkpelfK3uKR+BV6ZIdLdHPzFpHyD?= =?us-ascii?Q?rMt8Nz2ABTVb0g1+wB+f86B4jjWBx65WVwpTU56El0Pz0O8LqXuDJesWllrq?= =?us-ascii?Q?mDoLlbvnuuEEJFZO+VXEpREPPhOeQokioHr6zfOZUk+v94f04QCfyVETpivB?= =?us-ascii?Q?NxqX5H54lS6eWTw8luiALl8fLLtrV5inb0dYtFkaqvGFvbUL/rIC/Yb3MsdM?= =?us-ascii?Q?UfyRY22chVDBl/ImPamJ4sz2bZY2Wpe2y4Cxa6N8V2EZPFWjeQLn2eIZOJx/?= =?us-ascii?Q?K7qia4Bd5gDfsCAw0aIzyaW6LdhC4vKU3FJ/rKEAtsE8BCD6hfzFPFVV37iT?= =?us-ascii?Q?QBSQE+qlzlf9qkwYcoBfaFt2MvpT0wC13b9Fcqi3H8ZIhrZYdnrJiT6ADkOE?= =?us-ascii?Q?TR6GaVZDdlm2iRo29PowVp3sZ+erfpsOoLI8ffI5q7Ps0VL9E/jvIkgvtCmb?= =?us-ascii?Q?GhK7j4Onu8/fW3FfG+Z9od5jgY56Ky9G2AFKSQKNHWToI6J47/uVJL6Eka8L?= =?us-ascii?Q?Q+MO4eAVQppO53AtUaw5PpwQmIx0xK4UZ6phV1+zqch+J2o51AXnEuzPWWxh?= =?us-ascii?Q?iet6LOLosuTb7O/VkkjN8SzIIYCOMCj3PThnbdF8Q7rTSxasViTgqD0n4IMm?= =?us-ascii?Q?hlp84Rb6jvFwqSxRi6/xKrvCmi8JvwbWHr2LBW1Y90NnUcMse5EEvPEWOMt2?= =?us-ascii?Q?Na24fAmUuJeC79RHFi7QYMWfaRHlfznWUIQn8ZdDQAL6PigZKzMywTlaPzQM?= =?us-ascii?Q?QpWIsvOQaegHEviZZukgbfX3xb2gI2hrjlT4RxNXEfm4TIrd1/KXjbclMQXc?= =?us-ascii?Q?l3NVBBW5tWO9hhVRavNKUZw0W6PJB6dAjz2S5tuG37qArZKt0GRUxkoE4Wax?= =?us-ascii?Q?ZJDm2P3jORT1BGJa6UOdYyfLAO8ZSHavbmT3Vsikj91g8sGzdAu6pD9p0Rlf?= =?us-ascii?Q?LRD3Wk2+n0qwb2UGWsBJL9UUzJ0fnZ/OR+eYSzsEbjwyMMUTnvtP924tX8jF?= =?us-ascii?Q?8QOuc/uUj8Gs2lyov6530lI5JCJuPSXDhCs5s8NDlH/J6/+/gmikRnRKwjDN?= =?us-ascii?Q?nG3T4rL/gRs2scBYvdqiyJRcz0krYcDnwPvc9Uj+2uEPbTJv7QCYGnBwZT84?= =?us-ascii?Q?FMbrpb9GFEot7zE2JmWCVkvd1FOe9Izlif6lPxqKK00c4QI5egstIDN70eNB?= =?us-ascii?Q?VtLnzvRzAIEAsBqCk2mqcz39EdR96rKFVfKbL27SfvqIm8Isw9md3woDO/7+?= =?us-ascii?Q?wlyL0EuNEvloRB2YL8U2Wy+Br//kq14QLJn0ywERgjAEliio3OkNb6cuMDKZ?= =?us-ascii?Q?yV38w7tDIoRWsHdikk+fi+JuWpb1XQBx4CBPsqsn?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 311ebe70-1008-4dee-b574-08da58e63e2e X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2022 09:11:53.5161 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tlAnSwpnMRSJnQtdJMtBXHq4sUOTQESClOCMpvulOO8g5hB2fHqBk/velC/Khd8KaIqAVdjhhNRbdXl/oVAG1u2wsK2ZKY+DqglfWLG5Uvs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4680 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 09:16:55 -0000 Hello Felix, > conf =3D (struct btrace_config *) user_data; > conf->format =3D BTRACE_FORMAT_PT; >@@ -2282,10 +2282,15 @@ parse_xml_btrace_conf_pt (struct gdb_xml_parser >*parser, > size =3D xml_find_attribute (attributes, "size"); > if (size !=3D NULL) > conf->pt.size =3D (unsigned int) *(ULONGEST *) size->value.get (); >+ >+ ptwrite =3D xml_find_attribute (attributes, "ptwrite"); >+ if (ptwrite !=3D nullptr) >+ conf->pt.ptwrite =3D (bool) *(ULONGEST *) ptwrite->value.get (); > } > > static const struct gdb_xml_attribute btrace_conf_pt_attributes[] =3D { > { "size", GDB_XML_AF_OPTIONAL, gdb_xml_parse_attr_ulongest, NULL }, >+ { "ptwrite", GDB_XML_AF_OPTIONAL, gdb_xml_parse_attr_ulongest, nullptr = }, Should this be a boolean enum rather than a ULONGEST? >+@item Qbtrace-conf:pt:ptwrite=3D@var{value} >+Control recording of ptwrite packets. This allows for backwards- >+compatibility. >+ >+Reply: >+@table @samp >+@item OK >+The ptwrite config parameter has been set. >+@item E.errtext >+A badly formed request or an error was encountered. >+@end table We need to describe the allowed values and their meaning. It might be easier if this were a boolean yes/no or on/off. See the save-restore attribute in gdb/features/gdb-target.dtd, for example. We use this to indicate ptwrite decode support in GDB to gdbserver; we do n= ot really use this to configure ptwrite as we don't know, yet, whether the tar= get supports it. This becomes clear in patch 8. That sounds OK to me as I don't really see why one wouldn't want to enable ptwrite, but it should be reflected in the RSP documentation. regards, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928