From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by sourceware.org (Postfix) with ESMTPS id 4735C396E01F for ; Sat, 17 Dec 2022 09:22:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4735C396E01F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671268975; x=1702804975; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=OSGqIc/LoTqBt2H0wO0SWfSeBEz4vCoLXfRhozaYaIE=; b=kxR8dWMGEqu29YM+qHcqQb5JBTjKGpebr9GuvRfTwrwoSk/PCx1at6T5 etIKys9yl67nMyGFrgmJJLvnq3XXdZqpE8SSh08gmv3IoVcpf+o55rdHA kPvTcIqcm5RfuvOfl4WEf8nHxsmbIlD06qpg8az1J1mgsFGrEWWTcWGWg 6MHDr2eEmJlA5gawImSGW1Cb0ExkLYpkGlaFkwsscsrW4QZH2TtuBLP8s QbpZFNs/Rpa+VHjyIXkzkEnBWebyaXnAmCo4mDrMFav7IQ3yRHLGkgX7X O53Eeb8L6X7iNOKZnbvmZFoPd34vOnlKbi+l7yLpgwYznLVY7EGYpiV47 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10563"; a="316753655" X-IronPort-AV: E=Sophos;i="5.96,252,1665471600"; d="scan'208";a="316753655" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2022 01:22:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10563"; a="643512237" X-IronPort-AV: E=Sophos;i="5.96,252,1665471600"; d="scan'208";a="643512237" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 17 Dec 2022 01:22:51 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sat, 17 Dec 2022 01:22:50 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sat, 17 Dec 2022 01:22:50 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sat, 17 Dec 2022 01:22:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KK9a6QgFBDJuKebE+9uueo+Nxzt0zDByhDEe8emGtJBaymin7ba4EablPt/blQYzqekYWRjZzvfXOxol9kE16Zia7bxzfe9LRN37jzKwjHZ5ffc36vKS8oV+EyVISCrbLm6Rb1w7Vi2h09XR08qGDsVInJEzZ7MbkdO6NUzYVCUJ7R+Y2oPXDPy+/4SLnY+YRo0I1I5GVEwY0MWG0piC6XBTZeCf0JZ9HaFGM4UHAC3L8dGWnzJE3uW5+/aDhs37r7mdhI8b/4+p8nkcjNdo3PVUEPJhf7lwbFvPYE8FbiCM0n5b+seMqwIxJNp2A/UE9NaBeBLInbr1iDOeWoKVOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q1CT3RUcM2wGjPOGncv9Kd5tpRQOLvZV2KiMHflF+ys=; b=Zmibz38H1DMZNzBJPYvqTWX7qcjv+kTo5N3GjDxDFynJZQwqH92WZ6BOTuy68gbzd5qQ39GyST9mS8Ssuu2JUuSlvs0lZi5fu0TAR9ybEUOKd/l+Kg8tsaaxMyMYo8xoCRFqqDMsQeoyeSZKoMKTSh+/7nPsZTUFEmtKR2VLPbTrKf5f5W9cMT6W8FGRMRjHPoQHcl4X7O6aEu12DvsObKdzz6liVdRfdgVQAaoZw0wCoVd+IfGKO1JxNoO7/TAgFyo638PUKPcAWpZvLcNp3pWwoYiVz3shG3ruHrToK3DVr0F5Wm/qfSVTrYCpQWngvOMu8LXiegGVXdmnetqMOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by DM4PR11MB5357.namprd11.prod.outlook.com (2603:10b6:5:394::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Sat, 17 Dec 2022 09:22:48 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::b488:c524:778d:ee36]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::b488:c524:778d:ee36%5]) with mapi id 15.20.5924.012; Sat, 17 Dec 2022 09:22:48 +0000 From: "Metzger, Markus T" To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 22/46] Use require skip_btrace_tests Thread-Topic: [PATCH 22/46] Use require skip_btrace_tests Thread-Index: AQHZEaxH/zJtfdDyxk2QLMBwO43ftK5xzXuw Date: Sat, 17 Dec 2022 09:22:47 +0000 Message-ID: References: <20221217000818.3729389-1-tom@tromey.com> <20221217000818.3729389-23-tom@tromey.com> In-Reply-To: <20221217000818.3729389-23-tom@tromey.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5749:EE_|DM4PR11MB5357:EE_ x-ms-office365-filtering-correlation-id: db4d97a5-06af-4aae-9acc-08dae0104354 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZVuR/W50aGna3Ybpx/o5W95bsuCaaSk9LvyTyQ68sz9WNWCD5yIbXoeZHej4c3944Kwwp0m+SYi3vTzCUCws5Ee0hsnsjhCYboYyinXIiXImH/Tox/erLne5mAsxdWbHOe1ZRyQRG27CLNZI9Y8PFzev4qM4pcbMxnog/uNiXsOG8Y8HF3hpJ3sGhmTM8qj6jhWqSNSdsAwLzWhAJgjel5AESxX4k/56sVvr1B71xMs65cN6m1UCKO/7mhVdE0tIsW3B/7la30UNvmMczkamaT3webUbQBncTSUCBoT6+BiJOl8BD5dzH/v3+I623CVL0gWKoL7X/g394oEEcTut7/2EPg2j5MzeW7AtjFhR1ou5c0r94ZRQHEfw/zt29iLrJC6b+O0UMcmcyRJguP/WoN8cZtnyAG8w0bgxUabLCjUR4j0KgrFFKIFdP3vGk71nlcnDWvJNQgfzQzXGpX8QqS+jF2oDlEI18TCPnJLWzAFG7jM2AYphAhqpRk8Kqlrml5r8BxPULEDT6amubWGRISiOPPeKzM5Nl3SX1VKo/YiLVrG9sl015TmwNMZvjfRq2yDz4txt+4o0SYWTtY7bYyPcw/CQAbo5/AIpg2narAjdpwDtilxeVW8eX1rw/sYKIZjN4RZZQW4u08C0TeSJfZPDGfwhV8XfUTtdyodl9/BwQMbj4aUikTdsckOzalbNOxB0Wz3mV71JdrIc3jUMbA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM8PR11MB5749.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(366004)(346002)(396003)(136003)(451199015)(2906002)(86362001)(8936002)(5660300002)(316002)(66446008)(64756008)(4326008)(8676002)(33656002)(66946007)(76116006)(6506007)(66476007)(66556008)(41300700001)(478600001)(26005)(7696005)(186003)(9686003)(71200400001)(52536014)(38100700002)(6916009)(83380400001)(122000001)(38070700005)(55016003)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dD69B2VwkDK3/CsgamCG9dAaaiH9G7GLQbvdw4YgeNYZmWjC1KmiMjj61L9x?= =?us-ascii?Q?bAskq0BYckAbtkI2InWHxRbluKKJ1UI+71r1FrELS3+gY9Io0VHHqC8XckFf?= =?us-ascii?Q?flvuIuLX18mNPth2ti3bYdmvGVre5E0T3w7GJR39C1MclN4kTJkTy/i6tp2H?= =?us-ascii?Q?hY9kBaJ3AkOAMYfIlsva3w9NeetSbNg20uoiF/eespb8aD4a5NvwJ+4xJjY0?= =?us-ascii?Q?foYDXDWoDCqvZNsMYSGbHx02WqWEjHVa/bz4QsGNyvP6PQS9TAoCbfCiMjCN?= =?us-ascii?Q?3DI/6OC1BrjqeeXrBkJHsNAlryRDbhKv7eDOJAxL5W9HsBOmHp0qx+IuzJIK?= =?us-ascii?Q?ua2HpYhLBtq3VCHOtdfEk6Ny7D10nc0jl8m0nfW2+4KK9FMdq4LlcSxaj5Kw?= =?us-ascii?Q?sW6SnAtSEBuRB2Iwofo5xEI8O69BZ/dg08++xQrZltgi6kCYJoOFaS7w3HaT?= =?us-ascii?Q?6ASlQpbXoEfiqV+n1XJMVz/WslMnWyCRD7qFEUCoVlmSnaphj2uRDTDcpYAE?= =?us-ascii?Q?XjBQDXViY1eRWs3qK+x0gPwhLQawTVUylt4jcpFCKyG3XXtVKJ68Pe8ZrUec?= =?us-ascii?Q?lklhEo/4Fj8jCejqR6h3P8yXG4fwojZA0wYL2zjp1KlNoGTbe54N90FuVefX?= =?us-ascii?Q?OKM+ex3Y9wL+nALD5LStZfilyYH46kk8Pd0lTgO1Ok78vbYjIeqo4ioiaQQK?= =?us-ascii?Q?iUGKz1qhx7k/kB1hwqa/8IQHrI3thVPZlKM5hlSMW3EtPZXaldwv74rdFHQN?= =?us-ascii?Q?wLmz0ZN0m5kLYCaC6+xxdpcWkh1IzEJ9+OZpyo5l3Ar9MMy4dohMtRqsHepu?= =?us-ascii?Q?/2ebj1L0Opmw421G9yx52pjwt0qWjQ1Ry93k0bQX+FKNBE95mp2BE2w71PI3?= =?us-ascii?Q?DneopzV8dP1FZVH/9U/SODpSsBwCDa1aDykNSJ9J3np3chp4i0/Fpcu6+DYq?= =?us-ascii?Q?GeRWRzBbeHvoISCkqjUxrwlr4C0ATV9QzCBZ8fpMMVlXkJSCWyvuFkZIz7UG?= =?us-ascii?Q?TuLumVPq5VnLHVGkrx02+a/ZgoxtgGdQJClKJKHFsZ+SK+aNIRQamj6FRV3o?= =?us-ascii?Q?qcHz3cOfYrzD66ADzrZtvk2UHTgvhVk2TwwgEMt0NgLpJqKxsA6E9rdTZCoY?= =?us-ascii?Q?Af/S59DZjc77nfg8DDU8lkjkyX+1orgWTein6JTMKWzaLi/La090fAmuFZsp?= =?us-ascii?Q?NGZrpSYMpqT3wbHZF2HMKqC3S4kvmNJX/u2uWJrW9NwGIKK+0sWQQLsRwgHg?= =?us-ascii?Q?Dfu93CG/c4ToOP1GrpynRjOnSL+CzjtXD8C/urKpb7qBX3+LyoRMA1QoaL0O?= =?us-ascii?Q?na9nrqtrtk9JSlOdwNKDABTBosMtnXxvzyu1eR46SVpmM1PSjkVa/oi2mrTF?= =?us-ascii?Q?GSpcv2AOsUnpWREJRMKns0a1u1JiSkHHhU3uS1gnim10y6QfTH6A/aT3pWtf?= =?us-ascii?Q?N+XL12RClIOCtLz1F9CLpZmcPlBGtYNdhDEuD5j9/A7OuR5o9rwTizs2kLmv?= =?us-ascii?Q?ehsp99R0AXOrh8oNjpgrSBS+0niZYMag3oQIoFgPIPRVCp7fXSJFeUnNUP/5?= =?us-ascii?Q?kzIu8/oCqaM6ku3Mgua1Jwi1dY51tP/K5ZILc0TLqy9+HrOMmyquc95ohzTE?= =?us-ascii?Q?HQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: db4d97a5-06af-4aae-9acc-08dae0104354 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2022 09:22:47.9906 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y5cobZSO9sHKGnRLRWJG4pX22cnM0GQrq9AwKgudrzz00rPuxJ5hh3690YWZm87bqUPmBU+WpFgngJMrcyc364L13XUBxMNFzVK2RwbUvmg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5357 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >This changes some tests to use "require skip_btrace_tests". >--- > gdb/testsuite/gdb.btrace/buffer-size.exp | 5 +---- > gdb/testsuite/gdb.btrace/data.exp | 5 +---- > gdb/testsuite/gdb.btrace/delta.exp | 5 +---- > gdb/testsuite/gdb.btrace/enable-new-thread.exp | 5 +---- > gdb/testsuite/gdb.btrace/enable-running.exp | 5 +---- > gdb/testsuite/gdb.btrace/enable.exp | 5 +---- > gdb/testsuite/gdb.btrace/exception.exp | 5 +---- > gdb/testsuite/gdb.btrace/function_call_history.exp | 5 +---- > gdb/testsuite/gdb.btrace/gcore.exp | 5 +---- > gdb/testsuite/gdb.btrace/instruction_history.exp | 5 +---- > gdb/testsuite/gdb.btrace/multi-inferior.exp | 5 +---- > gdb/testsuite/gdb.btrace/multi-thread-step.exp | 5 +---- > gdb/testsuite/gdb.btrace/nohist.exp | 5 +---- > gdb/testsuite/gdb.btrace/non-stop.exp | 5 +---- > gdb/testsuite/gdb.btrace/reconnect.exp | 5 +---- > gdb/testsuite/gdb.btrace/record_goto-step.exp | 5 +---- > gdb/testsuite/gdb.btrace/record_goto.exp | 5 +---- > gdb/testsuite/gdb.btrace/rn-dl-bind.exp | 5 +---- > gdb/testsuite/gdb.btrace/segv.exp | 5 +---- > gdb/testsuite/gdb.btrace/step.exp | 5 +---- > gdb/testsuite/gdb.btrace/stepi.exp | 5 +---- > gdb/testsuite/gdb.btrace/tailcall-only.exp | 5 +---- > gdb/testsuite/gdb.btrace/tailcall.exp | 5 +---- > gdb/testsuite/gdb.btrace/unknown_functions.exp | 5 +---- > gdb/testsuite/gdb.btrace/vdso.exp | 5 +---- > gdb/testsuite/gdb.python/py-record-btrace-threads.exp | 5 +---- > gdb/testsuite/gdb.python/py-record-btrace.exp | 5 +---- > 27 files changed, 27 insertions(+), 108 deletions(-) LGTM with two nits and a general comment below. >-if { [skip_btrace_tests] } { >- unsupported "target does not support record-btrace" >- return -1 >-} >+require !skip_btrace_tests This looks a little bit odd, now, and the ! is easy to miss. Those skip ch= ecks should probably be rewritten as support checks to fit better into the new require logic. >-if { [skip_btrace_tests] } { >- unsupported "target does not support record-btrace" >- return -1 >-} >+require !skip_btrace_tests > > if { [use_gdb_stub] } { > unsupported "test creates multiple inferiors" Should this be require !skip_btrace_tests !use_gdb_stub >-if { [skip_btrace_tests] } { >- unsupported "target does not support record-btrace" >- return -1 >-} >+require !skip_btrace_tests > if { [skip_gdbserver_tests] } { > unsupported "target does not support gdbserver" > return -1 Same here with skip_gdbserver_tests. regards, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928