From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id BEF73382CC17 for ; Thu, 12 Aug 2021 11:07:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BEF73382CC17 X-IronPort-AV: E=McAfee;i="6200,9189,10073"; a="300912858" X-IronPort-AV: E=Sophos;i="5.84,315,1620716400"; d="scan'208";a="300912858" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2021 04:07:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,315,1620716400"; d="scan'208";a="421873651" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga006.jf.intel.com with ESMTP; 12 Aug 2021 04:07:45 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 12 Aug 2021 04:07:45 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 12 Aug 2021 04:07:44 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 12 Aug 2021 04:07:44 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 12 Aug 2021 04:07:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n7NOBvst7UBa6JfAbHieeCTB/Jj7QFlgPtADaJbeeDXVVAtTT1p/D5WFqmNLCfNr1zr00E5YF2NbXJy2R78Z/kQ6+e1feKPsdBBfFzZSklrDE024gqQr1HBJgld6Ib5xk/MOUCvYh5ftdEWEwyrk/L2sNj/p+9sqTRdo8eWqiNpQfUyZFQFEGXZ/ooe/sblQEALD9ZgMgJY4u3Xw3OOlFjtU9i6kX218dGL2d0dfcXJ0iLEDv08ksyYDjIX6omQ4XxJRJ9TMtq800FSmKhjmUZ+vCg4gGAExmvhXIg5Brph1FzHxd/dB7mLpgsyyMWamDhJMrAvwMSPeL/b8rI3m7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EGGjLZzD+wg9tBPZPBbZNfwRg4Q5sgjmpwR4EHjKGf4=; b=koUD44U13Of88IWHy6ggvzcvZtYULHeSAVZ5/7bVJ/dY7pZEc1t5VCX/ezqubRAXlQhXHWVJWut+U6JjXXAN+kcTNO5ZiqoJ7Whso7y6p9fsknxnmkerpKWgzM0S1O5pTti5iu293sUHkbmEjkt00BeLHvhO0vqv83wL20YgyNVdtVWFOsNRabiARkFVUlx/UVPnTWIKQCoculdwBQVJE/+9TxGVzu+/jK7TMShaIIKzMfS6/jZM5/g/jZK+bZ4zmNec5dySH09MyUKWdk9A+ntjknvj4ApTGnR9jnQXqmpA+H3avg93bQWVmVHCIj+6W71vMzJ2WJaLjPI3TtSt+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by DM6PR11MB3724.namprd11.prod.outlook.com (2603:10b6:5:13c::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.17; Thu, 12 Aug 2021 11:07:43 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::392c:516a:cc52:963]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::392c:516a:cc52:963%9]) with mapi id 15.20.4415.016; Thu, 12 Aug 2021 11:07:43 +0000 From: "Metzger, Markus T" To: "Willgerodt, Felix" , Simon Marchi , Pedro Alves CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v3 07/12] btrace, gdbserver: Add ptwrite to btrace_config_pt. Thread-Topic: [PATCH v3 07/12] btrace, gdbserver: Add ptwrite to btrace_config_pt. Thread-Index: AQHXYoPSzMo5SSoUh0iwZ8oUVilW76twCcYA Date: Thu, 12 Aug 2021 11:07:43 +0000 Message-ID: References: <20210616074205.1129553-1-felix.willgerodt@intel.com> <20210616074205.1129553-8-felix.willgerodt@intel.com> In-Reply-To: <20210616074205.1129553-8-felix.willgerodt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 16f669fe-12da-4bc8-c4eb-08d95d8168a6 x-ms-traffictypediagnostic: DM6PR11MB3724: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AF+gIs4PAs2Cf1aYo19nv+YnJkVGKZ1LMED/4V8WakL63Is6+EivgUqV58+64/LDXOVi/Ys9XAJMy2OTb+xvvSN5XpZwH9VPJjiA4CElCMV4Czk+LrfQZ8UQ21CjOZ2XQyRZzvIrToWq9yOxKZtQPQGji3il9TvefsMWFSQg0Mk0zK9zPjyEO7vtQaRfVMtw3a6Xrpd+/Rq4cJTH+St4FPPI2D1UY1xtie/5xBVKms0akuqwpF7ov5hyw3oRhZwVe46jtdPegDpv6b7z6K5SKXkfgwnZYZogvLdlzIf4pS6gYeIJ+BygSHSGWrrCDA5XHiX0I1qDypR5wS37TzT13+HjAr5IArQCv7OMWfFAa/EMqEJ8xIAZJrXshUMkqnE1YfYoCJsYPWSmvGzRtPIAX1qMPFCxVX/oclRasGpZ03pZLbKemfMgHa5Vbi7DVcET6WE5Ot3Wm1a4GZpNW/JnKhXSo4fMhDYghSFrNJ1L2nb1hnsW4QP67Rvz0fLeENkWFFxMzu/H9EoMB4ynHoVaHpIVEwiVWsyIQyMA5DgsiO6tMT8YxXXHwgykK5a9yHeMLJJpw9xCGe7YpdXzoHSwLmeeDlQSGjh7NxDcb/T2I56GpLYSpODGG2N+/nvSKMgQ6XFs39aF+qwtGkzE9ZBoSOO6HAZleqD2L4AEnYYCPwYL6eycV3l4o3s6cR2lmMbxY1H4lsu6NqMnBsyNoe7uMw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8936002)(86362001)(33656002)(2906002)(110136005)(5660300002)(316002)(8676002)(122000001)(38100700002)(7696005)(66946007)(66476007)(66556008)(64756008)(26005)(52536014)(76116006)(186003)(66446008)(55016002)(6506007)(9686003)(38070700005)(508600001)(4326008)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tWXsdNoUAm8ZLgeFrSy4lmJSUOcfcyTc2zdCiC5lDM5XPi7kXEnLsuGu1BYi?= =?us-ascii?Q?ChYbfIWrQ79SGuL1LrpRG5qPqSqwhZpnXMdeae4K1XOr3U0Wc2r6M+uPZN+o?= =?us-ascii?Q?qU/ViSwKZtwi5Fqtjzg9VvYuybjMjbKQeart5OG2ACsrcTilDj8f0UlbEkBx?= =?us-ascii?Q?ThHthTU189N3cd1gBV/vSmc8QOS3FwKKpRnwlTfoS3vjXNh2DDhWi/9Hie4A?= =?us-ascii?Q?rYe3VnWdETbzwFHuFZHR2jyQ1zhdOULNOheplXAh3C3COk8IglR1Sdps4qdE?= =?us-ascii?Q?0R9/c3PHR/gfbERFXrHhPF06cW7LC6jvo0ZQQ6b5RvCFoHJvowM5CHYr3QTR?= =?us-ascii?Q?datcvyj8Jd21s+7Prs1zqoI2B8NaSIiuBRMGuaDCDr8IoraWO/8F+e6/vPgH?= =?us-ascii?Q?Z4JGUptEJ8nbQseWRf2QbriTm3S2yZCiGjsuIYdkEmbOUgOf505B90BIgr8l?= =?us-ascii?Q?A/Mhj1JOBEvqDQbZIUgluYwHgiZt7j29rf7T87QMakNWjVuolw4Vw39qWN8w?= =?us-ascii?Q?P0J1NbY83WJZsE8brRV5HyuEGTjh5jUlav4j4hUZJOqco7VMuce8GkP2Diop?= =?us-ascii?Q?rsqhZxKTkk+Yk03zBHr/UPPM6gBN8oQrEGmAJuIX85iLyg/fmMuzrlMBuPkb?= =?us-ascii?Q?paHC1uSqUafNNMdpxUCY+V8N7cbh/s25ZczmUPTJ7PVUKo2Yw4co50r7GnBJ?= =?us-ascii?Q?UYtnKOvbuSQY+84QyNBcicmiQyLG+u0Tdv4vaQJOk+dIZNLMEMJUNvbcXr49?= =?us-ascii?Q?dVLENVrAKpC5xs64VP42aU2dVzyu8tYVnS1w/9BSowjOatvPVwvFkLb56RXX?= =?us-ascii?Q?VokCBNJCDZbPCdsoBWpmVaSHhcDJ1PMh1q1jguwW1Eetn8PZcZEh6rizwIX6?= =?us-ascii?Q?tzEozQHS4NukSQEwxAXl32ifa0du1WVpIOC5RDYqoJUEBjVjt+quk9dPLfTa?= =?us-ascii?Q?tUAHHI3kEHi9s2x6rLxvLoMZME2wWrdvJxovzSWph+IqP0R4GDEvKkI3nfA2?= =?us-ascii?Q?1Xsm1ZDJNoJNzSq3M1GA0CmalItRyJd4uOyEaG4oEdO6urjaAzDoteT3CZHZ?= =?us-ascii?Q?tpiN0LtFRFhV4eMKdKFIAfvHhKP7qUjk6frHv77ujcCHwqkgG9VGZg1SBqid?= =?us-ascii?Q?McXsItuPsxQBwaASXqKiWflYqGl+s/8yIKG6Xq8d1sQWFDKTkflMSLv5EbYX?= =?us-ascii?Q?UeW26zHugHQpNnThEtoPD//v/zfvyJCQt1NVQYESOWNLYAYMKkJiQYp7NBit?= =?us-ascii?Q?GQ5kf552jHu6+5Wxcj6q0CW1mfL9nEYibKz5DOf4BRX9lfHVob17AeOosLOH?= =?us-ascii?Q?3Io=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16f669fe-12da-4bc8-c4eb-08d95d8168a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2021 11:07:43.6484 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: StxAzeZItef/RBR2XbrgtWQlhWgy4vO6crcSfgaDymsiiE1KUZZkwsPOubJELWBSZDhD+SINN0k9RsX2r0AHvPsV3s+k6i1zCic+Hg4xQH0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3724 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_INVALID, DKIM_SIGNED, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Aug 2021 11:07:58 -0000 Thanks, Felix, This patch looks good to me but I have a question about XML schema and a sm= all nit. >diff --git a/gdb/features/btrace-conf.dtd b/gdb/features/btrace-conf.dtd >index 4b060bb408c..339ce4a4966 100644 >--- a/gdb/features/btrace-conf.dtd >+++ b/gdb/features/btrace-conf.dtd >@@ -12,3 +12,4 @@ > > > >+ I don't know if we can simply add new attributes. Would we at least need t= o bump the version number? Looking at git log, others have added new attri= butes in the past. And they didn't bump the version. >@@ -7096,6 +7096,7 @@ linux_process_target::read_btrace_conf (const >btrace_target_info *tinfo, > case BTRACE_FORMAT_PT: > buffer_xml_printf (buffer, " buffer_xml_printf (buffer, " size=3D\"0x%x\"", conf->pt.size); >+ buffer_xml_printf (buffer, " ptwrite=3D\"%d\"", conf->pt.ptwrite); Would we need to guard that with a check whether GDB supports this new attr= ibute? Have you tried mixing an old GDB and a new gdbserver? >diff --git a/gdbserver/server.cc b/gdbserver/server.cc >index 32dcc05924e..b899f50db35 100644 >--- a/gdbserver/server.cc >+++ b/gdbserver/server.cc >@@ -546,6 +546,21 @@ handle_btrace_conf_general_set (char *own_buf) > > current_btrace_conf.pt.size =3D (unsigned int) size; > } >+ else if (strncmp (op, "pt:ptwrite=3D", strlen ("pt:ptwrite=3D")) =3D=3D= 0) >+ { >+ int ptwrite; Please declare below where it is initialized. >+ char *endp =3D NULL; >+ >+ errno =3D 0; >+ ptwrite =3D strtoul (op + strlen ("pt:ptwrite=3D"), &endp, 16); Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928