From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id 1362B3858D39 for ; Wed, 19 Oct 2022 14:44:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1362B3858D39 X-IronPort-AV: E=McAfee;i="6500,9779,10505"; a="392730932" X-IronPort-AV: E=Sophos;i="5.95,196,1661842800"; d="scan'208";a="392730932" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 07:44:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10505"; a="698105095" X-IronPort-AV: E=Sophos;i="5.95,196,1661842800"; d="scan'208";a="698105095" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP; 19 Oct 2022 07:44:20 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 07:44:19 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 07:42:00 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 19 Oct 2022 07:42:00 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 19 Oct 2022 07:41:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y6Fs2QEyw5g92eag8aiM15iOLwcKENaugAUJHvlWQf/LwKSjeWiRLZvm8LROjQpMQn86G6zUJbKHajHcXdWkmgqd8Ww95LMUySNocgdLl7fvcrJIVZnARC5ZaC82kmjlDFhKbOYxkqEMi3ev9WBA3irGPh7DBINLdhlUUamKPIeFAC9diTbbzZOsqqXfnzKmSGzIBAG+NGSlOS7yIPQAtCjqpsfjgtlEE/tRPh3HcUTmzU0nka/xJEzDmS2p0Q/VM3vKFoyQ23NjnwCB+XjPm6gnJDA9TW7Tq2pM07sSlHgBkAekO9vkO4B9mdrVqiVSg5PWWb8KUDTb1VGktgdnnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RtqDqsN/0adFyiorON+vYg9FqHX6u3NnU8hN1oeAx1Y=; b=UXEUmIwp3FkyXMcLNrBj1g0aqmEySMrMPkx+0hxpHsTmvHZleaoObmwgNa1qLIYKi0oCHE1kqoGEA1h9wcJIO8mHDV2dYjT5H/0hyCMa17GD18lyPJJ7/q3CntVt+iAqQY4kh4qhzcJnG3qlsTEiFtrwQMWY1ZplqkfevhdkL4fn/NGK+MR5rVg1miXI4Ckun44Nr8DArn0OqlDhdOFhGD8TUqC+oe3ijkI/M5EOvdYRqXhXQnU6MfNppMUiQCIpAwAdMV9iEyMkQCjqSHBSmAIOo+BEfG3DCcOLXdKhEbuDv2xJHuRj+5GAQDw5MvTnu41AK/WCjfua6CoklIw8QA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by IA0PR11MB7379.namprd11.prod.outlook.com (2603:10b6:208:431::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct 2022 14:41:51 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::65d4:f6fa:40b9:2437]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::65d4:f6fa:40b9:2437%5]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 14:41:51 +0000 From: "Metzger, Markus T" To: "Willgerodt, Felix" CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v6 07/10] btrace, gdbserver: Add ptwrite to btrace_config_pt. Thread-Topic: [PATCH v6 07/10] btrace, gdbserver: Add ptwrite to btrace_config_pt. Thread-Index: AQHYycDcoczIpwx6KUKMReU9OWPAgq4V9pYQ Date: Wed, 19 Oct 2022 14:41:51 +0000 Message-ID: References: <20220916113646.49749-1-felix.willgerodt@intel.com> <20220916113646.49749-8-felix.willgerodt@intel.com> In-Reply-To: <20220916113646.49749-8-felix.willgerodt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5749:EE_|IA0PR11MB7379:EE_ x-ms-office365-filtering-correlation-id: 40a11f4c-4327-4b06-6059-08dab1e00f34 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g6d8fsu89pZbdKYYc+dJNW0b4iZoAg2JVSg0yruByBvuTEYyZRFbO/lbZOy4JcU9o+/406DDOBb7qNa9JjcjtzdOTmMTFgss+FB19xajl9BkYrt0j764rwUOM+/2w2P6nYNr1DJ7VleYoZWT5TxHejBrvCWCXpOeP7kIrNpjxHQfC+Xqwn1pGtleya7rw082aaw88aMCN/iBzNuEIHVnOejCztWeiUZdm4R/qQNeSBp45in0OSb5u27Lec6TVzBQ8sbV0/oVw/2w8LBKLhSV5LyTID6JMYUsTyQETXxC7VrBL+mO4iB6R/1LMWTMSBC5F3a3l8Nqk5vN0Dn1WS8v2EyYP+BHer6E4dfQCLIpwItK+q+0pxwI990/EgHFHelSb6wSB+gUKONT94dgC5DkAVKOz6aeT8DtMrPXVA77hN/MthEpPH3gPPL7L7mk6Xbq1aughXrr6fv3kDdcJ2xDuyqmh+98drO3na7QUwNmyBBv8/G2VcQ8iW8xuNR968qoDbBdCdbIJHXDhz71Kd5yk8rCya7kNf5m74qRd1jP07/BCun4CfTis/CeimM1Li+Vwj3JPMN+OZuwBMBJ1kukmd1SLYeHj3oQDu1y1BUb5n+TCEP4XtJUZ1O2VPwC52HAQtnhN2px5uxE5O8ISeKBWxV65+7Pib+dEYRxsEvT8yUyGdJNddAryu5ndWje7Mz4TP07rIod8R1MD8pKUnZ+iPw8yon4i1E92aVukf35jC0zaG/RTOcXJs2T786jWhzrQn3LhPQUHBTgDOVkXcvmKw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(376002)(396003)(366004)(136003)(39860400002)(451199015)(83380400001)(186003)(38070700005)(2906002)(5660300002)(52536014)(122000001)(38100700002)(478600001)(41300700001)(4326008)(6862004)(86362001)(55016003)(64756008)(8936002)(26005)(6506007)(8676002)(6636002)(7696005)(316002)(66446008)(66476007)(66946007)(76116006)(66556008)(71200400001)(9686003)(33656002)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LbiPsJCCMbpj91CPZ/ooldWTga3dmU/4BvWrjLPL6D+y9sE86ao6pls/6HlT?= =?us-ascii?Q?PmazlyC6FRCJi+bd8+xs8YLjdHXW+oImaA4d1zzucXS/o8Yh5IK3fpVU99/n?= =?us-ascii?Q?F07hfpCufJg8pyzILX7P9/d9j4yqJoDnKGdZQUpIV42zEk6R5COBxXm2HGS6?= =?us-ascii?Q?VKKnzoar4wZkWsF15j1tHAs8Wdj0d/7IBgauXp+sjUEuenLNyRC/tScxKiAM?= =?us-ascii?Q?7gT/Krt6bye+pl6rXWqzfsjlAxz/hjD7OPciLtBh00MmnTFKUaU2o7sVHjL3?= =?us-ascii?Q?pSXb3qYZk7YRSljSY9zH4ZLPfTU6a/KbzgG8r/HyPdbSsW7f9YBEYcFLGqd8?= =?us-ascii?Q?Th6NNZNHlu1vn3mR3DE1VTqQljB7Ac/QJawtQFX5/NanIyQ2SdwPEOHVvHJl?= =?us-ascii?Q?dQasxBe+IZ5Mr9sR/rLt2/AjMjnB1u3ml+7Tk0N7MStQTlQC4Ja2m1hWNWCI?= =?us-ascii?Q?DnTo4auxHH6LUpAAJtwNmlCST2f2wh1sothqx9P+ToZid9u61NuLI9mH/b5V?= =?us-ascii?Q?08X2noOhsIJOk5nYce0uqLX6Z1tRBeHAjby7kLnucrwY/Tl9g9wo7TjYo05L?= =?us-ascii?Q?7NwMPhyul7SQoCPrlmxOawwfvQkEfnTihY+C4k4EmnXoa0V/gBIhzPsFHiMV?= =?us-ascii?Q?NA633C6DELzbzqptUEQQDiVw4JufHeXatqfqnEyOQTdbpidTt2keJzM5OBCx?= =?us-ascii?Q?PjD9REgEuGe9x+WZi4kG8lCKkz51iAxkOWsoisKcJC0I2t1+JheDvNiCiRXF?= =?us-ascii?Q?qXtGHc4OsSgetSXAfmNTHB4ErCZ8L32eIsvzstZLCV+UicJFRFVHcJc/AbrC?= =?us-ascii?Q?X1Eywf1hi29QJuMvTGWT8nOWI9NwlJDUbh8bzHuUwbtSrbVGgqhtpp+jvrHg?= =?us-ascii?Q?+0MZUf0keXIGyML/NJ1GwCdBPMjmgvNZs1oROK6gitg9YCRBs2Cm3+YI15Od?= =?us-ascii?Q?xsGINR+c3WFx9rqqjI8bNyRhl5wRc1SrBSPyh4wjyA/GI+BBK8QTd0ugjJwf?= =?us-ascii?Q?FRRrNMRFmuoy1kEkydtM6EYfwOR4eZonmdGcnpydopTOjZApdDwsOcaAdWVR?= =?us-ascii?Q?j+1SyyzROchw6lPkbRbvF2J0ziIaQutgmZlmHTI/jOVYlpBPTBkYGbbpZThW?= =?us-ascii?Q?7R8A5b72QL3qGPGWwDADmiqiqXdY3MpIjEGzlZsmFkD6Ck7DTR0xVIDnGREj?= =?us-ascii?Q?zMRxWhYY+5jyIjLQ+SAp8hg0ovB0BO2/s6sPCluGxbIF1YglX9pkTlBst/lj?= =?us-ascii?Q?Q4lziPjpIR66WPtGCF2rzW2Gxg5zamCOSugJnoencXPxY9MYRy6lgoVR7Raa?= =?us-ascii?Q?+SkFUmh48QqDEptc135GSijVNOSxSOGDV+afg0pC+lrw+11UGy4TT//P7Bu1?= =?us-ascii?Q?7W2Ev7JWfL24AFLhJyFLqN5Q5hsNUfKzh/dDE4bkOcny/xmFqGgP/P/04g6J?= =?us-ascii?Q?Y2IFk1ndvLGhJH75NZ9mIYE1tba35L2MkvJ79AvdLp6+Ex1Ua0vF2x8REJSB?= =?us-ascii?Q?FZBNuUH9pPHvADpNgkZ+jA5VtuU7WfABNk0bo0wqBM8uK1GtNsGX9op7ZPPK?= =?us-ascii?Q?ZpuX2eFpjp0V+3cAp3r94vE788VY2rflYgxvORNelXu/C2doHw0fjluabAV3?= =?us-ascii?Q?UA=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40a11f4c-4327-4b06-6059-08dab1e00f34 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 14:41:51.1603 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SdG0a6F7ijwRPtQAbr7WvpJsrwd+nMFFTXelvWFDprGY5V8URc3X9Kg+Nos8tBlkpNT4LFfXchm6lqD/NSW3SKOBorfBVBvBoLnom3Qp928= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7379 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2022 14:44:23 -0000 Hello Felix, >This enables gdb and gdbserver to communicate about ptwrite support. If >ptwrite support would be enabled unconditionally, GDBs with older libipt >versions would break. >--- > gdb/btrace.c | 8 +++++++- > gdb/doc/gdb.texinfo | 21 +++++++++++++++++++++ > gdb/features/btrace-conf.dtd | 1 + > gdb/remote.c | 30 ++++++++++++++++++++++++++++++ > gdbserver/linux-low.cc | 2 ++ > gdbserver/server.cc | 18 ++++++++++++++++++ > gdbsupport/btrace-common.h | 6 ++++++ > 7 files changed, 85 insertions(+), 1 deletion(-) Looks good to me with one nit: >--- a/gdb/features/btrace-conf.dtd >+++ b/gdb/features/btrace-conf.dtd >@@ -12,3 +12,4 @@ > > > >+ Should there be a space between 'ptwrite' and '(yes|no)'? >diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc >index 2f71360d3bd..1333ec13dbd 100644 >--- a/gdbserver/linux-low.cc >+++ b/gdbserver/linux-low.cc >@@ -6806,6 +6806,8 @@ linux_process_target::read_btrace_conf (const >btrace_target_info *tinfo, > case BTRACE_FORMAT_PT: > buffer_xml_printf (buffer, " buffer_xml_printf (buffer, " size=3D\"0x%x\"", conf->pt.size); >+ const char *ptw =3D conf->pt.ptwrite ? "yes" : "no"; >+ buffer_xml_printf (buffer, " ptwrite=3D\"%s\"", ptw); We don't really need the PTW variable. thanks, markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928