From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Tom de Vries <tdevries@suse.de>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH][gdb/testsuite] Fix gdb.btrace/tsx.exp on system with tsx disabled in microcode
Date: Mon, 12 Jul 2021 15:19:08 +0000 [thread overview]
Message-ID: <DM8PR11MB5749843BA33CFA1EADF68287DE159@DM8PR11MB5749.namprd11.prod.outlook.com> (raw)
In-Reply-To: <08afefa5-59ba-e5a6-cffb-4d0d43b2d50f@suse.de>
Hello Tom,
>> We allow (and require) a single instruction in main.
>> That works if we stopped
>> directly at the call. I don't think we can guarantee that.
>>
>
>Well, we require at least one instruction. There can be more that one.
>So that should work if we stopped directly at the call, or before.
>
>The current form is only wrong if there is no instruction from main in
>the trace, which I don't expect given that we start recording in main.
>Is my understanding wrong here?
No, that's correct.
>> In the other patterns, I put .* in front to ignore any compiler-generated
>> code prior to the actual test.
>
>A .* at the start of a -re clause is redundant, so it's best to leave
>that out, to avoid confusion.
Here's my confusion, apparently. So the .* I put in front of those patterns
is simply redundant.
>Are you satisfied with this explanation, or do still require changes?
I'm fine in that case. Thanks for explaining.
LGTM,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
prev parent reply other threads:[~2021-07-12 15:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 11:27 Tom de Vries
2021-07-12 11:54 ` Metzger, Markus T
2021-07-12 14:05 ` Tom de Vries
2021-07-12 14:35 ` Metzger, Markus T
2021-07-12 15:08 ` Tom de Vries
2021-07-12 15:19 ` Metzger, Markus T [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB5749843BA33CFA1EADF68287DE159@DM8PR11MB5749.namprd11.prod.outlook.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).