From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Tom de Vries <tdevries@suse.de>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH] [gdb/testsuite] Add xfail in gdb.python/py-record-btrace.exp
Date: Tue, 14 Feb 2023 11:34:22 +0000 [thread overview]
Message-ID: <DM8PR11MB574994E89FC61E3A34E33BF6DEA29@DM8PR11MB5749.namprd11.prod.outlook.com> (raw)
In-Reply-To: <2bfa0573-bd7c-5dd6-6fea-f4837c4eeb66@suse.de>
Hello Tom,
+ set have_xfail 0
+ set v [linux_kernel_version]
+ if { $v == {} } {
+ set have_xfail 0
It is already initialized to 0 so we may turn this into
If { $v != {} } {
+ } else {
+ set have_xfail \
+ [expr [version_compare [list 5 5 0] <= $v] \
+ && [version_compare $v < [list 6 1 0]]]
+ }
+ set xfail_re \
+ [join \
+ [list \
+ "warning: Decode error \\(.*\\) at instruction $decimal" \
+ "\\(offset = $hex, pc = $hex\\):" \
+ "compressed return without call\\."]]
The exact error symptom may vary. On my system I got 'bad packet context'.
It should suffice to grep for the first part, without the actual error string.
Looks good to me.
Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
prev parent reply other threads:[~2023-02-14 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 18:10 [PATCH] [gdb/testsuite] Add have_linux_btrace_bug Tom de Vries
2023-02-13 19:17 ` Metzger, Markus T
2023-02-14 10:59 ` [PATCH] [gdb/testsuite] Add xfail in gdb.python/py-record-btrace.exp Tom de Vries
2023-02-14 11:34 ` Metzger, Markus T [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB574994E89FC61E3A34E33BF6DEA29@DM8PR11MB5749.namprd11.prod.outlook.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).