RE: [PATCH] Change message when reaching end of reverse history.

["Metzger, Markus T" <markus.t.metzger@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2112 bytes --]

Looks good to me, too.  Please make sure to update tests that check for the old string.

That leaves the question whether we need an indication for MI, too.

Regards,
Markus.

From: Alex Chronopoulos <achronop@gmail.com>
Sent: Thursday, April 4, 2024 9:55 PM
To: Guinevere Larsen <blarsen@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>; Metzger, Markus T <markus.t.metzger@intel.com>; gdb-patches@sourceware.org
Subject: Re: [PATCH] Change message when reaching end of reverse history.

Absolutely, thank you both.

My understanding is that the backward message remains the same. If not let me know. Otherwise will update the patch.

On Thu, Apr 4, 2024, 19:26 Guinevere Larsen <blarsen@redhat.com<mailto:blarsen@redhat.com>> wrote:
On 4/4/24 09:39, Eli Zaretskii wrote:
>> Date: Thu, 4 Apr 2024 09:16:46 -0300
>> Cc: gdb-patches@sourceware.org<mailto:gdb-patches@sourceware.org>, achronop@gmail.com<mailto:achronop@gmail.com>
>> From: Guinevere Larsen <blarsen@redhat.com<mailto:blarsen@redhat.com>>
>>
>>> If the above makes no sense, would someone please explain in more
>>> detail what was the original issue, and I will try to come up with a
>>> better suggestion.
>>>
>> The original issue is that when a user is in replay mode going forward,
>> and they hit the message "no more reverse-execution history", some
>> interpret that message as 'you can no longer execute forward' instead of
>> the intended 'if you continue executing, we will do new things and
>> record them, instead of just replaying what was already done'.
> Then how about this instead:
>
>    End of recorded history; following steps will be added to history.
>
Sounds good to me. Markus, Alex, do you agree?

--
Cheers,
Guinevere Larsen
She/Her/Hers
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928