From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by sourceware.org (Postfix) with ESMTPS id CF533383542C for ; Thu, 12 Aug 2021 11:07:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CF533383542C X-IronPort-AV: E=McAfee;i="6200,9189,10073"; a="194911771" X-IronPort-AV: E=Sophos;i="5.84,315,1620716400"; d="scan'208";a="194911771" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2021 04:07:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,315,1620716400"; d="scan'208";a="507655958" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP; 12 Aug 2021 04:07:13 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 12 Aug 2021 04:07:12 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 12 Aug 2021 04:07:12 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 12 Aug 2021 04:07:12 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 12 Aug 2021 04:07:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A+Mhezb+Xk4/Vy42CY6/a92veehoIsFePyW7P1ZXT/CeRqHI6DmcJfopwv707kLeO4Ek6wMug/QNoW8CaEV4Wiqj7O0speE4WYtXBrME3Y4BD740brEa8b7QunfZZW5Xxk0OosCoOeeHFrJjeXjq5WBNCa6T4M45fS/CR4y2fxQuG8L1hMi72WBd0A4LFMWHr+jelf+JELD6zR4PBzdCsGQSC7y/ICHSaue1MbbEC5eVRoFTDcNLLDVNJiiW9f0tw880AicqAuaMFYT+PmfjznuzRcL7K8oTTleJwHGEekAcioKNutiA0kFlKxRoFSIZhtFfSVvwfkvTQAQhw0SatA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W2AkyfgUvqhJbvRIxQe1/jr7wEDrdXt1FW3jb4FBaME=; b=DKfoCozIifBMi9+zLx1TCIv1yiPqMIt69bTl9WDfIfjOgcxdpi6HlntdrVniMVXAjQSHTkE5HL48NyJxU15NQIydZXi/Lx2xxkmd6z+LWKVawPj1DPIJmwj6haHg/fRfUDzZpSCZhW+DJu8Q8P31ouCdT+PH2HxEe9zUR7G6u9lBdvIQO7MSc2cymyeu9DdPqOjD5e71Jv7AvYfjAoibCxxlEY6/C7myMQmMyu7fLiFc3GcSmF3TPL4ELh26OL5LFgtKnl77FsRzPU85TsKu0V4gP6bJ54Fx6PZWVPhwTeH+RU2N9FXxX5Hdg11NJF7oCohNV6FUQH5oXeU0UKZ0gQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by DM6PR11MB3724.namprd11.prod.outlook.com (2603:10b6:5:13c::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.17; Thu, 12 Aug 2021 11:07:11 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::392c:516a:cc52:963]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::392c:516a:cc52:963%9]) with mapi id 15.20.4415.016; Thu, 12 Aug 2021 11:07:11 +0000 From: "Metzger, Markus T" To: "Willgerodt, Felix" CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v3 04/12] btrace: Handle stepping and goto for auxiliary instructions. Thread-Topic: [PATCH v3 04/12] btrace: Handle stepping and goto for auxiliary instructions. Thread-Index: AQHXYoO0R2RWPUG3uE+K07DSJ1oZQatv/Cmw Date: Thu, 12 Aug 2021 11:07:11 +0000 Message-ID: References: <20210616074205.1129553-1-felix.willgerodt@intel.com> <20210616074205.1129553-5-felix.willgerodt@intel.com> In-Reply-To: <20210616074205.1129553-5-felix.willgerodt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: df650693-9786-4c9e-714a-08d95d81553f x-ms-traffictypediagnostic: DM6PR11MB3724: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B5sR19gXNyzZRkR1i/Nqc+J69czbk/mzhF54DMCHy9lfflnzVoooV2cMtlfnhxoRJptdrpgjf8yuOvsGA4As9uCvNbOKB1NOwkpoIqJnThu76xPTY8etQExqhR5h/fEz0+n7Qs1UgKLmMVK4+MYEoIoDWpqgnUWu/qtXVfm/UE5a0uZhMENoC7pHSD6j1jNzD54Qu84LhHwd1EW0lVeo9kU01diRxhs+uCTXexgmYdjcSOSQdP2IkNonNdcTZN13HMaexw+7VsLVgq56CVytRW1LreuSvhW8m0b9wEk/VpH86tdo5PzBto3z3LpCEShrFJ0o57p3ZPJdnKHHyIk+lTGZ6pE0iP7XDWb1ucf169M2m0I024F6b13dOFrvqA9rQxETwDp9pKf4QOmSwNAe6Y2Ri/pb6ocR6CoxFDxpBiMxt/oH7jRVz+bRXpP92KeFNj2zW3yx+2Gs4NZlKy2n7WiT9kvkvM4f0ok+RgCZSzh/b60CkXnbPdF7rkBqpLyGoCykIJGV4LQLWiLOsMrCp2hzndrN4ae7YGv2PI80+/cuxsxp0JjxZdLpV1RSjwTSn6W4qn3ph4Pqu+CWK1K5IsB2F754kyhGRWCPIBwp+umUaknKCV5RDbYSPlTKo1weKlhknJqKVQKSddR8A0GcsF+hO7jn69VyRxi2LsVcxOnY4vnPXiAFimAAVyemWUIVXHkuC5ZfMVdKkyFeZFQSKA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8936002)(86362001)(33656002)(2906002)(4744005)(6636002)(5660300002)(6862004)(316002)(8676002)(122000001)(38100700002)(7696005)(66946007)(66476007)(66556008)(64756008)(26005)(52536014)(76116006)(186003)(66446008)(55016002)(6506007)(9686003)(38070700005)(508600001)(4326008)(83380400001)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?J8igXN1Na2C9/Etxj3Pb14uQxbJhwK1qsvZPfHEbBxgPqm4B5lR5ul+969lh?= =?us-ascii?Q?vwgBFG9AHzxObxHuwoKFSqE3qgGZsAKWTBCN//xzT3IxbbK+zfMm5FMByyr+?= =?us-ascii?Q?Zx5MvH4FWJA/i2hIWEV8l7O5PtsENFk/HFVIKe90tpjDBw9YxY1VQJf7I7oy?= =?us-ascii?Q?cd+Y9Q+YqkEMnx5zisp0r3vStfXntjZZDoHNDoQbXy+8JM4XoZa+oArklXiU?= =?us-ascii?Q?4DPPgZ4lHWLxmOrkOYsQzX96Fgj9vsgDzdYfZkptBPiOxAcLVYbEh5KCtoLv?= =?us-ascii?Q?d57h6N7RWRbE1SCMsHTdKsOynWDnGdqVwxqqMJRKA0NgIL/2tW1BJhZ39q69?= =?us-ascii?Q?oB9Jp9JePsfVVWaMYrTXO5auIijALgresLrGFQA0vSQMeviJoC/EIzWJgSZc?= =?us-ascii?Q?OkEBcJqdoFo8fhl/VQjqGid2OlJNIC59deRUWv/1Z7WScj+sAXrFYLCZ7Wr5?= =?us-ascii?Q?Voa69MCB1p0e3p7ywKpnQI+vKdUuiq7SqiLelHo8XA3jusLDTLpsM9nSKMYJ?= =?us-ascii?Q?P9NfCFDj3ilfxbT7Za3Zw9UAb+0gHcJ8w20szSzYynB+SXnfkDlHi7/MByp8?= =?us-ascii?Q?Y7aSZ2mFqRK5LqSD0acKgCeUT2OFFD13v8xB1fk/LQf4ngxfzYQ9JvK5D3xe?= =?us-ascii?Q?EzrCQwUZhymRt81OEfVNMibFxLo5KE79Mh9dn9K6glnwY/PtGGcZRF7bsPG3?= =?us-ascii?Q?k9gtkFeCNQYmCwWjQ6qMwsHMu6vBPUzHE57HnUxkOyIHntPKbjXbAbMWSGPZ?= =?us-ascii?Q?Hn5AR9rMxrTZDwDQI9vy4pwlAKdKc5/AsDptNm3ZDmv3OzBtT5aAO3H1r1Vz?= =?us-ascii?Q?XRdqzN+nvoLypZpbAc2BTDroE7QL81HWwg44UAO/oLIfY5LBQ4BZmo73Uu2D?= =?us-ascii?Q?Pgd0pVRkWPicu6o4kszrkjVHLK74J2e8nA5xD5VeFDYBudP0SsFHJEwruv5U?= =?us-ascii?Q?XFVdsyRwG1nzt1RlETVGo0QeW4eUW9OgwSY6EHOSF8yAsqa5jI/TT+vU4FJF?= =?us-ascii?Q?BcujD7XmZEz0Rn70i6ptxARQDwwIDDUFHcbAKI2lE6knv9f1/6i2rJU5/M4u?= =?us-ascii?Q?DX2W5fCQ03RzxXWIy38mfCzYe3J/ZurE7rzjzJmYxxR4lkKs7bpVu+tjk+Pc?= =?us-ascii?Q?BCOelFUx9dMqKok5cZXCf3OkhCXjeTS1So8vLXP9FDCwws04UteJBHcwXZU8?= =?us-ascii?Q?J9PA3ffXQ1PAcGNzyoPUHCMGqyd9w8VhXHCEs8uBF9qZokrdKFVqUTkzCpVK?= =?us-ascii?Q?XWTPNeqm4xk4VMUTVKVbImrq6Diyl55Z3SOF/HC/Jsu7VLGLia4NcRBY2oCl?= =?us-ascii?Q?y14=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: df650693-9786-4c9e-714a-08d95d81553f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2021 11:07:11.0936 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kOf2MmgOQ3N7iHEWjdLDmUx8mN6DA0OBSF76nbjEMhqsfKjDI4QntJh70ParS+aJJS8eP0udV5qiqqmiV0S2EDP1JcqNEpRRMi3GDVTeUsU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3724 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_INVALID, DKIM_SIGNED, KAM_DMARC_NONE, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Aug 2021 11:07:29 -0000 Thanks, Felix, The patch looks good with one issue. >@@ -2400,12 +2405,25 @@ record_btrace_single_step_forward (struct >thread_info *tp) > of the execution history. */ > steps =3D btrace_insn_next (replay, 1); > if (steps =3D=3D 0) >+ { >+ *replay =3D start; >+ return btrace_step_no_history (); >+ } >+ >+ const struct btrace_insn *insn =3D btrace_insn_get (replay); >+ >+ /* If we're stepping a BTRACE_INSN_AUX instruction, print the auxil= iary >+ data and skip the instruction. */ >+ if (insn->iclass =3D=3D BTRACE_INSN_AUX) We need to check for nullptr. Btrace_insn_get() return nullptr in case of = trace errors, where we add a gap to the trace. > { >- *replay =3D start; >- return btrace_step_no_history (); >+ printf_unfiltered ("[%s]\n", >+ btinfo->aux_data[insn->aux_data_index].c_str ()); >+ continue; > } >+ >+ if (insn !=3D NULL) >+ break; Here you add the check. Note that NULL is spelled nullptr nowadays. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928